aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM aside from a few small nits.
================
Comment at: clang-tidy/fuchsia/MultipleInheritanceCheck.cpp:85
+void MultipleInheritanceCheck::registerMatchers(MatchFinder *Finder) {
+ // Match declarations which have bases.
+ Finder->addMatcher(cxxRecordDecl(hasBases()).bind("decl"), this);
----------------
No need to register the matchers for languages other than C++.
================
Comment at: clang-tidy/fuchsia/MultipleInheritanceCheck.cpp:113-114
+ diag(D->getLocStart(),
+ "inheriting mulitple classes which aren't "
+ "pure virtual is discouraged");
+ }
----------------
s/which/that
https://reviews.llvm.org/D40580
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
