aaron.ballman added a comment. In https://reviews.llvm.org/D42213#982047, @MaskRay wrote:
> In https://reviews.llvm.org/D42213#981700, @aaron.ballman wrote: > > > The documentation needs to be regenerated for this patch. One thing that > > seems to be inconsistent is with the "what gets matched" messages is that > > sometimes it includes extra adornments like curly braces and other times it > > does not. It might be good to pick a style and try to be more consistent > > with it. > > > Do I need to do anything to re-generate the doc and check it into this > revision? If so, can you show me the Doxygen generation instruction? Yes, the documentation for this is something that has to be generated manually. You should just have to execute clang/docs/tools/dump_ast_matchers.py to regenerate the documentation. > Reverted some changes as they may cause confusion which are pointed by you. Thanks! I found one more minor nit with some example code, but this basically looks good aside from the documentation bit. ================ Comment at: include/clang/ASTMatchers/ASTMatchers.h:803 /// -/// template<typename T> f() {}; +/// template<typename T> void f() {}; /// void func() { f<int>(); }; ---------------- Spurious semi-colon in the declaration. Repository: rC Clang https://reviews.llvm.org/D42213 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
