mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land.
This looks fine to me. Thanks! ================ Comment at: test/std/re/re.regex/re.regex.construct/bad_ctype.pass.cpp:28 + } catch (const std::regex_error &ex) { + result = (ex.code() == std::regex_constants::error_ctype); + } ---------------- I'm a big fan of the "return NOW" style of programming. But this matches the other tests, so I'm ok with it. (If I care enough, I'll change them all later) try { std::regex re(pat); } catch catch (const std::regex_error &ex) { return ex.code() == std::regex_constants::error_ctype; } return false; https://reviews.llvm.org/D42291 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits