[PATCH] D40720: No -fsanitize=function warning when calling noexcept function through non-noexcept pointer in C++17

This revision was automatically updated to reflect the committed changes. Closed by commit rC321859: No -fsanitize=function warning when calling noexcept function through non… (authored by sberg, committed by ). Changed prior to commit: https://reviews.llvm.org/D40720?vs=128289&id=128710#toc R

r321859 - No -fsanitize=function warning when calling noexcept function through non-noexcept pointer in C++17

Author: sberg Date: Thu Jan 4 23:57:12 2018 New Revision: 321859 URL: http://llvm.org/viewvc/llvm-project?rev=321859&view=rev Log: No -fsanitize=function warning when calling noexcept function through non-noexcept pointer in C++17 As discussed in the mail thread

[PATCH] D41740: [clang-tidy] Adding a new bugprone check for streaming objects of type int8_t or uint8_t

JonasToth added inline comments. Comment at: clang-tidy/bugprone/StreamInt8Check.cpp:26 + hasDeclaration(cxxRecordDecl(hasName("std::basic_ostream", +hasArgument(1, expr(hasType(hasCanonicalType( +anyOf(asString("signed char

[PATCH] D41740: [clang-tidy] Adding a new bugprone check for streaming objects of type int8_t or uint8_t

JonasToth added a comment. Could you please add a test case with a template that reduces the type to int8 or uint8? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D41516: emmintrin.h documentation fixes and updates

kromanova added inline comments. Comment at: cfe/trunk/lib/Headers/emmintrin.h:1143 /// -///If either of the two lower double-precision values is NaN, 1 is returned. +///If either of the two lower double-precision values is NaN, 0 is returned. /// For

[PATCH] D41740: [clang-tidy] Adding a new bugprone check for streaming objects of type int8_t or uint8_t

Eugene.Zelenko added inline comments. Comment at: clang-tidy/bugprone/StreamInt8Check.cpp:1 +//===--- StreamInt8Check.cpp - clang-tidy--===// +// Please add real description, use space after it and shorten to 80 symbols. ===

[PATCH] D41039: Add support for attribute "trivial_abi"

rjmccall added a comment. In https://reviews.llvm.org/D41039#951807, @rjmccall wrote: > In https://reviews.llvm.org/D41039#951648, @ahatanak wrote: > > > I had a discussion with Duncan today and he pointed out that perhaps we > > shouldn't allow users to annotate a struct with "trivial_abi" if o

[PATCH] D41523: xmmintrin.h documentation fixes and updates

craig.topper added inline comments. Comment at: lib/Headers/xmmintrin.h:2199 /// -/// This intrinsic corresponds to the VPINSRW / PINSRW instruction. +/// This intrinsic corresponds to the PINSRW instruction. /// kromanova wrote: > craig.topper wrote: > > W

[PATCH] D41523: xmmintrin.h documentation fixes and updates

kromanova added inline comments. Comment at: lib/Headers/xmmintrin.h:2199 /// -/// This intrinsic corresponds to the VPINSRW / PINSRW instruction. +/// This intrinsic corresponds to the PINSRW instruction. /// craig.topper wrote: > Why is VPINSRW removed? I

[PATCH] D41517: mmintrin.h documentation fixes and updates

craig.topper added inline comments. Comment at: lib/Headers/mmintrin.h:55 /// -/// This intrinsic corresponds to the VMOVD / MOVD instruction. +/// This intrinsic corresponds to the MOVD instruction. /// kromanova wrote: > I tried clang on Linux, x86_64, an

[PATCH] D41517: mmintrin.h documentation fixes and updates

kromanova added inline comments. Comment at: lib/Headers/mmintrin.h:55 /// -/// This intrinsic corresponds to the VMOVD / MOVD instruction. +/// This intrinsic corresponds to the MOVD instruction. /// I tried clang on Linux, x86_64, and if -mavx option is p

r321855 - Reapply r321781: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones

Author: bruno Date: Thu Jan 4 18:33:18 2018 New Revision: 321855 URL: http://llvm.org/viewvc/llvm-project?rev=321855&view=rev Log: Reapply r321781: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones When modules come from module map files explicitly specified

[PATCH] D41357: WIP: Fix Diagnostic layering, moving diagnostics out of Basic

craig.topper added inline comments. Comment at: lib/Basic/DiagnosticIDs.cpp:58 /// GetDiagInfo - Return the StaticDiagInfoRec entry for the specified DiagID, /// or null if the ID is invalid. This comment is out of date with the struct being renamed. ==

[PATCH] D41756: [libcxx] implement simd_mask<> casts and some horizontal operations.

timshen updated this revision to Diff 128706. timshen added a comment. Add tests to boolean version of the horizontal operations. https://reviews.llvm.org/D41756 Files: libcxx/include/experimental/simd libcxx/test/std/experimental/simd/simd.casts/to_compatible.pass.cpp libcxx/test/std/exp

[PATCH] D41750: Fix TLS support check for Darwin 32-bit simulator targets.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, thanks https://reviews.llvm.org/D41750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D41748: [libcxx] [test] Fix Xxx_scan tests using nonstandard things and MSVC++ warnings

CaseyCarter added inline comments. Comment at: test/std/numerics/numeric.ops/transform.exclusive.scan/transform_exclusive_scan_init_bop_uop.pass.cpp:31 -template -struct identity : std::unary_function -{ -constexpr const T& operator()(const T& x) const { return x;} -}; -

[PATCH] D41756: [libcxx] implement simd_mask<> casts and some horizontal operations.

timshen created this revision. timshen added reviewers: mclow.lists, EricWF. Herald added a subscriber: sanjoy. popcount is implemented in terms of for loop. On x86, it can be specialized to _mm_movemask_* + __builtin_popcountll() in the future. https://reviews.llvm.org/D41756 Files: libcxx/

[PATCH] D41755: [CMake] Collect target names in the global LLVM_RUNTIMES property

phosek created this revision. phosek added a reviewer: beanz. Herald added subscribers: cfe-commits, mgorny. This allows exporting the runtimes targets using the CMake export. Repository: rCXX libc++ https://reviews.llvm.org/D41755 Files: lib/CMakeLists.txt Index: lib/CMakeLists.txt

[PATCH] D41754: [CMake] Collect target names in the global LLVM_RUNTIMES property

phosek created this revision. phosek added a reviewer: beanz. Herald added subscribers: cfe-commits, mgorny. This allows exporting the runtimes targets using the CMake export. Repository: rCXXA libc++abi https://reviews.llvm.org/D41754 Files: src/CMakeLists.txt Index: src/CMakeLists.txt

[PATCH] D41751: [analyzer] [NFS] Minor refactoring of trackNullOrUndefValue

george.karpenkov created this revision. george.karpenkov added reviewers: dcoughlin, NoQ. Herald added subscribers: a.sidorin, szepet, xazax.hun. Simple refactoring attempt: factor out some code, remove some repetition, use `auto` where appropriate. https://reviews.llvm.org/D41751 Files: lib

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

compnerd added a comment. Looking over this patch again, I think I really would prefer that this was split up into two patches. The first one should be entirely mechanical, replacing `n64` with `newabi`. The second patch would actually make the changes that you are are after. That would real

[PATCH] D41750: Fix TLS support check for Darwin 32-bit simulator targets.

vsapsai created this revision. vsapsai added reviewers: arphaman, bob.wilson. Also instead of checking architecture explicitly, use recently added "simulator" environment in the triple. rdar://problem/35083787 https://reviews.llvm.org/D41750 Files: clang/lib/Basic/Targets/OSTargets.h clang

[libcxx] r321852 - Move + and * operators of MoveOnly into MoveOnly.h.

Author: bion Date: Thu Jan 4 17:32:00 2018 New Revision: 321852 URL: http://llvm.org/viewvc/llvm-project?rev=321852&view=rev Log: Move + and * operators of MoveOnly into MoveOnly.h. Modified: libcxx/trunk/test/std/numerics/numeric.ops/transform.reduce/transform_reduce_iter_iter_iter_init.pa

[libcxx] r321849 - Add move-only types test to transform_reduce iter iter iter init op op.

Author: bion Date: Thu Jan 4 17:31:52 2018 New Revision: 321849 URL: http://llvm.org/viewvc/llvm-project?rev=321849&view=rev Log: Add move-only types test to transform_reduce iter iter iter init op op. Modified: libcxx/trunk/test/std/numerics/numeric.ops/transform.reduce/transform_reduce_it

[libcxx] r321850 - Automated trailing whitespace removal by VS Code.

Author: bion Date: Thu Jan 4 17:31:55 2018 New Revision: 321850 URL: http://llvm.org/viewvc/llvm-project?rev=321850&view=rev Log: Automated trailing whitespace removal by VS Code. Modified: libcxx/trunk/include/numeric Modified: libcxx/trunk/include/numeric URL: http://llvm.org/viewvc/llvm

[libcxx] r321851 - Fix incorrect handling of move-only types in transform_reduce iter iter iter init, and add test.

Author: bion Date: Thu Jan 4 17:31:57 2018 New Revision: 321851 URL: http://llvm.org/viewvc/llvm-project?rev=321851&view=rev Log: Fix incorrect handling of move-only types in transform_reduce iter iter iter init, and add test. Modified: libcxx/trunk/include/numeric libcxx/trunk/test/st

[libcxx] r321847 - Fix nonstandard bits in transform_reduce_iter_iter_init_bop_uop.

Author: bion Date: Thu Jan 4 17:31:47 2018 New Revision: 321847 URL: http://llvm.org/viewvc/llvm-project?rev=321847&view=rev Log: Fix nonstandard bits in transform_reduce_iter_iter_init_bop_uop. * _VSTD should be std. * is needed for forward. * unary_function is no longer standard (and unnecess

[libcxx] r321848 - Add move-only types test for transform_reduce bop/uop.

Author: bion Date: Thu Jan 4 17:31:50 2018 New Revision: 321848 URL: http://llvm.org/viewvc/llvm-project?rev=321848&view=rev Log: Add move-only types test for transform_reduce bop/uop. Modified: libcxx/trunk/test/std/numerics/numeric.ops/transform.reduce/transform_reduce_iter_iter_init_bop_

[PATCH] D41372: [libcxx] Fix transform_reduce mishandling move-only types, and nonstandard macro use in tests.

BillyONeal updated this revision to Diff 128695. BillyONeal added a comment. Moved things to MoveOnly.h. https://reviews.llvm.org/D41372 Files: include/numeric test/std/numerics/numeric.ops/transform.reduce/transform_reduce_iter_iter_init_bop_uop.pass.cpp test/std/numerics/numeric.ops/t

r321846 - Remove redundant test

Author: adrian Date: Thu Jan 4 17:28:59 2018 New Revision: 321846 URL: http://llvm.org/viewvc/llvm-project?rev=321846&view=rev Log: Remove redundant test Modified: cfe/trunk/test/CodeGenCXX/debug-info-composite-cc.cpp Modified: cfe/trunk/test/CodeGenCXX/debug-info-composite-cc.cpp URL: htt

[PATCH] D41039: Add support for attribute "trivial_abi"

ahatanak updated this revision to Diff 128694. ahatanak added a comment. No worries. Upload the patch again. https://reviews.llvm.org/D41039 Files: include/clang/AST/Decl.h include/clang/AST/DeclCXX.h include/clang/AST/Type.h include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

[PATCH] D41311: [CodeGen] Fix crash when a function taking transparent union is redeclared.

vsapsai added a subscriber: ahatanak. vsapsai added a comment. Add Akira as __fp16 expert to make sure I don't break some edge cases. https://reviews.llvm.org/D41311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D41039: Add support for attribute "trivial_abi"

aprantl added a comment. Unfortunately it looks like I do not have permission to re-upload Akira's last patch to this review. Repository: rL LLVM https://reviews.llvm.org/D41039 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D41039: Add support for attribute "trivial_abi"

aprantl reopened this revision. aprantl added a comment. I'm sorry, I made a copy&paste error in a the commit message for https://reviews.llvm.org/D41743 and accidentally associated that commit with this review. I suppose I should learn to use arcanist. Reopening, and my apologies for the noise!

[PATCH] D41039: Add support for attribute "trivial_abi"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL321845: Debug Info: Support DW_AT_calling_convention on composite types. (authored by adrian, committed by ). Changed pri

[PATCH] D41039: Add support for attribute "trivial_abi"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC321845: Debug Info: Support DW_AT_calling_convention on composite types. (authored by adrian, committed by ). Changed pri

[PATCH] D41743: Debug Info: Support DW_AT_calling_convention on composite types.

This revision was automatically updated to reflect the committed changes. Closed by commit rL321844: Debug Info: Support DW_AT_calling_convention on composite types. (authored by adrian, committed by ). Herald added a reviewer: deadalnix. Changed prior to commit: https://reviews.llvm.org/D41743

r321845 - Debug Info: Support DW_AT_calling_convention on composite types.

Author: adrian Date: Thu Jan 4 17:13:52 2018 New Revision: 321845 URL: http://llvm.org/viewvc/llvm-project?rev=321845&view=rev Log: Debug Info: Support DW_AT_calling_convention on composite types. This implements the DWARF 5 feature described at http://www.dwarfstd.org/ShowIssue.php?issue=141215.

[PATCH] D41743: Debug Info: Support DW_AT_calling_convention on composite types.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! https://reviews.llvm.org/D41743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D41749: [analyzer] suppress nullability inference from a macro when result is used in another macro

george.karpenkov created this revision. george.karpenkov added reviewers: dcoughlin, NoQ. Herald added subscribers: a.sidorin, szepet, xazax.hun. The current code used to not suppress the report, if the dereference was performed in a macro, assuming it is that same macro. However, the assumption

[PATCH] D41748: [libcxx] [test] Fix Xxx_scan tests using nonstandard things and MSVC++ warnings

BillyONeal created this revision. BillyONeal added reviewers: mclow.lists, EricWF. - These tests use function objects from functional, back_inserter from iterator, and equal from algorithm, so add those headers. - The use of iota targeting vector with an int parameter triggers warnings on MSVC++

[PATCH] D41747: [libcxx] implement simd_mask<> and operators.

timshen updated this revision to Diff 128687. timshen added a comment. Remove unintended binary file. https://reviews.llvm.org/D41747 Files: libcxx/include/experimental/simd libcxx/test/std/experimental/simd/simd.elementwise/operators.pass.cpp libcxx/test/std/experimental/simd/simd.mask.a

[PATCH] D41743: Debug Info: Support DW_AT_calling_convention on composite types.

aprantl updated this revision to Diff 128686. aprantl added a comment. Just unconditionally emit the flags for all CXXRecordDecls. Richard convinced me that a debugger does not want to be in the business of determining the correct calling convention. https://reviews.llvm.org/D41743 Files: l

[PATCH] D41747: [libcxx] implement simd_mask<> and operators.

timshen created this revision. timshen added reviewers: mclow.lists, EricWF. Herald added a subscriber: sanjoy. simd_mask stores a simd, where U has the same length of T, but is an unsigned integer. Then all functionality of simd_mask can be implemented in terms of simd. For reference, Vc seems

[PATCH] D41733: [Driver] Suggest correctly spelled driver options

modocache updated this revision to Diff 128681. modocache added a comment. Add 'did you mean' suggestions for -cc1 invocations as well. Repository: rC Clang https://reviews.llvm.org/D41733 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/Driver.cpp lib/Frontend/CompilerIn

[PATCH] D41538: [analyzer] Fix some checker's output plist not containing the checker name #2

NoQ accepted this revision. NoQ added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/StaticAnalyzer/Core/BugReporter/BugType.h:51 StringRef getCategory() const { return Category; } - StringRef getCheckName() const { return Check.ge

[PATCH] D41148: [libcxx] implement declarations based on P0214R7.

timshen updated this revision to Diff 128679. timshen added a comment. Rebase. https://reviews.llvm.org/D41148 Files: libcxx/include/experimental/__config libcxx/include/experimental/simd libcxx/test/std/experimental/simd/nothing_to_do.pass.cpp libcxx/test/std/experimental/simd/simd.cas

[PATCH] D41376: [libcxx] Implement ABI for Clang/GCC vector extension, constructors, copy_from and copy_to.

timshen updated this revision to Diff 128680. timshen added a comment. Rebase. Also modify the simd reference implementation to separate the stored type and value_type (which could be bool later). https://reviews.llvm.org/D41376 Files: libcxx/include/__config libcxx/include/experimental/__

[PATCH] D41746: Make std::get_temporary_buffer respect overaligned types when possible

ckennelly created this revision. ckennelly added reviewers: EricWF, mclow.lists. Repository: rCXX libc++ https://reviews.llvm.org/D41746 Files: include/memory test/std/utilities/memory/temporary.buffer/overaligned.pass.cpp Index: test/std/utilities/memory/temporary.buffer/overaligned.pas

[PATCH] D37442: [C++17] Disallow lambdas in template parameters (PR33696).

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, looks good other than `ExpressionType`. This is fine to commit with either of the names I suggested; let me know if you have a better alternative :) Comment at: incl

[PATCH] D41743: Debug Info: Support DW_AT_calling_convention on composite types.

aprantl added a comment. Thanks! I think you got me convinced that we should probably stick the calling convention attribute unconditionally on all C++ types. At least in DWARF 5 it should be part of the abbreviation and thus almost free. Repository: rL LLVM https://reviews.llvm.org/D41743

[PATCH] D41743: Debug Info: Support DW_AT_calling_convention on composite types.

rsmith added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:2812-2814 + // Implicitly by reference is everything clearly looks like a non-pod type: + // - Types that define a destructor, a copy constructor, and a copy + //assignment operator. I

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

Rakete updated this revision to Diff 128668. Rakete added a comment. Rebased + friendly 2018 ping :) https://reviews.llvm.org/D36357 Files: include/clang/Basic/DiagnosticParseKinds.td lib/Parse/ParseExprCXX.cpp test/Parser/cxx0x-lambda-expressions.cpp test/SemaCXX/new-delete-0x.

[PATCH] D41733: [Driver] Suggest correctly spelled driver options

modocache added a comment. Thank you, @bruno! Good idea, I'll add a `-cc1` invocation test. Comment at: lib/Driver/Driver.cpp:191 if (A->getOption().hasFlag(options::Unsupported)) { - Diag(diag::err_drv_unsupported_opt) << A->getAsString(Args); - ContainsError |=

[PATCH] D37442: [C++17] Disallow lambdas in template parameters (PR33696).

Rakete updated this revision to Diff 128667. Rakete added a comment. Rebased + friendly 2018 ping https://reviews.llvm.org/D37442 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Parse/ParseDecl.cpp lib/Parse/ParseDeclCXX.cpp lib/Parse/ParseStmt.

[PATCH] D41743: Debug Info: Support DW_AT_calling_convention on composite types.

aprantl added a comment. I related https://reviews.llvm.org/D41039 (Add support for attribute "trivial_abi") which will also benefit from this feature. It is not a hard dependency though, this patch is also useful for standard C++. Repository: rL LLVM https://reviews.llvm.org/D41743

[PATCH] D41736: make attribute instantiation instantiate all attributes

rsmith closed this revision. rsmith added a comment. Committed as r321834. Repository: rC Clang https://reviews.llvm.org/D41736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r321834 - Make attribute instantiation instantiate all attributes, not just the first of

Author: rsmith Date: Thu Jan 4 15:42:29 2018 New Revision: 321834 URL: http://llvm.org/viewvc/llvm-project?rev=321834&view=rev Log: Make attribute instantiation instantiate all attributes, not just the first of each kind. Attribute instantiation would previously default to instantiating each kin

[PATCH] D41743: Debug Info: Support DW_AT_calling_convention on composite types.

aprantl created this revision. aprantl added reviewers: echristo, dblaikie, probinson. aprantl added a project: debug-info. Herald added a subscriber: JDevlieghere. This implements the DWARF 5 feature described at http://www.dwarfstd.org/ShowIssue.php?issue=141215.1 This allows a consumer to unde

[PATCH] D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list

rsmith added inline comments. Comment at: lib/Sema/SemaInit.cpp:7691-7695 case FK_RValueReferenceBindingToLValue: S.Diag(Kind.getLocation(), diag::err_lvalue_to_rvalue_ref) << DestType.getNonReferenceType() << Args[0]->getType() << Args[0]->getSourceRange();

[PATCH] D38216: [C++17] Fix class template argument deduction for default constructors without an initializer

Rakete updated this revision to Diff 128662. Rakete marked an inline comment as done. Rakete added a comment. Rebased + friendly 2018 ping https://reviews.llvm.org/D38216 Files: lib/Sema/SemaDecl.cpp test/CXX/dcl.dcl/dcl.spec/dcl.type/dcl.type.class.deduct/p1.cpp test/Parser/c

[PATCH] D40445: [C++17] Allow an empty expression in an if init statement

rsmith added inline comments. Comment at: lib/Parse/ParseExprCXX.cpp:1760 +if (InitStmt && TryConsumeToken(tok::semi)) { + WarnOnInit(); + return ParseCXXCondition(nullptr, Loc, CK); Please create a NullStmt here (`Actions.ActOnNullStmt`), rather th

[PATCH] D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list

Rakete updated this revision to Diff 128661. Rakete added a comment. Rebased + friendly 2018 ping :) https://reviews.llvm.org/D39679 Files: lib/Sema/SemaInit.cpp test/SemaCXX/references.cpp Index: test/SemaCXX/references.cpp

[PATCH] D41736: make attribute instantiation instantiate all attributes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Comment at: include/clang/AST/Attr.h:142 + /// explicitly provided in the current declaration? + bool isInheritEvenIfAlreadyPresent() const {

[PATCH] D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Generally this looks good. Is there some way we can prevent this bug from recurring by construction (eg, by making a `return` ill-formed, or making it "just work")? Wrapping the code block in

[PATCH] D40445: [C++17] Allow an empty expression in an if init statement

Rakete updated this revision to Diff 128659. Rakete added a comment. Rebased + friendly 2018 ping :) https://reviews.llvm.org/D40445 Files: lib/Parse/ParseExprCXX.cpp test/CXX/stmt.stmt/stmt.select/p3.cpp Index: test/CXX/stmt.stmt/stmt.select/p3.cpp

r321830 - Use POSIX argument syntax in test rewrite-includes-messages.c

Author: hubert.reinterpretcast Date: Thu Jan 4 15:03:48 2018 New Revision: 321830 URL: http://llvm.org/viewvc/llvm-project?rev=321830&view=rev Log: Use POSIX argument syntax in test rewrite-includes-messages.c Invoke diff such that options precede operands. Not doing so leads to unspecified beha

[PATCH] D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor.

bruno added a comment. Herald added a subscriber: mgrang. The change seems good to me in general. I wonder if this will hit any broken assumption in the code. Did you run other tests beside unittests? https://reviews.llvm.org/D34030 ___ cfe-commits

[PATCH] D41544: Use backslash escape, replacing xargs -0 in test macro-multiline.c

This revision was automatically updated to reflect the committed changes. Closed by commit rC321828: Use backslash escape, replacing xargs -0 in test macro-multiline.c (authored by hubert.reinterpretcast, committed by ). Changed prior to commit: https://reviews.llvm.org/D41544?vs=128034&id=1286

r321828 - Use backslash escape, replacing xargs -0 in test macro-multiline.c

Author: hubert.reinterpretcast Date: Thu Jan 4 14:58:30 2018 New Revision: 321828 URL: http://llvm.org/viewvc/llvm-project?rev=321828&view=rev Log: Use backslash escape, replacing xargs -0 in test macro-multiline.c Summary: xargs supports escaping of newline characters with backslash. xargs -0 i

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

v.g.vassilev updated this revision to Diff 128657. v.g.vassilev added a comment. Reverse template specialization order. https://reviews.llvm.org/D41416 Files: include/clang/AST/DeclTemplate.h lib/AST/DeclTemplate.cpp lib/Serialization/ASTReader.cpp lib/Serialization/ASTReaderDecl.cpp

[PATCH] D41740: [clang-tidy] Adding a new bugprone check for streaming objects of type int8_t or uint8_t

Quuxplusone added inline comments. Comment at: clang-tidy/bugprone/StreamInt8Check.cpp:44 +} else if (Name == "int8_t") { +diag(Offender->getLocStart(), "streaming int8_t"); +break; I don't know clang-tidy style either, but might i

[PATCH] D41740: [clang-tidy] Adding a new bugprone check for streaming objects of type int8_t or uint8_t

BRevzin added a comment. So admittedly, I don't have any experience in clang-tidy. This check is intended to catch what is to us a really annoying source of error (and I'm probably not the only one?). I suspect there are far better ways of writing this check than the one that I pretty much gues

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

v.g.vassilev updated this revision to Diff 128655. v.g.vassilev added a comment. Zero `IsPartial` and improve comments in assert and free text. https://reviews.llvm.org/D41416 Files: include/clang/AST/DeclTemplate.h lib/AST/DeclTemplate.cpp lib/Serialization/ASTReader.cpp lib/Serializat

[PATCH] D41736: make attribute instantiation instantiate all attributes

erichkeane added a comment. LGTM, I like the shouldInheritEvenIfAlreadyPresent name better than isInherited... FWIW. I'll let @aaron.ballman make the final call though. Repository: rC Clang https://reviews.llvm.org/D41736 ___ cfe-commits mailin

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

v.g.vassilev added a comment. I have created a simple (-ish) benchmark targeted to stress test modules with a good number of template specializations. I use the mp11 library from boost. I am building two modules which contain around 1K specializations (mostly

[PATCH] D41736: make attribute instantiation instantiate all attributes

rsmith added a comment. In https://reviews.llvm.org/D41736#967552, @aaron.ballman wrote: > I don't suppose there is a chance at test coverage for this change? Added Erich's test, plus a test that all instances of another attribute (`annotate`) get instantiated (the latter test failed prior to

[PATCH] D41736: make attribute instantiation instantiate all attributes

rsmith updated this revision to Diff 128654. Herald added a subscriber: javed.absar. Repository: rC Clang https://reviews.llvm.org/D41736 Files: include/clang/AST/Attr.h include/clang/Basic/Attr.td lib/Sema/SemaDecl.cpp lib/Sema/SemaTemplateInstantiateDecl.cpp test/SemaTemplate/attri

[PATCH] D41720: [clang-tidy] Add a -show-color flag.

itessier marked an inline comment as done. itessier added a comment. > This patch is missing test coverage. Done. Comment at: clang-tidy/tool/ClangTidyMain.cpp:150-152 +Show color diagnostics. If not specified, +defaults to on when a color-capable terminal +is detected.)"), --

[PATCH] D41720: [clang-tidy] Add a -show-color flag.

itessier updated this revision to Diff 128652. https://reviews.llvm.org/D41720 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidyOptions.cpp clang-tidy/ClangTidyOptions.h clang-tidy/tool/ClangTidyMain.cpp test/clang-tidy/show-color.cpp Index: test/clang-tidy/show-color.cpp =

[PATCH] D40720: No -fsanitize=function warning when calling noexcept function through non-noexcept pointer in C++17

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thank you! https://reviews.llvm.org/D40720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D41357: WIP: Fix Diagnostic layering, moving diagnostics out of Basic

rsmith added a comment. Yes, I think this is the right general direction -- in general, moving towards making clang's diagnostic infrastructure a reusable component that isn't tied to a particular diagnostics table, and in particular moving the knowledge of the complete set of diagnostics and d

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

v.g.vassilev updated this revision to Diff 128645. v.g.vassilev added a comment. Loading of lazy partial template specializations should not trigger loading of full template specializations. Often during selection process we need to load all partial template specializations. It is very rare to

[PATCH] D41311: [CodeGen] Fix crash when a function taking transparent union is redeclared.

vsapsai updated this revision to Diff 128643. vsapsai added a comment. - Fix using CreateCoercedStore for promoted float parameters. For promoted parameters double -> float conversion should use fptrunc, not casting through memory preserving bits. Tried to change CreateCoercedStore to do CreateFP

[PATCH] D41039: Add support for attribute "trivial_abi"

ahatanak updated this revision to Diff 128642. ahatanak added a comment. I've only fixed the places where the bits to track the triviality of special functions are set or reset, so this is still a WIP. I'll update the patch again later today, but let me know if anyone has any feedback in the mea

[PATCH] D41311: [CodeGen] Fix crash when a function taking transparent union is redeclared.

vsapsai reopened this revision. vsapsai added a comment. This revision is now accepted and ready to land. The fix wasn't entirely correct and was reverted in r321306 as it caused test failures FAIL: imp.execution_time FAIL: 2007-01-04-KNR-Args.execution_time FAIL: sse_expandfft.execution_time FA

Re: r321816 - [OPENMP] Add debug info for generated functions.

You mean r321818 and r321820? I skipped them because they are for NVPTX and target directives which aren't fully functional in 6.0 anyway, right? Or patches in the future? Am 2018-01-04 21:58, schrieb Alexey Bataev: Hi Jonas, I don't think it is necessary. It is better to backport my 2 next pa

[PATCH] D41733: [Driver] Suggest correctly spelled driver options

bruno added a comment. This is great! I assume it also works for cc1 invocations, right? Can you also add a test for %clang_cc1? Repository: rC Clang https://reviews.llvm.org/D41733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 128641. juliehockett added a comment. 1. Adding in a basic test setup for the framework 2. Pulling the YAML specs out into their own file 3. Expanding the representation to consider different types of declarations (namespace, tag, and function) and store

Re: r321816 - [OPENMP] Add debug info for generated functions.

Hi Alexey, should this change be backported to 6.0? Regards, Jonas Am 2018-01-04 20:45, schrieb Alexey Bataev via cfe-commits: Author: abataev Date: Thu Jan 4 11:45:16 2018 New Revision: 321816 URL: http://llvm.org/viewvc/llvm-project?rev=321816&view=rev Log: [OPENMP] Add debug info for gene

r321820 - [OPENMP] Fix capturing of expressions in clauses.

Author: abataev Date: Thu Jan 4 12:50:08 2018 New Revision: 321820 URL: http://llvm.org/viewvc/llvm-project?rev=321820&view=rev Log: [OPENMP] Fix capturing of expressions in clauses. Patch fixes incorrect capturing of the expressions in clauses with expressions that must be captured for the comb

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

bsdjhb added a comment. ping @sdardis, @compnerd https://reviews.llvm.org/D39074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41733: [Driver] Suggest correctly spelled driver options

jroelofs added inline comments. Comment at: lib/Driver/Driver.cpp:191 if (A->getOption().hasFlag(options::Unsupported)) { - Diag(diag::err_drv_unsupported_opt) << A->getAsString(Args); - ContainsError |= Diags.getDiagnosticLevel(diag::err_drv_unsupported_opt, -

[PATCH] D40478: Added control flow architecture protection Flag

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D40478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

r321818 - [OPENMP] Fix casting in NVPTX support library.

Author: abataev Date: Thu Jan 4 12:18:55 2018 New Revision: 321818 URL: http://llvm.org/viewvc/llvm-project?rev=321818&view=rev Log: [OPENMP] Fix casting in NVPTX support library. If the reduction required shuffle in the NVPTX codegen, we may need to cast the reduced value to the integer type. T

[PATCH] D41517: mmintrin.h documentation fixes and updates

craig.topper added inline comments. Comment at: lib/Headers/mmintrin.h:1292 /// -/// This intrinsic corresponds to the VXORPS / XORPS instruction. +/// This intrinsic corresponds to the XOR instruction. /// kromanova wrote: > craig.topper wrote: > > PXOR? >

r321816 - [OPENMP] Add debug info for generated functions.

Author: abataev Date: Thu Jan 4 11:45:16 2018 New Revision: 321816 URL: http://llvm.org/viewvc/llvm-project?rev=321816&view=rev Log: [OPENMP] Add debug info for generated functions. Most of the generated functions for the OpenMP were generated with disabled debug info. Patch fixes this for bette

[PATCH] D41736: make attribute instantiation instantiate all attributes

aaron.ballman added a comment. I don't suppose there is a chance at test coverage for this change? Comment at: include/clang/AST/Attr.h:142 + /// explicitly provided in the current declaration? + bool isInheritEvenIfAlreadyPresent() const { +return InheritEvenIfAlreadyPre

[PATCH] D41736: make attribute instantiation instantiate all attributes

erichkeane added a comment. Presumably this didn't break any tests, so I'm Ok with it. The initial patch was to make sure that template specializations could clear certain attributes, so I think this properly gets that done. The below test was apparently missed in the initial patch (and was t

[PATCH] D41736: make attribute instantiation instantiate all attributes

rsmith created this revision. rsmith added reviewers: aaron.ballman, erichkeane. rsmith added a project: clang. Herald added a subscriber: sanjoy. Attribute instantiation would previously default to instantiating each kind of attribute only once. This was overridden by a flag whose intended purpo

  1   2   >