rsmith added a comment.
In https://reviews.llvm.org/D41736#967552, @aaron.ballman wrote:
> I don't suppose there is a chance at test coverage for this change?
Added Erich's test, plus a test that all instances of another attribute
(`annotate`) get instantiated (the latter test failed prior to this change).
================
Comment at: include/clang/AST/Attr.h:142
+ /// explicitly provided in the current declaration?
+ bool isInheritEvenIfAlreadyPresent() const {
+ return InheritEvenIfAlreadyPresent;
----------------
aaron.ballman wrote:
> I'm not too keen on the name -- perhaps `isInheritedEvenIfAlreadyPresent()`?
I started with that, but then changed to this abomination because
`isInherited[...]` suggests it's telling you whether this attribute was
inherited (like `isInherited()` does), which is not what it's for.
How about `shouldInheritEvenIfAlreadyPresent`?
Repository:
rC Clang
https://reviews.llvm.org/D41736
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
