aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM, thank you!



================
Comment at: include/clang/AST/Attr.h:142
+  /// explicitly provided in the current declaration?
+  bool isInheritEvenIfAlreadyPresent() const {
+    return InheritEvenIfAlreadyPresent;
----------------
rsmith wrote:
> aaron.ballman wrote:
> > I'm not too keen on the name -- perhaps `isInheritedEvenIfAlreadyPresent()`?
> I started with that, but then changed to this abomination because 
> `isInherited[...]` suggests it's telling you whether this attribute was 
> inherited (like `isInherited()` does), which is not what it's for.
> 
> How about `shouldInheritEvenIfAlreadyPresent`?
Sold!


Repository:
  rC Clang

https://reviews.llvm.org/D41736



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to