craig.topper added inline comments.

================
Comment at: lib/Basic/DiagnosticIDs.cpp:58
 
 /// GetDiagInfo - Return the StaticDiagInfoRec entry for the specified DiagID,
 /// or null if the ID is invalid.
----------------
This comment is out of date with the struct being renamed.


================
Comment at: lib/Basic/DiagnosticIDs.cpp:73
-#define VALIDATE_DIAG_SIZE(NAME)                                               
\
-  static_assert(                                                               
\
-      static_cast<unsigned>(diag::NUM_BUILTIN_##NAME##_DIAGNOSTICS) <          
\
----------------
Did this static_assert stuff get lost?


================
Comment at: tools/driver/cc1_main.cpp:210
+
+/// GetDiagInfo - Return the StaticDiagInfoRec entry for the specified DiagID,
+/// or null if the ID is invalid.
----------------
StaticDiagInfoRec was renamed.


Repository:
  rC Clang

https://reviews.llvm.org/D41357



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D41357: W... David Blaikie via Phabricator via cfe-commits
    • [PATCH] D413... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D413... Craig Topper via Phabricator via cfe-commits

Reply via email to