Lekensteyn added a comment.
ping? I'll push it next week if there is no new feedback.
https://reviews.llvm.org/D37954
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315668: [OpenCL] Add LangAS::opencl_private to represent
private address space in AST (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D35082?vs=118813&id=118882#toc
Repository:
Author: yaxunl
Date: Thu Oct 12 20:37:48 2017
New Revision: 315668
URL: http://llvm.org/viewvc/llvm-project?rev=315668&view=rev
Log:
[OpenCL] Add LangAS::opencl_private to represent private address space in AST
Currently Clang uses default address space (0) to represent private address
space for
Author: alexshap
Date: Thu Oct 12 20:21:39 2017
New Revision: 315665
URL: http://llvm.org/viewvc/llvm-project?rev=315665&view=rev
Log:
[clang] Enable clang build with LLVM_BUILD_INSTRUMENTED without setting
LLVM_PROFTDATA
At the moment if LLVM_BUILD_INSTRUMENTED is set to True
one has to set LL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315665: [clang] Enable clang build with
LLVM_BUILD_INSTRUMENTED without setting… (authored by alexshap).
Changed prior to commit:
https://reviews.llvm.org/D38859?vs=118869&id=118881#toc
Repository:
r
rjmccall added inline comments.
Comment at: clang/lib/Sema/SemaDecl.cpp:15055
}
+ // If it is the last field is checked elsewhere.
}
vsapsai wrote:
> rjmccall wrote:
> > "Whether" rather than "If", please. You should also leave a com
Author: rsmith
Date: Thu Oct 12 18:55:36 2017
New Revision: 315662
URL: http://llvm.org/viewvc/llvm-project?rev=315662&view=rev
Log:
Support for destroying operator delete, per C++2a proposal P0722.
This feature is not (yet) approved by the C++ committee, so this is liable to
be reverted or signi
Author: arphaman
Date: Thu Oct 12 18:53:13 2017
New Revision: 315661
URL: http://llvm.org/viewvc/llvm-project?rev=315661&view=rev
Log:
Recommit r315087 "[refactor] add support for refactoring options"
The recommit fixes a UB bug that occurred only on a small number of bots.
Original message:
Th
vsk added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:2263
+ }
+}
+
joerg wrote:
> vsk wrote:
> > rjmccall wrote:
> > > Is there a reason this only fails on x86? If LLVM doesn't have generic
> > > wide-operation lowering, this probably needs
joerg added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:2263
+ }
+}
+
vsk wrote:
> rjmccall wrote:
> > Is there a reason this only fails on x86? If LLVM doesn't have generic
> > wide-operation lowering, this probably needs to be a target whi
yaxunl added inline comments.
Comment at: tools/libclang/CXType.cpp:402
+ ASTContext &Ctx = cxtu::getASTUnit(GetTU(CT))->getASTContext();
+ return Ctx.getTargetAddressSpace(T);
}
arichardson wrote:
> yaxunl wrote:
> > Is this function suppose to return AST add
vsapsai added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5226
+def err_objc_variable_sized_type_not_at_end : Error<
+ "field %0 with variable sized type %1 is not at the end of class">;
+def note_next_field_declaration : Note<
On Thu, Oct 12, 2017 at 8:39 AM, Anastasia Stulova
wrote:
>
> I think this bit is a bit confusing to us. Some of our original OpenCL
> checks were removed in some places because in some cases OpenCL semantic was
> adopted elsewhere.
It's confusing indeed. We should probably enhance the docs for
s
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D38859
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
bruno created this revision.
Herald added a subscriber: yaxunl.
Change behavior introduced in r298369 and only error out on vector component
invalid length access on OpenCL mode.
https://reviews.llvm.org/D38868
Files:
lib/Sema/SemaExprMember.cpp
test/SemaOpenCL/vector_swizzle_length.cl
I
Author: rnk
Date: Thu Oct 12 17:53:02 2017
New Revision: 315656
URL: http://llvm.org/viewvc/llvm-project?rev=315656&view=rev
Log:
[MS] Don't bail on replacing dllimport vbase dtors with base dtors
Fix PR32990 by effectively reverting r283063 and solving it a different
way.
We want to limit the h
Author: george.karpenkov
Date: Thu Oct 12 17:51:41 2017
New Revision: 315655
URL: http://llvm.org/viewvc/llvm-project?rev=315655&view=rev
Log:
[Analyzer] Assume that CFBooleanRef const globals are non-null
Differential Revision: https://reviews.llvm.org/D38867
Added:
cfe/trunk/lib/StaticAnal
alexshap updated this revision to Diff 118869.
alexshap added a comment.
Update the wording
Repository:
rL LLVM
https://reviews.llvm.org/D38859
Files:
utils/perf-training/CMakeLists.txt
Index: utils/perf-training/CMakeLists.txt
alexshap updated this revision to Diff 118868.
Repository:
rL LLVM
https://reviews.llvm.org/D38859
Files:
utils/perf-training/CMakeLists.txt
Index: utils/perf-training/CMakeLists.txt
===
--- utils/perf-training/CMakeLists.txt
Author: jkorous
Date: Thu Oct 12 17:31:07 2017
New Revision: 315652
URL: http://llvm.org/viewvc/llvm-project?rev=315652&view=rev
Log:
Typos in tutorial
Modified:
cfe/trunk/www/hacking.html
Modified: cfe/trunk/www/hacking.html
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/www/hacking.ht
vsk added a comment.
In https://reviews.llvm.org/D38859#896517, @alexshap wrote:
> yeah, i agree, this is not a good idea. My thoughts were different - right
> now it's not particularly convenient that one has to specify LLVM_PROFDATA
> when it's not actually used by the build.
> Maybe we can
alexshap added a comment.
yeah, i agree, this is not a good idea. My thoughts were different - right now
it's not particularly convenient that one has to specify LLVM_PROFDATA when
it's not actually used by the build.
Maybe we can create the target "generate-profdata" only if LLVM_PROFDATA is se
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
You generally don't need a pre-commit review for such a change.
https://reviews.llvm.org/D38863
___
cfe-commits mailing list
cfe-commits@list
vsk added a comment.
llvm-profdata is tightly coupled with the host compiler: while this setup may
work if you get lucky, I don't think it's resilient to changes in libProfData.
Also, using the instrumented llvm-profdata will be slow and create extra
profiles.
As an alternative, have you consi
Author: anemet
Date: Thu Oct 12 16:56:54 2017
New Revision: 315643
URL: http://llvm.org/viewvc/llvm-project?rev=315643&view=rev
Log:
Handle/assert on DK_Remark
We don't generate remarks during inline assembly parsing so no need to handle
these for now.
Modified:
cfe/trunk/lib/CodeGen/CodeGen
On 12 October 2017 at 15:41, Roman Lebedev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Fri, Oct 13, 2017 at 1:22 AM, Richard Smith
> wrote:
> > On 12 October 2017 at 15:11, Roman Lebedev via Phabricator via
> cfe-commits
> > wrote:
> >>
> >> lebedev.ri reopened this revision.
> >>
Author: ahatanak
Date: Thu Oct 12 16:24:38 2017
New Revision: 315639
URL: http://llvm.org/viewvc/llvm-project?rev=315639&view=rev
Log:
[Sema][ObjC] Complete merging ObjC methods before checking their
overriding methods.
This should fix test case Analysis/retain-release.m that was failing on
the r
vsk added a comment.
In https://reviews.llvm.org/D38861#896435, @rjmccall wrote:
> Okay. Sounds good to me.
>
> We intend to actually implement the generic lowering, I hope?
Yes, I'll make a note of that in PR34920, and am tracking the bug internally in
rdar://problem/34963321.
https://revi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315638: [Sema][Crash] Correctly handle an non-dependent
noexcept expr in function… (authored by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D38700?vs=118245&id=118858#toc
Repository:
rjmccall added a comment.
Okay. Sounds good to me.
We intend to actually implement the generic lowering, I hope?
https://reviews.llvm.org/D38861
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Author: erichkeane
Date: Thu Oct 12 16:01:53 2017
New Revision: 315638
URL: http://llvm.org/viewvc/llvm-project?rev=315638&view=rev
Log:
[Sema][Crash] Correctly handle an non-dependent noexcept expr in function
template
It seems that all of the other templated cases are handled correctly,
howeve
vsk added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:2263
+ }
+}
+
rjmccall wrote:
> Is there a reason this only fails on x86? If LLVM doesn't have generic
> wide-operation lowering, this probably needs to be a target whitelist rather
> th
vsk updated this revision to Diff 118857.
vsk added a comment.
Herald added a subscriber: aheejin.
- Update to check against a whitelist of supported targets.
https://reviews.llvm.org/D38861
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/builtins-overflow-unsupported.c
test/CodeGen/builtin
jkorous-apple created this revision.
https://reviews.llvm.org/D38863
Files:
www/hacking.html
Index: www/hacking.html
===
--- www/hacking.html
+++ www/hacking.html
@@ -246,9 +246,9 @@
For example:
- python C:\Tool\llvm\u
rjmccall added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5226
+def err_objc_variable_sized_type_not_at_end : Error<
+ "field %0 with variable sized type %1 is not at the end of class">;
+def note_next_field_declaration : Note<
On Fri, Oct 13, 2017 at 1:22 AM, Richard Smith wrote:
> On 12 October 2017 at 15:11, Roman Lebedev via Phabricator via cfe-commits
> wrote:
>>
>> lebedev.ri reopened this revision.
>> lebedev.ri added a comment.
>> This revision is now accepted and ready to land.
>>
>> Reverted due to http://bb9.
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
This function feels increasingly poorly-named, but let's leave that alone for
now.
Repository:
rL LLVM
https://reviews.llvm.org/D38794
__
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Yes, thank for you handling the cast case well.
Repository:
rL LLVM
https://reviews.llvm.org/D38796
___
cfe-commits mailing list
cfe-commi
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D38795
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D38793
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D38791
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D38788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
rjmccall added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:2263
+ }
+}
+
Is there a reason this only fails on x86? If LLVM doesn't have generic
wide-operation lowering, this probably needs to be a target whitelist rather
than a blacklist.
arichardson planned changes to this revision.
arichardson added inline comments.
Comment at: include/clang/Basic/AddressSpaces.h:66
+inline LangAS LangASFromTargetAS(unsigned TargetAS) {
+ return static_cast((TargetAS) +
yaxunl wrote:
> how about `getLangASFro
rjmccall added a comment.
A few minor comments; feel free to commit after addressing them.
Comment at: include/clang/Basic/AddressSpaces.h:34
// OpenCL specific address spaces.
opencl_global,
yaxunl wrote:
> rjmccall wrote:
> > I think you need a real c
vsk created this revision.
LLVM's smul.with.overflow intrinsic isn't supported on X86 for bit
widths larger than 64, or on X86-64 for bit widths larger than 128.
The failure mode is either a linker error ("the __muloti4 builtin isn't
available for this target") or an assertion failure ("Selection
On 12 October 2017 at 15:11, Roman Lebedev via Phabricator via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> lebedev.ri reopened this revision.
> lebedev.ri added a comment.
> This revision is now accepted and ready to land.
>
> Reverted due to http://bb9.pgr.jp/#/builders/20/builds/59 that i
lebedev.ri reopened this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.
Reverted due to http://bb9.pgr.jp/#/builders/20/builds/59 that i don't
currently know how to deal with.
It is really sad that i failed to encounter it during testing.
Repository:
rL
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Looks good, thanks!
https://reviews.llvm.org/D38700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: lebedevri
Date: Thu Oct 12 15:03:20 2017
New Revision: 315631
URL: http://llvm.org/viewvc/llvm-project?rev=315631&view=rev
Log:
Revert "[Sema] Diagnose tautological comparison with type's min/max values"
This reverts r315614,r315615,r315621,r315622
Breaks http://bb9.pgr.jp/#/builders/20/b
Author: morehouse
Date: Thu Oct 12 15:00:09 2017
New Revision: 315630
URL: http://llvm.org/viewvc/llvm-project?rev=315630&view=rev
Log:
[cmake] Rename LIB_FUZZING_ENGINE to LLVM_LIB_FUZZING_ENGINE.
Modified:
cfe/trunk/tools/clang-format/CMakeLists.txt
cfe/trunk/tools/clang-format/fuzzer/C
Author: zturner
Date: Thu Oct 12 14:56:05 2017
New Revision: 315627
URL: http://llvm.org/viewvc/llvm-project?rev=315627&view=rev
Log:
[lit] Raise the logic for enabling clang & lld substitutions to llvm.
This paves the way for other projects which might /use/ clang or
lld but not necessarily need
On Fri, Oct 13, 2017 at 12:12 AM, Nico Weber wrote:
> Huh, I consider clang not warning on this a feature, not a bug. Why are we
> trying to match what gcc does here?
Because i have been bitten by this more than once.
It did result in big amount of wasted time, and this "thread":
https://lists.llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315624: [CUDA] Added __hmma_m16n16k16_* builtins to support
mma instructions on sm_70 (authored by tra).
Changed prior to commit:
https://reviews.llvm.org/D38742?vs=118636&id=118848#toc
Repository:
r
Author: tra
Date: Thu Oct 12 14:32:19 2017
New Revision: 315624
URL: http://llvm.org/viewvc/llvm-project?rev=315624&view=rev
Log:
[CUDA] Added __hmma_m16n16k16_* builtins to support mma instructions on sm_70
Differential Revision: https://reviews.llvm.org/D38742
Added:
cfe/trunk/test/CodeGen
Author: lebedevri
Date: Thu Oct 12 14:15:26 2017
New Revision: 315622
URL: http://llvm.org/viewvc/llvm-project?rev=315622&view=rev
Log:
[Analysis] Un-silence -Wtautological-unsigned-zero-compare in null-deref-ps.c
Stage-2 builds failed:
error: 'warning' diagnostics expected but not seen:
File
Huh, I consider clang not warning on this a feature, not a bug. Why are we
trying to match what gcc does here?
Say you have code like this:
int64_t aligned_start = 0;
int64_t aligned_size = 0;
CalculateVMAlignedBoundaries(region.offset,
region.size,
mstorsjo added a comment.
This one can be abandoned now.
https://reviews.llvm.org/D36111
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: davide
Date: Thu Oct 12 14:08:29 2017
New Revision: 315621
URL: http://llvm.org/viewvc/llvm-project?rev=315621&view=rev
Log:
[SemaChecking] Suppress a GCC warning. NFCI.
Modified:
cfe/trunk/lib/Sema/SemaChecking.cpp
Modified: cfe/trunk/lib/Sema/SemaChecking.cpp
URL:
http://llvm.org/
rnk accepted this revision.
rnk added a comment.
lgtm
Comment at: src/libunwind.cpp:188
+ co->getInfo(&info);
+ pint_t orgArgSize = (pint_t)info.gp;
+ uint64_t orgFuncStart = info.start_ip;
mstorsjo wrote:
> rnk wrote:
> > I think it makes sense
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315620: [cmake] [asan] Remove unnecessary gtest dep from
dynamic tests (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D38840?vs=118826&id=118842#toc
Repository:
rL LLVM
http
Nebiroth updated this revision to Diff 118838.
Nebiroth marked an inline comment as done.
Nebiroth added a comment.
Addressed review comments.
Fixed some tests not having updated providers.
Removed TargetDeclarationFinder for less code reuse.
DocumentHighlight struct is now unparsed correctly.
h
Author: lebedevri
Date: Thu Oct 12 13:27:41 2017
New Revision: 315615
URL: http://llvm.org/viewvc/llvm-project?rev=315615&view=rev
Log:
[Analysis] Silence -Wtautological-constant-compare in two tests
Yes, did not check that. Need to do better :(
I do not believe it makes sense to do expect that w
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
LGTM, provided tests pass both in standalone and "normal" modes.
https://reviews.llvm.org/D38840
___
cfe-commits mailing list
yaxunl added inline comments.
Comment at: include/clang/Basic/AddressSpaces.h:66
+inline LangAS LangASFromTargetAS(unsigned TargetAS) {
+ return static_cast((TargetAS) +
how about `getLangASFromTargetAS` ? It is preferred to start with small letters.
===
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315614: [Sema] Diagnose tautological comparison with type's
min/max values (authored by lebedevri).
Changed prior to commit:
https://reviews.llvm.org/D38101?vs=118833&id=118835#toc
Repository:
rL LLV
Author: lebedevri
Date: Thu Oct 12 13:16:51 2017
New Revision: 315614
URL: http://llvm.org/viewvc/llvm-project?rev=315614&view=rev
Log:
[Sema] Diagnose tautological comparison with type's min/max values
Summary:
Currently, clang only diagnoses completely out-of-range comparisons (e.g.
`char` and
lebedev.ri updated this revision to Diff 118833.
lebedev.ri added a comment.
Getting really weird problems when trying to use arc patch, maybe re-updating
the differential helps
Repository:
rL LLVM
https://reviews.llvm.org/D38101
Files:
docs/ReleaseNotes.rst
include/clang/Basic/Diagnost
Author: abataev
Date: Thu Oct 12 13:03:39 2017
New Revision: 315611
URL: http://llvm.org/viewvc/llvm-project?rev=315611&view=rev
Log:
[OPENMP] Fix PR34927: Emit initializer for reduction array with declare
reduction.
If the reduction is an array or an array section and reduction operation
is decl
alexshap created this revision.
Herald added a subscriber: mgorny.
At the moment if LLVM_BUILD_INSTRUMENTED is set to True
one has to set LLVM_PROFTDATA even if it's not necessary (because of
message(FATAL_ERROR ...)).
Building instrumented Clang is useful even if one doesn't plan to use the
t
lebedev.ri added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:8930
+// We only care about expressions where just one side is literal
+if (IsRHSIntegralLiteral ^ IsLHSIntegralLiteral) {
+ // Is the constant on the RHS or LHS?
rsmith wrote:
>
lebedev.ri updated this revision to Diff 118829.
lebedev.ri marked an inline comment as done.
Repository:
rL LLVM
https://reviews.llvm.org/D38101
Files:
docs/ReleaseNotes.rst
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
mgorny updated this revision to Diff 118826.
mgorny retitled this revision from "[compiler-rt] [cmake] [asan] Reuse
generate_asan_tests for dynamic tests" to "[compiler-rt] [cmake] [asan] Remove
unnecessary gtest dep from dynamic tests".
mgorny edited the summary of this revision.
mgorny added a
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks, this looks great.
Comment at: lib/Sema/SemaChecking.cpp:8940
+ } else if (!T->hasUnsignedIntegerRepresentation())
+IsComparisonConstant = E->isIntegerConstantExp
Author: ctopper
Date: Thu Oct 12 11:57:15 2017
New Revision: 315607
URL: http://llvm.org/viewvc/llvm-project?rev=315607&view=rev
Log:
[X86] Add CLWB intrinsic. clang part
Reviewers: RKSimon, zvi, igorb
Reviewed By: RKSimon
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.or
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315607: [X86] Add CLWB intrinsic. clang part (authored by
ctopper).
Changed prior to commit:
https://reviews.llvm.org/D38781?vs=118816&id=118822#toc
Repository:
rL LLVM
https://reviews.llvm.org/D387
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315605: [cmake] [interception] Remove duplicate gtest from
test COMPILE_DEPS (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D38839?vs=118754&id=118821#toc
Repository:
rL LLVM
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315604: [cmake] Fix skipping DEPS (typo) in
sanitizer_test_compile() (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D38838?vs=118752&id=118820#toc
Repository:
rL LLVM
https:
yaxunl created this revision.
There are two issues:
1. only (void*)0 should be treated as nullptr
2. only explicit addr space should be printed
This patch introduces a flag in Qualifier to indicating a non-default address
space qualifier is deduced by context. Only
non-implicit address space q
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
LGTM - one minor
Comment at: lib/Headers/clwbintrin.h:42
+///
+/// \param __p
+///A pointer to the memory location used to identify the cache line to be
---
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315603: [clang-format] Allow building fuzzer with OSS-Fuzz
flags. (authored by morehouse).
Changed prior to commit:
https://reviews.llvm.org/D38853?vs=118805&id=118819#toc
Repository:
rL LLVM
https:
Author: morehouse
Date: Thu Oct 12 11:39:10 2017
New Revision: 315603
URL: http://llvm.org/viewvc/llvm-project?rev=315603&view=rev
Log:
[clang-format] Allow building fuzzer with OSS-Fuzz flags.
Reviewers: kcc, bogner
Reviewed By: kcc
Subscribers: cfe-commits, mgorny
Differential Revision: http
yaxunl updated this revision to Diff 118813.
yaxunl marked 7 inline comments as done.
yaxunl edited the summary of this revision.
yaxunl added a comment.
Separate implicit addr space flag to another patch as John suggested.
This patch only introduces the private addr space but does not print it.
craig.topper updated this revision to Diff 118816.
craig.topper added a comment.
Address review feedback
https://reviews.llvm.org/D38781
Files:
include/clang/Basic/BuiltinsX86.def
lib/Headers/CMakeLists.txt
lib/Headers/clwbintrin.h
lib/Headers/immintrin.h
test/CodeGen/builtin-clwb.c
kcc added a reviewer: bogner.
kcc accepted this revision.
kcc added a comment.
This revision is now accepted and ready to land.
LGTM
+Justin FYI
Please also take a look at llvm-isel-fuzzer, which I've just added to oss-fuzz
https://reviews.llvm.org/D38853
___
morehouse created this revision.
Herald added a subscriber: mgorny.
https://reviews.llvm.org/D38853
Files:
clang/tools/clang-format/CMakeLists.txt
clang/tools/clang-format/fuzzer/CMakeLists.txt
Index: clang/tools/clang-format/fuzzer/CMakeLists.txt
===
Author: ctopper
Date: Thu Oct 12 10:21:01 2017
New Revision: 315594
URL: http://llvm.org/viewvc/llvm-project?rev=315594&view=rev
Log:
[X86] Use -ffreestanding instead of using the mm_malloc.h include guard hack on
more of the builtin tests.
Modified:
cfe/trunk/test/CodeGen/adc-builtins.c
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
@arichardson, great work! Thanks a lot!
https://reviews.llvm.org/D38816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
@mgorny so this one actually changes semantics.
The previous one reused generated object files, and with the change it will
start recompiling all the tests again.
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
Yep, thanks! Good to go provided tests run.
Looks like we haven't spotted it due to other bug you have fixed cancelling
this one out.
https://reviews.llvm.org/D38838
__
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
Yep, thanks! This was probably the root cause of the failure.
https://reviews.llvm.org/D38839
___
cfe-commits mailing list
cf
I mention it only out of interest of deduplication of functionality/code
within the LLVM project as a whole. Be nice not to maintain two things if
one would suffice.
On Thu, Oct 12, 2017 at 6:21 AM Sam McCall wrote:
> Interesting - this is pretty primitive, and still fairly tightly coupled
> to
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: include/clang/Frontend/CodeGenOptions.def:182
CODEGENOPT(SoftFloat , 1, 0) ///< -soft-float.
+CODEGENOPT(FineGrainedBitfieldAccesses, 1, 0) ///< E
sgundapa created this revision.
Herald added a subscriber: eraman.
This patch has the following changes
1. A new flag "-mhvx-length={64B|128B}" is introduced to specify the
length of the vector. Previously we have used "-mhvx-double" for 128 Bytes.
This adds the target-feature "+hvx-length{64|12
danielmarjamaki added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:123
+ // Is variable changed anywhere in TU?
+ for (const Decl *D : AMgr.getASTContext().getTranslationUnitDecl()->decls())
{
+if (isChanged(D, VD))
danielmarjamaki w
arichardson added inline comments.
Comment at: lib/AST/TypePrinter.cpp:1323
OS << "address_space(";
-OS << T->getEquivalentType().getAddressSpace();
+OS << T->getEquivalentType()
+ .getQualifiers()
Anastasia wrote:
> Why do we need this
erichkeane added a comment.
Bump! I realize the two of you are super busy, but if anyone else on
cfe-commits wants to take a look, I'd apprecate it!
-Erich
https://reviews.llvm.org/D38700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
RKSimon added inline comments.
Comment at: lib/Headers/clwbintrin.h:34
+
+static __inline__ void __DEFAULT_FN_ATTRS
+_mm_clwb(void const *__m) {
Worth adding the doxygen description? You can probably just copy+paste+modify
the _mm_clflush documentation.
==
lebedev.ri added a comment.
In https://reviews.llvm.org/D36836#889375, @aaron.ballman wrote:
> Adding @dberlin for licensing discussion questions.
Ping.
Yes, i agree that what i have added is not a directory, and not a proper
license.
That is more of a template to hopefully stat moving things
danielmarjamaki added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:123
+ // Is variable changed anywhere in TU?
+ for (const Decl *D : AMgr.getASTContext().getTranslationUnitDecl()->decls())
{
+if (isChanged(D, VD))
dcoughlin wrote:
1 - 100 of 157 matches
Mail list logo
