vsk added a comment.

In https://reviews.llvm.org/D38859#896517, @alexshap wrote:

> yeah, i agree, this is not a good idea. My thoughts were different - right 
> now it's not particularly convenient that one has to specify LLVM_PROFDATA 
> when it's not actually used by the build.
>  Maybe we can create the target "generate-profdata" only if LLVM_PROFDATA is 
> set (but don't fail otherwise) ?


+ 1, sgtm


Repository:
  rL LLVM

https://reviews.llvm.org/D38859



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to