smeenai added a comment.
In https://reviews.llvm.org/D25208#647743, @EricWF wrote:
> Actually I probably shouldn't have approved this due to
> http://llvm.org/PR30642. I forgot about that when I last reviewed this.
Yup. I wrote https://github.com/smeenai/bad-visibility-finder to find all
prob
jlebar created this revision.
Herald added a subscriber: jholewinski.
Specifically, we upgrade llvm.nvvm.:
- brev{32,64}
- clz.{i,ll}
- popc.{i,ll}
- abs.{i,ll}
- {min,max}.{i,ll,u,ull}
- h2f
These either map directly to an existing LLVM target-generic
intrinsic or map to a simple LLVM target-ge
arpith-jacob updated this revision to Diff 84629.
arpith-jacob added a comment.
Updated 'getOpenMPCaptureRegions' to return the OMPD_teams region kind for the
teams directive.
https://reviews.llvm.org/D28753
Files:
include/clang/AST/StmtOpenMP.h
include/clang/Basic/OpenMPKinds.h
include/
arpith-jacob updated this revision to Diff 84627.
arpith-jacob added a comment.
Added a method 'getCapturedStmt' as part of OMPExecutableDirective.
https://reviews.llvm.org/D28753
Files:
include/clang/AST/StmtOpenMP.h
include/clang/Basic/OpenMPKinds.h
include/clang/Sema/Sema.h
lib/Basic
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292194: [AST] AttributedType should derive type properties
from the EquivalentType (authored by majnemer).
Changed prior to commit:
https://reviews.llvm.org/D28788?vs=84609&id=84625#toc
Repository:
r
Author: majnemer
Date: Mon Jan 16 22:14:25 2017
New Revision: 292194
URL: http://llvm.org/viewvc/llvm-project?rev=292194&view=rev
Log:
[AST] AttributedType should derive type properties from the EquivalentType
Using the canonical type instead of the equivalent type can result in
insufficient temp
Author: friss
Date: Mon Jan 16 21:38:45 2017
New Revision: 292192
URL: http://llvm.org/viewvc/llvm-project?rev=292192&view=rev
Log:
Fix AArch64 global-merge backend option name.
-mglobal-merge is translated to the appropriate backend option in
the driver. r277322 changed the AArch64 option name i
Author: ericwf
Date: Mon Jan 16 21:16:26 2017
New Revision: 292190
URL: http://llvm.org/viewvc/llvm-project?rev=292190&view=rev
Log:
Add ABI option to remove recently inlined __shared_count functions from the
library.
In order to allow inlining of previously out-of-line functions without an ABI
Author: ericwf
Date: Mon Jan 16 21:05:31 2017
New Revision: 292185
URL: http://llvm.org/viewvc/llvm-project?rev=292185&view=rev
Log:
Fix DLL build by removing _LIBCPP_FUNC_VIS from member of class marked dllexport
Modified:
libcxx/trunk/include/memory
Modified: libcxx/trunk/include/memory
UR
Author: hxy9243
Date: Mon Jan 16 20:46:33 2017
New Revision: 292184
URL: http://llvm.org/viewvc/llvm-project?rev=292184&view=rev
Log:
[Test patch] Inline hot functions in libcxx shared_ptr
Moves hot functions such as atomic add into the memory header file
so that they can be inlined, which brings
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292184: [Test patch] Inline hot functions in libcxx
shared_ptr (authored by hxy9243).
Changed prior to commit:
https://reviews.llvm.org/D24991?vs=84569&id=84622#toc
Repository:
rL LLVM
https://revie
Author: rsmith
Date: Mon Jan 16 20:14:37 2017
New Revision: 292183
URL: http://llvm.org/viewvc/llvm-project?rev=292183&view=rev
Log:
Partial revert of r290511.
The rules around typechecking deduced template arguments during partial
ordering are not clear, and while the prior behavior does not see
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
Actually I probably shouldn't have approved this due to
http://llvm.org/PR30642. I forgot about that when I last reviewed this.
https://reviews.llvm.org/D25208
__
graydon created this revision.
Code committed in https://reviews.llvm.org/rL290219 went through a few
iterations; test wound up with
stale comment.
https://reviews.llvm.org/D28790
Files:
test/Modules/implicit-private-with-different-name.m
Index: test/Modules/implicit-private-with-different
Author: ericwf
Date: Mon Jan 16 19:16:44 2017
New Revision: 292181
URL: http://llvm.org/viewvc/llvm-project?rev=292181&view=rev
Log:
Add warning messages to buildit/testit about their upcoming removal
Modified:
libcxx/trunk/lib/buildit
libcxx/trunk/test/testit
Modified: libcxx/trunk/lib/
EricWF updated this revision to Diff 84613.
EricWF retitled this revision from "Split exception.cpp implementation into
different files for different runtimes" to "Split exception.cpp and new.cpp
implementation into different files for different runtimes".
EricWF edited the summary of this revisi
Author: ericwf
Date: Mon Jan 16 18:32:08 2017
New Revision: 292177
URL: http://llvm.org/viewvc/llvm-project?rev=292177&view=rev
Log:
Rename new_handler in tests to avoid conflicts with MSVC symbols.
On Windows the header new.h defines "new_handler" in the global
namespace.
Modified:
libcxx/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292175: Update tools to use new getStyle API (authored by
amaiorano).
Changed prior to commit:
https://reviews.llvm.org/D28315?vs=84539&id=84611#toc
Repository:
rL LLVM
https://reviews.llvm.org/D283
Author: amaiorano
Date: Mon Jan 16 18:13:32 2017
New Revision: 292175
URL: http://llvm.org/viewvc/llvm-project?rev=292175&view=rev
Log:
Update tools to use new getStyle API
Depends on https://reviews.llvm.org/D28081
Differential Revision: https://reviews.llvm.org/D28315
Modified:
clang-tool
Author: amaiorano
Date: Mon Jan 16 18:12:27 2017
New Revision: 292174
URL: http://llvm.org/viewvc/llvm-project?rev=292174&view=rev
Log:
clang-format: Make GetStyle return Expected instead of FormatStyle
Change the contract of GetStyle so that it returns an error when an error occurs
(i.e. when it
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292174: clang-format: Make GetStyle return
Expected instead of FormatStyle (authored by amaiorano).
Changed prior to commit:
https://reviews.llvm.org/D28081?vs=84538&id=84610#toc
Repository:
rL LLVM
majnemer created this revision.
Using the canonical type instead of the equivalent type can result in
insufficient template instantiations.
This fixes PR31656.
https://reviews.llvm.org/D28788
Files:
include/clang/AST/Type.h
test/CodeGenCXX/microsoft-abi-default-cc.cpp
Index: test/CodeGen
EricWF created this revision.
`exception.cpp` is a bloody mess. It's full of confusing `#ifdef` branches for
each different ABI library we support, and it's getting unmaintainable.
This patch breaks down `exception.cpp` into multiple different header files,
roughly one per implementation.
htt
alexfh added inline comments.
Comment at: test/clang-tidy/modernize-raw-string-literal.cpp:94
+char const *const Concatenated("\"foo\""
+ "\"bar\"");
leanil wrote:
> alexfh wrote:
> > Does this test fail without the patch? Also, sh
arpith-jacob created this revision.
The if-clause on the combined directive potentially applies to both the
'target' and the 'parallel' regions. Codegen'ing the if-clause on the
combined directive requires additional support because the expression in
the clause must be captured by the 'target' cap
I got an email where it says that I accepted the revision. Looks like
phab didn't add cfe-commits to the list of recipients though :(
On Mon, Jan 16, 2017 at 6:43 PM, David Blaikie wrote:
> Looks like Ben signed off on this on Phab - but the email didn't go to the
> list (making this look like co
graydon created this revision.
Add a callback from ASTReader to DeserializationListener when the former
reads an IMPORTED_MODULES block. This supports Swift in using PCH for
bridging headers.
https://reviews.llvm.org/D28779
Files:
include/clang/Serialization/ASTDeserializationListener.h
lib
mclow.lists updated this revision to Diff 84593.
mclow.lists added a comment.
Updated the macro name.
Use REQUIRES-ALL
Found a couple more tests that needed to be updated.
Fixed the libcxx/test bit.
https://reviews.llvm.org/D20660
Files:
include/memory
test/libcxx/depr/depr.auto.ptr/auto.pt
JDevlieghere updated this revision to Diff 84589.
JDevlieghere added a comment.
- Don't replace explicit constructors
- Add @Prazek's suggested tests
Repository:
rL LLVM
https://reviews.llvm.org/D28768
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cp
mclow.lists added a comment.
> there's probably a better way to state `_LIBCPP_STD_VER <= 14 ||
> defined(_LIBCPP_NO_REMOVE_AUTO_PTR)`.
There probably is; but remember, we want to make it so someone can
`-D_LIBCPP_NO_REMOVE_AUTO_PTR` on the command-line and get this back.
> I would love to hav
Author: ericwf
Date: Mon Jan 16 15:15:08 2017
New Revision: 292159
URL: http://llvm.org/viewvc/llvm-project?rev=292159&view=rev
Log:
Fix std::tuples EBO when targeting the MSVC ABI.
MSVC/clang-cl doesn't do a full EBO unless __declspec(empty_bases)
is applied to the derived type. This causes cert
Prazek added inline comments.
Comment at: test/clang-tidy/modernize-return-braced-init-list.cpp:95
+}
+
+vector f6() {
please also add test that contains
for function
Type foo():
return call(Type());
return OtherType(Type()); // implicit conversion
It would
Prazek added inline comments.
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:52-53
+ for (const auto &NoExceptRange : NoExceptRanges) {
+// FIXME use DiagnosticIDs::Level::Note
+diag(NoExceptRange.getBegin(), "In function declared no-throw here:")
+<< Fix
Upgrade done. Phab is up again.
On Mon, Jan 16, 2017 at 9:36 PM Eric Liu wrote:
> Hi all,
>
> Sorry about the short notice, but I am about to push an upgrade for
> Phabricator. The upgrade might take a while (<30 mins hopefully).
>
> Thanks,
> Eric
>
_
Author: ericwf
Date: Mon Jan 16 15:01:00 2017
New Revision: 292158
URL: http://llvm.org/viewvc/llvm-project?rev=292158&view=rev
Log:
[libc++] Introduce _LIBCPP_EXTERN_VIS to fix __libcpp_debug_function link errors
Summary: On Windows tests that use `_LIBCPP_ASSERT` fail to link because the
asser
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D28728#646489, @smeenai wrote:
> This will need to be exported on other platforms too when hidden visibility
> happens :)
Are you sure?I don't think "extern" vari
Author: ericwf
Date: Mon Jan 16 14:47:35 2017
New Revision: 292157
URL: http://llvm.org/viewvc/llvm-project?rev=292157&view=rev
Log:
Improve CMake and LIT support for Windows
This patch contains multiple cleanups and fixes to better support building on
Windows.
* [Test] Fix handling of library r
Hi all,
Sorry about the short notice, but I am about to push an upgrade for
Phabricator. The upgrade might take a while (<30 mins hopefully).
Thanks,
Eric
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D24991
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
Author: ericwf
Date: Mon Jan 16 13:52:58 2017
New Revision: 292152
URL: http://llvm.org/viewvc/llvm-project?rev=292152&view=rev
Log:
Make sym_check python 3 compatible
Modified:
libcxx/trunk/utils/sym_check/sym_check/util.py
Modified: libcxx/trunk/utils/sym_check/sym_check/util.py
URL:
http
JDevlieghere added a comment.
In https://reviews.llvm.org/D28768#647333, @Prazek wrote:
> Thanks for the check. Have you run it on llvm?
Not yet, there was an issue with templated types and I wanted to fix that
first. It's running now.
Repository:
rL LLVM
https://reviews.llvm.org/D28768
JDevlieghere updated this revision to Diff 84581.
JDevlieghere marked 8 inline comments as done.
JDevlieghere added a comment.
- Added more tests
- Improved matchers
- Addressed code review comments from @malcolm.parsons, @Prazek and
@aaron.ballman
Repository:
rL LLVM
https://reviews.llvm.or
Hello everyone,
LLVM buildmaster will be updated and restarted after 5 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D28705
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
sbarzowski removed rL LLVM as the repository for this revision.
sbarzowski updated this revision to Diff 84577.
sbarzowski added a comment.
Herald added subscribers: JDevlieghere, mgorny.
I took advantage of new getExceptionSpecSourceRange (it wasn't available
before) instead of getting exception
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/ReturnBracedInitListCheck.cpp:60
+ auto Diag =
+ diag(Loc, "use braced initializer list for constructing return types");
+
This diagnostic doesn't really tell the user what's wrong with t
enyquist added inline comments.
Comment at: Format/FormatToken.h:148
+ /// \brief Whether the token is the final token in the identifier of a PP
+ // macro. This will be either 1) the identifier token following the 'define'
djasper wrote:
> This adds a lot of
Looks like Ben signed off on this on Phab - but the email didn't go to the
list (making this look like code was sent for review, then committed,
without review/approval happening)
Ben: I think Phab doesn't send mail for an approval with no text, so at
least as a workaround you can write something
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg.
Comment at: test/clang-move/no-move-macro-helpers.cpp:1
+// RUN: mkdir -p %T/no-move-macro-helper
+// RUN: cp %S/Inputs/macro_helper_test.h
%T/no-move-macro-helper/macr
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
Also ignore helpers which are defined in macro. Currently clang-move doesn't
handle macro well enough, especiall for complex macros. This patch will ignore
declarations in macros to make the beha
hxy9243 updated this revision to Diff 84569.
hxy9243 added a comment.
Addresses comments from @mclow.lists.
Repository:
rL LLVM
https://reviews.llvm.org/D24991
Files:
libcxx/include/memory
libcxx/src/memory.cpp
Index: libcxx/src/memory.cpp
===
alexfh added a comment.
In https://reviews.llvm.org/D28729#647250, @Prazek wrote:
> Does solution like this works for you? We don't officially support alpha
> checkers, but it is much easier to check if something is already implemented
> in static analyzer easily
Is it the only problem you're
mclow.lists added inline comments.
Comment at: libcxx/include/memory:3700
+
+template
+inline T
`template `, please.
Otherwise when some client code does `#define T true` (yes, I've seen that!)
this breaks. `_Tp` is a reserved identifier, and if they use that
Prazek added a comment.
Thanks for the check. Have you run it on llvm?
Comment at: clang-tidy/modernize/ReturnBracedInitListCheck.cpp:27-32
+ auto soughtConstructExpr =
+ cxxConstructExpr(unless(isListInitialization())).bind("ctor");
+
+ auto hasConstructExpr = has(ignor
hxy9243 updated this revision to Diff 84565.
hxy9243 added a comment.
Addresses comments from @EricWF.
Thanks for reviewing, I know it takes a lot of energy. It helped me learn a lot.
Repository:
rL LLVM
https://reviews.llvm.org/D24991
Files:
libcxx/include/memory
libcxx/src/memory.cpp
arphaman updated this revision to Diff 84564.
arphaman marked an inline comment as done.
arphaman added a comment.
Use better diagnostic message as suggested by Erik
Repository:
rL LLVM
https://reviews.llvm.org/D28670
Files:
include/clang/AST/DeclBase.h
include/clang/Basic/DiagnosticSema
arphaman added inline comments.
Comment at: lib/Sema/SemaDeclObjC.cpp:4337
+ VersionTuple MethodVersion = Method->getVersionIntroduced();
+ if (SemaRef.getASTContext().getTargetInfo().getPlatformMinVersion() >=
+ AcceptedInVersion &&
erik.pilkington wr
Author: labath
Date: Mon Jan 16 09:57:07 2017
New Revision: 292141
URL: http://llvm.org/viewvc/llvm-project?rev=292141&view=rev
Log:
[StaticAnalyzer] Fix android build
std::to_string is not available in the android NDK. Use llvm::to_string instead.
Committing as obvious.
Modified:
cfe/trunk
Author: marshall
Date: Mon Jan 16 09:28:03 2017
New Revision: 292135
URL: http://llvm.org/viewvc/llvm-project?rev=292135&view=rev
Log:
Mark the dynamic-exception tests as unsupported under C++17, since it has no
dynamic-exception specs. Also, remove a FIXME workaround from the config that
allowe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292134: [OpenMP] Refactor code that calls codegen for target
regions on the device. (authored by arpith).
Changed prior to commit:
https://reviews.llvm.org/D28752?vs=84509&id=84563#toc
Repository:
rL
Author: arpith
Date: Mon Jan 16 09:26:02 2017
New Revision: 292134
URL: http://llvm.org/viewvc/llvm-project?rev=292134&view=rev
Log:
[OpenMP] Refactor code that calls codegen for target regions on the device.
This patch refactors code that calls codegen for target regions. Currently
the codebase
arpith-jacob added a comment.
Thanks Alexey.
> Is this an NFC patch? If so add 'NFC' to this patch.
Do you mean NVPTX? No, this is a patch to support target directives for any
accelerator.
https://reviews.llvm.org/D28752
___
cfe-commits mailing
arphaman created this revision.
arphaman added reviewers: bruno, rsmith, akyrtzi.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
Herald added a subscriber: nemanjai.
This patch fixes a token caching problem that currently occurs when clang is
s
djasper added inline comments.
Comment at: Format/FormatToken.h:148
+ /// \brief Whether the token is the final token in the identifier of a PP
+ // macro. This will be either 1) the identifier token following the 'define'
This adds a lot of code, runtime and
Author: joerg
Date: Mon Jan 16 08:07:24 2017
New Revision: 292119
URL: http://llvm.org/viewvc/llvm-project?rev=292119&view=rev
Log:
Ensure that clang -pthread creates the right macro. -D_POSIX_THREADS
seems to have been a C&P error from old GCC specs for OpenBSD.
Modified:
cfe/trunk/lib/Basic
baloghadamsoftware added a comment.
Any progress regarding this patch? Is https://reviews.llvm.org/D26837
necessarily a dependency, or we just need isCompoundType() function? This
function could be moved to a separate patch so the dependency could be removed.
https://reviews.llvm.org/D27202
Author: djasper
Date: Mon Jan 16 07:43:46 2017
New Revision: 292116
URL: http://llvm.org/viewvc/llvm-project?rev=292116&view=rev
Log:
Fix test failures after recent clang-format format change.
Modified:
cfe/trunk/test/Index/overriding-ftemplate-comments.cpp
Modified: cfe/trunk/test/Index/ove
Author: aaronballman
Date: Mon Jan 16 07:42:21 2017
New Revision: 292115
URL: http://llvm.org/viewvc/llvm-project?rev=292115&view=rev
Log:
Replace non-ASCII ellipsis with "..." to silence Sphinx warnings.
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/trunk/docs/UsersManual.rst
URL:
baloghadamsoftware created this revision.
baloghadamsoftware added reviewers: zaks.anna, NoQ.
baloghadamsoftware added subscribers: xazax.hun, o.gyorgy, cfe-commits.
This patch fixes some issues for the IteratorPastEnd checkers. There are
basically two main issues this patch targets: one is the h
Prazek added a comment.
I also have sent it on the branch
Repository:
rL LLVM
https://reviews.llvm.org/D28727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Prazek marked an inline comment as done.
Closed by commit rL292112: Add -fstrict-vtable-pointers to UsersManual
(authored by Prazek).
Changed prior to commit:
https://reviews.llvm.org/D28727?vs=84492&id=84551#toc
Reposit
Author: prazek
Date: Mon Jan 16 07:20:08 2017
New Revision: 292112
URL: http://llvm.org/viewvc/llvm-project?rev=292112&view=rev
Log:
Add -fstrict-vtable-pointers to UsersManual
Summary: Add missing flag to UsersManual
It would be good to merge it to 4.0 branch.
Reviewers: hans
Subscribers: cfe-
Prazek closed this revision.
Prazek added a comment.
Pushed on branch.
Please check if everything looks good when RC will be released.
https://reviews.llvm.org/D28746
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
Prazek added a comment.
Does solution like this works for you? We don't officially support alpha
checkers, but it is much easier to check if something is already implemented in
static analyzer easily
https://reviews.llvm.org/D28729
___
cfe-commits
Prazek closed this revision.
Prazek added a comment.
Pushed on branch
https://reviews.llvm.org/D28606
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek updated this revision to Diff 84550.
Prazek marked an inline comment as done.
Prazek added a comment.
-enable-alpha-checks is now not visible for users, but it make
my life as clang-tidy developer much easier.
https://reviews.llvm.org/D28729
Files:
clang-tidy/ClangTidy.cpp
clang-tid
Author: djasper
Date: Mon Jan 16 07:13:15 2017
New Revision: 292110
URL: http://llvm.org/viewvc/llvm-project?rev=292110&view=rev
Log:
clang-format: Always wrap before multi-line parameters/operands.
Before:
aa(, aaa::
Author: asiri
Date: Mon Jan 16 07:13:01 2017
New Revision: 292109
URL: http://llvm.org/viewvc/llvm-project?rev=292109&view=rev
Log:
[libcxx] Follow-up to r292107
I've missed a couple of updates. NFC.
Modified:
libcxx/trunk/src/thread.cpp
Modified: libcxx/trunk/src/thread.cpp
URL:
http://ll
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lgtm. Thanks!
https://reviews.llvm.org/D28315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lgtm. Thanks!
https://reviews.llvm.org/D28081
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
amaiorano added a comment.
In https://reviews.llvm.org/D28315#647212, @ioeric wrote:
> In https://reviews.llvm.org/D28315#647154, @amaiorano wrote:
>
> > In https://reviews.llvm.org/D28315#647103, @ioeric wrote:
> >
> > > Let me know when broken tests are fixed and this patch (and the
> > > corr
malcolm.parsons added a comment.
`{}` doesn't allow narrowing; can you check for that?
Comment at: clang-tidy/modernize/ReturnBracedInitListCheck.cpp:50
+ SourceLocation Loc = MatchedConstructExpr->getExprLoc();
+ if (Loc.isMacroID())
+return;
Test?
===
JDevlieghere updated this revision to Diff 84549.
JDevlieghere added a comment.
Add test for auto return type.
Repository:
rL LLVM
https://reviews.llvm.org/D28768
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/ReturnBracedIn
JDevlieghere added a comment.
In https://reviews.llvm.org/D28768#647206, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D28768#647204, @JDevlieghere wrote:
>
> > I wanted to do that but it seems that the test script hard codes it to
> > C++11, and the `auto` return type is a C++14 feature
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292108: [libcxx] Improve design documentation for the
external-thread-library (authored by asiri).
Changed prior to commit:
https://reviews.llvm.org/D28610?vs=84129&id=84548#toc
Repository:
rL LLVM
Author: asiri
Date: Mon Jan 16 06:44:08 2017
New Revision: 292108
URL: http://llvm.org/viewvc/llvm-project?rev=292108&view=rev
Log:
[libcxx] Improve design documentation for the external-thread-library
configuration
NFC.
Differential revision: https://reviews.llvm.org/D28610
Reviewers: EricWF
ioeric added a comment.
In https://reviews.llvm.org/D28315#647154, @amaiorano wrote:
> In https://reviews.llvm.org/D28315#647103, @ioeric wrote:
>
> > Let me know when broken tests are fixed and this patch (and the
> > corresponding patch) is ready again for review. Also let me know if you
> >
malcolm.parsons added a comment.
In https://reviews.llvm.org/D28768#647204, @JDevlieghere wrote:
> I wanted to do that but it seems that the test script hard codes it to C++11,
> and the `auto` return type is a C++14 feature. Maybe I'm mistaken though, but
> I didn't manage to get it working, e
JDevlieghere marked 2 inline comments as done.
JDevlieghere added a comment.
In https://reviews.llvm.org/D28768#647203, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D28768#647198, @JDevlieghere wrote:
>
> > In https://reviews.llvm.org/D28768#647177, @malcolm.parsons wrote:
> >
> > > What
malcolm.parsons added a comment.
In https://reviews.llvm.org/D28768#647198, @JDevlieghere wrote:
> In https://reviews.llvm.org/D28768#647177, @malcolm.parsons wrote:
>
> > What happens if the function has `auto` as the return type?
>
>
> Nothing, the constructor is left untouched.
Please add a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292107: [libcxx] Don't assume __libcpp_thread_t is an
integral type (authored by asiri).
Changed prior to commit:
https://reviews.llvm.org/D28608?vs=84114&id=84544#toc
Repository:
rL LLVM
https://re
Author: asiri
Date: Mon Jan 16 06:19:54 2017
New Revision: 292107
URL: http://llvm.org/viewvc/llvm-project?rev=292107&view=rev
Log:
[libcxx] Don't assume __libcpp_thread_t is an integral type
We have already refactored the underlying platform thread type into
__libcpp_thread_t, but there are few
JDevlieghere updated this revision to Diff 84543.
JDevlieghere added a comment.
- Fixed comments from @malcolm.parsons
In https://reviews.llvm.org/D28768#647177, @malcolm.parsons wrote:
> What happens if the function has `auto` as the return type?
Nothing, the constructor is left untouched.
malcolm.parsons added a comment.
What happens if the function has `auto` as the return type?
Comment at: clang-tidy/modernize/ReturnBracedInitListCheck.cpp:23
+void ReturnBracedInitListCheck::registerMatchers(MatchFinder *Finder) {
+ // Only register the matchers for C++.
+ i
JDevlieghere created this revision.
JDevlieghere added reviewers: hokein, Prazek, aaron.ballman, alexfh.
JDevlieghere added a subscriber: cfe-commits.
JDevlieghere set the repository for this revision to rL LLVM.
JDevlieghere added a project: clang-tools-extra.
Herald added a subscriber: mgorny.
R
amaiorano added a comment.
In https://reviews.llvm.org/D28315#647103, @ioeric wrote:
> Let me know when broken tests are fixed and this patch (and the corresponding
> patch) is ready again for review. Also let me know if you need any help.
I updated the two patches after rebasing on latest (no
amaiorano updated this revision to Diff 84539.
amaiorano added a comment.
Rebased changes on latest. No functional changes in this diff since last.
All tests pass (on Windows).
https://reviews.llvm.org/D28315
Files:
change-namespace/ChangeNamespace.cpp
clang-apply-replacements/tool/ClangAp
amaiorano updated this revision to Diff 84538.
amaiorano added a comment.
Rebased changes on latest, no functional change in this diff.
https://reviews.llvm.org/D28081
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Tooling/Refactoring.cpp
test/Format/style-on-command-lin
vlad.tsyrklevich created this revision.
vlad.tsyrklevich added reviewers: cfe-commits, zaks.anna, dcoughlin, NoQ.
CStringChecker assumes that SVals are not undefined at two points with comments
stating that other checkers will check for that condition first; however, it
can crash if a user choos
arphaman added a comment.
Are there any other comments for this patch? I would like to commit it in the
next couple of days, as it was accepted and I believe I addressed Richard's
concerns.
Thanks
Repository:
rL LLVM
https://reviews.llvm.org/D25817
__
1 - 100 of 111 matches
Mail list logo
