alexfh added inline comments.
================
Comment at: test/clang-tidy/modernize-raw-string-literal.cpp:94
+char const *const Concatenated("\"foo\""
+ "\"bar\"");
----------------
leanil wrote:
> alexfh wrote:
> > Does this test fail without the patch? Also, should there be a test
> > covering the case where no replacement is made (and the current code issues
> > a warning)?
> No, it doesn't. This is to check that MeasureTokenLength works as I expect.
> It wouldn't warn if it measured the two parts separately.
> And I left the check here for those who may have the same concerns, although
> it's indeed not the core functionality I test here. Should I remove it?
The test is fine, but it's better to add it as a separate patch. This patch
needs proper tests of the new functionality.
https://reviews.llvm.org/D28667
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
