amaiorano added a comment. In https://reviews.llvm.org/D28315#647212, @ioeric wrote:
> In https://reviews.llvm.org/D28315#647154, @amaiorano wrote: > > > In https://reviews.llvm.org/D28315#647103, @ioeric wrote: > > > > > Let me know when broken tests are fixed and this patch (and the > > > corresponding patch) is ready again for review. Also let me know if you > > > need any help. > > > > > > I updated the two patches after rebasing on latest (no conflicts). These > > should be ready to go. If you don't mind testing the two again on Linux, > > that would be greatly appreciated. Otherwise, on Windows the tests pass. > > > All tests passed on Linux. Are these patches still depending on > https://reviews.llvm.org/D28419? Or the previous issue has been somehow > resolved on Windows? Thank you for testing it on Linux. No, there is no dependency on https://reviews.llvm.org/D28419 insofar as getting these 2 patches in. https://reviews.llvm.org/D28419 is about making sure tests work on Windows if you use Git and set core.autocrlf; however, I suspect the Windows build machines are using svn. https://reviews.llvm.org/D28315 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
