smeenai added a comment. In https://reviews.llvm.org/D25208#647743, @EricWF wrote:
> Actually I probably shouldn't have approved this due to > http://llvm.org/PR30642. I forgot about that when I last reviewed this. Yup. I wrote https://github.com/smeenai/bad-visibility-finder to find all problematic instances, and https://reviews.llvm.org/D27430 fixes all the issues caused by this diff (I haven't gotten around to addressing the comments on that yet). https://reviews.llvm.org/D25208 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
