danielmarjamaki created this revision.
danielmarjamaki added reviewers: zaks.anna, dcoughlin.
danielmarjamaki added a subscriber: cfe-commits.
danielmarjamaki set the repository for this revision to rL LLVM.
Example code:
void f1(int x) {
int a[20] = {0};
if (x==25) {}
if (a[x] == 1
eladcohen added a comment.
ping
https://reviews.llvm.org/D27897
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Dylan McKay writes:
> Did you get the BugZilla account sorted Senthil?
Nope, direct email also didn't help. Can you please file a bug with
Title:
UINT16_TYPE and INT16_TYPE are defined as short instead of int for AVR
Description:
UINT16_TYPE and INT16_TYPE are implicitly defined by the pr
Author: compnerd
Date: Tue Jan 3 23:49:57 2017
New Revision: 290939
URL: http://llvm.org/viewvc/llvm-project?rev=290939&view=rev
Log:
build: use the platform dependent library prefix/suffix
Use the cmake variables to get the platform dependent values for the
static library prefix and suffix, whi
Author: compnerd
Date: Tue Jan 3 23:50:01 2017
New Revision: 290941
URL: http://llvm.org/viewvc/llvm-project?rev=290941&view=rev
Log:
fix elast configuration on Windows targets
A typo and missing header inclusion was obscured by the litany of user
defined literal warnings. This fixes the detect
Author: compnerd
Date: Tue Jan 3 23:49:59 2017
New Revision: 290940
URL: http://llvm.org/viewvc/llvm-project?rev=290940&view=rev
Log:
config: MSVC 19+ has unicode chars
MSVC 19+ and clang-cl with emulation version >= 19.00 will provide
char{16,32}_t as builtin types. Adjust the configuration ac
Author: compnerd
Date: Tue Jan 3 23:49:55 2017
New Revision: 290938
URL: http://llvm.org/viewvc/llvm-project?rev=290938&view=rev
Log:
build: use more portable spelling for flag
Use `CMAKE_LIBRARY_PATH_FLAG` instead of hard-coding it to -L. This
silences a warning with cl which expects `/LIBPATH
Author: compnerd
Date: Tue Jan 3 23:45:24 2017
New Revision: 290937
URL: http://llvm.org/viewvc/llvm-project?rev=290937&view=rev
Log:
tweak definition to avoid GCC warning
Use an `extern "C" { }` block around the definition rather than doing
the inline definition. This avoids a GCC warning abou
hintonda updated this revision to Diff 83000.
hintonda added a comment.
Rollback previous change and instead only call
actOnDelayedExceptionSpecification if noexcept type is not EST_None.
https://reviews.llvm.org/D28258
Files:
lib/Parse/ParseCXXInlineMethods.cpp
Index: lib/Parse/ParseCXXInl
Author: alexshap
Date: Tue Jan 3 22:33:28 2017
New Revision: 290936
URL: http://llvm.org/viewvc/llvm-project?rev=290936&view=rev
Log:
[clang] Update lit config in utils/perf-training
This diff replaces --driver-mode=cpp in
utils/perf-training/order-files.lit.cfg and
utils/perf-training/lit.cfg w
This revision was automatically updated to reflect the committed changes.
Closed by commit rL290936: [clang] Update lit config in utils/perf-training
(authored by alexshap).
Changed prior to commit:
https://reviews.llvm.org/D28269?vs=82986&id=82999#toc
Repository:
rL LLVM
https://reviews.ll
amaiorano added a comment.
In https://reviews.llvm.org/D28081#633786, @ioeric wrote:
> The patch LGTM now. I'll accept both this and the one for clang-tool-extra
> when it is ready.
>
> Regarding builbots, we have bots that continually run builds/tests
> (http://lab.llvm.org:8011/). Many buildb
smeenai added a comment.
In https://reviews.llvm.org/D27430#634882, @smeenai wrote:
> In https://reviews.llvm.org/D27430#634880, @smeenai wrote:
>
> > Sounds good to me for `_LIBCPP_HIDDEN`, but as far as I understand, for the
> > `inline _LIBCPP_INLINE_VISIBILITY` cases, at least the `inline` n
hintonda added a comment.
Richard, what do you think about just avoiding the problem altogether by only
calling actOnDelayedExceptionSpecification is noexcept type != EST_None?
https://reviews.llvm.org/D28258
___
cfe-commits mailing list
cfe-commit
smeenai added a comment.
In https://reviews.llvm.org/D27430#634880, @smeenai wrote:
> Sounds good to me for `_LIBCPP_HIDDEN`, but as far as I understand, for the
> `inline _LIBCPP_INLINE_VISIBILITY` cases, at least the `inline` needs to be
> at the definition itself, otherwise it won't have any
smeenai added a comment.
In https://reviews.llvm.org/D27430#632652, @EricWF wrote:
> Please put these attributes to the first declaration instead of the
> definition.
Sounds good to me for `_LIBCPP_HIDDEN`, but as far as I understand, for the
`inline _LIBCPP_INLINE_VISIBILITY` cases, at least
Author: rsmith
Date: Tue Jan 3 20:59:16 2017
New Revision: 290933
URL: http://llvm.org/viewvc/llvm-project?rev=290933&view=rev
Log:
Fix deduction of pack elements after a braced-init-list.
Previously, if the arguments for a parameter pack contained a braced-init-list,
we would abort deduction (k
rnk created this revision.
rnk added a reviewer: rsmith.
rnk added a subscriber: cfe-commits.
Replace some old code that probably pre-dated the change to delay
emission of dllexported code until after the closing brace of the
outermost record type. Only uninstantiated default argument expressions
thakis closed this revision.
thakis added a comment.
http://llvm.org/viewvc/llvm-project?view=revision&revision=290930
https://reviews.llvm.org/D28165
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Author: nico
Date: Tue Jan 3 20:33:36 2017
New Revision: 290930
URL: http://llvm.org/viewvc/llvm-project?rev=290930&view=rev
Log:
Change clang-format's Chromium JavaScript defaults
Chromium is starting to use clang-format on more JavaScript.
In doing this, we discovered that our defaults were n
beanz added a comment.
LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D28269
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danbeam updated this revision to Diff 82989.
danbeam marked an inline comment as done.
danbeam added a comment.
setting up arc
https://reviews.llvm.org/D28165
Files:
lib/Format/Format.cpp
Index: lib/Format/Format.cpp
===
--- li
Author: rsmith
Date: Tue Jan 3 20:03:39 2017
New Revision: 290926
URL: http://llvm.org/viewvc/llvm-project?rev=290926&view=rev
Log:
Remove accidentally-added lines in r290923 test, and add another testcase.
Modified:
cfe/trunk/test/SemaTemplate/deduction.cpp
Modified: cfe/trunk/test/SemaTem
jlebar created this revision.
jlebar added a reviewer: rnk.
jlebar added a subscriber: cfe-commits.
All callers of CheckCallingConvAttr passed FD == nullptr, so just get
rid of the aspirational function arg.
https://reviews.llvm.org/D28271
Files:
clang/include/clang/Sema/Sema.h
clang/lib/Se
alexshap updated this revision to Diff 82986.
alexshap added a comment.
switch to --driver-mode=g++
Repository:
rL LLVM
https://reviews.llvm.org/D28269
Files:
utils/perf-training/lit.cfg
utils/perf-training/order-files.lit.cfg
Index: utils/perf-training/order-files.lit.cfg
Author: compnerd
Date: Tue Jan 3 19:53:24 2017
New Revision: 290924
URL: http://llvm.org/viewvc/llvm-project?rev=290924&view=rev
Log:
Refactor bitscan64 check
Introduce a `_LIBCPP_HAS_BITSCAN64` macro to specify if the 64-bit
variant of the bitscan family of APIs is available. This avoids
dupli
aaron.ballman updated this revision to Diff 82985.
aaron.ballman marked 3 inline comments as done.
aaron.ballman added a comment.
Stripped out the codegen changes since @rnk 's commit fixed the issue.
https://reviews.llvm.org/D28166
Files:
include/clang/AST/Type.h
include/clang/AST/TypeLoc.
aaron.ballman marked an inline comment as done.
aaron.ballman added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.h:3570
for (auto *A : llvm::make_range(Arg, ArgRange.end()))
- ArgTypes.push_back(getVarArgType(A));
+ ArgTypes.push_back(getVarArgType(A, C
Author: rsmith
Date: Tue Jan 3 19:48:55 2017
New Revision: 290923
URL: http://llvm.org/viewvc/llvm-project?rev=290923&view=rev
Log:
Fix template argument deduction when only some of a parameter pack is a
non-deduced context.
When a parameter pack has multiple corresponding arguments, and some s
alexshap added a comment.
btw: --driver-mode=g++ works as well
Repository:
rL LLVM
https://reviews.llvm.org/D28269
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexshap added a comment.
it works for me, i have just double checked. Although to generate a file which
provides any measurable improvements (was i measuring the total build time of
LLVM (using the new binary)) i had to make some extra changes
(on OSX 10.12.1) (slightly change dtrace script, r
compnerd updated this revision to Diff 82983.
compnerd marked 3 inline comments as done.
compnerd added a comment.
Use l-values, static_cast.
Repository:
rL LLVM
https://reviews.llvm.org/D28226
Files:
include/__threading_support
include/mutex
Index: include/mutex
===
compnerd marked 3 inline comments as done.
compnerd added inline comments.
Comment at: include/__threading_support:91
+ {
+return reinterpret_cast<__libcpp_mutex_t*>(__value);
+ }
EricWF wrote:
> Wouldn't a `static_cast` be valid here?
Yeah.
=
beanz added a comment.
I don't think this works either. Pretty sure not setting the driver mode
defaults it to gcc, when we should be setting it to g++.
Can you try setting driver mode to g++ instead of removing the flag?
Repository:
rL LLVM
https://reviews.llvm.org/D28269
__
alexshap created this revision.
alexshap added reviewers: mehdi_amini, beanz, bogner.
alexshap added a subscriber: cfe-commits.
alexshap set the repository for this revision to rL LLVM.
This diff removes --driver-mode=cpp from
utils/perf-training/order-files.lit.cfg and
utils/perf-training/lit.cf
Author: stl_msft
Date: Tue Jan 3 18:53:41 2017
New Revision: 290922
URL: http://llvm.org/viewvc/llvm-project?rev=290922&view=rev
Log:
[libcxx] [test] Strip trailing whitespace.
Fixes D27786.
Modified:
libcxx/trunk/test/std/experimental/utilities/meta/meta.detect/detected_or.pass.cpp
l
Author: stl_msft
Date: Tue Jan 3 18:53:31 2017
New Revision: 290921
URL: http://llvm.org/viewvc/llvm-project?rev=290921&view=rev
Log:
[libcxx] [test] Fix recently introduced warnings emitted by MSVC.
These tests were using malloc()'s return value without checking for null,
which MSVC's /analyze
Author: rtrieu
Date: Tue Jan 3 18:46:30 2017
New Revision: 290920
URL: http://llvm.org/viewvc/llvm-project?rev=290920&view=rev
Log:
Extend -Wtautological-overlap-compare to more cases.
Previously, -Wtautological-overlap-compare did not warn on cases where the
boolean expression was in an assignm
erichkeane added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:13499
+ if (Attr)
+ProcessDeclAttributeList(S, New, Attr);
+
I wasn't sure if this was the correct change in here. My other option was to
move the above 2 lines (13495/13496) above these l
erichkeane created this revision.
erichkeane added reviewers: cfe-commits, bruno, aaron.ballman, rsmith.
This is an update of this patch: https://reviews.llvm.org/D25824
I cannot seem to get that review to update with my diff. This first patch
removes the dependency on isParsing and switches to
hintonda added inline comments.
Comment at: lib/Parse/ParseDeclCXX.cpp:3547
NoexceptRange = SourceRange(KeywordLoc, T.getCloseLocation());
-} else {
- NoexceptType = EST_None;
}
} else {
rsmith wrote:
> Should `NoexceptRange` be set in the
Author: dehao
Date: Tue Jan 3 18:33:23 2017
New Revision: 290919
URL: http://llvm.org/viewvc/llvm-project?rev=290919&view=rev
Log:
Add -plugin-opt=sample-profile for thinLTO build.
Summary: ThinLTO needs to pass down the sample profile file path to linker.
Reviewers: tejohnson, davidxl, mehdi_a
danielcdh updated this revision to Diff 82975.
danielcdh added a comment.
fix function name
https://reviews.llvm.org/D27832
Files:
lib/Driver/Tools.cpp
test/Driver/gold-lto-samplepgo.c
Index: test/Driver/gold-lto-samplepgo.c
danielcdh added a comment.
ping...
Thanks,
Dehao
https://reviews.llvm.org/D25435
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
echristo added a comment.
One inline comment for the clang part and then let's split the llvm part out
into a separate patch please.
Thanks!
-eric
Comment at: clang/lib/Headers/altivec.h:8045
/* vec_sl */
static __inline__ vector unsigned char __ATTRS_o_ai
--
Author: gbiv
Date: Tue Jan 3 17:35:19 2017
New Revision: 290916
URL: http://llvm.org/viewvc/llvm-project?rev=290916&view=rev
Log:
Re-add objectsize function/incomplete type checks.
I accidentally omitted these when refactoring this code. This caused
problems when building parts of the test-suite
fowles created this revision.
fowles added a reviewer: klimek.
fowles added a subscriber: cfe-commits.
Add an argumentsAre matcher
https://reviews.llvm.org/D28260
Files:
include/clang/ASTMatchers/ASTMatchers.h
unittests/ASTMatchers/ASTMatchersTraversalTest.cpp
Index: unittests/ASTMatchers
rsmith added inline comments.
Comment at: lib/Parse/ParseDeclCXX.cpp:3547
NoexceptRange = SourceRange(KeywordLoc, T.getCloseLocation());
-} else {
- NoexceptType = EST_None;
}
} else {
Should `NoexceptRange` be set in the `else` case too,
hxy9243 updated this revision to Diff 82962.
hxy9243 marked 4 inline comments as done.
hxy9243 added a comment.
Minor fix, remove redundant inlines.
Repository:
rL LLVM
https://reviews.llvm.org/D24991
Files:
libcxx/include/memory
libcxx/src/memory.cpp
Index: libcxx/src/memory.cpp
==
hintonda created this revision.
hintonda added reviewers: sepavloff, rsmith, aaron.ballman.
hintonda added a subscriber: cfe-commits.
Treat invalid noexcept specifications in the same way we
treat invalid throw specifications, by not resetting the exception
type to EST_None, and testing isUsable i
hxy9243 set the repository for this revision to rL LLVM.
hxy9243 updated this revision to Diff 82958.
hxy9243 added a comment.
Move the header back in its place, and only copy over necessary parts. Now call
__atomic_add_fetch from inside the functions.
Repository:
rL LLVM
https://reviews.llv
kzhuravl created this revision.
kzhuravl added reviewers: yaxunl, Anastasia, b-sumner.
kzhuravl added a subscriber: cfe-commits.
Herald added a subscriber: wdng.
https://reviews.llvm.org/D28257
Files:
lib/Parse/ParsePragma.cpp
test/SemaOpenCL/extensions.cl
Index: test/SemaOpenCL/extensions.
compnerd updated this revision to Diff 82954.
compnerd added a comment.
Remove incorrect use of `VC_EXTRALEAN`. Fix signature for
`__libcpp_set_thread_specific`. Provide CC adjustment thunks for the thread
creation. Add an assertion for sleep timeout truncation. Implement exec-once
interfac
kkwli0 created this revision.
kkwli0 added reviewers: ABataev, sfantao, carlo.bertolli, arpith-jacob,
hfinkel, mikerice.
kkwli0 added a subscriber: cfe-commits.
This patch is to add support of the 'is_device_ptr' clause in the 'target
parallel for' pragma.
https://reviews.llvm.org/D28255
File
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
I'd rather we don't deviate from google style at all, but this brings us closer
from where we are to that, so lgtm :-)
https://reviews.llvm.org/D28165
_
compnerd closed this revision.
compnerd added a comment.
SVN r290910. I like your idea for an additional BITSCAN macro. I think that
Id rather do that in a follow up.
Repository:
rL LLVM
https://reviews.llvm.org/D28223
___
cfe-commits mailing
Author: compnerd
Date: Tue Jan 3 15:53:51 2017
New Revision: 290910
URL: http://llvm.org/viewvc/llvm-project?rev=290910&view=rev
Log:
clean up use of _WIN32
Replace the use of _WIN32 in libc++. Replace most use with a C runtime
check _LIBCPP_MSVCRT or the new _LIBCPP_WIN32 to indicate that we ar
danbeam marked an inline comment as done.
danbeam added inline comments.
Comment at: lib/Format/Format.cpp:643
+ChromiumStyle.AllowShortIfStatementsOnASingleLine = false;
+ChromiumStyle.AllowShortLoopsOnASingleLine = false;
+ }
thakis wrote:
> Thanks for
mclow.lists created this revision.
mclow.lists added a reviewer: EricWF.
mclow.lists added a subscriber: cfe-commits.
http://llvm.org/show_bug.cgi?id=28929 shows a scenario where `make_shared` of a
class with a protected constructor compiles successfully (it should fail).
This is because we appl
mclow.lists added inline comments.
Comment at: test/libcxx/test/config.py:415
self.cxx.compile_flags += ['-I' + cxx_headers]
+if self.libcxx_obj_root is None:
+return
Whoops. This change doesn't belong here.
But it fixes a problem run
danbeam updated this revision to Diff 82946.
danbeam added a comment.
make a branch specific to JS and duplicate some format options for explicitness
https://reviews.llvm.org/D28165
Files:
lib/Format/Format.cpp
Index: lib/Format/Format.cpp
===
Author: rnk
Date: Tue Jan 3 15:29:51 2017
New Revision: 290907
URL: http://llvm.org/viewvc/llvm-project?rev=290907&view=rev
Log:
Relax CHECK line from r290906
Modified:
cfe/trunk/test/CodeGen/variadic-null-win64.c
Modified: cfe/trunk/test/CodeGen/variadic-null-win64.c
URL:
http://llvm.org/
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM. My comment is a suggestion, not a requirement.
Comment at: include/support/win32/support.h:112
// Search from LSB to MSB for first set bit.
// Returns zero
compnerd updated this revision to Diff 82944.
compnerd added a comment.
fix `__LP64__` usage as pointed out by @smeenai
Repository:
rL LLVM
https://reviews.llvm.org/D28223
Files:
include/__config
include/__locale
include/support/win32/support.h
include/type_traits
src/chrono.cpp
halyavin added inline comments.
Comment at: include/__threading_support:421
+if (!SleepConditionVariableCS(__cv, __m,
+
duration_cast(timeout).count()))
+ return GetLastError();
We can have integer overflow on cast to DW
ahatanak added a comment.
ping
https://reviews.llvm.org/D27478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.h:3570
for (auto *A : llvm::make_range(Arg, ArgRange.end()))
- ArgTypes.push_back(getVarArgType(A));
+ ArgTypes.push_back(getVarArgType(A, CallArgTypeInfo == nullptr));
rnk wrote:
Author: rnk
Date: Tue Jan 3 15:23:35 2017
New Revision: 290906
URL: http://llvm.org/viewvc/llvm-project?rev=290906&view=rev
Log:
[Win64] Don't widen integer literal zero arguments to unprototyped function
calls
The special case to widen the integer literal zero when passed to
variadic function
majnemer added a comment.
In https://reviews.llvm.org/D28226#634282, @compnerd wrote:
> The dynamic behavior only is used for Windows, not pthreads. So, we dont see
> it here, but it becomes apparent in the windows support. I was trying to
> minimize the changes to libc++ itself to avoid havi
mclow.lists added a comment.
I like this. A lot.
I'm a bit concerned about @smeenai 's comments about __LP64_, and @EricWF 's
comment about solaris.
This patch accomplishes (or maybe just moves closer, I need to check) to a goal
of mine, which is to have no references to `_WIN32` in any heade
rnk added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.h:3570
for (auto *A : llvm::make_range(Arg, ArgRange.end()))
- ArgTypes.push_back(getVarArgType(A));
+ ArgTypes.push_back(getVarArgType(A, CallArgTypeInfo == nullptr));
rnk wrote:
kparzysz abandoned this revision.
kparzysz added a comment.
In https://reviews.llvm.org/D25811#632670, @EricWF wrote:
> While I was attempting to review this patch I ended up coming up with fixed
> tests myself. I committed them in r290746. I'm very sorry to step on your
> toes.
No problem at
rnk added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.h:3570
for (auto *A : llvm::make_range(Arg, ArgRange.end()))
- ArgTypes.push_back(getVarArgType(A));
+ ArgTypes.push_back(getVarArgType(A, CallArgTypeInfo == nullptr));
I'm testin
ahatanak added a comment.
ping
https://reviews.llvm.org/D25556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arpith
Date: Tue Jan 3 14:19:56 2017
New Revision: 290904
URL: http://llvm.org/viewvc/llvm-project?rev=290904&view=rev
Log:
[OpenMP] Code cleanup for NVPTX OpenMP codegen
This patch cleans up private methods for NVPTX OpenMP codegen. It converts
private
members to static functions to fo
smeenai added inline comments.
Comment at: include/support/win32/support.h:113
// Returns zero if no set bit is found.
-#if defined(_WIN64)
+#if defined(__LP64__)
if (_BitScanForward64(&where, mask))
Windows wouldn't have `__LP64__` defined (since it's LLP64
This revision was automatically updated to reflect the committed changes.
Closed by commit rL290904: [OpenMP] Code cleanup for NVPTX OpenMP codegen
(authored by arpith).
Changed prior to commit:
https://reviews.llvm.org/D28124?vs=82619&id=82931#toc
Repository:
rL LLVM
https://reviews.llvm.o
ahatanak added a comment.
If I change the condition to the following,
if (!s->p || 1)
clang suggests enclosing !s->p with a parenthesis, but the comment in
ReachableCode.cpp says the parenthesis should enclose the integer literal. It
seems like there is a contradiction here?
Repository:
awson added a comment.
You don't need #define VC_EXTRA_LEAN since:
1. VC_EXTRA_LEAN is a mistype, only VC_EXTRALEAN has some meaning in Windows
ecosystem;
2. VC_EXTRALEAN is used *only* in MFC headers which obviously aren't used in
clang codebase.
Thus it would be better to remove this altoget
aaron.ballman updated this revision to Diff 82930.
aaron.ballman added a comment.
I've updated this patch to correct the codegen changes. If you'd prefer, I can
review/commit in two separate phases, one for the codegen bug and one for the
attribute issue, as I think these changes might be reason
kimgr added a comment.
I agree. Since the current set of encodings all have different element sizes
and this is not likely to change, this looks good.
Repository:
rL LLVM
https://reviews.llvm.org/D28223
___
cfe-commits mailing list
cfe-commits@l
bruno added a comment.
Ping!
https://reviews.llvm.org/D26267
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added a comment.
This has been discussed during the initial review for the header:
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160425/157187.html
The main issue is after preprocessing the header the original function name is
no longer available in diagnostics reported. Th
compnerd added a comment.
I think that it will suffice for now. We can change the flag to be more
granular in the future. I think that this is going well beyond the original
intent of cleaning up the usage of the `_WIN32` macros at this point.
Repository:
rL LLVM
https://reviews.llvm.org/
kimgr added a comment.
Another belated thought: it all depends on the intended meaning of the symbol:
- Does it say anything about the element size (i.e. sizeof(wchar_t)?
- Does it specify the native encoding of wide-char strings for a platform (i.e.
UTF-16 on Windows)?
It looks like the same s
compnerd updated this revision to Diff 82927.
compnerd added a comment.
Switch to `_LIBCPP_SHORT_WCHAR`.
Repository:
rL LLVM
https://reviews.llvm.org/D28223
Files:
include/__config
include/__locale
include/support/win32/support.h
include/type_traits
src/chrono.cpp
src/include/con
compnerd commandeered this revision.
compnerd edited reviewers, added: EricWF; removed: compnerd.
compnerd added a comment.
Ill use this version for the commit, but Id like to get an okay on it before I
do that :-).
https://reviews.llvm.org/D28212
arpith-jacob updated this revision to Diff 82922.
arpith-jacob added a comment.
Updated patch based on reviews.
The serialized parallel region executed by the master was modified to call the
'end' runtime call with a PrePostActionTy so that it is called upon exit of any
cleanup scope.
Added re
kimgr added a comment.
@smeenai I think I tried to make a jumbled mess of points :-)
1. Associating an encoding with a char/element type seems wrong; any number of
encodings can use wchar_t.
2. Windows allegedly uses UTF-16 now, not UCS-2
3. There might be a bug in locale.cpp if it actually does
mprobst created this revision.
mprobst added a reviewer: djasper.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Before:
declare function foo();
let x = 1;
After:
declare function foo();
let x = 1;
The problem was that clang-format would unconditionally t
rsmith added a comment.
In https://reviews.llvm.org/D28166#634196, @aaron.ballman wrote:
> So I think the correct behavior is to only enable the vararg behavior when
> the function is variadic with an ellipsis rather than variadic due to a lack
> of prototype.
That sounds right. Note that fun
compnerd added a comment.
The dynamic behavior only is used for Windows, not pthreads. So, we dont see
it here, but it becomes apparent in the windows support. I was trying to
minimize the changes to libc++ itself to avoid having it to consider the
recursive vs non-recursive cases. If the li
compnerd added a comment.
I dont think that making Win32 threading an external one makes much sense
unless we also do the same for pthreads. Its just as valid a threading model
as pthreads, so why give preferential treatment to that? (Sure, there are more
buildbots using it, but thats not a s
emaste abandoned this revision.
emaste added a comment.
Abandon in favour of https://reviews.llvm.org/D23934
https://reviews.llvm.org/D20791
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
firolino added inline comments.
Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:34
+ // a tag declaration (e.g. struct, class etc.):
+ // class A { } Object1, Object2; <-- won't be matched
+ Finder->addMatcher(
aaron.ballman wrote:
> firolin
tra added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:511-516
+// Activate workers.
+syncCTAThreads(CGF);
+
+// Barrier at end of parallel region.
+syncCTAThreads(CGF);
+
arpith-jacob wrote:
> tra wrote:
> > Are two back-to-b
smeenai added a comment.
In https://reviews.llvm.org/D28223#634199, @compnerd wrote:
> I figured that using the explicit encoding is nicer since it means that its
> more documenting.
I think @kimgr's point was that if you're using an explicit encoding, it should
be UTF-16 rather than UCS-2 :)
carlo.bertolli closed this revision.
carlo.bertolli added a comment.
Commited r290898.
Repository:
rL LLVM
https://reviews.llvm.org/D17840
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
carlo.bertolli created this revision.
carlo.bertolli added reviewers: ABataev, sfantao, kkwli0.
carlo.bertolli added subscribers: arpith-jacob, gtbercea, caomhin, cfe-commits.
The regression test was missing from the previous already accepted patch.
https://reviews.llvm.org/D28243
Files:
test
arpith-jacob added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:511-516
+// Activate workers.
+syncCTAThreads(CGF);
+
+// Barrier at end of parallel region.
+syncCTAThreads(CGF);
+
tra wrote:
> Are two back-to-back syncCTAThre
1 - 100 of 193 matches
Mail list logo
