mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM. My comment is a suggestion, not a requirement.
================
Comment at: include/support/win32/support.h:112
// Search from LSB to MSB for first set bit.
// Returns zero if no set bit is found.
+#if (defined(_M_ARM) || defined(__arm__)) ||
\
----------------
I would be tempted to add another macro here. Something like:
#if (defined(_M_ARM) || defined(__arm__)) || \
(defined(_M_AMD64) || defined(__x86_64__))
#define _LIBCPP_WIN_HAS_BITSCAN
#endif
to avoid repeating the "four-armed combo"
Repository:
rL LLVM
https://reviews.llvm.org/D28223
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
