halyavin added inline comments.
================
Comment at: include/__threading_support:421
+ if (!SleepConditionVariableCS(__cv, __m,
+
duration_cast<milliseconds>(timeout).count()))
+ return GetLastError();
----------------
We can have integer overflow on cast to DWORD here and get unexpectedly small
wait for large timeouts.
================
Comment at: include/__threading_support:458
+{
+ // TODO(compnerd) provide a wrapper for CC adjustment
+ *__t = reinterpret_cast<HANDLE>(_beginthreadex(
----------------
For other reviewers: CC means Calling Convention.
Repository:
rL LLVM
https://reviews.llvm.org/D28220
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
