Hahnfeld added a comment.
In https://reviews.llvm.org/D22663#495728, @zlei wrote:
> In https://reviews.llvm.org/D22663#494460, @Hahnfeld wrote:
>
> > With the changes applied and configured with
> > `CLANG_DEFAULT_RTLIB=compiler-rt` some tests fail so you may have to adapt
> > the idea of `-rtl
marsupial created this revision.
marsupial added a reviewer: vsk.
marsupial added a subscriber: cfe-commits.
marsupial set the repository for this revision to rL LLVM.
Make integers explicitly unsigned, so the tuple constructor will resolve
properly when but with clang 3.6, 3.7 and gcc 6.1.1 libs
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D21343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276726: [OpenMP] diagnose orphaned teams construct (authored
by kli).
Changed prior to commit:
https://reviews.llvm.org/D22785?vs=65430&id=65472#toc
Repository:
rL LLVM
https://reviews.llvm.org/D227
Author: kli
Date: Mon Jul 25 23:32:50 2016
New Revision: 276726
URL: http://llvm.org/viewvc/llvm-project?rev=276726&view=rev
Log:
[OpenMP] diagnose orphaned teams construct
The OpenMP spec mandates that 'a teams construct must be contained within a
target construct'. Currently, this scenario is
kkwli0 added a comment.
Will add the braces. Thanks.
https://reviews.llvm.org/D22785
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zlei added a comment.
In https://reviews.llvm.org/D22663#494460, @Hahnfeld wrote:
> With the changes applied and configured with
> `CLANG_DEFAULT_RTLIB=compiler-rt` some tests fail so you may have to adapt
> the idea of `-rtlib=platform` for the tests.
Got it. And I also need to fix those fai
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG with some nits
Comment at: include/clang/AST/OpenMPClause.h:4419
@@ -4405,1 +4418,3 @@
+ }
+ /// \brief Build clause with number of variables \a NumVars.
///
---
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D22787
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG with a nit
Comment at: lib/Sema/SemaOpenMP.cpp:3360-3366
@@ -3356,5 +3359,9 @@
if (NestingProhibited) {
- SemaRef.Diag(StartLoc, diag::err_omp_prohibited_region
mclow.lists updated this revision to Diff 65463.
mclow.lists added a comment.
Updated with Eric's constexpr tests.
Once this is approved, it will be applied twice - once in
``, and once in ``
https://reviews.llvm.org/D21343
Files:
include/experimental/numeric
test/std/experimental/numeric/
ahatanak created this revision.
ahatanak added a reviewer: doug.gregor.
ahatanak added a subscriber: cfe-commits.
This patch fixes Sema to propagate the nullability of the initializer
expression of a variable declared with auto or __auto_type to the deduced type.
The patch consists of two parts:
Author: vedantk
Date: Mon Jul 25 19:24:59 2016
New Revision: 276716
URL: http://llvm.org/viewvc/llvm-project?rev=276716&view=rev
Log:
[Coverage] Do not write out coverage mappings with zero entries
After r275121, we stopped mapping regions from system headers. Lambdas
declared in regions belongin
ahatanak updated this revision to Diff 65446.
ahatanak added a comment.
Addressed review comment and made a couple of other changes.
- Move Sema::diagnoseNullPtrToNonnullCast to SemaChecking.cpp.
- In diagnoseNullPtrToNonnullCast, call "Type::isAnyPointerType" instead of
"Type::isPointerType" so
sebpop added a comment.
In https://reviews.llvm.org/D22782#495436, @mclow.lists wrote:
> Do we have a test for the problem that this is solving?
I think we can write a testcase that shows that copy constructors are not
optimized away unless the string constructor is inlined.
This patch fixes
manmanren updated this revision to Diff 65449.
manmanren added a comment.
Addressing Ben's comments
https://reviews.llvm.org/D22773
Files:
include/clang/Driver/Options.td
include/clang/Lex/HeaderSearchOptions.h
include/clang/Serialization/ASTReader.h
lib/Frontend/CompilerInvocation.cpp
teemperor added a comment.
This patch is no longer needed because the CloneDetector from patch
https://reviews.llvm.org/D20795 no longer uses custom hashing.
https://reviews.llvm.org/D22515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
teemperor marked 3 inline comments as done.
teemperor added a comment.
https://reviews.llvm.org/D20795
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
teemperor added inline comments.
Comment at: lib/Analysis/CloneDetection.cpp:178
@@ +177,3 @@
+
+ bool VisitFunctionDecl(FunctionDecl *D) {
+// If we found a function, we start the clone search on its body statement.
NoQ wrote:
> You'd probably want to add `O
teemperor updated this revision to Diff 65441.
teemperor added a comment.
- The CloneGroup values in StringMap no longer store a copy of their own key.
https://reviews.llvm.org/D20795
Files:
include/clang/Analysis/CloneDetection.h
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/Anal
Author: cbieneman
Date: Mon Jul 25 18:48:14 2016
New Revision: 276711
URL: http://llvm.org/viewvc/llvm-project?rev=276711&view=rev
Log:
[CMake] Pass DYLD_LIBRARY_PATH as CMake variable instead of as envar
On OS X 10.11 System Integrity Protection prevents the DYLD environment
variables from bein
manmanren added a comment.
In https://reviews.llvm.org/D22773#495524, @benlangmuir wrote:
> > the pcm could still be rewritten by a compilation that doesn't use a PCH,
> > and then it would be out of date because of the timestamp instead of the
> > diagnostic options
>
> >
>
> > "a compilation
benlangmuir added a comment.
> the pcm could still be rewritten by a compilation that doesn't use a PCH, and
> then it would be out of date because of the timestamp instead of the
> diagnostic options
>
> "a compilation that doesn't use a PCH", is that a different project? And we
> have two
teemperor updated this revision to Diff 65439.
teemperor marked 7 inline comments as done.
teemperor added a comment.
- Fixed the minor problems as pointed out by Artem.
- Now using AnalysisConsumer instead of RecursiveASTVisitor.
- Function names are now confirming to LLVM code-style.
- Renamed D
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: cfe-commits, caomhin.
This patch adds support for the is_device_ptr clause. It expands SEMA to use
the mappable expression logic that can only be tested with
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: cfe-commits, caomhin.
This patch add support to map pointers through references in class members.
Although a reference does not have storage that a user can a
Author: jvesely
Date: Mon Jul 25 17:36:22 2016
New Revision: 276704
URL: http://llvm.org/viewvc/llvm-project?rev=276704&view=rev
Log:
Make min follow the OCL 1.0 specs
OpenCL 1.0: "Returns y if y < x, otherwise it returns x. If x *and* y
are infinite or NaN, the return values are undefined."
Ope
kkwli0 created this revision.
kkwli0 added reviewers: ABataev, sfantao, carlo.bertolli, arpith-jacob, hfinkel.
kkwli0 added a subscriber: cfe-commits.
The spec mandates that 'a teams construct must be contained within a target
construct'. Currently, this scenario is not diagnosed. This patch is
Prazek added a comment.
In https://reviews.llvm.org/D22725#495329, @etienneb wrote:
> In https://reviews.llvm.org/D22725#494167, @Prazek wrote:
>
> > hmm It seems that I mislead you, I suck at C api - memmove source and
> > destination can overlap, but std::move can't. So I guess you have to rem
mclow.lists added a comment.
Do we have a test for the problem that this is solving?
https://reviews.llvm.org/D22782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
manmanren added a comment.
In https://reviews.llvm.org/D22773#495403, @benlangmuir wrote:
> We need to add this option to the module hash (see getModuleHash - we already
> add a bunch of other HSOpts there). Otherwise the pcm could still be
> rewritten by a compilation that doesn't use a PCH,
Author: ahatanak
Date: Mon Jul 25 16:58:19 2016
New Revision: 276696
URL: http://llvm.org/viewvc/llvm-project?rev=276696&view=rev
Log:
[Sema][ObjC] Compute the nullability of a conditional expression based
on the nullabilities of its operands.
This commit is a follow-up to r276076 and enables
com
benlangmuir added a comment.
We need to add this option to the module hash (see getModuleHash - we already
add a bunch of other HSOpts there). Otherwise the pcm could still be rewritten
by a compilation that doesn't use a PCH, and then it would be out of date
because of the timestamp instead o
manmanren accepted this revision.
manmanren added a comment.
This revision is now accepted and ready to land.
LGTM except one nit.
Manman
Comment at: include/clang/Sema/Sema.h:9595
@@ -9594,1 +9594,3 @@
+
+ VersionTuple getCurContextVersion() const;
Can yo
jbcoe marked an inline comment as done.
jbcoe added a comment.
https://reviews.llvm.org/D22513
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jbcoe removed rL LLVM as the repository for this revision.
jbcoe updated this revision to Diff 65423.
jbcoe added a comment.
Fix underline length in docs.
https://reviews.llvm.org/D22513
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyMod
etienneb added inline comments.
Comment at: clang-tidy/modernize/UseAlgorithmCheck.cpp:73
@@ +72,3 @@
+ Finder->addMatcher(
+ callExpr(allOf(callee(functionDecl(matchesName("::memcpy"))),
+ argumentCountIs(3)))
It's more efficient to use
sbenza added inline comments.
Comment at: clang-tidy/misc/MoveForwardingReferenceCheck.cpp:20
@@ +19,3 @@
+
+static void ReplaceMoveWithForward(const UnresolvedLookupExpr *Callee,
+ const TemplateTypeParmType *TypeParmType,
aaron.
etienneb added a comment.
In https://reviews.llvm.org/D22725#494167, @Prazek wrote:
> hmm It seems that I mislead you, I suck at C api - memmove source and
> destination can overlap, but std::move can't. So I guess you have to remove
> the memmove support. Sorry.
On windows (MSVC CRT), both f
It could, it fixes a set of issues wrt to modules.
On 25/07/16 22:39, Hans Wennborg wrote:
Should this be merged to 3.9?
On Fri, Jul 22, 2016 at 2:08 PM, Vassil Vassilev via cfe-commits
wrote:
Author: vvassilev
Date: Fri Jul 22 16:08:24 2016
New Revision: 276473
URL: http://llvm.org/viewvc/ll
beanz added a subscriber: beanz.
beanz added a comment.
One small comment on the CMake code.
Comment at: CMakeLists.txt:210
@@ +209,3 @@
+ message(WARNING "Resetting default rtlib to use platform default")
+ set(CLANG_DEFAULT_RTLIB "")
+endif()
You'll want thi
vladisld added a comment.
In https://reviews.llvm.org/D22463#495211, @vladisld wrote:
> + you get a good integration with Gerrit enabled services like Gerrithub
> (http://gerrithub.io/) and other CI systems (like Jenkins for example)
BTW, Buildbot is also supporting git-repo:
http://docs.buil
vladisld added a comment.
In https://reviews.llvm.org/D22463#494828, @jlebar wrote:
> I think the general feeling is that most of us (myself included) would rather
> not learn a new tool if there's a simpler >alternative, such as a vanilla git
> workflow.
Generally you're right, however learn
jlebar added a comment.
In https://reviews.llvm.org/D22463#495211, @vladisld wrote:
> In https://reviews.llvm.org/D22463#494828, @jlebar wrote:
>
> > I think the general feeling is that most of us (myself included) would
> > rather not learn a new tool if there's a simpler >alternative, such as
mmasten added a comment.
I was just recently given commit privileges, so I can do it. Thanks Hal.
https://reviews.llvm.org/D19544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vmiklos added a comment.
Rebased on top of r276684 and resolved conflicts.
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vmiklos updated this revision to Diff 65417.
https://reviews.llvm.org/D21814
Files:
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/tool/ClangRename.cpp
clang-rename/tool/clang-rename.py
docs/clang-rename.rst
test/clang-rename/ClassFindByName.cpp
test/clan
Eugene.Zelenko added inline comments.
Comment at:
docs/clang-tidy/checks/cppcoreguidelines-special-member-functions.rst:4
@@ +3,3 @@
+cppcoreguidelines-special-member-functions
+===
+
Size should be same as size of name above.
Should me merge this to 3.9?
On Mon, Jul 25, 2016 at 10:17 AM, Sunil Srivastava via cfe-commits
wrote:
> Author: ssrivastava
> Date: Mon Jul 25 12:17:06 2016
> New Revision: 276653
>
> URL: http://llvm.org/viewvc/llvm-project?rev=276653&view=rev
> Log:
> Support '#pragma once' in headers when usi
jbcoe set the repository for this revision to rL LLVM.
jbcoe updated this revision to Diff 65414.
jbcoe marked an inline comment as done.
jbcoe added a comment.
Rename to cppcoreguidelines-special-member-functions to avoid the duplication
required with naming it rule-of-3 and rule-of-5.
Reduce c
Should this be merged to 3.9?
On Fri, Jul 22, 2016 at 2:08 PM, Vassil Vassilev via cfe-commits
wrote:
> Author: vvassilev
> Date: Fri Jul 22 16:08:24 2016
> New Revision: 276473
>
> URL: http://llvm.org/viewvc/llvm-project?rev=276473&view=rev
> Log:
> [modules] Teach the ASTWriter to ignore mutat
Author: eugenezelenko
Date: Mon Jul 25 15:30:13 2016
New Revision: 276684
URL: http://llvm.org/viewvc/llvm-project?rev=276684&view=rev
Log:
[Clang-rename] Remove custom version, fix extra space in error message.
Also fixed some Include What You Use Warnings.
Differential revision: https://review
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276684: [Clang-rename] Remove custom version, fix extra
space in error message. (authored by eugenezelenko).
Changed prior to commit:
https://reviews.llvm.org/D22654?vs=65379&id=65412#toc
Repository:
mstorsjo created this revision.
mstorsjo added a subscriber: cfe-commits.
Herald added subscribers: samparker, rengolin, aemerson.
This fixes compiling with headers from the Windows SDK for ARM, where the
YieldProcessor function (in winnt.h) refers to _ARM_BARRIER_ISHST.
The actual MSVC armintr.
Done! Attached a new diff.
From: David Majnemer [mailto:david.majne...@gmail.com]
Sent: Monday, July 25, 2016 1:18 PM
To: Keane, Erich
Cc: cfe-commits@lists.llvm.org
Subject: Re: [ReviewRequest] [Sema/Parser] GCC Compatibility Patch: Support for
__final specifier
You've added a comment describ
You've added a comment describing the new enum value. Please make sure the
comment starts with a cap letter and ends with a period.
On Mon, Jul 25, 2016 at 4:09 PM, Keane, Erich wrote:
> Thanks for the quick review! I’ve updated the patch with the name changes
> in the attached diff file.
>
>
On Mon, Jul 25, 2016 at 1:03 PM, Vlad Dovlekaev via llvm-commits <
llvm-comm...@lists.llvm.org> wrote:
> vladisld added a comment.
>
> In https://reviews.llvm.org/D22463#494828, @jlebar wrote:
>
> > I think the general feeling is that most of us (myself included) would
> rather not learn a new too
Thanks for the quick review! I’ve updated the patch with the name changes in
the attached diff file.
From: David Majnemer [mailto:david.majne...@gmail.com]
Sent: Monday, July 25, 2016 12:40 PM
To: Keane, Erich
Cc: cfe-commits@lists.llvm.org
Subject: Re: [ReviewRequest] [Sema/Parser] GCC Compati
manmanren created this revision.
manmanren added a reviewer: benlangmuir.
manmanren added a subscriber: cfe-commits.
With PCH+Module, sometimes compiler gives a hard error:
"Module file ‘.pcm' is out of date and needs to be rebuilt"
This happens when we have a PCH importing a module and the modul
Alexander_Droste removed rL LLVM as the repository for this revision.
Alexander_Droste updated this revision to Diff 65404.
Alexander_Droste added a comment.
Hi, thanks for the notification! Obviously, on some systems `char` is unsigned
by default
which is why the check now tolerates distinct si
CrisCristescu updated this revision to Diff 65403.
CrisCristescu marked an inline comment as done.
CrisCristescu added a comment.
PP CodeCompletionII initialisation.
Repository:
rL LLVM
https://reviews.llvm.org/D17820
Files:
include/clang/Lex/Preprocessor.h
include/clang/Sema/CodeComplet
I'd rename VS_Alt_Final to VS_GNU_Final.
On Mon, Jul 25, 2016 at 2:24 PM, Keane, Erich via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi all, my first potential-contribution, so I apologize if I’m submitting
> this improperly, I’m unfamiliar with the ‘type’ keys that you use in the
> topi
CrisCristescu updated this revision to Diff 65401.
CrisCristescu marked 3 inline comments as done.
CrisCristescu added a comment.
Addressing some sugesstions.
Repository:
rL LLVM
https://reviews.llvm.org/D17820
Files:
include/clang/Lex/Preprocessor.h
include/clang/Sema/CodeCompleteConsum
lefticus added a comment.
I believe all or most of the "untested" comments are correctly tested in the
updated test files via static_asserts with contexpr. I've commented on just the
first one to make sure I understand correctly.
Comment at: include/array:156
@@ -155,3 +155,3
lefticus updated this revision to Diff 65398.
lefticus added a comment.
Correct context from last patch
https://reviews.llvm.org/D22584
Files:
include/array
include/iterator
test/std/containers/sequences/array/at.pass.cpp
test/std/containers/sequences/array/begin.pass.cpp
test/std/con
Author: cbieneman
Date: Mon Jul 25 13:54:30 2016
New Revision: 276674
URL: http://llvm.org/viewvc/llvm-project?rev=276674&view=rev
Log:
[CMake] Cleaning up some CMake warnings
In Bootstrap builds Clang logs some warnings. These are caused because Clang
passes CLANG_STAGE and BOOTSTRAP_DEFAULT_PA
LokiAstari added a comment.
Hope you don't mind me chiming in:
> Roughly go ahead with what you are suggesting, although the option should not
> be called AccessModifierStandardIndent, as that carries no meaning and
> actually is far from the "standard" way. Reasonable names that spring to mind
lefticus added a comment.
I believe I messed up the context for the files, will attempt to resubmit the
patch.
https://reviews.llvm.org/D22584
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
lefticus marked 3 inline comments as done.
lefticus added a comment.
https://reviews.llvm.org/D22584
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz added a comment.
lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D22654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hfinkel added a comment.
In https://reviews.llvm.org/D19544#492258, @mmasten wrote:
> I think this is just saying that some of the weird types are not supported on
> all targets. For now, is it ok to proceed with checking this code in?
Correct.
In https://reviews.llvm.org/D19544#493403, @mmas
alexfh added a comment.
A couple of nits.
Comment at: clang-tidy/performance/InefficientStringConcatenationCheck.cpp:51
@@ +50,3 @@
+ hasArgument(
+ 0, declRefExpr(BasicStringType),
+ declRefExpr(hasDeclaration(decl().bind("lhsStrT"))).bind("lhsStr")),
---
lefticus updated this revision to Diff 65390.
lefticus added a comment.
Fixed syntax errors in test files.
https://reviews.llvm.org/D22584
Files:
include/array
include/iterator
test/std/containers/sequences/array/at.pass.cpp
test/std/containers/sequences/array/begin.pass.cpp
test/std/
Hi all, my first potential-contribution, so I apologize if I'm submitting this
improperly, I'm unfamiliar with the 'type' keys that you use in the topic, so
hopefully I have this right.
As reported in bug 28473, GCC supports 'final' functionality in pre-C++11 code
using the __final keyword. Cl
erik.pilkington created this revision.
erik.pilkington added a reviewer: rsmith.
erik.pilkington added a subscriber: cfe-commits.
The FunctionScopeInfo stack in Sema uses an optimization where the memory for
the top-level functions is reused. The function FunctionScopeInfo::Clear() is
used to re
bittnerbarni added inline comments.
Comment at: clang-tidy/performance/InefficientStringConcatenationCheck.cpp:55
@@ +54,3 @@
+ hasDeclaration(decl(equalsBoundNode("lhsStrT"))),
+ hasDescendant(BasicStringPlusOperator));
+
Yes this
bittnerbarni updated this revision to Diff 65384.
bittnerbarni marked an inline comment as done.
https://reviews.llvm.org/D20196
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientStringConcatenationCheck.cpp
clang-tidy/performance/InefficientStringConcatenationC
Eugene.Zelenko updated this revision to Diff 65379.
Eugene.Zelenko added a comment.
Don't include DiagnosticIDs.h
Repository:
rL LLVM
https://reviews.llvm.org/D22654
Files:
clang-rename/tool/ClangRename.cpp
test/clang-rename/InvalidNewName.cpp
Index: test/clang-rename/InvalidNewName.cpp
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:192
@@ +191,3 @@
+ };
+
+ // The map of all functions supported by the checker. It is initialized
Even though there are some doxygen-style comments in the checkers,
+Richard Trieu - worth fixing? If anyone does get
around to fixing this, would be good to remove the workaround committed
here in r276022.
On Mon, Jul 25, 2016 at 10:51 AM Richard Smith
wrote:
> On 25 Jul 2016 6:29 p.m., "David Blaikie via cfe-commits" <
> cfe-commits@lists.llvm.org> wrote:
> >
alexfh added a comment.
Alexander, FYI, the patch has been reverted, since it breaks multiple
buildbots, e.g.
-
http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15/builds/13909/steps/ninja%20check%201/logs/FAIL%3A%20Clang%20Tools%3A%3Ampi-type-mismatch.cpp
-
http://lab.llvm.org:8011/builde
On 25 Jul 2016 6:29 p.m., "David Blaikie via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
>
> Should we fix the diagnostic? Or is the code triggering it just esoteric
enough to not be a good justification for changing the warning?
Hmm, maybe we should. The case is something like
template voi
ashi1 added inline comments.
Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:188
@@ +187,3 @@
+#endif
+// expected-warning@+6{{unsupported OpenCL extension 'cl_khr_mipmap_image' -
ignoring}}
+#else
yaxunl wrote:
> Anastasia wrote:
> > Can you move this error m
sepavloff updated this revision to Diff 65376.
sepavloff added a comment.
Added one more case in shouldLinkDependentDeclWithPrevious
https://reviews.llvm.org/D16989
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaDecl.cpp
test/SemaCXX/PR25848.cpp
test/SemaCXX/friend2.cpp
Index: test/Sema
Should we fix the diagnostic? Or is the code triggering it just esoteric
enough to not be a good justification for changing the warning?
On Tue, Jul 19, 2016 at 1:42 PM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Tue Jul 19 15:35:09 2016
> New Revis
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D22767
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
yaxunl added inline comments.
Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:188
@@ +187,3 @@
+#endif
+// expected-warning@+6{{unsupported OpenCL extension 'cl_khr_mipmap_image' -
ignoring}}
+#else
Anastasia wrote:
> Can you move this error message down inste
etienneb added a subscriber: etienneb.
etienneb added a comment.
thx for the check
Comment at: clang-tidy/misc/MoveForwardingReferenceCheck.cpp:25
@@ +24,3 @@
+ const SourceManager &SM = Context->getSourceManager();
+ const LangOptions LangOpts = Context->getLangOpts();
+
ashi1 created this revision.
ashi1 added reviewers: yaxunl, Anastasia.
ashi1 added a subscriber: cfe-commits.
ashi1 set the repository for this revision to rL LLVM.
Added CLK_ABGR definition for get_image_channel_order return value inside
opencl-c.h file
Repository:
rL LLVM
https://reviews.ll
Actually, I now see the PR doesn't reproduce on 3.9, so this must have
broke after the branch point.
On Fri, Jul 22, 2016 at 7:02 AM, Hans Wennborg wrote:
> Richard: should we merge this to 3.9?
>
> On Thu, Jul 21, 2016 at 7:03 PM, David Majnemer via cfe-commits
> wrote:
>> Author: majnemer
>> D
Author: joel_k_jones
Date: Mon Jul 25 12:18:44 2016
New Revision: 276655
URL: http://llvm.org/viewvc/llvm-project?rev=276655&view=rev
Log:
[cc1as] Add MCTargetOptions argument to createAsmBackend
Allow an assembler backend to get ABI options. This is to match the changes
to http://reviews.llvm.or
Merged the revert to 3.9 in r276656.
Thanks,
Hans
On Mon, Jul 25, 2016 at 10:02 AM, Pieb, Wolfgang wrote:
> Yes, it should. I'm just now realizing that the original change got into 3.9.
>
> Thanks,
> Wolfgang
>
>> -Original Message-
>> From: hwennb...@google.com [mailto:hwennb...@google.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276655: [cc1as] Add MCTargetOptions argument to
createAsmBackend (authored by joel_k_jones).
Changed prior to commit:
https://reviews.llvm.org/D16538?vs=62793&id=65374#toc
Repository:
rL LLVM
https:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276653: Support '#pragma once' in headers when using PCH
(authored by ssrivastava).
Changed prior to commit:
https://reviews.llvm.org/D19815?vs=57320&id=65372#toc
Repository:
rL LLVM
https://reviews
Author: ssrivastava
Date: Mon Jul 25 12:17:06 2016
New Revision: 276653
URL: http://llvm.org/viewvc/llvm-project?rev=276653&view=rev
Log:
Support '#pragma once' in headers when using PCH
The '#pragma once' directive was erroneously ignored when encountered
in the header-file specified in gene
Ping?
On Mon, Jul 18, 2016 at 11:28 AM David Blaikie wrote:
> What build problem did this cause? Did this just not compile (it looks as
> if ArgList has hasArg and hasFlag, so I'm not sure what the specific
> problem might've been)
>
> On Wed, Jul 13, 2016 at 11:45 PM Dean Michael Berris via cfe
Author: alexfh
Date: Mon Jul 25 12:08:10 2016
New Revision: 276650
URL: http://llvm.org/viewvc/llvm-project?rev=276650&view=rev
Log:
Revert "Remove trailing spaces."
This reverts commit r276641. Breaks multiple buildbots.
Modified:
clang-tools-extra/trunk/test/clang-tidy/mpi-type-mismatch.cp
Author: alexfh
Date: Mon Jul 25 12:08:18 2016
New Revision: 276651
URL: http://llvm.org/viewvc/llvm-project?rev=276651&view=rev
Log:
Revert "MPITypeMismatchCheck for Clang-Tidy"
This reverts commit r276640. Breaks multiple buildbots.
Removed:
clang-tools-extra/trunk/clang-tidy/mpi/CMakeLists
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:191
@@ +190,3 @@
+// impossible to verify this precisely, but at least
+// this check avoids potential crashes.
+bool matchesCall(const CallExpr *CE) const;
--
NoQ updated this revision to Diff 65369.
NoQ marked 4 inline comments as done.
https://reviews.llvm.org/D20811
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp
test/Analysis/std-l
1 - 100 of 147 matches
Mail list logo
