I'd rename VS_Alt_Final to VS_GNU_Final. On Mon, Jul 25, 2016 at 2:24 PM, Keane, Erich via cfe-commits < cfe-commits@lists.llvm.org> wrote:
> Hi all, my first potential-contribution, so I apologize if I’m submitting > this improperly, I’m unfamiliar with the ‘type’ keys that you use in the > topic, so hopefully I have this right. > > > > As reported in bug 28473, GCC supports ‘final’ functionality in pre-C++11 > code using the __final keyword. Clang currently supports the ‘final’ > keyword in accordance with the C++11 specification, however it ALSO > supports it in pre-C++11 mode, with a warning. > > > > This patch adds the ‘__final’ keyword for compatibility with GCC in GCC > Keywords mode (so it is enabled with existing flags), and issues a warning > on its usage (suggesting switching to the C++11 keyword). This patch also > adds a regression test for the functionality described. I believe this > patch has minimal impact, as it simply adds a new keyword for existing > behavior. > > > > This has been validated with check-clang to avoid regressions. Patch is > created in reference to revisions 276665 > > > > Thanks, > > Erich > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
