rmaprath added a comment.
In http://reviews.llvm.org/D16948#444006, @rmaprath wrote:
> In http://reviews.llvm.org/D16948#443999, @EricWF wrote:
>
> > I installed a Fedora 23 system and ran the test suite and I didn't see any
> > of the same failures. It must be something other than the distro.
>
EricWF added a comment.
In http://reviews.llvm.org/D16948#444006, @rmaprath wrote:
> In http://reviews.llvm.org/D16948#443999, @EricWF wrote:
>
> > I installed a Fedora 23 system and ran the test suite and I didn't see any
> > of the same failures. It must be something other than the distro.
> >
rmaprath added a comment.
In http://reviews.llvm.org/D16948#443999, @EricWF wrote:
> I installed a Fedora 23 system and ran the test suite and I didn't see any of
> the same failures. It must be something other than the distro.
> Are you using an odd filesystem? Or maybe it could be your system
EricWF added a comment.
In http://reviews.llvm.org/D16948#443945, @rmaprath wrote:
> In http://reviews.llvm.org/D16948#443942, @EricWF wrote:
>
> > In http://reviews.llvm.org/D16948#443941, @rmaprath wrote:
> >
> > > I'm seeing a few failures on my Fedora 20 system. Will go through these
> > > t
EricWF added a comment.
In http://reviews.llvm.org/D20677#443997, @rmaprath wrote:
> Thanks Eric.
>
> I think I noted a few other `assert(true)` statements elsewhere (with similar
> application), will update those separately.
>
> Btw, do you use some systematic way to detect ABI breakages? I've
rmaprath added a comment.
Thanks Eric.
I think I noted a few other `assert(true)` statements elsewhere (with similar
application), will update those separately.
Btw, do you use some systematic way to detect ABI breakages? I've only bumped
into http://lvc.github.io/abi-compliance-checker/ but d
Author: abataev
Date: Tue May 31 01:21:27 2016
New Revision: 271251
URL: http://llvm.org/viewvc/llvm-project?rev=271251&view=rev
Log:
[MSVC] Fix stack overflow in unqualified type lookup logic, by Will
Wilson.
An unqualified lookup for in base classes may cause stack overflow if
the base class is
Author: ctopper
Date: Tue May 31 00:49:13 2016
New Revision: 271250
URL: http://llvm.org/viewvc/llvm-project?rev=271250&view=rev
Log:
[X86] Use unaligned load intrinsics to implement other intrinsics instead of
manually creating the unaligned load.
Modified:
cfe/trunk/lib/Headers/avxintrin.h
EricWF marked 6 inline comments as done.
EricWF added a comment.
@majnemer Thanks for looking at this!
Comment at: include/experimental/filesystem:610
@@ +609,3 @@
+static void __append_range(string& __dest, _Iter __b, _Iter __e) {
+// TODO(EricWF) We get better allo
Hi Alexey,
On 31 May 2016 at 12:25, Alexey Bataev wrote:
> Hi Will,
> Thanks for the report and sorry for a delay with answer. Generally, your
> patch looks good with some small nits. I can fix some minor issues like
> extra braces etc. and commit it if you don't mind.
>
Sure thing. Commit away
Author: ericwf
Date: Mon May 30 23:27:57 2016
New Revision: 271249
URL: http://llvm.org/viewvc/llvm-project?rev=271249&view=rev
Log:
Mark LWG issue 2520 as complete
Modified:
libcxx/trunk/test/std/utilities/memory/unique.ptr/unique.ptr.runtime/unique.ptr.runtime.ctor/pointer_deleter02.pass.c
Hi Will,
Thanks for the report and sorry for a delay with answer. Generally, your patch
looks good with some small nits. I can fix some minor issues like extra braces
etc. and commit it if you don't mind.
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
28.05.2016
majnemer added a subscriber: majnemer.
Comment at: include/experimental/filesystem:610
@@ +609,3 @@
+static void __append_range(string& __dest, _Iter __b, _Iter __e) {
+// TODO(EricWF) We get better allocation behavior here if we don't
+// provide the same exce
srhines added a comment.
In http://reviews.llvm.org/D20709#443536, @kristof.beyls wrote:
> Hi Pirama,
>
> My understanding is that this introduces (yet another) ARM 32 bit ABI variant
> - in this case with longs being 64 bit.
> My understanding is also that this is the ABI that is used in Rende
Author: ericwf
Date: Mon May 30 20:51:34 2016
New Revision: 271248
URL: http://llvm.org/viewvc/llvm-project?rev=271248&view=rev
Log:
Add tests that got missed in r271247.
Added:
libcxx/trunk/test/libcxx/thread/futures/futures.promise/
libcxx/trunk/test/libcxx/thread/futures/futures.promi
Author: ericwf
Date: Mon May 30 20:50:55 2016
New Revision: 271247
URL: http://llvm.org/viewvc/llvm-project?rev=271247&view=rev
Log:
Mark LWG issue 2276 as complete. Add _LIBCPP_ASSERTS for it
Modified:
libcxx/trunk/include/future
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk
Author: ctopper
Date: Mon May 30 20:50:10 2016
New Revision: 271246
URL: http://llvm.org/viewvc/llvm-project?rev=271246&view=rev
Log:
[AVX512] Emit generic masked store instrinsics instead of using x86 specific
intrinsics.
This will allow us to remove the x86 instrinics from the backend.
Modifi
EricWF added a comment.
Thanks. I fixed the missing include causing most of the failures. Please update
me when you can with new results.
http://reviews.llvm.org/D16948
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
rmaprath added a comment.
In http://reviews.llvm.org/D16948#443942, @EricWF wrote:
> In http://reviews.llvm.org/D16948#443941, @rmaprath wrote:
>
> > I'm seeing a few failures on my Fedora 20 system. Will go through these
> > tomorrow.
>
>
> If you want to just send me the raw ouput I'll go over
Author: ericwf
Date: Mon May 30 20:11:20 2016
New Revision: 271241
URL: http://llvm.org/viewvc/llvm-project?rev=271241&view=rev
Log:
Mark LWG issue 2537 as complete
Modified:
libcxx/trunk/test/std/containers/container.adaptors/priority.queue/priqueue.cons.alloc/ctor_comp_cont_alloc.pass.cpp
Author: ericwf
Date: Mon May 30 20:03:07 2016
New Revision: 271240
URL: http://llvm.org/viewvc/llvm-project?rev=271240&view=rev
Log:
Mark LWG issue #2585 as complete
Modified:
libcxx/trunk/test/std/containers/sequences/forwardlist/forwardlist.modifiers/resize_size_value.pass.cpp
libcxx/t
EricWF added a comment.
In http://reviews.llvm.org/D16948#443941, @rmaprath wrote:
> I'm seeing a few failures on my Fedora 20 system. Will go through these
> tomorrow.
If you want to just send me the raw ouput I'll go over them tonight.
http://reviews.llvm.org/D16948
rmaprath added a comment.
I'm seeing a few failures on my Fedora 20 system. Will go through these
tomorrow.
http://reviews.llvm.org/D16948
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Just for reference here is a list of symbols which have been removed:
https://gist.github.com/EricWF/bf00dbc5fccc78b779f8d260727a0710
LGTM. Your free to submit it after addressing the inline c
flx added a comment.
Alex, Sam, could you take another look? It'd be great to get this change in to
make the check more useful.
http://reviews.llvm.org/D20277
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
EricWF added a comment.
Nevermind. I figured out why it wasn't working. Phab didn't know the libc++
patch was in a different repo and so it wouldn't apply the patch.
http://reviews.llvm.org/D20677
___
cfe-commits mailing list
cfe-commits@lists.llvm
EricWF added a comment.
For some reason I'm having trouble applying your patch. Could you please upload
it with more context? (ie git diff -U999 or similar)
http://reviews.llvm.org/D20677
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271239: [clang-tidy] UnnecessaryCopyInitialization - Extend
to trigger on non-const… (authored by flx).
Changed prior to commit:
http://reviews.llvm.org/D20010?vs=58181&id=59010#toc
Repository:
rL LL
Author: flx
Date: Mon May 30 19:25:57 2016
New Revision: 271239
URL: http://llvm.org/viewvc/llvm-project?rev=271239&view=rev
Log:
[clang-tidy] UnnecessaryCopyInitialization - Extend to trigger on non-const
"this" object argument if it is not modified.
Summary:
Also trigger the check in the foll
Author: ericwf
Date: Mon May 30 19:23:31 2016
New Revision: 271238
URL: http://llvm.org/viewvc/llvm-project?rev=271238&view=rev
Log:
Mark LWG issue 2565 as complete. Update the tests to check it.
Added:
libcxx/trunk/test/std/utilities/function.objects/func.wrap/func.wrap.func/func.wrap.func.
rmaprath marked 6 inline comments as done.
rmaprath added a comment.
http://reviews.llvm.org/D20677
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath updated this revision to Diff 59009.
rmaprath added a comment.
Addressed review comments from @EricWF:
- Addressed the nits
- Disabled `backtrace_test.pass.cpp` for the moment, need to check if using
`_Unwind_backtrace` with no unwinding tables (-fno-exceptions) makes sense
- Enabled a
Author: ericwf
Date: Mon May 30 18:53:19 2016
New Revision: 271237
URL: http://llvm.org/viewvc/llvm-project?rev=271237&view=rev
Log:
Make string_view work with -fno-exceptions and get tests passing.
Modified:
libcxx/trunk/include/experimental/string_view
libcxx/trunk/test/std/experimenta
On 30 May 2016 at 16:48, Saleem Abdulrasool wrote:
> On Mon, May 30, 2016 at 12:54 PM, Rafael Espíndola
> wrote:
>>
>> Why .rodata.cfstring? Which linker treats that specially?
>
>
> Its mimicking the fact that the CF macros tried to place the structures in
> their own section. This would techni
Author: ericwf
Date: Mon May 30 18:15:19 2016
New Revision: 271235
URL: http://llvm.org/viewvc/llvm-project?rev=271235&view=rev
Log:
Cleanup error handling when TLS creation fails
Modified:
libcxx/trunk/include/thread
Modified: libcxx/trunk/include/thread
URL:
http://llvm.org/viewvc/llvm-pr
Author: ericwf
Date: Mon May 30 16:30:46 2016
New Revision: 271231
URL: http://llvm.org/viewvc/llvm-project?rev=271231&view=rev
Log:
Mark LWG issue #2522 as complete
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.org/viewvc/llvm-pr
EricWF added a comment.
Looking good. I would like to see some tests for the methods we have specificly
defined to have behavior in -fno-exceptions mode.
Comment at: src/cxa_noexception.cpp:27
@@ +26,3 @@
+
+_LIBCXXABI_FUNC_VIS void
+__cxa_increment_exception_refcount(void *thr
EricWF created this revision.
EricWF added a reviewer: mclow.lists.
EricWF added a subscriber: cfe-commits.
Implement LWG issue #2488
(http://cplusplus.github.io/LWG/lwg-defects.html#2488).
http://reviews.llvm.org/D20800
Files:
include/functional
src/bind.cpp
test/std/utilities/functio
rmaprath abandoned this revision.
rmaprath added a comment.
Updated http://reviews.llvm.org/D20677 with the necessary changes. This patch
is no longer required.
http://reviews.llvm.org/D20784
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mprobst updated this revision to Diff 59001.
mprobst added a comment.
- extract method for readability
http://reviews.llvm.org/D20798
Files:
lib/Format/Format.cpp
lib/Format/SortJavaScriptImports.cpp
unittests/Format/SortImportsTestJS.cpp
Index: unittests/Format/SortImportsTestJS.cpp
===
rmaprath updated this revision to Diff 59000.
rmaprath added a comment.
Addressing review comments from @EricWF:
- Rather than explicitly decoupling the no-exceptions `libc++` library from the
`__cxa_*` routines (http://reviews.llvm.org/D20784), provide a placeholder
implementation of those fun
EricWF created this revision.
EricWF added a reviewer: mclow.lists.
EricWF added a subscriber: cfe-commits.
Exactly what it sounds like.
I plan to commit this in a couple of days assuming no objections.
http://reviews.llvm.org/D20799
Files:
include/functional
test/std/utilities/function.obj
On Mon, May 30, 2016 at 12:54 PM, Rafael Espíndola <
rafael.espind...@gmail.com> wrote:
> Why .rodata.cfstring? Which linker treats that specially?
>
Its mimicking the fact that the CF macros tried to place the structures in
their own section. This would technically allow a linker to coalesce th
ioeric updated this revision to Diff 58993.
ioeric added a comment.
- Removed inline from isHeaderInsertion.
http://reviews.llvm.org/D20734
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
unittests/Format/CleanupTest.cpp
Index: unittests/Format/CleanupTest.cpp
ioeric updated this revision to Diff 58992.
ioeric marked 3 inline comments as done.
ioeric added a comment.
- Addressed reviewer's comments.
http://reviews.llvm.org/D20734
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
unittests/Format/CleanupTest.cpp
Index: unittests/Format
yaxunl updated this revision to Diff 58991.
yaxunl marked 5 inline comments as done.
yaxunl added a comment.
Fix variable capitalization and indentation.
http://reviews.llvm.org/D20133
Files:
lib/CodeGen/CGExprScalar.cpp
test/CodeGenOpenCL/as_type.cl
Index: test/CodeGenOpenCL/as_type.cl
==
ioeric added inline comments.
Comment at: lib/Format/Format.cpp:1550
@@ +1549,3 @@
+ HeaderInsertionReplaces =
+ fixCppIncludeInsertions(Code, HeaderInsertionReplaces, Style);
+ NewReplaces.insert(HeaderInsertionReplaces.begin(),
djasper wrote:
> So, not kn
rmaprath added a comment.
In http://reviews.llvm.org/D20784#443708, @EricWF wrote:
> I don't like the direction of this patch, and it seems like the wrong
> direction for what your trying to achieve as well.
> If your trying to support a system with two variants of libc++abi, one that
> throws
Why .rodata.cfstring? Which linker treats that specially?
On 30 May 2016 at 12:23, Saleem Abdulrasool via cfe-commits
wrote:
> Author: compnerd
> Date: Mon May 30 11:23:07 2016
> New Revision: 271211
>
> URL: http://llvm.org/viewvc/llvm-project?rev=271211&view=rev
> Log:
> CodeGen: tweak CFConsta
Author: rksimon
Date: Mon May 30 14:20:55 2016
New Revision: 271227
URL: http://llvm.org/viewvc/llvm-project?rev=271227&view=rev
Log:
[X86] Ensure load/store tests unaligned pointers really are align 1
Modified:
cfe/trunk/test/CodeGen/avx-builtins.c
cfe/trunk/test/CodeGen/sse-builtins.c
mprobst created this revision.
mprobst added a reviewer: djasper.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
E.g. sort `import {b, a} from 'x';` into `import {a, b} from 'x';`.
http://reviews.llvm.org/D20798
Files:
lib/Format/Format.cpp
lib/Format/SortJavaScr
djasper added inline comments.
Comment at: lib/Format/Format.cpp:1284
@@ +1283,3 @@
+ // if \p CheckMainHeader is true and \p IncludeName is a main header, returns
+ // 0. Otherwise, returns INT_MAX if \p IncludeName does not match any
category
+ // pattern.
N
sepavloff marked 2 inline comments as done.
sepavloff added a comment.
In http://reviews.llvm.org/D16989#432282, @rsmith wrote:
> Please also add some testcases for the corresponding case for a friend
> function template:
>
> template void f();
> template struct A {
> template void f() {
sepavloff updated this revision to Diff 58983.
sepavloff added a comment.
Updated patch
http://reviews.llvm.org/D16989
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaDecl.cpp
test/SemaCXX/PR25848.cpp
test/SemaCXX/friend2.cpp
Index: test/SemaCXX/friend2.cpp
==
ioeric added inline comments.
Comment at: lib/Format/Format.cpp:1550
@@ +1549,3 @@
+// Insert #include directives into the correct blocks.
+tooling::Replacements fixHeaderInsertions(StringRef Code,
+ const tooling::Replacements
&Replaces,
ioeric updated this revision to Diff 58982.
ioeric marked 16 inline comments as done.
ioeric added a comment.
- Addressed reviewers' comments.
http://reviews.llvm.org/D20734
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
unittests/Format/CleanupTest.cpp
Index: unittests/Forma
Author: compnerd
Date: Mon May 30 13:26:06 2016
New Revision: 271221
URL: http://llvm.org/viewvc/llvm-project?rev=271221&view=rev
Log:
CodeGen: address post-commit review comments
David Majnemer pointed out that isOSBinFormatMachO is more compact. NFC.
Modified:
cfe/trunk/lib/CodeGen/CodeGe
Author: rksimon
Date: Mon May 30 12:58:38 2016
New Revision: 271219
URL: http://llvm.org/viewvc/llvm-project?rev=271219&view=rev
Log:
[X86][SSE] Added missing tests (merge failure)
Differential Revision: http://reviews.llvm.org/D20617
Modified:
cfe/trunk/test/CodeGen/sse-builtins.c
Modified
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271218: [X86][SSE] _mm_store1_ps/_mm_store1_pd should
require an aligned pointer (authored by RKSimon).
Changed prior to commit:
http://reviews.llvm.org/D20617?vs=58397&id=58979#toc
Repository:
rL LL
Author: rksimon
Date: Mon May 30 12:55:25 2016
New Revision: 271218
URL: http://llvm.org/viewvc/llvm-project?rev=271218&view=rev
Log:
[X86][SSE] _mm_store1_ps/_mm_store1_pd should require an aligned pointer
According to the gcc headers, intel intrinsics docs and msdn codegen the
_mm_store1_pd (a
yaxunl marked 7 inline comments as done.
Comment at: lib/CodeGen/CGExprScalar.cpp:3420
@@ -3407,35 +3419,3 @@
llvm::Type *SrcTy = Src->getType();
- if (isa(DstTy) && isa(SrcTy)) {
-unsigned numElementsDst = cast(DstTy)->getNumElements();
-unsigned numElementsSrc = cast
djasper added inline comments.
Comment at: include/clang/Format/Format.h:778
@@ -776,1 +777,3 @@
+/// replacement corresponding to the header insertion has offset UINT_MAX (i.e.
+/// -1U).
tooling::Replacements
Why don't we just stick with UINT_MAX everywhere?
=
teemperor created this revision.
teemperor added reviewers: v.g.vassilev, zaks.anna.
teemperor added a subscriber: cfe-commits.
The ASTStructure class generates data for performant searching Stmts with
similar structure.
http://reviews.llvm.org/D20795
Files:
include/clang/AST/ASTStructure.h
emaste updated this revision to Diff 58977.
emaste added a comment.
Use gmtime to report in UTC when `SOURCE_DATE_EPOCH` is set. This follows GCC
and makes sense given the purpose of `SOURCE_DATE_EPOCH`.
For reference here is discussion on the GCC list when this was introduced
there: https://gc
yaxunl updated this revision to Diff 58978.
yaxunl added a comment.
Revised as Richard suggested.
http://reviews.llvm.org/D20630
Files:
include/clang/Frontend/LangStandards.def
lib/Frontend/CompilerInvocation.cpp
test/Driver/opencl.cl
test/Frontend/stdlang.c
Index: test/Frontend/stdlan
EricWF added a comment.
I don't like the direction of this patch, and it seems like the wrong direction
for what your trying to achieve as well.
If your trying to support a system with two variants of libc++abi, one that
throws and the other that does not, then you'll want libc++ to remain
unmo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271215: [CUDA] Fix order of vectorized ldg intrinsics'
elements. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D20794?vs=58972&id=58976#toc
Repository:
rL LLVM
http://review
Author: jlebar
Date: Mon May 30 12:12:55 2016
New Revision: 271215
URL: http://llvm.org/viewvc/llvm-project?rev=271215&view=rev
Log:
[CUDA] Fix order of vectorized ldg intrinsics' elements.
Summary: The order is [x, y, z, w], not [w, x, y, z].
Subscribers: cfe-commits, tra
Differential Revision
Author: ctopper
Date: Mon May 30 12:10:30 2016
New Revision: 271214
URL: http://llvm.org/viewvc/llvm-project?rev=271214&view=rev
Log:
[X86] Replace unaligned store builtins in SSE/AVX intrinsic files with code
that will compile to a native unaligned store. Remove the builtins since they
are no l
bkramer added inline comments.
Comment at: include-fixer/IncludeFixer.h:71
@@ +70,3 @@
+/// \param FirstIncludeOffset The insertion point for new include directives.
+/// -1U(UINT_MAX) indicates uninitialization, which will insert the header at
+/// first line. If there is no #inc
bkramer added inline comments.
Comment at: lib/Format/Format.cpp:1283
@@ +1282,3 @@
+ // Returns the priority of the category which \p IncludeName belongs to, and
+ // if \p CheckMainHeader is true and \p IncldueName is a
+ // main header, returns 0. Otherwise, returns INT_MAX
jlebar created this revision.
jlebar added subscribers: tra, cfe-commits.
The order is [x, y, z, w], not [w, x, y, z].
http://reviews.llvm.org/D20794
Files:
lib/Headers/__clang_cuda_intrinsics.h
Index: lib/Headers/__clang_cuda_intrinsics.h
=
Author: compnerd
Date: Mon May 30 11:36:48 2016
New Revision: 271212
URL: http://llvm.org/viewvc/llvm-project?rev=271212&view=rev
Log:
test: add explicit targets for some tests
These tests currently expect MachO section names and do not provide a target.
Explicitly provide one.
Modified:
cfe
EricWF added a comment.
FYI I have a LIT change out for review that adds "// REQUIRES-ANY: [...]" which
would be subtle for use in this patch.
http://reviews.llvm.org/D20757
http://reviews.llvm.org/D20660
___
cfe-commits mailing list
cfe-commits@l
Author: compnerd
Date: Mon May 30 11:23:07 2016
New Revision: 271211
URL: http://llvm.org/viewvc/llvm-project?rev=271211&view=rev
Log:
CodeGen: tweak CFConstantStrings for COFF and ELF
Adjust the constant CFString emission to emit into more appropriate sections on
ELF and COFF targets. It would
mnbvmar updated this revision to Diff 58940.
mnbvmar added a comment.
Clang-formatted code.
Added a simple macro test.
Resolved @Prazek's issues.
http://reviews.llvm.org/D19165
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/IncrementBoolCheck.cpp
clang-tidy/modernize/Incr
etienneb added a comment.
drive-by
Comment at: clang-tidy/ClangTidy.cpp:24
@@ -24,2 +23,3 @@
#include "clang/ASTMatchers/ASTMatchFinder.h"
-#include "clang/Frontend/ASTConsumers.h"
+#include "clang/Basic/DiagnosticOptions.h"
+#include "clang/Basic/FileManager.h"
---
hokein added inline comments.
Comment at: include-fixer/IncludeFixer.h:80
@@ +79,3 @@
+unsigned FirstIncludeOffset=-1U,
+const clang::format::FormatStyle &Style=clang::format::getLLVMStyle());
+
Using a default argument in `Style` can simplify the code in
Author: etienneb
Date: Mon May 30 10:42:08 2016
New Revision: 271210
URL: http://llvm.org/viewvc/llvm-project?rev=271210&view=rev
Log:
[clang-tidy] Remove redundant quote in add_new_check script
Summary:
Remove redundant quote.
These quotes were added here: http://reviews.llvm.org/D20766
Reviewe
etienneb updated this revision to Diff 58969.
etienneb added a comment.
nits
http://reviews.llvm.org/D20792
Files:
clang-tidy/add_new_check.py
Index: clang-tidy/add_new_check.py
===
--- clang-tidy/add_new_check.py
+++ clang-tidy
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg, thanks!
http://reviews.llvm.org/D20792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
etienneb created this revision.
etienneb added a reviewer: bkramer.
etienneb added a subscriber: cfe-commits.
Remove redundant quote.
These quotes were added here: http://reviews.llvm.org/D20766
http://reviews.llvm.org/D20792
Files:
clang-tidy/add_new_check.py
clang-tidy/misc/UnusedUsingDecl
hokein updated this revision to Diff 58964.
hokein marked an inline comment as done.
hokein added a comment.
Use format::getStyle to get clang-format style.
http://reviews.llvm.org/D20621
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext.
Author: etienneb
Date: Mon May 30 10:25:25 2016
New Revision: 271208
URL: http://llvm.org/viewvc/llvm-project?rev=271208&view=rev
Log:
[ASTMatchers] Add support of hasCondition for SwitchStmt.
Summary:
The switch statement could be added to the hasCondition matcher.
Example:
```
clang-query> mat
On Mon, May 30, 2016 at 5:05 PM, Etienne Bergeron via cfe-commits
wrote:
> Author: etienneb
> Date: Mon May 30 10:05:10 2016
> New Revision: 271207
>
> URL: http://llvm.org/viewvc/llvm-project?rev=271207&view=rev
> Log:
> [clang-tidy] Fix script adding new clang-tidy check
>
> Summary:
> The `getN
Prazek updated this revision to Diff 58961.
Prazek added a comment.
aborting with virtual functions
http://reviews.llvm.org/D18821
Files:
clang-tidy/CMakeLists.txt
clang-tidy/bugprone/BoolToIntegerConversionCheck.cpp
clang-tidy/bugprone/BoolToIntegerConversionCheck.h
clang-tidy/bugprone
emaste created this revision.
emaste added a subscriber: cfe-commits.
`SOURCE_DATE_EPOCH` specifies a UNIX timestamp (number of seconds since 01 Jan
1970 00:00:00 UTC) to be used as the timestamp input for build processes e.g.
`__DATE__` and `__TIME__`
See https://reproducible-builds.org/specs/
doug.gregor added a comment.
Yeah, this looks like the right approach. PCH follows the same rules as modules
when it comes to newer information shadowing imported information.
http://reviews.llvm.org/D20383
___
cfe-commits mailing list
cfe-commits@
Author: etienneb
Date: Mon May 30 10:05:10 2016
New Revision: 271207
URL: http://llvm.org/viewvc/llvm-project?rev=271207&view=rev
Log:
[clang-tidy] Fix script adding new clang-tidy check
Summary:
The `getName()` call is useless. It's better to show a better example
as tutorial.
Reviewers: alexfh
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271207: [clang-tidy] Fix script adding new clang-tidy check
(authored by etienneb).
Changed prior to commit:
http://reviews.llvm.org/D20766?vs=58878&id=58958#toc
Repository:
rL LLVM
http://reviews.l
m_zuckerman updated this revision to Diff 58957.
http://reviews.llvm.org/D20790
Files:
lib/Headers/avx512fintrin.h
test/CodeGen/avx512f-builtins.c
Index: test/CodeGen/avx512f-builtins.c
===
--- test/CodeGen/avx512f-builtins.c
++
m_zuckerman created this revision.
m_zuckerman added reviewers: AsafBadouh, igorb, delena.
m_zuckerman added a subscriber: cfe-commits.
http://reviews.llvm.org/D20790
Files:
lib/Headers/avx512fintrin.h
test/CodeGen/avx512f-builtins.c
Index: test/CodeGen/avx512f-builtins.c
===
ioeric added inline comments.
Comment at: include-fixer/IncludeFixer.h:80
@@ +79,3 @@
+unsigned FirstIncludeOffset=-1U,
+const clang::format::FormatStyle &Style=clang::format::getLLVMStyle());
+
I don't see why we'd want Style to be optional.
hokein updated this revision to Diff 58955.
hokein marked an inline comment as done.
hokein added a comment.
Refactor createReplacementsForHeaders.
http://reviews.llvm.org/D20621
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext.h
inclu
Hi Anastasia,
My apologies for my slow reply. My main issue was that the defaults have
changed, which is somewhat annoying. However, digging deeper into this I’m
noticing two serious problems:
* When I do:
#pragma OPENCL EXTENSION cl_khr_fp16 : disable
the cl_khr_fp16 macro stays defined in
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271205: [Clang][avx512][builtin] Adding missing intrinsics
for cvt (authored by mzuckerm).
Changed prior to commit:
http://reviews.llvm.org/D20618?vs=58405&id=58953#toc
Repository:
rL LLVM
http://re
Author: mzuckerm
Date: Mon May 30 08:22:12 2016
New Revision: 271205
URL: http://llvm.org/viewvc/llvm-project?rev=271205&view=rev
Log:
[Clang][avx512][builtin] Adding missing intrinsics for cvt
Differential Revision: http://reviews.llvm.org/D20618
Modified:
cfe/trunk/lib/Headers/avx512fin
ioeric added inline comments.
Comment at: lib/Format/Format.cpp:1551
@@ +1550,3 @@
+return Replaces;
+ tooling::Replacements HeaderInsertionReplaces;
+ tooling::Replacements NewReplaces;
djasper wrote:
> Why do you split out all the header insertion replacem
ioeric updated this revision to Diff 58952.
ioeric marked 9 inline comments as done.
ioeric added a comment.
- Addressed reviewer's comments.
http://reviews.llvm.org/D20734
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
unittests/Format/CleanupTest.cpp
Index: unittests/Format
Author: abataev
Date: Mon May 30 08:05:14 2016
New Revision: 271204
URL: http://llvm.org/viewvc/llvm-project?rev=271204&view=rev
Log:
[OPENMP 4.5] Additional codegen for statically scheduled loops with
'simd' modifier.
Runtime library defines new schedule constant kmp_sch_static_balanced_chunked
1 - 100 of 114 matches
Mail list logo
