ioeric added inline comments. ================ Comment at: lib/Format/Format.cpp:1551 @@ +1550,3 @@ + return Replaces; + tooling::Replacements HeaderInsertionReplaces; + tooling::Replacements NewReplaces; ---------------- djasper wrote: > Why do you split out all the header insertion replacements here instead of > just ignoring the ones that aren't header insertions in > fixCppIncludeInsertions? I think this enables us to exit early in `fixCppIncludeInsertions` if there is no header insertion replacement at all. Also, it is easier to split out header insertion replacements and then merge fixed replacements with other replacements instead of doing this in place, which IMO might not be more efficient since there are still set deletion and insertion for each header insertion replacement.
http://reviews.llvm.org/D20734 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
