etienneb added a comment. drive-by
================ Comment at: clang-tidy/ClangTidy.cpp:24 @@ -24,2 +23,3 @@ #include "clang/ASTMatchers/ASTMatchFinder.h" -#include "clang/Frontend/ASTConsumers.h" +#include "clang/Basic/DiagnosticOptions.h" +#include "clang/Basic/FileManager.h" ---------------- This one is for sure included by 'clang/Basic/Diagnostic.h'. ================ Comment at: clang-tidy/ClangTidy.h:17 @@ -16,4 +16,3 @@ #include "clang/Basic/Diagnostic.h" -#include "clang/Basic/SourceManager.h" -#include "clang/Tooling/Refactoring.h" -#include "llvm/ADT/StringExtras.h" +#include "clang/Basic/DiagnosticIDs.h" +#include "clang/Basic/LangOptions.h" ---------------- This one is for sure included by 'clang/Basic/Diagnostic.h'. ================ Comment at: clang-tidy/ClangTidyDiagnosticConsumer.h:17 @@ -14,1 +16,3 @@ #include "clang/Basic/Diagnostic.h" +#include "clang/Basic/DiagnosticIDs.h" +#include "clang/Basic/LangOptions.h" ---------------- This one is for sure included by 'clang/Basic/Diagnostic.h'. ================ Comment at: clang-tidy/ClangTidyModule.h:13 @@ -12,3 +12,3 @@ #include "ClangTidy.h" #include "llvm/ADT/StringRef.h" ---------------- There is an issue with includes ordering here and/or line 20. ================ Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:15 @@ -14,1 +14,3 @@ #include "clang/AST/ASTContext.h" +#include "clang/AST/Decl.h" +#include "clang/AST/DeclCXX.h" ---------------- There is always the tradeoff between including separate files, or including AST.h I'm not sure I prefer expanding them. alexfh? toughs? ================ Comment at: clang-tidy/utils/OptionsUtils.cpp:1 @@ -1,2 +1,2 @@ //===--- DanglingHandleCheck.cpp - clang-tidy------------------------------===// // ---------------- Could you fix this 'DanglingHandleCheck.cpp' -> 'OptionsUtils.cpp' Repository: rL LLVM http://reviews.llvm.org/D20714 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
