ioeric added inline comments.

================
Comment at: include-fixer/IncludeFixer.h:80
@@ +79,3 @@
+    unsigned FirstIncludeOffset=-1U,
+    const clang::format::FormatStyle &Style=clang::format::getLLVMStyle());
+
----------------
I don't see why we'd want Style to be optional.

================
Comment at: include-fixer/tool/ClangIncludeFixer.cpp:110
@@ +109,3 @@
+  format::FormatStyle InsertStyle;
+  format::getPredefinedStyle(Style, format::FormatStyle::LK_Cpp, &InsertStyle);
+
----------------
We might still want to use `clang::format::getStyle("file", FilePath, 
FallbackStyle);`, which will use format style defined in clang-format config 
file in the path, if such config file exists. `Style` option is just a fallback 
style.


http://reviews.llvm.org/D20621



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to