Thanks for the clarification.
On Thursday, January 14, 2016, Laszlo Nagy
wrote:
> yes, it is just an initial drop. improvements are planed to make a full
> replacement of the one written in Perl.
>
> On Thu, Jan 14, 2016 at 12:14 AM, Ismail Donmez > wrote:
>
>> Hi,
>>
>> On Wed, Jan 13, 2016 at
ABataev removed a subscriber: rsmith.
ABataev updated this revision to Diff 44833.
ABataev added a comment.
Updated to latest version
http://reviews.llvm.org/D10599
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticParseKinds.td
include/cla
rjmccall added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:385
@@ +384,3 @@
+ unsigned getFloat128Width() const { return Float128Width; }
+ unsigned getFloat128Align() const { return Float128Align; }
+ const llvm::fltSemantics &getFloat128Format() const {
Author: djasper
Date: Wed Jan 13 23:37:52 2016
New Revision: 257741
URL: http://llvm.org/viewvc/llvm-project?rev=257741&view=rev
Log:
clang-format: [JS] Fix incorrect line break leading to semicolon insertion.
clang-format only works for JavaScript code, if all the semicolons are
present anyway,
kromanova added a subscriber: cfe-commits.
kromanova added a comment.
Adding cfe-commits as a subscriber.
Repository:
rL LLVM
http://reviews.llvm.org/D16177
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
pcc created this revision.
pcc added reviewers: kcc, eugenis.
pcc added a subscriber: cfe-commits.
This is part of a new statistics gathering feature for the sanitizers.
See clang/docs/SanitizerStats.rst for further info and docs.
http://reviews.llvm.org/D16175
Files:
docs/SanitizerStats.rst
pxli168 updated this revision to Diff 44826.
pxli168 added a comment.
Fix format of diag err string, remove useless ':' after expecting.
http://reviews.llvm.org/D15914
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/Builtins.h
include/clang/Basic/DiagnosticSemaKinds.td
lib/B
hubert.reinterpretcast added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:550
@@ -548,1 +549,3 @@
case BuiltinType::Double:
+// FIXME: For targets where lond double and __float128 have the same size,
+// they are currently indistinguishable in the debugger w
Author: pcc
Date: Wed Jan 13 20:49:48 2016
New Revision: 257738
URL: http://llvm.org/viewvc/llvm-project?rev=257738&view=rev
Log:
CodeGen: Only emit CFI unrelated cast checks for bit casts.
We were previously emitting them for no-op casts (e.g. implicit casts
to const).
Modified:
cfe/trunk/l
Author: pcc
Date: Wed Jan 13 20:49:51 2016
New Revision: 257739
URL: http://llvm.org/viewvc/llvm-project?rev=257739&view=rev
Log:
Driver: Remove SanitizerArgs::clear() function and SanitizerSet ctor,
replace with in-class initializers.
Modified:
cfe/trunk/include/clang/Basic/Sanitizers.h
jlebar marked 2 inline comments as done.
jlebar added a comment.
Thank you for the review, Artem.
http://reviews.llvm.org/D16080
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar marked 2 inline comments as done.
Comment at: test/Driver/cuda-preprocess.cu:13-16
@@ +12,6 @@
+
+// RUN: %clang -E -target x86_64-linux-gnu --cuda-gpu-arch=sm_20 %s 2>&1 \
+// RUN: | FileCheck -check-prefix NOARCH %s
+// RUN: %clang -E -target x86_64-linux-gnu --cuda-gpu
jlebar updated this revision to Diff 44823.
jlebar added a comment.
Address tra's review comments.
http://reviews.llvm.org/D16080
Files:
test/Preprocessor/cuda-preprocess.cu
Index: test/Preprocessor/cuda-preprocess.cu
===
--- /d
weimingz created this revision.
weimingz added a reviewer: nicholas.
weimingz added a subscriber: cfe-commits.
r255371 errors on redeclaring with a conflicting asm label.
This patch changes errors to warnings to prevent breaking existing codes.
http://reviews.llvm.org/D16171
Files:
include/cla
rjmccall added a comment.
Yes, this seems to be exactly what I wanted, thanks! LGTM.
http://reviews.llvm.org/D15686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nwilson added inline comments.
Comment at: include/clang/AST/DeclTemplate.h:377
@@ -376,3 +376,3 @@
NamedDecl *TemplatedDecl;
TemplateParameterList* TemplateParams;
I can't seem to follow the link properly, but I'm assuming it's supposed to be
where Richa
hubert.reinterpretcast added a comment.
Please add tests for `const bool` for both the function and variable cases
(should get the error).
Comment at: test/CXX/concepts-ts/dcl.dcl/dcl.spec/dcl.spec.concept/p5.cpp:22
@@ +21,3 @@
+template
+concept auto fcrta(void) -> bool { retu
On Wed, Jan 13, 2016 at 6:48 PM, Richard Smith
wrote:
> On Wed, Jan 13, 2016 at 3:41 PM, Arthur O'Dwyer via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Following Louis' suggestion, how about __pack_nth?
>>
>
> Maybe just __pack_element, to mirror its intended use to implement things
>
alexfh added a subscriber: jroelofs.
alexfh added a comment.
In http://reviews.llvm.org/D15528#326031, @jroelofs wrote:
> Hmm. There's no "close revision" button. Abandoning it in lieu of closing it.
Weird. That's probably because I've not marked it "Accepted". Now I tried a few
other actions
hubert.reinterpretcast added inline comments.
Comment at: include/clang/AST/DeclTemplate.h:375
@@ +374,3 @@
+ bool isConcept() const { return TemplatedDecl.getInt(); }
+ void setConcept(bool IC) { TemplatedDecl.setInt(true); }
+
nwilson wrote:
> hubert.reinterpr
On Wed, Jan 13, 2016 at 3:41 PM, Arthur O'Dwyer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Following Louis' suggestion, how about __pack_nth?
>
Maybe just __pack_element, to mirror its intended use to implement things
like tuple_element? (I'm not completely happy about using this gene
nwilson added inline comments.
Comment at: include/clang/AST/DeclTemplate.h:375
@@ +374,3 @@
+ bool isConcept() const { return TemplatedDecl.getInt(); }
+ void setConcept(bool IC) { TemplatedDecl.setInt(true); }
+
hubert.reinterpretcast wrote:
> The parameter is
hokein added inline comments.
Comment at: clang-tidy/tool/ClangTidyMain.cpp:78
@@ +77,3 @@
+static cl::opt
+HeaderFileExtensions("header-file-extensions",
+ cl::desc("File extensions that regard as header file.\n"
alexfh wrote:
> We don't need
nwilson added a comment.
Please let me know if the subject or summary of this Patch is ambiguous.
http://reviews.llvm.org/D16163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nwilson created this revision.
nwilson added reviewers: rsmith, faisalv, hubert.reinterpretcast, aaron.ballman.
nwilson added a subscriber: cfe-commits.
Adding checks and diagnostics which fall under Concepts TS[dcl.spec.concept]p5:
function concepts are required to have 'bool' return type.
Addin
Thanks! Merged as indicated below.
On Wed, Jan 13, 2016 at 3:48 PM, Marshall Clow wrote:
> r257702 | marshall | 2016-01-13 15:05:15 -0800 (Wed, 13 Jan 2016) | 1 line
>
> Better comments in test. NFC
r257721.
> r257696 | marshall | 2016-01-13 14:52:36 -0800 (Wed, 13 Jan 2016) | 1 line
>
> Fix te
Author: hans
Date: Wed Jan 13 18:02:08 2016
New Revision: 257721
URL: http://llvm.org/viewvc/llvm-project?rev=257721&view=rev
Log:
Merging r257702:
r257702 | marshall | 2016-01-13 15:05:15 -0800 (Wed, 13 Jan 2016) | 1 line
B
Thanks! Richard, what say the code owner?
On Wed, Jan 13, 2016 at 3:59 PM, George Burgess IV
wrote:
> FYI: This patch should to be merged into the clang 3.8.0 branch.
>
> Thank you!
> George
>
> On Wed, Jan 13, 2016 at 3:36 PM, George Burgess IV via cfe-commits
> wrote:
>>
>> Author: gbiv
>> Dat
Author: hans
Date: Wed Jan 13 18:01:17 2016
New Revision: 257720
URL: http://llvm.org/viewvc/llvm-project?rev=257720&view=rev
Log:
Merging r257696:
r257696 | marshall | 2016-01-13 14:52:36 -0800 (Wed, 13 Jan 2016) | 1 line
F
FYI: This patch should to be merged into the clang 3.8.0 branch.
Thank you!
George
On Wed, Jan 13, 2016 at 3:36 PM, George Burgess IV via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: gbiv
> Date: Wed Jan 13 17:36:34 2016
> New Revision: 257710
>
> URL: http://llvm.org/viewvc/llvm-p
Author: hans
Date: Wed Jan 13 17:53:40 2016
New Revision: 257716
URL: http://llvm.org/viewvc/llvm-project?rev=257716&view=rev
Log:
Merging r257682:
r257682 | marshall | 2016-01-13 13:54:34 -0800 (Wed, 13 Jan 2016) | 1 line
F
Thanks. I've merged this together with r257695 to 3.8 in r257714.
On Wed, Jan 13, 2016 at 2:55 PM, Richard Smith wrote:
> The right way to update this file is to change the www/make_cxx_dr_status
> script and then rerun it. (It expects to find a copy of the cwg_index.html
> page from the wg21 web
eugenis added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:2654-2678
@@ +2653,27 @@
+ for (auto CheckKindMaskPair : CheckKinds) {
+int Kind = CheckKindMaskPair.first;
+SanitizerMask Mask = CheckKindMaskPair.second;
+// All CFI checks are recoverable.
+asser
eugenis updated this revision to Diff 44805.
eugenis marked 2 inline comments as done.
Repository:
rL LLVM
http://reviews.llvm.org/D15699
Files:
lib/CodeGen/CGClass.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.h
lib/CodeGen/CodeGenModule.cpp
lib/Driver/Tools.cpp
test/Code
Following Louis' suggestion, how about __pack_nth?
On Wed, Jan 13, 2016 at 3:16 PM, Nathan Wilson via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
>
> On Wed, Jan 13, 2016 at 4:52 PM, Richard Smith
> wrote:
>
>> On Wed, Jan 13, 2016 at 2:31 PM, Nathan Wilson
>> wrote:
>>
>>> nwilson added
This revision was automatically updated to reflect the committed changes.
Closed by commit rL257710: [Sema] Suppress diags in overload resolution.
(authored by gbiv).
Changed prior to commit:
http://reviews.llvm.org/D16159?vs=44797&id=44803#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1
Author: gbiv
Date: Wed Jan 13 17:36:34 2016
New Revision: 257710
URL: http://llvm.org/viewvc/llvm-project?rev=257710&view=rev
Log:
[Sema] Suppress diags in overload resolution.
We were emitting diagnostics from our shiny new C-only overload
resolution mode. This patch attempts to silence all such
Author: jroelofs
Date: Wed Jan 13 17:27:08 2016
New Revision: 257707
URL: http://llvm.org/viewvc/llvm-project?rev=257707&view=rev
Log:
Tame a -Wunknown-attributes warning
Modified:
libcxx/trunk/include/__config
Modified: libcxx/trunk/include/__config
URL:
http://llvm.org/viewvc/llvm-project
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D16159
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
On Wed, Jan 13, 2016 at 4:52 PM, Richard Smith
wrote:
> On Wed, Jan 13, 2016 at 2:31 PM, Nathan Wilson
> wrote:
>
>> nwilson added a comment.
>>
>> In http://reviews.llvm.org/D15421#326144, @rsmith wrote:
>>
>> > Bikeshedding on the name a bit... how about `__type_pack_element`?
>>
>> Hmm, I kin
Author: marshall
Date: Wed Jan 13 17:05:15 2016
New Revision: 257702
URL: http://llvm.org/viewvc/llvm-project?rev=257702&view=rev
Log:
Better comments in test. NFC
Modified:
libcxx/trunk/test/libcxx/strings/iterators.noexcept.pass.cpp
Modified: libcxx/trunk/test/libcxx/strings/iterators.noex
yes, it is just an initial drop. improvements are planed to make a full
replacement of the one written in Perl.
On Thu, Jan 14, 2016 at 12:14 AM, Ismail Donmez wrote:
> Hi,
>
> On Wed, Jan 13, 2016 at 12:38 AM, Laszlo Nagy via cfe-commits
> wrote:
> > Author: rizsotto
> > Date: Tue Jan 12 16:38
george.burgess.iv created this revision.
george.burgess.iv added reviewers: bob.wilson, rsmith.
george.burgess.iv added a subscriber: cfe-commits.
Fix PR26085 by suppressing diags from CheckSingleAssignmentConstraints during
overload resolution.
It seems that passing `Diagnose`/`Complain` flags
beanz created this revision.
beanz added reviewers: rnk, chapuni, hintonda.
beanz added a subscriber: cfe-commits.
CMake freaks out in trivial cases like:
> cmake -G Ninja -DLLVM_ENABLE_PIC=Off -DLLVM_INSTALL_TOOLCHAIN_ONLY=On ../llvm
This is a result of static ink dependencies not all being par
Author: marshall
Date: Wed Jan 13 16:52:36 2016
New Revision: 257696
URL: http://llvm.org/viewvc/llvm-project?rev=257696&view=rev
Log:
Fix test for C++03 - lacking noexcept
Modified:
libcxx/trunk/test/libcxx/strings/iterators.exceptions.pass.cpp
Modified: libcxx/trunk/test/libcxx/strings/ite
Author: rsmith
Date: Wed Jan 13 16:51:59 2016
New Revision: 257695
URL: http://llvm.org/viewvc/llvm-project?rev=257695&view=rev
Log:
Update make_cxx_dr_status after the 3.8 branch.
Modified:
cfe/trunk/www/make_cxx_dr_status
Modified: cfe/trunk/www/make_cxx_dr_status
URL:
http://llvm.org/vie
The right way to update this file is to change the www/make_cxx_dr_status
script and then rerun it. (It expects to find a copy of the cwg_index.html
page from the wg21 website in the current directory.) Done in r257695.
On Wed, Jan 13, 2016 at 11:20 AM, Hans Wennborg wrote:
> Richard, can you ch
Hello,
In the attachment is a small patch for clang-format-sublime.py, that
prevents the console window from showing. Right now, it is flashing ever so
briefly, ever so annoyingly; this patches fixes that.
I've tested it on Windows and Mac OS X.
I do not have write access; if you agree with the
Apologies for reviving a long dead thread, but I think we need to re-evalute
this change.
With CMake 3.4 I’m seeing some nasty error spew on our internal builds. The
spew can be reproduced with the following CMake invocation:
> cmake -G Ninja -DLLVM_ENABLE_PIC=Off -DLLVM_INSTALL_TOOLCHAIN_ONLY=
On Wed, Jan 13, 2016 at 2:31 PM, Nathan Wilson wrote:
> nwilson added a comment.
>
> In http://reviews.llvm.org/D15421#326144, @rsmith wrote:
>
> > Bikeshedding on the name a bit... how about `__type_pack_element`?
>
> Hmm, I kind of felt like having `nth` in there implied we're indexing into
> s
ldionne added a comment.
In http://reviews.llvm.org/D15421#326209, @nwilson wrote:
> In http://reviews.llvm.org/D15421#326144, @rsmith wrote:
>
> > Bikeshedding on the name a bit... how about `__type_pack_element`?
>
>
> Hmm, I kind of felt like having `nth` in there implied we're indexing into
nwilson added a comment.
In http://reviews.llvm.org/D15421#326144, @rsmith wrote:
> Bikeshedding on the name a bit... how about `__type_pack_element`?
Hmm, I kind of felt like having `nth` in there implied we're indexing into
something... What about `__nth_pack_element`?
http://reviews.llvm.
Author: marshall
Date: Wed Jan 13 15:54:34 2016
New Revision: 257682
URL: http://llvm.org/viewvc/llvm-project?rev=257682&view=rev
Log:
Fix PR#25973 : 'basic_string::assign(InputIt, InputIt) doesn't provide the
strong exception safety guarantee'. This turned out to be a pervasive problem
in , whi
jyknight created this revision.
jyknight added a subscriber: cfe-commits.
Herald added subscribers: jyknight, dschuff, jfb.
Fixes PR11517 for SPARC.
On most targets, clang lowers va_arg itself, eschewing the use of the
llvm vaarg instruction. This is necessary (at least for now) as the type
argum
rsmith added a comment.
Bikeshedding on the name a bit... how about `__type_pack_element`?
http://reviews.llvm.org/D15421
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added inline comments.
Comment at: include/clang/Basic/Builtins.h:216-219
@@ -215,3 +215,6 @@
/// \brief This names the __make_integer_seq BuiltinTemplateDecl.
BTK__make_integer_seq
+
+ /// \brief This names the __nth_element BuiltinTemplateDecl.
+ , BTK__nth_elemen
sbenza created this revision.
sbenza added a reviewer: alexfh.
sbenza added a subscriber: cfe-commits.
Add check performance-faster-string-find.
It replaces single character string literals to character literals in calls to
string::find and friends.
http://reviews.llvm.org/D16152
Files:
clang
rsmith added a comment.
I think this functionality can be provided more simply by adding another flag
to `PrintingPolicy` to request fully-qualified names always be produced. It
already usually provides fully-qualified names; the only notable exception I
can see is that if a qualifier was alrea
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Sorry, this LGTM. You should push it to 3.8 as well.
Comment at: include/iterator:1418
@@ +1417,3 @@
+template
+struct __libcpp_is_trivial_iterator >
+ : public
_LIBCP
ldionne added a reviewer: rsmith.
ldionne updated this revision to Diff 44779.
ldionne added a comment.
Rebase on top of the master branch, and add Richard Smith as a reviewer, since
he also reviewed David Majnemer's original patch (suggested by Nathan Wilson).
http://reviews.llvm.org/D15421
F
comex added reviewers: aaron.ballman, rsmith.
comex added a comment.
Ping, and adding potential reviewers like I was supposed to do in the first
place.
http://reviews.llvm.org/D15907
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
jroelofs abandoned this revision.
jroelofs added a comment.
Hmm. There's no "close revision" button. Abandoning it in lieu of closing it.
http://reviews.llvm.org/D15528
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
Tests need to be updated, for example:
clang/test/Index/remap-load.c:7:11: error: expected string not found in input
// CHECK: remap-load.c:2:10: BinaryOperator= Extent=[2:10 - 2:23]
^
:334:1: note: scanning from here
// CHECK: remap-load.c:2:10: BinaryOperator=+ Extent=[2:10 - 2:23]
^
:
akyrtzi added a comment.
Tests need to be updated, for example:
clang/test/Index/remap-load.c:7:11: error: expected string not found in input
// CHECK: remap-load.c:2:10: BinaryOperator= Extent=[2:10 - 2:23]
^
:334:1: note: scanning from here
// CHECK: remap-load.c:2:10: BinaryOperator=+ Exte
xur updated this revision to Diff 44776.
xur added a comment.
added new tests and comments based on the review comments.
http://reviews.llvm.org/D15829
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/BackendUtil.cpp
lib/CodeGen/CodeGenModule.
xur marked an inline comment as done.
xur added a comment.
I'll sent the revised patch based on the comments shortly.
Comment at: lib/CodeGen/BackendUtil.cpp:435
@@ +434,3 @@
+ if (CodeGenOpts.ProfileIRInstr) {
+assert (!CodeGenOpts.ProfileInstrGenerate);
+if (!CodeGenO
On Fri, Jan 8, 2016 at 1:54 PM, Philippe Canal wrote:
> Hi Richard,
>
> In our use (Persistency of C++ objects, including the (meta)description of
> their data content as well as use the name as key to access the class'
> reflection information at run-time), the 'context' is indeed always the "at
jix created this revision.
jix added a subscriber: cfe-commits.
jix set the repository for this revision to rL LLVM.
Herald added a subscriber: aemerson.
Parameter default values are expected to be attached to all redeclarations of a
template. During serialization they are serialized only for the
Richard, can you check that I got this right? Are there any more DRs
that were addressed in 3.8?
If it looks good, I'll merge this to the branch.
Cheers,
Hans
On Wed, Jan 13, 2016 at 11:14 AM, Hans Wennborg via cfe-commits
wrote:
> Author: hans
> Date: Wed Jan 13 13:14:03 2016
> New Revision: 2
Author: hans
Date: Wed Jan 13 13:14:03 2016
New Revision: 257652
URL: http://llvm.org/viewvc/llvm-project?rev=257652&view=rev
Log:
Update cxx_dr_status.html after the 3.8 branch
Modified:
cfe/trunk/www/cxx_dr_status.html
Modified: cfe/trunk/www/cxx_dr_status.html
URL:
http://llvm.org/viewvc
mclow.lists added inline comments.
Comment at: include/iterator:1418
@@ +1417,3 @@
+template
+struct __libcpp_is_trivial_iterator >
+ : public
_LIBCPP_BOOL_CONSTANT(__libcpp_is_trivial_iterator<_Iter>::value) {};
EricWF wrote:
> Should this trait handle `c
NoQ added a reviewer: rsmith.
NoQ added a comment.
Richard: excuse me, adding you because you are an expert on the `modulemap`,
could you have a quick look at the proposed changes here and probably point me
in the right direction, because i'm not quite sure how to test the
modules-enabled build
hubert.reinterpretcast added inline comments.
Comment at: include/clang/AST/DeclTemplate.h:373
@@ -372,1 +372,3 @@
+ /// Whether this is a (C++ Concepts TS) function concept.
+ bool isConcept() const { return TemplatedDecl.getInt(); }
This code is not limited
ahatanak added a comment.
Ping.
The same pragma is being used in other places (regex.cpp and locale.cpp) to
silence the warning.
http://reviews.llvm.org/D15897
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D16081
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra added inline comments.
Comment at: test/Driver/cuda-preprocess.cu:13-16
@@ +12,6 @@
+
+// RUN: %clang -E -target x86_64-linux-gnu --cuda-gpu-arch=sm_20 %s 2>&1 \
+// RUN: | FileCheck -check-prefix NOARCH %s
+// RUN: %clang -E -target x86_64-linux-gnu --cuda-gpu-arch=sm_20
-
jroelofs accepted this revision.
jroelofs added a reviewer: jroelofs.
jroelofs marked 2 inline comments as done.
jroelofs added a comment.
Thanks for the review! Committed r257642.
http://reviews.llvm.org/D15528
___
cfe-commits mailing list
cfe-comm
Marshall, Eric,
Please check that this was OK, as I don't usually commit to libc++.
Thanks,
Hans
On Wed, Jan 13, 2016 at 9:33 AM, Hans Wennborg via cfe-commits
wrote:
> Author: hans
> Date: Wed Jan 13 11:33:21 2016
> New Revision: 257629
>
> URL: http://llvm.org/viewvc/llvm-project?rev=257629&v
Author: jroelofs
Date: Wed Jan 13 11:36:41 2016
New Revision: 257642
URL: http://llvm.org/viewvc/llvm-project?rev=257642&view=rev
Log:
Teach clang-tidy how to upgrade warnings into errors.
Similar in format to the `-checks=` argument, this new `-warnings-as-errors=`
argument upgrades any warnings
Author: hans
Date: Wed Jan 13 11:35:29 2016
New Revision: 257641
URL: http://llvm.org/viewvc/llvm-project?rev=257641&view=rev
Log:
Creating release_38 branch off revision 257626
Added:
libunwind/branches/release_38/
- copied from r257626, libunwind/trunk/
__
Author: hans
Date: Wed Jan 13 11:35:07 2016
New Revision: 257634
URL: http://llvm.org/viewvc/llvm-project?rev=257634&view=rev
Log:
Creating release_38 branch off revision 257626
Added:
libcxx/branches/release_38/ (props changed)
- copied from r257626, libcxx/trunk/
Propchange: libcxx
Author: hans
Date: Wed Jan 13 11:35:10 2016
New Revision: 257635
URL: http://llvm.org/viewvc/llvm-project?rev=257635&view=rev
Log:
Creating release_38 branch off revision 257626
Added:
libcxxabi/branches/release_38/
- copied from r257626, libcxxabi/trunk/
__
Author: hans
Date: Wed Jan 13 11:32:59 2016
New Revision: 257628
URL: http://llvm.org/viewvc/llvm-project?rev=257628&view=rev
Log:
Update version to 3.9
Modified:
cfe/trunk/docs/ReleaseNotes.rst
cfe/trunk/docs/conf.py
Modified: cfe/trunk/docs/ReleaseNotes.rst
URL:
http://llvm.org/viewvc
Author: hans
Date: Wed Jan 13 11:33:21 2016
New Revision: 257629
URL: http://llvm.org/viewvc/llvm-project?rev=257629&view=rev
Log:
Update version to 3.9
Modified:
libcxx/trunk/include/__config
Modified: libcxx/trunk/include/__config
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trunk/incl
jroelofs updated this revision to Diff 44759.
jroelofs added a comment.
clang-format the patch, and rename method.
http://reviews.llvm.org/D15528
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
NoQ removed rL LLVM as the repository for this revision.
NoQ updated this revision to Diff 44758.
NoQ added a comment.
Reverted the patch due to a few issues. This revision should fix these issues.
The explain-svals test is fixed to target a specific target, in order to make
sure that the defini
aprantl added a comment.
Added a few stylistic comments and request for more documentation.
Comment at: lib/CodeGen/MacroPPCallbacks.cpp:1
@@ +1,2 @@
+//===--- MacroPPCallbacks.h ---*- C++
-*-===//
+//
Please run your patch t
Author: djasper
Date: Wed Jan 13 10:41:34 2016
New Revision: 257615
URL: http://llvm.org/viewvc/llvm-project?rev=257615&view=rev
Log:
clang-format: [ObjC+JS] Allow bin-packing of array literals.
After reading the style guides again, they don't actually say how to
pack or not pack array literals.
Author: djg
Date: Wed Jan 13 10:39:30 2016
New Revision: 257614
URL: http://llvm.org/viewvc/llvm-project?rev=257614&view=rev
Log:
[WebAssembly] Accomodate wasm's 128-bit long double.
Modified:
libcxxabi/trunk/src/cxa_demangle.cpp
Modified: libcxxabi/trunk/src/cxa_demangle.cpp
URL:
http://ll
Author: djg
Date: Wed Jan 13 10:32:00 2016
New Revision: 257612
URL: http://llvm.org/viewvc/llvm-project?rev=257612&view=rev
Log:
[WebAssembly] Set std::numeric_limits's traps field for WebAssembly.
WebAssembly's integer division instruction traps on division by zero; set the
traps field of integ
EricWF added a comment.
Almost LGTM. Could you re-upload with more context quickly? (ex git diff -U999)
Comment at: include/iterator:1418
@@ +1417,3 @@
+template
+struct __libcpp_is_trivial_iterator >
+ : public
_LIBCPP_BOOL_CONSTANT(__libcpp_is_trivial_iterator<_Iter>::
Author: s.egerton
Date: Wed Jan 13 10:19:33 2016
New Revision: 257610
URL: http://llvm.org/viewvc/llvm-project?rev=257610&view=rev
Log:
Revert r257602 because it breaks integrated-as.s on mips hosts.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/test/Driver/mips-ias-Wa.s
Modified: c
alexfh added a comment.
Looks good with a couple of nits. I'll be happy to submit your patch once you
address the comments.
Also, please include more context in your patches. See
http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface.
Comment at: clan
ABataev updated this revision to Diff 44754.
ABataev added a comment.
Update after review
http://reviews.llvm.org/D15709
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGen/TargetInfo.cpp
lib/Sema/SemaDeclAttr.cpp
Author: dergachev
Date: Wed Jan 13 09:52:25 2016
New Revision: 257608
URL: http://llvm.org/viewvc/llvm-project?rev=257608&view=rev
Log:
Revert "[analyzer] Provide .def-files and visitors for SVal/SymExpr/MemRegion."
This reverts commit r257605.
The test fails on architectures that use unsigned i
Author: dergachev
Date: Wed Jan 13 09:13:48 2016
New Revision: 257605
URL: http://llvm.org/viewvc/llvm-project?rev=257605&view=rev
Log:
[analyzer] Provide .def-files and visitors for SVal/SymExpr/MemRegion.
Provide separate visitor templates for the three hierarchies, and also
the `FullSValVisito
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
After pondering this patch for a while I couldn't come up with a case where
this would cause problems, but it provides great improvements for editing
headers in an interactive setup. So LGTM
This revision was automatically updated to reflect the committed changes.
Closed by commit rL257605: [analyzer] Provide .def-files and visitors for
SVal/SymExpr/MemRegion. (authored by dergachev).
Changed prior to commit:
http://reviews.llvm.org/D15448?vs=44734&id=44752#toc
Repository:
rL LL
Author: s.egerton
Date: Wed Jan 13 08:27:59 2016
New Revision: 257602
URL: http://llvm.org/viewvc/llvm-project?rev=257602&view=rev
Log:
[mips] Added support for -Wa,-mips32 and similar.
Reviewers: vkalintiris, dsanders
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D150
This revision was automatically updated to reflect the committed changes.
Closed by commit rL257599: Support virtual-near-miss check. (authored by
alexfh).
Changed prior to commit:
http://reviews.llvm.org/D15823?vs=44661&id=44746#toc
Repository:
rL LLVM
http://reviews.llvm.org/D15823
Files
1 - 100 of 123 matches
Mail list logo
