Re: RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3

2024-10-11 Thread SendaoYan
On Fri, 11 Oct 2024 03:14:40 GMT, SendaoYan wrote: > Hi all, > On alinux3(alibaba cloud linux version 3) system, the /tmp disk partition is > mounted as tmpfs filesystem type, this filesystem type doesn't support create > time(birth time). > This PR is a REDO PR of https://github.com/openjdk/jd

Re: RFR: 8341880: RISC-V: riscv_vector.h native build fails with gcc13 after JDK-8320500 [v2]

2024-10-11 Thread Hamlin Li
On Fri, 11 Oct 2024 04:02:53 GMT, SendaoYan wrote: >> Hi all, >> The file >> `src/jdk.incubator.vector/linux/native/libsleef/lib/vector_math_rvv.c` >> introduced by [JDK-8341880](https://bugs.openjdk.org/browse/JDK-8341880) >> native build fails by fedora OS shipped gcc13. >> Gcc13 doesn't hav

Integrated: 8341806: Gcc version detection failure on Alinux3

2024-10-11 Thread SendaoYan
On Wed, 9 Oct 2024 11:52:13 GMT, SendaoYan wrote: > Hi all, > There is a gcc version detection bug in `make/autoconf/toolchain.m4`. > Before this PR, the gcc version detection shell command is: > > gcc --version 2>&1 | tr "\n" " " | sed -e 's/ *Copyright .*//' | sed -e > 's/^.* ([1-9][0-9]*.[0-

Integrated: 8341880: RISC-V: riscv_vector.h native build fails with gcc13 after JDK-8320500

2024-10-11 Thread SendaoYan
On Thu, 10 Oct 2024 07:37:43 GMT, SendaoYan wrote: > Hi all, > The file > `src/jdk.incubator.vector/linux/native/libsleef/lib/vector_math_rvv.c` > introduced by [JDK-8341880](https://bugs.openjdk.org/browse/JDK-8341880) > native build fails by fedora OS shipped gcc13. > Gcc13 doesn't have `__r

Re: RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3

2024-10-11 Thread Severin Gehwolf
On Fri, 11 Oct 2024 03:14:40 GMT, SendaoYan wrote: > Hi all, > On alinux3(alibaba cloud linux version 3) system, the /tmp disk partition is > mounted as tmpfs filesystem type, this filesystem type doesn't support create > time(birth time). > This PR is a REDO PR of https://github.com/openjdk/jd

Re: RFR: 8341880: RISC-V: riscv_vector.h native build fails with gcc13 after JDK-8320500 [v2]

2024-10-11 Thread SendaoYan
On Fri, 11 Oct 2024 07:44:52 GMT, Hamlin Li wrote: >> SendaoYan has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - chech gcc and clang verison to determine #include or not >> - chech gcc and clang verison to determine #include or not >

Re: RFR: 8341880: RISC-V: riscv_vector.h native build fails with gcc13 after JDK-8320500 [v2]

2024-10-11 Thread SendaoYan
On Fri, 11 Oct 2024 04:02:53 GMT, SendaoYan wrote: >> Hi all, >> The file >> `src/jdk.incubator.vector/linux/native/libsleef/lib/vector_math_rvv.c` >> introduced by [JDK-8341880](https://bugs.openjdk.org/browse/JDK-8341880) >> native build fails by fedora OS shipped gcc13. >> Gcc13 doesn't hav

Re: RFR: 8341880: RISC-V: riscv_vector.h native build fails with gcc13 after JDK-8320500 [v3]

2024-10-11 Thread SendaoYan
> Hi all, > The file > `src/jdk.incubator.vector/linux/native/libsleef/lib/vector_math_rvv.c` > introduced by [JDK-8341880](https://bugs.openjdk.org/browse/JDK-8341880) > native build fails by fedora OS shipped gcc13. > Gcc13 doesn't have `__riscv_v_intrinsic` macro by default, and do have > `_

Re: RFR: 8341880: RISC-V: riscv_vector.h native build fails with gcc13 after JDK-8320500 [v3]

2024-10-11 Thread SendaoYan
On Fri, 11 Oct 2024 07:57:48 GMT, SendaoYan wrote: >> Hi all, >> The file >> `src/jdk.incubator.vector/linux/native/libsleef/lib/vector_math_rvv.c` >> introduced by [JDK-8341880](https://bugs.openjdk.org/browse/JDK-8341880) >> native build fails by fedora OS shipped gcc13. >> Gcc13 doesn't hav

Re: RFR: 8341880: RISC-V: riscv_vector.h native build fails with gcc13 after JDK-8320500 [v3]

2024-10-11 Thread Hamlin Li
On Fri, 11 Oct 2024 07:57:48 GMT, SendaoYan wrote: >> Hi all, >> The file >> `src/jdk.incubator.vector/linux/native/libsleef/lib/vector_math_rvv.c` >> introduced by [JDK-8341880](https://bugs.openjdk.org/browse/JDK-8341880) >> native build fails by fedora OS shipped gcc13. >> Gcc13 doesn't hav

Re: RFR: 8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode [v3]

2024-10-11 Thread Chris Plummer
On Fri, 11 Oct 2024 06:43:33 GMT, Axel Boldt-Christmas wrote: >> This is the implementation task for `JEP 490: ZGC: Remove the >> Non-Generational Mode`. See the JEP for details. >> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850) > > Axel Boldt-Christmas has updated the pull request

Re: RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3

2024-10-11 Thread SendaoYan
On Fri, 11 Oct 2024 19:06:39 GMT, Brian Burkhalter wrote: > Test passed on Linux-{aarch64,x64}, macOS-{aarch64,x64}, Windows-x64. Thanks for the verify very much. - PR Comment: https://git.openjdk.org/jdk/pull/21462#issuecomment-2408291098

Re: RFR: 8311530: Deprecate jdk.jsobject module for removal [v3]

2024-10-11 Thread Erik Joelsson
On Thu, 10 Oct 2024 12:25:53 GMT, Kevin Rushforth wrote: >> Deprecate the `jdk.jsobject` module for removal from the JDK, and ship it >> with JavaFX instead. >> >> See [JDK-8337280](https://bugs.openjdk.org/browse/JDK-8337280) / PR >> openjdk/jfx#1529 for the JavaFX PR that will include the mo

Re: RFR: 8339570: Add Tidy build support for JDK tests [v5]

2024-10-11 Thread Nizar Benalla
> Can I get a review for this patch that adds the necessary changes for local > support of the `tidy` library. > > The dependency can be retrieved by running `make/devkit/createTidyBundle.sh` > on Linux and MacOs systems. > > This dependency is primarily going to be used to test the generated

Re: RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3

2024-10-11 Thread Chen Liang
On Fri, 11 Oct 2024 03:14:40 GMT, SendaoYan wrote: > Hi all, > On alinux3(alibaba cloud linux version 3) system, the /tmp disk partition is > mounted as tmpfs filesystem type, this filesystem type doesn't support create > time(birth time). > This PR is a REDO PR of https://github.com/openjdk/jd

Re: RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3

2024-10-11 Thread Brian Burkhalter
On Fri, 11 Oct 2024 03:14:40 GMT, SendaoYan wrote: > Hi all, > On alinux3(alibaba cloud linux version 3) system, the /tmp disk partition is > mounted as tmpfs filesystem type, this filesystem type doesn't support create > time(birth time). > This PR is a REDO PR of https://github.com/openjdk/jd

Re: RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3

2024-10-11 Thread Brian Burkhalter
On Fri, 11 Oct 2024 03:14:40 GMT, SendaoYan wrote: > Hi all, > On alinux3(alibaba cloud linux version 3) system, the /tmp disk partition is > mounted as tmpfs filesystem type, this filesystem type doesn't support create > time(birth time). > This PR is a REDO PR of https://github.com/openjdk/jd

Re: RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3

2024-10-11 Thread Magnus Ihse Bursie
On Fri, 11 Oct 2024 03:14:40 GMT, SendaoYan wrote: > Hi all, > On alinux3(alibaba cloud linux version 3) system, the /tmp disk partition is > mounted as tmpfs filesystem type, this filesystem type doesn't support create > time(birth time). > This PR is a REDO PR of https://github.com/openjdk/jd

Re: RFR: 8340818: Add a new jtreg test root to test the generated documentation [v5]

2024-10-11 Thread Nizar Benalla
> Please review this change that adds a new test root `docs` dedicated to > testing the documentation, which has been a work in progress for a while. > Tests for links, encoding, HTML, accessibility will be later added in > following PRs. > > We also define a new make target `test-docs` meant

Re: RFR: 8339570: Add Tidy build support for JDK tests [v5]

2024-10-11 Thread Magnus Ihse Bursie
On Fri, 11 Oct 2024 12:53:31 GMT, Nizar Benalla wrote: >> Can I get a review for this patch that adds the necessary changes for local >> support of the `tidy` library. >> >> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh` >> on Linux and MacOs systems. >> >> This

Re: RFR: 8340818: Add a new jtreg test root to test the generated documentation [v5]

2024-10-11 Thread Magnus Ihse Bursie
On Fri, 11 Oct 2024 12:54:42 GMT, Nizar Benalla wrote: >> Please review this change that adds a new test root `docs` dedicated to >> testing the documentation, which has been a work in progress for a while. >> Tests for links, encoding, HTML, accessibility will be later added in >> following P

Re: RFR: 8340818: Add a new jtreg test root to test the generated documentation [v5]

2024-10-11 Thread Magnus Ihse Bursie
On Fri, 11 Oct 2024 12:54:42 GMT, Nizar Benalla wrote: >> Please review this change that adds a new test root `docs` dedicated to >> testing the documentation, which has been a work in progress for a while. >> Tests for links, encoding, HTML, accessibility will be later added in >> following P

Re: RFR: 8340818: Add a new jtreg test root to test the generated documentation [v5]

2024-10-11 Thread Nizar Benalla
On Fri, 11 Oct 2024 12:54:42 GMT, Nizar Benalla wrote: >> Please review this change that adds a new test root `docs` dedicated to >> testing the documentation, which has been a work in progress for a while. >> Tests for links, encoding, HTML, accessibility will be later added in >> following P

Re: RFR: 8340818: Add a new jtreg test root to test the generated documentation [v5]

2024-10-11 Thread Magnus Ihse Bursie
On Fri, 11 Oct 2024 12:54:42 GMT, Nizar Benalla wrote: >> Please review this change that adds a new test root `docs` dedicated to >> testing the documentation, which has been a work in progress for a while. >> Tests for links, encoding, HTML, accessibility will be later added in >> following P

Re: RFR: 8340818: Add a new jtreg test root to test the generated documentation [v5]

2024-10-11 Thread Magnus Ihse Bursie
On Fri, 11 Oct 2024 12:54:42 GMT, Nizar Benalla wrote: >> Please review this change that adds a new test root `docs` dedicated to >> testing the documentation, which has been a work in progress for a while. >> Tests for links, encoding, HTML, accessibility will be later added in >> following P

Re: RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3

2024-10-11 Thread Brian Burkhalter
On Fri, 11 Oct 2024 14:37:00 GMT, Chen Liang wrote: >> Hi all, >> On alinux3(alibaba cloud linux version 3) system, the /tmp disk partition is >> mounted as tmpfs filesystem type, this filesystem type doesn't support >> create time(birth time). >> This PR is a REDO PR of https://github.com/open

Re: RFR: 8340818: Add a new jtreg test root to test the generated documentation [v5]

2024-10-11 Thread Magnus Ihse Bursie
On Fri, 11 Oct 2024 12:54:42 GMT, Nizar Benalla wrote: >> Please review this change that adds a new test root `docs` dedicated to >> testing the documentation, which has been a work in progress for a while. >> Tests for links, encoding, HTML, accessibility will be later added in >> following P

Re: RFR: 8340818: Add a new jtreg test root to test the generated documentation [v5]

2024-10-11 Thread Magnus Ihse Bursie
On Fri, 11 Oct 2024 12:54:42 GMT, Nizar Benalla wrote: >> Please review this change that adds a new test root `docs` dedicated to >> testing the documentation, which has been a work in progress for a while. >> Tests for links, encoding, HTML, accessibility will be later added in >> following P

Re: RFR: 8340818: Add a new jtreg test root to test the generated documentation [v5]

2024-10-11 Thread Nizar Benalla
On Fri, 11 Oct 2024 12:54:42 GMT, Nizar Benalla wrote: >> Please review this change that adds a new test root `docs` dedicated to >> testing the documentation, which has been a work in progress for a while. >> Tests for links, encoding, HTML, accessibility will be later added in >> following P

Re: RFR: 8340818: Add a new jtreg test root to test the generated documentation [v5]

2024-10-11 Thread Erik Joelsson
On Fri, 11 Oct 2024 15:55:08 GMT, Nizar Benalla wrote: > Is it okay to assume that if someone wants to test the generated docs, he > will have most luckily built them beforehand? > So it can work if users use `make test TEST=some/specific/test/in/docs`, > while not being ideal. I definitely th

Re: RFR: 8340818: Add a new jtreg test root to test the generated documentation [v5]

2024-10-11 Thread Magnus Ihse Bursie
On Fri, 11 Oct 2024 12:54:42 GMT, Nizar Benalla wrote: >> Please review this change that adds a new test root `docs` dedicated to >> testing the documentation, which has been a work in progress for a while. >> Tests for links, encoding, HTML, accessibility will be later added in >> following P

Re: RFR: 8339570: Add Tidy build support for JDK tests [v5]

2024-10-11 Thread Magnus Ihse Bursie
On Fri, 11 Oct 2024 12:53:31 GMT, Nizar Benalla wrote: >> Can I get a review for this patch that adds the necessary changes for local >> support of the `tidy` library. >> >> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh` >> on Linux and MacOs systems. >> >> This