On Fri, 11 Oct 2024 12:54:42 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:
>> Please review this change that adds a new test root `docs` dedicated to
>> testing the documentation, which has been a work in progress for a while.
>> Tests for links, encoding, HTML, accessibility will be later added in
>> following PRs.
>>
>> We also define a new make target `test-docs` meant for local use and depends
>> on the docs.
>> This also adds the necessary configurations needed at Oracle.
>>
>> This patch includes a test `TestDocs` which serves to show developers how
>> they are meant to resolve the docs to test them, I want to include it
>> temporarily until better tests are added later.
>>
>> TIA
>
> Nizar Benalla has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add tidy as a dependency to `run-test-prebuilt-docs` and `docs` profiles
I think this is hard to solve fully generally, but I think we could add
something along these lines:
$(eval $(call AddTestDependency, docs_all, docs-jdk))
and have a function in MainSupport in something along these lines: (warning!
untested code)
define AddTestDependency
test-$(strip $1): $2
exploded-test-$(strip $1): $2
ifeq ($(filter $(TEST), $1)
TEST_DEPS += $2
endif
endef
I believe we have some old quirks and workarounds that we might be able to
change into using `AddTestDependency` as a more general solution, but that is
out of scope for this PR.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/21272#issuecomment-2407676559
PR Comment: https://git.openjdk.org/jdk/pull/21272#issuecomment-2407677863
