On Fri, 11 Oct 2024 12:54:42 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:
>> Please review this change that adds a new test root `docs` dedicated to >> testing the documentation, which has been a work in progress for a while. >> Tests for links, encoding, HTML, accessibility will be later added in >> following PRs. >> >> We also define a new make target `test-docs` meant for local use and depends >> on the docs. >> This also adds the necessary configurations needed at Oracle. >> >> This patch includes a test `TestDocs` which serves to show developers how >> they are meant to resolve the docs to test them, I want to include it >> temporarily until better tests are added later. >> >> TIA > > Nizar Benalla has updated the pull request incrementally with one additional > commit since the last revision: > > Add tidy as a dependency to `run-test-prebuilt-docs` and `docs` profiles Finally, we need to append `docs-jdk` to `TEST_DEPS` automatically in the cases we can determine that a test in the docs test root is requested. One way of doing this is to look for `test-docs_all` and `test-docs` in `$(MAKECMDGOALS)`, and look for `docs_all` in `$(TEST)`. Perhaps we can also extend that to look for `docs/...` in `$(TEST)`. That will end up in a bit of duplicated code, though. I'm thinking if there is a way to intercept this dependency much closer to the `SetupTarget` of `test` and `exploded-test`, which is where both `make test-docs_all` and `make test TEST=docs_all` end up. Currently, I'm a bit stuck here. I'll need to think a bit more on that. ------------- PR Comment: https://git.openjdk.org/jdk/pull/21272#issuecomment-2407663654
