On Wed, 11 Jun 2025 12:11:03 GMT, Magnus Ihse Bursie wrote:
>> SendaoYan has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - add ECHO=echo when call generated configure script
>> - Revert "8359181: Error messages generated by configure --
On Wed, 11 Jun 2025 08:56:25 GMT, SendaoYan wrote:
>> Hi all,
>>
>> The macro `HELP_PRINT_ADDITIONAL_HELP_AND_EXIT` is only called directly from
>> make/autoconf/configure. In JDK-8301197, most uses of `printf` was changed
>> to `echo`, but this explicit call wasn't updated to also set ` ECHO
On Wed, 11 Jun 2025 08:05:00 GMT, Erik Joelsson wrote:
> In JDK-8301197, we changed most uses of `printf` to `echo`, but this explicit
> call wasn't updated to also set `ECHO=echo`. Doing that fixes the issue.
@erikj79 Thanks your correction, I have revert the original commit and add `
ECHO=ec
On Wed, 11 Jun 2025 08:56:25 GMT, SendaoYan wrote:
>> Hi all,
>>
>> I have no idea why in make function `HELP_PRINT_ADDITIONAL_HELP_AND_EXIT`
>> can use `$PRINTF` variable but can not use `$ECHO` varibale. This PR use
>> `$PRINTF` instead of `$ECHO`.
>>
>> Change has been verified locally, al
> Hi all,
>
> I have no idea why in make function `HELP_PRINT_ADDITIONAL_HELP_AND_EXIT` can
> use `$PRINTF` variable but can not use `$ECHO` varibale. This PR use
> `$PRINTF` instead of `$ECHO`.
>
> Change has been verified locally, almost no risk.
SendaoYan has updated the pull request increm
On Wed, 11 Jun 2025 03:21:06 GMT, SendaoYan wrote:
> Hi all,
>
> I have no idea why in make function `HELP_PRINT_ADDITIONAL_HELP_AND_EXIT` can
> use `$PRINTF` variable but can not use `$ECHO` varibale. This PR use
> `$PRINTF` instead of `$ECHO`.
>
> Change has been verified locally, almost no
