On Wed, 11 Jun 2025 03:21:06 GMT, SendaoYan <s...@openjdk.org> wrote:
> Hi all, > > I have no idea why in make function `HELP_PRINT_ADDITIONAL_HELP_AND_EXIT` can > use `$PRINTF` variable but can not use `$ECHO` varibale. This PR use > `$PRINTF` instead of `$ECHO`. > > Change has been verified locally, almost no risk. This does not seem like the correct solution. This macro is only called directly from `make/autoconf/configure`, which is our wrapper script around the autoconf generated scripts. That wrapper expects this macro to be using `printf` so it sets `PRINTF=printf` on the command line: https://github.com/openjdk/jdk/blob/9586817cea3f1cad8a49d43e9106e25dafa04765/make/autoconf/configure#L369 In JDK-8301197, we changed most uses of `printf` to `echo`, but this explicit call wasn't updated to also set `ECHO=echo`. Doing that fixes the issue. ------------- PR Review: https://git.openjdk.org/jdk/pull/25740#pullrequestreview-2916080514
