On Wed, 11 Jun 2025 08:56:25 GMT, SendaoYan <s...@openjdk.org> wrote:
>> Hi all, >> >> I have no idea why in make function `HELP_PRINT_ADDITIONAL_HELP_AND_EXIT` >> can use `$PRINTF` variable but can not use `$ECHO` varibale. This PR use >> `$PRINTF` instead of `$ECHO`. >> >> Change has been verified locally, almost no risk. > > SendaoYan has updated the pull request incrementally with two additional > commits since the last revision: > > - add ECHO=echo when call generated configure script > - Revert "8359181: Error messages generated by configure --help after > 8301197" > > This reverts commit ffbd770f099030f72870c096eb9694d16cc2f34f. I think this looks good, but please give Magnus a chance to review as his opinion may differ and this is more of his area than mine. ------------- Marked as reviewed by erikj (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25740#pullrequestreview-2916251382
