On Wed, 11 Jun 2025 08:56:25 GMT, SendaoYan <s...@openjdk.org> wrote:
>> Hi all, >> >> The macro `HELP_PRINT_ADDITIONAL_HELP_AND_EXIT` is only called directly from >> make/autoconf/configure. In JDK-8301197, most uses of `printf` was changed >> to `echo`, but this explicit call wasn't updated to also set ` ECHO=echo`, >> this PR add ` ECHO=echo` when call this macro. >> >> Change has been verified locally, almost no risk. > > SendaoYan has updated the pull request incrementally with two additional > commits since the last revision: > > - add ECHO=echo when call generated configure script > - Revert "8359181: Error messages generated by configure --help after > 8301197" > > This reverts commit ffbd770f099030f72870c096eb9694d16cc2f34f. This looks like the proper solution. Thanks for finding and fixing. ------------- Marked as reviewed by ihse (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25740#pullrequestreview-2916878473
