Re: [jdk25] RFR: 8359181: Error messages generated by configure --help after 8301197

2025-06-15 Thread SendaoYan
On Fri, 13 Jun 2025 12:09:53 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit > [7b7136b4](https://github.com/openjdk/jdk/commit/7b7136b4eca15693cfcd46ae63d644efc8a88d2c) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being

Re: [jdk25] RFR: 8359181: Error messages generated by configure --help after 8301197

2025-06-13 Thread Magnus Ihse Bursie
On Fri, 13 Jun 2025 12:09:53 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit > [7b7136b4](https://github.com/openjdk/jdk/commit/7b7136b4eca15693cfcd46ae63d644efc8a88d2c) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being

[jdk25] RFR: 8359181: Error messages generated by configure --help after 8301197

2025-06-13 Thread SendaoYan
Hi all, This pull request contains a backport of commit [7b7136b4](https://github.com/openjdk/jdk/commit/7b7136b4eca15693cfcd46ae63d644efc8a88d2c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by SendaoYan on 12 Jun 2025 and was review

Re: RFR: 8359181: Error messages generated by configure --help after 8301197 [v2]

2025-06-12 Thread SendaoYan
On Wed, 11 Jun 2025 12:11:03 GMT, Magnus Ihse Bursie wrote: >> SendaoYan has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - add ECHO=echo when call generated configure script >> - Revert "8359181: Error messages generated by configure --

Re: RFR: 8359181: Error messages generated by configure --help after 8301197 [v2]

2025-06-11 Thread Magnus Ihse Bursie
On Wed, 11 Jun 2025 08:56:25 GMT, SendaoYan wrote: >> Hi all, >> >> The macro `HELP_PRINT_ADDITIONAL_HELP_AND_EXIT` is only called directly from >> make/autoconf/configure. In JDK-8301197, most uses of `printf` was changed >> to `echo`, but this explicit call wasn't updated to also set ` ECHO

Re: RFR: 8359181: Error messages generated by configure --help after 8301197 [v2]

2025-06-11 Thread SendaoYan
On Wed, 11 Jun 2025 08:05:00 GMT, Erik Joelsson wrote: > In JDK-8301197, we changed most uses of `printf` to `echo`, but this explicit > call wasn't updated to also set `ECHO=echo`. Doing that fixes the issue. @erikj79 Thanks your correction, I have revert the original commit and add ` ECHO=ec

Re: RFR: 8359181: Error messages generated by configure --help after 8301197 [v2]

2025-06-11 Thread Erik Joelsson
On Wed, 11 Jun 2025 08:56:25 GMT, SendaoYan wrote: >> Hi all, >> >> I have no idea why in make function `HELP_PRINT_ADDITIONAL_HELP_AND_EXIT` >> can use `$PRINTF` variable but can not use `$ECHO` varibale. This PR use >> `$PRINTF` instead of `$ECHO`. >> >> Change has been verified locally, al

Re: RFR: 8359181: Error messages generated by configure --help after 8301197 [v2]

2025-06-11 Thread SendaoYan
> Hi all, > > I have no idea why in make function `HELP_PRINT_ADDITIONAL_HELP_AND_EXIT` can > use `$PRINTF` variable but can not use `$ECHO` varibale. This PR use > `$PRINTF` instead of `$ECHO`. > > Change has been verified locally, almost no risk. SendaoYan has updated the pull request increm

Re: RFR: 8359181: Error messages generated by configure --help after 8301197

2025-06-11 Thread Erik Joelsson
On Wed, 11 Jun 2025 03:21:06 GMT, SendaoYan wrote: > Hi all, > > I have no idea why in make function `HELP_PRINT_ADDITIONAL_HELP_AND_EXIT` can > use `$PRINTF` variable but can not use `$ECHO` varibale. This PR use > `$PRINTF` instead of `$ECHO`. > > Change has been verified locally, almost no

RFR: 8359181: Error messages generated by configure --help after 8301197

2025-06-10 Thread SendaoYan
Hi all, I have no idea why in make function `HELP_PRINT_ADDITIONAL_HELP_AND_EXIT` can use `$PRINTF` variable but can not use `$ECHO` varibale. This PR use `$PRINTF` instead of `$ECHO`. Change has been verified locally, almost no risk. - Commit messages: - 8359181: Error messages