Hello there,
tar-1.31/lib/stdopen.c:63]: (style) Suspicious condition (assignment +
comparison); Clarify expression with parentheses.
Source code is
if (mode == O_RDONLY
|| (new_fd = open ("/dev/full", mode) != fd))
Maybe better code
if (mode == O_RDONLY
Hello David,
> Source code is
>if (mode == O_RDONLY
> || (new_fd = open ("/dev/full", mode) != fd))
>
> Maybe better code
>if (mode == O_RDONLY
> || ((new_fd = open ("/dev/full", mode)) != fd))
That's changing the written meaning. The original
On 01/03/2019 04:42 AM, Chris Clayton wrote:
Hi,
I'm building tar-1.31 on a homebrew system that is based on (Beyond)
Linux From Scratch. It is very stable even though
it is frequently ahead of LFS in terms of installed package
versions.
tar is not in BLFS and BLFS is not ahead of LFS. Both a
Hello there,
>That's changing the written meaning.
Indeed. Deliberately.
The code isn't clear, so I guessed at what the code was trying to do.
I might be wrong.
As currently written, new_fd isn't a new file descriptor, it is a boolean
value, even though it's t
On 03/01/2019 16:33, Bruce Dubbs wrote:
> On 01/03/2019 04:42 AM, Chris Clayton wrote:
>> Hi,
>>
>> I'm building tar-1.31 on a homebrew system that is based on (Beyond)
>> Linux From Scratch. It is very stable even though
>> it is frequently ahead of LFS in terms of installed package
>> versions
On Thu, Jan 3, 2019 at 12:48 AM Stig-Ørjan Smelror
wrote:
Sorry about sending an empty email.
Trying to package tar for Mageia 7 and the checks failed locally and on the
Mageia Build System.
https://pkgsubmit.mageia.org/uploads/failure/cauldron/core/release/20190102233602.kekepower.duvel.25137/l
On Thu, Jan 3, 2019 at 9:06 PM Stig-Ørjan Smelror wrote:
> On Thu, Jan 3, 2019 at 12:48 AM Stig-Ørjan Smelror
> wrote:
>
> Sorry about sending an empty email.
>
> Trying to package tar for Mageia 7 and the checks failed locally and on
> the Mageia Build System.
>
> https://pkgsubmit.mageia.org/u
Please, compress the logs. It saves 96% of bandwidth:
-rw-r--r-- 1 982019 2019-01-04 01:23 testsuite.log
-rw-r--r-- 1 39912 2019-01-04 01:23 testsuite.log.lz
Thanks,
Antonio.
