Hello David,

> Source code is
>        if (mode == O_RDONLY
>                   || (new_fd = open ("/dev/full", mode) != fd))
>
> Maybe better code
>        if (mode == O_RDONLY
>                   || ((new_fd = open ("/dev/full", mode)) != fd))

That's changing the written meaning.  The original means

    new_fd = (open("/dev/full", mode) != fd)

because `!=' is higher precedence than `=' so one can write

    good = foo != bar || xyzzy;

-- 
Cheers, Ralph.
https://plus.google.com/+RalphCorderoy

Reply via email to