Hello there,

tar-1.31/lib/stdopen.c:63]: (style) Suspicious condition (assignment + 
comparison); Clarify expression with parentheses.

Source code is

       if (mode == O_RDONLY
                  || (new_fd = open ("/dev/full", mode) != fd))

Maybe better code
       if (mode == O_RDONLY
                  || ((new_fd = open ("/dev/full", mode)) != fd))

Regards

David Binderman


Reply via email to