Re: [PATCH] test-raise: use _Noreturn

On 10/06/2011 01:14 AM, Bruno Haible wrote: Eric Blake wrote: Shouldn't that imply that gnulib's replacement should be taught to guarantee that exit() is declared noreturn even if the system's header is missing that information? Yes, this would be a good idea. Alternatively, can't we use _e

new module 'modff'

Similarly for the 'modff' function. Here's the main piece of code: = lib/modff.c = /* Get signed integer and fractional parts of a floating-point number. Copyright (C) 2011 Free Software Foundation, Inc. This program is free so

Re: a saner bootstrap script

Hi Jim, On 5 Oct 2011, at 14:08, Gary V. Vaughan wrote: > On 5 Oct 2011, at 00:16, Jim Meyering wrote: >> Gary V. Vaughan wrote: >>> I haven't had time yet to pick up the coreutils bootstrap.conf update, but >>> I'll probably be able to get to it by the end of the week. If you're in a >>> hurry,

Re: Slight simplification to README-release

Hi Reuben, > Anything that reasonably reduces the number of manual steps here has > to be a good thing. I combine two sets of make targets: > ... > +make check syntax-check distcheck But that's probably not how people actually do it. In a big package, "make check" will take, say, 10 minutes

Slight simplification to README-release

Anything that reasonably reduces the number of manual steps here has to be a good thing. I combine two sets of make targets: diff --git a/ChangeLog b/ChangeLog index 76607bb..1410875 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2011-10-06 Reuben Thomas + + Simplify README-relea

Re: [PATCH] test-raise: use _Noreturn

Eric Blake wrote: > Shouldn't that imply that gnulib's replacement should be > taught to guarantee that exit() is declared noreturn even if the > system's header is missing that information? Yes, this would be a good idea. > Or, avoiding a change to gnulib's , why not use this? > > static _Nore

new module 'fmodf'

> 2011-10-05 Bruno Haible > > New module 'fabsf'. > ... Likewise for 'fmodf'. Here's the nontrivial part of the commit: = lib/fmodf.c = /* Remainder. Copyright (C) 2011 Free Software Foundation, Inc. This program is

Re: [PATCH] test-raise: use _Noreturn

On 10/05/2011 04:46 PM, Eric Blake wrote: -static void +static _Noreturn void handler (int sig) { exit (0); While this patch removes a gcc warning of type "function might be possible candidate for attribute 'noreturn'" on some platform, it introduces a gcc warning of type "'noreturn' function

Re: [PATCH] test-raise: use _Noreturn

On 10/05/2011 04:34 PM, Bruno Haible wrote: Hi, Bernhard Voelker wrote: diff --git a/tests/test-raise.c b/tests/test-raise.c index 38c2353..6129f9a 100644 --- a/tests/test-raise.c +++ b/tests/test-raise.c @@ -25,7 +25,7 @@ SIGNATURE_CHECK (raise, int, (int)); #include "macros.h" -static vo

Re: [PATCH] test-raise: use _Noreturn

Hi, Bernhard Voelker wrote: > diff --git a/tests/test-raise.c b/tests/test-raise.c > index 38c2353..6129f9a 100644 > --- a/tests/test-raise.c > +++ b/tests/test-raise.c > @@ -25,7 +25,7 @@ SIGNATURE_CHECK (raise, int, (int)); > > #include "macros.h" > > -static void > +static _Noreturn void >

new module 'fabsf'

For 22 functions that ought to take 'float' arguments and return a 'float' result, MSVC 9 only provides a macro definition. This is not POSIX compliant, see POSIX:2008 / System Interfaces / General Information / Use and Implementation of Interfaces

[PATCH] test-raise: use _Noreturn

From f50501ce455ba0b854fd3e20f22a5779c2c00a52 Mon Sep 17 00:00:00 2001 From: Bernhard Voelker Date: Wed, 5 Oct 2011 23:45:15 +0200 Subject: [PATCH] test-raise: use _Noreturn * tests/test-raise.c (handler): use _Noreturn. Otherwise, coreutils' "make check" would fail with this: cc1: warnings be

Questionable inline usage in gettext.h

Hi folks, I'm using Gnulib's gettext module for i18n, and I've noticed some questionable use of "inline" in lib/gettext.h. For reference, I'm quoting one function from that header file (comments follow): > #define pgettext_expr(Msgctxt, Msgid) \ > dcpgettext_expr (NULL, Msgctxt, Msgid, LC_MESS

Re: [PATCH] file-has-acl: revert unintended change in behavior of ls -L

On Wednesday 05 October 2011 17:31:07 Jim Meyering wrote: > Bruno Haible wrote: > > Jim Meyering wrote: > >> I propose to push Kamil's fix (mainly to have a record of it, > >> in case we need it later), but then to immediately revert it > >> along with the file-has-acl.c change that started this. >

Re: MacOS X 10.7 and gettext

Hi Bruno, On 5 Oct 2011, at 18:54, Bruno Haible wrote: > Gary V. Vaughan wrote: >>> the "normal" way to install packages, for people who >>> are not used to fiddling with source code, is through MacPorts, >>> and MacPorts carries gettext 0.18.1.1 with the fix. >> >> Actually MacPorts is not that

Re: [PATCH] file-has-acl: revert unintended change in behavior of ls -L

Bruno Haible wrote: > Jim Meyering wrote: >> I propose to push Kamil's fix (mainly to have a record of it, >> in case we need it later), but then to immediately revert it >> along with the file-has-acl.c change that started this. >> That seems to be the right thing to do, going forward, >> since t

Re: [PATCH] file-has-acl: revert unintended change in behavior of ls -L

Jim Meyering wrote: > I propose to push Kamil's fix (mainly to have a record of it, > in case we need it later), but then to immediately revert it > along with the file-has-acl.c change that started this. > That seems to be the right thing to do, going forward, > since the kernel folks have recentl

Re: MacOS X 10.7 and gettext

On 10/05/2011 06:54 AM, Bruno Haible wrote: Interestingly, while MacOS X 10.7 was released on 2011-07-20, the stpncpy glitch was - fixed in MacPorts on 2010-08-13 (these people must have access to prereleases of MacOS X or its libc), This was fixed in MacPorts by Jeremy Huddleston, who

Re: [PATCH] file-has-acl: revert unintended change in behavior of ls -L

Bruno Haible wrote: > Kamil Dudka wrote: >> > a) A non-symlink, non-directory. Here acl_extended_file_nofollow and >> > acl_extended_file are equivalent. >> >> If I understand this, you expect non-directories cannot be mount points, thus >> the call cannot trigger the mount, right? > > That

Re: Relocation patch for cygwin

Charles Wilson wrote: > > Only it's a pity that you gave me the advice to use Cygwin's > > /proc/self/maps, > > which I did [2], and now we discover that it is much slower than the Win32 > > API calls that I had originally. > ... > The problem is, it can really cause issues for "the rest of cygwin

Re: MacOS X 10.7 and gettext

Gary V. Vaughan wrote: > > the "normal" way to install packages, for people who > > are not used to fiddling with source code, is through MacPorts, > > and MacPorts carries gettext 0.18.1.1 with the fix. > > Actually MacPorts is not that widely used anymore, most people have long > since migrated

Re: a saner bootstrap script

Hi Jim, On 5 Oct 2011, at 00:16, Jim Meyering wrote: > Gary V. Vaughan wrote: >> On 4 Oct 2011, at 17:09, Jim Meyering wrote: >>> Do you feel like rebasing it? >> >> Sure, although it will take me a few days to find the time - is that because >> you're planning to adopt my bootstrap script into c