On 10/05/2011 04:34 PM, Bruno Haible wrote:
Hi,

Bernhard Voelker wrote:
diff --git a/tests/test-raise.c b/tests/test-raise.c
index 38c2353..6129f9a 100644
--- a/tests/test-raise.c
+++ b/tests/test-raise.c
@@ -25,7 +25,7 @@ SIGNATURE_CHECK (raise, int, (int));

   #include "macros.h"

-static void
+static _Noreturn void
   handler (int sig)
   {
     exit (0);

While this patch removes a gcc warning of type
"function might be possible candidate for attribute 'noreturn'"
on some platform, it introduces a gcc warning of type
"'noreturn' function does return" on other platforms (namely
on those where<stdlib.h>  does not declare exit() as a non-
returning function).

Shouldn't that imply that gnulib's <stdlib.h> replacement should be taught to guarantee that exit() is declared noreturn even if the system's header is missing that information?

--
Eric Blake   ebl...@redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Reply via email to