Re: coreutils-6.4 released (stable)

2006-11-10 Thread Paul Eggert
Matthew Woehlke <[EMAIL PROTECTED]> writes: > I'm quite certain I remember it bombing (there are 'unsigned long > long's sprinkled in there without it). But I am guessing the problem > is just that CVS is a little off of coreutils-6.4, which is what I was > trying to patch. I think the main proble

FYI: tiny change in fts.c

2006-11-10 Thread Jim Meyering
I've just checked in this change: * lib/fts.c [FTS_DEBUG]: Don't try to print a pointer via %s. Index: lib/fts.c === RCS file: /cvsroot/gnulib/gnulib/lib/fts.c,v retrieving revision 1.25 diff -u -r1.25 fts.c --- lib/fts.c 8

Re: [bug-gnulib] Re: gnulib-tool --with-tests --test

2006-11-10 Thread Bruno Haible
Ralf Wildenhues wrote: > The patch below should some of the reported issues. OK to apply? Thanks for this patch. Everything except the first hunk (gl_source_base) is fine. Please apply. About the gl_source_base of the tests directory: The idea is that the tests directory has its sources separate

Announce: vc-dwim-0.2.2, includes new, ChangeLog-writing tool: vc-chlog

2006-11-10 Thread Jim Meyering
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I've just made a new release of vc-dwim: Here are the files: http://et.redhat.com/~meyering/vc-dwim-0.2.2.tar.gz http://et.redhat.com/~meyering/vc-dwim-0.2.2.tar.gz.sig You can check out the sources like this: hg clone http://hg.et.redhat.com/h

Re: gnulib-tool --with-tests --test

2006-11-10 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Thu, Nov 09, 2006 at 12:12:27AM CET: > It would be nice if > gnulib-tool --with-tests --test > > succeeded out of the box, including actually running the tests. The patch below should some of the reported issues. OK to apply? FWIW, I still don't understand the neces

Re: yet another hello pretest

2006-11-10 Thread Bruno Haible
Jim, > I don't see > how you could be objecting to such an addition to hello's system.h. It's up to Karl to decide what he puts into hello's system.h. I only mentioned that these definitions can _in_general_ lead to "unused variable" warnings. Bruno

Re: yet another hello pretest

2006-11-10 Thread Jim Meyering
Bruno Haible <[EMAIL PROTECTED]> wrote: > Jim Meyering wrote: >> Better still, add this in system.h: >> >> #if ! ENABLE_NLS >> # undef textdomain >> # define textdomain(Domainname) /* empty */ >> # undef bindtextdomain >> # define bindtextdomain(Domainname, Dirname) /* empty */

Re: yet another hello pretest

2006-11-10 Thread Bruno Haible
Jim Meyering wrote: > Better still, add this in system.h: > > #if ! ENABLE_NLS > # undef textdomain > # define textdomain(Domainname) /* empty */ > # undef bindtextdomain > # define bindtextdomain(Domainname, Dirname) /* empty */ > #endif If you do this, you'll get "unused

Re: missing dependencies [Re: inline.m4: use compiler, not cpp

2006-11-10 Thread Bruno Haible
Jim Meyering wrote: > >> but there > >> is a bug (haven't investigated at all yet) whereby most of the generated > >> dependencies (lib/.deps/*.Po files) are not included into the Makefile. I agree with Ralf that it's most likely tied to the issue I reported two days ago: In summary (thanks Ralf f

Re: stdint_.h incorrectly assumes unsigned of 'int64_t'

2006-11-10 Thread Matthew Woehlke
Paul Eggert wrote: Matthew Woehlke <[EMAIL PROTECTED]> writes: ...which I assume those who have been following my NSK woes will immediately spot the flaw in? :-) Thanks, I installed this patch into gnulib: [patch snipped] That looks good, thanks! (This was stdint_.h from coreutils-6.4, IIR

Re: yet another hello pretest

2006-11-10 Thread Jim Meyering
Bruno Haible <[EMAIL PROTECTED]> wrote: > Paul Eggert wrote: >> 2. The "#if ENABLE_NLS" isn't needed, since gettext.h does the right >> thing anyway. > >> -#if ENABLE_NLS >>/* Set the text message domain. */ >>bindtextdomain (PACKAGE, LOCALEDIR); >>textdomain (PACKAGE); >> -#endif

missing dependencies [Re: inline.m4: use compiler, not cpp

2006-11-10 Thread Jim Meyering
Ralf Wildenhues <[EMAIL PROTECTED]> wrote: > Hello Jim, > > * Jim Meyering wrote on Fri, Nov 10, 2006 at 03:53:42PM CET: >> >> I did not run "make clean", but did ensure that config.h was updated. >> That alone should have caused all "old" .o files to be rebuilt, but there >> is a bug (haven't inv

Re: proposed patch to allocsa, vasnprintf for Tandem NSK (OSS)

2006-11-10 Thread Matthew Woehlke
Paul Eggert wrote: Matthew Woehlke writes: Actually, while trying to compile m4, it looks like this may indeed be a problem. OSS's sys/stat.h bombs if int64_t is not defined, Can you please explain exactly why this problem occurs? gnulib's stdint.h replacement should include the relevant syste

Re: [bug-gnulib] yet another hello pretest

2006-11-10 Thread Bruno Haible
Paul Eggert wrote: > 2. The "#if ENABLE_NLS" isn't needed, since gettext.h does the right > thing anyway. > -#if ENABLE_NLS >/* Set the text message domain. */ >bindtextdomain (PACKAGE, LOCALEDIR); >textdomain (PACKAGE); > -#endif But with this, configuring with "./configure --d

Re: inline.m4: use compiler, not cpp

2006-11-10 Thread Ralf Wildenhues
Hello Jim, * Jim Meyering wrote on Fri, Nov 10, 2006 at 03:53:42PM CET: > > I did not run "make clean", but did ensure that config.h was updated. > That alone should have caused all "old" .o files to be rebuilt, but there > is a bug (haven't investigated at all yet) whereby most of the generated

Re: inline.m4: use compiler, not cpp

2006-11-10 Thread Jim Meyering
Bruno Haible <[EMAIL PROTECTED]> wrote: > Jim Meyering wrote: >> 2006-11-10 Jim Meyering <[EMAIL PROTECTED]> >> >> * m4/inline.m4 (gl_INLINE): Check with the compiler, not cpp, >> so that relevant options in CFLAGS (like -O, -fno-inline) are >> taken into account. > > Thanks again

Re: [bug-gnulib] lib/gettext.h breaks --enable-gcc-warnings

2006-11-10 Thread Bruno Haible
Paul Eggert wrote: > 2006-11-09  Paul Eggert  <[EMAIL PROTECTED]> > > * lib/gettext.h (dgettext, dcgettext, ngettext) [! ENABLE_NLS]: > (dngettext, dcngettext, bindtextdomain) [! ENABLE_NLS]: > (bind_textdomain_codeset) [! ENABLE_NLS]: > Evaluate all the arguments.

Re: [bug-gnulib] inline.m4: use compiler, not cpp

2006-11-10 Thread Bruno Haible
Jim Meyering wrote: > 2006-11-10 Jim Meyering <[EMAIL PROTECTED]> > > * m4/inline.m4 (gl_INLINE): Check with the compiler, not cpp, > so that relevant options in CFLAGS (like -O, -fno-inline) are > taken into account. Thanks again! I applied this patch, with added comments, an

Re: [bug-gnulib] coreutils build failure due to missing gl_INLINE dependency

2006-11-10 Thread Bruno Haible
Jim Meyering wrote: > Since two other modules (oset and list) also include m4/inline.m4 > without a provision to use gl_INLINE, it's clear that it's worthwhile > to make a module out of this inline.m4 file, so I did that. Thanks!

inline.m4: use compiler, not cpp

2006-11-10 Thread Jim Meyering
The gl_INLINE macro was failing to define HAVE_INLINE, and that led to link errors when building coreutils with CFLAGS=-O. gl_INLINE used cpp and $CPPFLAGS, and since the latter doesn't include $CFLAGS, it missed the critical -O option. Without -O, gcc *does* define __NO_INLINE__, so HAVE_INLINE w

coreutils build failure due to missing gl_INLINE dependency

2006-11-10 Thread Jim Meyering
I tried to build coreutils using the very latest from gnulib and got link failures due to missing xcharalloc, used by e.g., quotearg.o. I tracked it back to the lack of a HAVE_INLINE definition in config.h, which in turn was due to a defect in the gnulib xalloc module. It did not arrange to use th

Re: [bug-gnulib] use of __gen_tempname

2006-11-10 Thread Bruno Haible
Eric, > > Please apply. I'm sorry that I missed this mail. Something must be wrong with my mailbox. Bruno