I tried to build coreutils using the very latest from gnulib and got
link failures due to missing xcharalloc, used by e.g., quotearg.o.
I tracked it back to the lack of a HAVE_INLINE definition in config.h,
which in turn was due to a defect in the gnulib xalloc module. It did
not arrange to use the gl_INLINE macro that provides HAVE_INLINE.
It *did* list m4/inline.m4 as one of its "Files:", but didn't do anything
else.
Since two other modules (oset and list) also include m4/inline.m4
without a provision to use gl_INLINE, it's clear that it's worthwhile
to make a module out of this inline.m4 file, so I did that.
But the following patch didn't solve the coreutils build problem, due
to a problem with inline.m4 itself. That's the topic of the next message.
I've checked in these changes:
* modules/inline: New file/module.
* modules/xalloc (Files): Remove m4/inline.m4.
(Depends-on): Add inline, instead.
* modules/oset: Likewise.
* modules/list: Likewise.
Index: modules/inline
===================================================================
RCS file: modules/inline
diff -N modules/inline
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ modules/inline 10 Nov 2006 09:55:44 -0000
@@ -0,0 +1,20 @@
+Description:
+Test for the 'inline' keyword or equivalent.
+
+Files:
+m4/inline.m4
+
+Depends-on:
+
+configure.ac:
+gl_INLINE
+
+Makefile.am:
+
+Include:
+
+License:
+GPL
+
+Maintainer:
+all
Index: modules/xalloc
===================================================================
RCS file: /sources/gnulib/gnulib/modules/xalloc,v
retrieving revision 1.20
diff -u -r1.20 xalloc
--- modules/xalloc 8 Nov 2006 00:22:30 -0000 1.20
+++ modules/xalloc 10 Nov 2006 09:55:44 -0000
@@ -5,9 +5,9 @@
lib/xalloc.h
lib/xmalloc.c
m4/xalloc.m4
-m4/inline.m4
Depends-on:
+inline
xalloc-die
configure.ac:
Index: modules/oset
===================================================================
RCS file: /sources/gnulib/gnulib/modules/oset,v
retrieving revision 1.2
diff -u -r1.2 oset
--- modules/oset 7 Nov 2006 13:46:03 -0000 1.2
+++ modules/oset 10 Nov 2006 09:55:44 -0000
@@ -5,9 +5,9 @@
lib/gl_oset.h
lib/gl_oset.c
m4/gl_list.m4
-m4/inline.m4
Depends-on:
+inline
stdbool
configure.ac:
@@ -24,4 +24,3 @@
Maintainer:
Bruno Haible
-
Index: modules/list
===================================================================
RCS file: /sources/gnulib/gnulib/modules/list,v
retrieving revision 1.2
diff -u -r1.2 list
--- modules/list 7 Nov 2006 13:46:03 -0000 1.2
+++ modules/list 10 Nov 2006 09:55:44 -0000
@@ -5,9 +5,9 @@
lib/gl_list.h
lib/gl_list.c
m4/gl_list.m4
-m4/inline.m4
Depends-on:
+inline
stdbool
configure.ac:
@@ -24,4 +24,3 @@
Maintainer:
Bruno Haible
-
