Ralf Wildenhues wrote:
> The patch below should some of the reported issues.  OK to apply?

Thanks for this patch. Everything except the first hunk (gl_source_base)
is fine. Please apply.

About the gl_source_base of the tests directory: The idea is that
the tests directory has its sources separate from the main directory,
so that when a dependency (providing a .h file, for example) is missing
from a library module but present in the tests module, we still an
error while compiling the library. Otherwise testing with --with-tests
might fail to uncover dependency bugs that --without-tests would uncover;
this is obviously undesirable. - Can you find another fix for the problem?

> FWIW, I still don't understand the necessity of a separate configure
> script in the gltests/ subdirectory at all.  Is that just for testing
> purposes?

Like above: If the tests module requires an m4 macro invocation that the
library module would also need but lacks, --with-tests would not uncover
the bug.

Bruno


Reply via email to