Jpeg DPG support for GC IP v11_5_0
Signed-off-by: Saleemkhan Jamadar
Reviewed-by: Leo Liu
Reviewed-by: Veerabadhran Gopalakrishnan
---
drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c | 44
drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.h | 36 +++
drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c | 312
add ucode id and cmd buffer for jpeg psp sram programming
and Jpeg DPG support.
Signed-off-by: Saleemkhan Jamadar
Reviewed-by: Leo Liu
Reviewed-by: Veerabadhran Gopalakrishnan
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 3 +++
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 2 ++
drivers/gpu
v1 - update the fw header for each vcn instance (Veera)
VCN1 has different FW binary in VCN v4_0_6.
Add changes to load the VCN1 fw binary
Signed-off-by: Saleemkhan Jamadar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 38 -
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 2
Hi,
Looks good to me !
Acked-by: Saleemkhan Jamadar
-Original Message-
From: amd-gfx On Behalf Of Sonny Jiang
Sent: Monday, June 24, 2024 11:28 PM
To:amd-gfx@lists.freedesktop.org
Cc: Jiang, Sonny
Subject: [PATCH] drm/amdgpu/jpeg5: Add support for DPG mode
From: Sonny Jiang
Add
DPG mode is enabled for vcn and jpeg on VCN v4_0_5
Signed-off-by: Saleemkhan Jamadar
---
drivers/gpu/drm/amd/amdgpu/soc21.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/soc21.c
b/drivers/gpu/drm/amd/amdgpu/soc21.c
index 6cc86d13f32a
Hi Tim,
Looks good to me.
Reviewed-by: Saleemkhan Jamadar
Thanks!
--
Saleem
On 23/07/24 16:37, Tim Huang wrote:
To prevent below probe failure, add a check for models with VCN
IP v4.0.6 where VCN1 may be harvested.
v2:
Apply the same check to VCN IP v4.0 and v5.0.
[ 54.070117] RIP
Added support to capture unsch fw debug logs in debugfs.
To enable set amdgpu_umschfw_log =1 in boot args.
v1 - reame varibale to umsch_mm_fwlog (Veera)
Signed-off-by: Saleemkhan Jamadar
Reviewed-by: Veerabadhran Gopalakrishnan
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 +
drivers
Doorbell is configured during start of each playback.
v1 - add comment for the doorbell programming change (Veera)
Signed-off-by: Saleemkhan Jamadar
Acked-by: Leo Liu
---
drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git
Initialize number of jpeg ring for gc ip 11_5_0
Signed-off-by: Saleemkhan Jamadar
Reviewed-by: Veerabadhran Gopalakrishnan
---
drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c
b/drivers/gpu/drm/amd/amdgpu
Register CC_UVD_HARVESTING is obsolete for JPEG 3.1.2
Signed-off-by: Saleemkhan Jamadar
Reviewed-by: Veerabadhran Gopalakrishnan
---
drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c
b/drivers/gpu/drm/amd/amdgpu
add session context buffer to decoder ring test.
v2 - put the buffer at the end of the IB (Christian)
Signed-off-by: Saleemkhan Jamadar
Acked-by: Leo Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 30 ++---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 3 +++
2 files
add session context buffer to decoder ring test fro vcn v1 to v3.
Signed-off-by: Saleemkhan Jamadar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 43 ++---
1 file changed, 38 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
b/drivers/gpu
Enable VCN Dynamic Power Gating control for GC IP v11.0.4.
Signed-off-by: Saleemkhan Jamadar
Reviewed-by: Veerabadhran Gopalakrishnan
---
drivers/gpu/drm/amd/amdgpu/soc21.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/soc21.c
b/drivers/gpu/drm/amd/amdgpu
add session context buffer to decoder ring test.
v3 - indent and v2 changes correction. (Christian)
v2 - put the buffer at the end of the IB (Christian)
Signed-off-by: Saleemkhan Jamadar
Acked-by: Leo Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 13 +++--
drivers/gpu/drm/amd
add session context buffer to decoder ring test.
v4 - data type, explain change of ib size change (Christian)
v3 - indent and v2 changes correction. (Christian)
v2 - put the buffer at the end of the IB (Christian)
Signed-off-by: Saleemkhan Jamadar
Acked-by: Leo Liu
---
drivers/gpu/drm/amd
Hi Christian,
response inline [Saleem].
Regards,
Saleem
On 07/07/23 12:35, Christian König wrote:
Am 06.07.23 um 16:47 schrieb Saleemkhan Jamadar:
add session context buffer to decoder ring test.
v4 - data type, explain change of ib size change (Christian)
v3 - indent and v2 changes
add session context buffer to decoder ring test.
v5 - clear the session ct buffer (Christian)
v4 - data type, explain change of ib size change (Christian)
v3 - indent and v2 changes correction. (Christian)
v2 - put the buffer at the end of the IB (Christian)
Signed-off-by: Saleemkhan Jamadar
add session context buffer to decoder ring test for vcn v1 to v3.
v2 - add the buffer into IB (Leo liu)
Signed-off-by: Saleemkhan Jamadar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
b
add session context buffer to decoder ring test fro vcn v1 to v3.
v3 - correct the cmd for sesssion ctx buf
v2 - add the buffer into IB (Leo liu)
Signed-off-by: Saleemkhan Jamadar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a
add session context buffer to decoder ring test.
v5 - clear the session ct buffer (Christian)
v4 - data type, explain change of ib size change (Christian)
v3 - indent and v2 changes correction. (Christian)
v2 - put the buffer at the end of the IB (Christian)
Signed-off-by: Saleemkhan Jamadar
add session context buffer to decoder ring test for vcn v1 to v3.
v3 - correct the cmd for sesssion ctx buf
v2 - add the buffer into IB (Leo liu)
Signed-off-by: Saleemkhan Jamadar
Reviewed-by: Leo Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 25 ++---
1 file changed
VCN FW depncencies revert it to unblock others
This reverts commit d0edfbe8bc2d18ede8f805c6eb71c63e0b40c1da.
Signed-off-by: Saleemkhan Jamadar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 25 +++--
1 file changed, 7 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu
VCN FW depncencies revert it to unblock others
This reverts commit ce085b8068e1071b0068f9a5dee78c97ef587022.
Signed-off-by: Saleemkhan Jamadar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 13 ++---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 5 +
2 files changed, 3 insertions
add session context buffer to decoder ring test for vcn v1 to v3.
Signed-off-by: Saleemkhan Jamadar
Reviewed-by: Veerabadhran Gopalakrishnan
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 33 ++---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 5 +++-
2 files changed, 28
v1 - remove cs parse code (Christian)
On VCN v4_0_6 AV1 is supported on both the instances.
Remove cs IB parse code since explict handling of AV1 schedule is
not required.
Signed-off-by: Saleemkhan Jamadar
---
drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c | 165
1 file
Hi Shashank,
Replied inline [Saleem]
Regards,
Salem
On 02/01/25 18:58, Sharma, Shashank wrote:
+ (amd-gfx)
On 01/01/2025 07:03, Saleemkhan Jamadar wrote:
#resending patch
From 79cd62f882197505dbf9c489ead2b0bcab98209f Mon Sep 17 00:00:00 2001
From: Saleemkhan Jamadar
Date: Wed, 18 Dec
Made changes to the doorbell mapping func more generic,
by taking parameters that vary based on IPs and/or usecase
into db_info structure.
Signed-off-by: Saleemkhan Jamadar
]
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 27 +++
.../gpu/drm/amd/include/amdgpu_userqueue.h
VCN and VPE have different offset range, update the doorbell
offset range repsectively.
Doorbell size for VCN and VPE is 32bit.
Signed-off-by: Saleemkhan Jamadar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/gpu
This structure basically used to the populate the doorbell
information that is required to be mapped.
Signed-off-by: Saleemkhan Jamadar
---
drivers/gpu/drm/amd/include/amdgpu_userqueue.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/amd/include/amdgpu_userqueue.h
b
different.
How:
Introduce another structure to locally populate the varying parameters.
Modify the the door mapping api to use these structure parameters to
get db_size and offset range based on the queue type.
Regards,
Saleem
Saleemkhan Jamadar (3):
drm/amdgpu: add stucture to populate dorrbell
TMZ support is enabled for vcn on GC IP 11_5_0
Signed-off-by: Saleemkhan Jamadar
Reviewed-by: Leo Liu
---
drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c
b/drivers/gpu/drm/amd/amdgpu
current test is more intrusive for user queue test
Signed-off-by: Saleemkhan Jamadar
Suggested-by: Christian Koenig
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_umsch_mm.c | 459 +--
1 file changed, 1 insertion(+), 458 deletions(-)
diff --git a/drivers
There is a comilation error after merging:
commit id : 7de7cafeb474d1454b1744c9a51eac4c8a6ed29a
Signed-off-by: Saleemkhan Jamadar
Reviewed-by: Arvind Yadav
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm
)
Signed-off-by: Saleemkhan Jamadar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 27 +++
.../gpu/drm/amd/include/amdgpu_userqueue.h| 12 +
2 files changed, 28 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c
b/drivers
VCN and VPE have different offset range, update the doorbell
offset range repsectively.
Doorbell size for VCN and VPE is 32bit .
v1 : add gfx switch case and fix checkpatch warnings (Shashank)
Signed-off-by: Saleemkhan Jamadar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 24
different.
How:
Introduce another structure to locally populate the varying parameters.
Modify the the door mapping api to use these structure parameters to get
db_size and offset range based on the queue type.
Regards,
Saleem
Saleemkhan Jamadar (2):
drm/amdgpu: map doorbell for the requested u
Hi,
Changes looks good to me.
Series is Reviewed-by: Saleemkhan Jamadar
Regards,
Saleem
[AMD Official Use Only - AMD Internal Distribution Only]
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Thursday, February 13, 2025 3:18 AM
To: amd-gfx@lists.freedesktop.org
Hi Alex,
Change looks good to me.
Reviewed-by: Saleemkhan Jamadar
Regards,
Saleem
On 2/21/2025 8:20 PM, Alex Deucher wrote:
Use the IP type to look up the userq functions rather
than hardcoding it.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 12
v1 - DRM_ERROR to dev_err (Mario)
Update message to identifiy the vblank initialization fail case
Signed-off-by: Saleemkhan Jamadar
Reviewed-by: Rodrigo Siqueira
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a
Hi Mario,
Made the suggested change.
Regards,
Saleem
--2.34.1
Content-Type: text/plain; charset=UTF-8; format=fixed
Content-Transfer-Encoding: 8bit
v1 - DRM_ERROR to drm_err (Mario)
Update message to identifiy the vblank initialization fail case
Signed-off-by: Saleemkhan Jamadar
40 matches
Mail list logo
