[PATCH 10/24] drm/amd/display: Add SPL namespace

2025-02-21 Thread Zaeem Mohamed
From: Navid Assadian [Why] In order to avoid component conflicts, spl namespace is needed. [How] Adding SPL namespace to the public API os that each user of SPL can have their own namespace. Signed-off-by: Navid Assadian Reviewed-by: Samson Tam --- drivers/gpu/drm/amd/display/dc/sspl/dc_spl.

[PATCH 13/24] drm/amd/display: Refactor DCN4x and related code

2025-02-21 Thread Zaeem Mohamed
From: "Patel, Swapnil" [why & how] Refactor existing code related to DCN4x for better code sharing with other modules Reviewed-by: Charlene Liu Signed-off-by: Swapnil Patel Signed-off-by: Zaeem Mohamed --- .../amd/display/dc/dccg/dcn20/dcn20_dccg.h| 94 .../amd/d

[PATCH 11/24] drm/amd/display: replace dio encoder access

2025-02-21 Thread Zaeem Mohamed
mar Somasundaram Signed-off-by: Peichen Huang Signed-off-by: Zaeem Mohamed --- .../gpu/drm/amd/display/dc/core/dc_resource.c | 2 +- .../amd/display/dc/hwss/dce110/dce110_hwseq.c | 5 +- .../amd/display/dc/hwss/dcn20/dcn20_hwseq.c | 5 +- .../amd/display/dc/hwss/dcn401/dcn401_hwseq.c |

[PATCH 12/24] drm/amd/display: add a quirk to enable eDP0 on DP1

2025-02-21 Thread Zaeem Mohamed
functions to set quirk entries, retrieve_dmi_info can set quirks according to quirk entries Cc: Mario Limonciello Cc: sta...@vger.kernel.org Reviewed-by: Mario Limonciello Reviewed-by: Nicholas Kazlauskas Signed-off-by: Yilin Chen Signed-off-by: Zaeem Mohamed --- .../gpu/drm/amd/display

[PATCH 02/24] drm/amd/display: Disable PSR-SU on eDP panels

2025-02-21 Thread Zaeem Mohamed
From: Tom Chung [Why] PSR-SU may cause some glitching randomly on several panels. [How] Temporarily disable the PSR-SU and fallback to PSR1 for all eDP panels. Link: https://gitlab.freedesktop.org/drm/amd/-/issues/3388 Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Reviewe

[PATCH 03/24] drm/amd/display: update incorrect cursor buffer size

2025-02-21 Thread Zaeem Mohamed
From: Alex Hung [WHAT & HOW] Fix the incorrect value of the cursor_buffer_size. Signed-off-by: Alex Hung Reviewed-by: Zaeem Mohamed --- .../amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4.c| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH 11/24] drm/amd/display: replace dio encoder access

2025-02-21 Thread Zaeem Mohamed
mar Somasundaram Signed-off-by: Peichen Huang Signed-off-by: Zaeem Mohamed --- .../gpu/drm/amd/display/dc/core/dc_resource.c | 2 +- .../amd/display/dc/hwss/dce110/dce110_hwseq.c | 5 +- .../amd/display/dc/hwss/dcn20/dcn20_hwseq.c | 5 +- .../amd/display/dc/hwss/dcn401/dcn401_hwseq.c |

[PATCH 05/24] drm/amd/display: Fix mismatch type comparison in custom_float

2025-02-21 Thread Zaeem Mohamed
From: Samson Tam [Why & How] Passing uint into uchar function param. Pass uint instead Signed-off-by: Samson Tam Reviewed-by: Alvin Lee --- drivers/gpu/drm/amd/display/dc/sspl/spl_fixpt31_32.c | 2 +- drivers/gpu/drm/amd/display/dc/sspl/spl_fixpt31_32.h | 4 ++-- 2 files changed, 3 insertion

[PATCH 22/24] drm/amd/display: Fix HPD after gpu reset

2025-02-21 Thread Zaeem Mohamed
Limonciello Reviewed-by: Aurabindo Pillai Signed-off-by: Roman Li Signed-off-by: Zaeem Mohamed --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c b/drivers/gpu/drm/amd

[PATCH 01/24] drm/amd/display: Revert "Disable PSR-SU on some OLED panel"

2025-02-21 Thread Zaeem Mohamed
From: Tom Chung This reverts commit 9b908d788090911d339a217c015e0022e8020b75. We planning to disable the PSR-SU and fallback to PSR1 for all eDP panels not only for specific eDP panel temporarily. Reviewed-by: Sun peng Li Signed-off-by: Tom Chung Signed-off-by: Roman Li --- .../drm/amd/disp

[PATCH 12/24] drm/amd/display: add a quirk to enable eDP0 on DP1

2025-02-21 Thread Zaeem Mohamed
functions to set quirk entries, retrieve_dmi_info can set quirks according to quirk entries Cc: Mario Limonciello Cc: sta...@vger.kernel.org Reviewed-by: Mario Limonciello Reviewed-by: Nicholas Kazlauskas Signed-off-by: Yilin Chen Signed-off-by: Zaeem Mohamed --- .../gpu/drm/amd/display

[PATCH 16/24] drm/amd/display: fix dcn4x init failed

2025-02-21 Thread Zaeem Mohamed
From: Charlene Liu [why] failed due to cmdtable not created. switch atombios cmdtable as default. Reviewed-by: Alvin Lee Signed-off-by: Charlene Liu Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dc/bios/command_table2.c | 9 - .../gpu/drm/amd/display/dc/bios

[PATCH 20/24] drm/amd/display: Increase halt timeout for DMCUB to 1s

2025-02-21 Thread Zaeem Mohamed
violations. [How] Increase the timeout before soft reset to ensure the DMCUB has quiesced. Reviewed-by: Dillon Varone Signed-off-by: Nicholas Kazlauskas Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dmub/src/dmub_dcn31.c | 15 ++- drivers/gpu/drm/amd/display/dmub/src

[PATCH 08/24] drm/amd/display: fix check for identity ratio

2025-02-21 Thread Zaeem Mohamed
From: Samson Tam [Why] IDENTITY_RATIO check uses 2 bits for integer, which only allows checking downscale ratios up to 3. But we support up to 6x downscale [How] Update IDENTITY_RATIO to check 3 bits for integer Add ASSERT to catch if we downscale more than 6x Signed-off-by: Samson Tam Revi

[PATCH 07/24] drm/amd/display: Fix mismatch type comparison

2025-02-21 Thread Zaeem Mohamed
From: "Assadian, Navid" The mismatch type comparison/assignment may cause data loss. Since the values are always non-negative, it is safe to use unsigned variables to resolve the mismatch. Signed-off-by: Navid Assadian Reviewed-by: Joshua Aberback --- drivers/gpu/drm/amd/display/dc/sspl/dc_sp

[PATCH 14/24] drm/amd/display: ACPI Re-timer Programming

2025-02-21 Thread Zaeem Mohamed
eeds to be called before we call transmitter ENABLE. In the POST case, it has to be called after we call transmitter DISABLE. [How] Implemented ACPI retimer programming interface. Reviewed-by: Alvin Lee Signed-off-by: Rafal Ostrowski Signed-off-by: Zaeem Mohamed --- .../gpu/drm/amd/display

[PATCH 00/24] DC Patches FEBRUARY 18, 2025

2025-02-21 Thread Zaeem Mohamed
This DC patchset brings iprovements in multiple areas. In summary, we have: - Disable PSR-SU on eDP panels - Fix HPD after GPU reset - Fixes on dcn4x init, DML2 state policy on DCN36 - Various minor logic fixes Cc: Daniel Wheeler Alex Hung (1): drm/amd/display: update incorrect cursor bu

[PATCH 04/24] drm/amd/display: Apply DCN35 DML2 state policy for DCN36 too

2025-02-21 Thread Zaeem Mohamed
From: Nicholas Kazlauskas [Why] DCN36 should inherit the same policy as DCN35 for DML2. [How] Add it to the list of checks in translation helper. Signed-off-by: Nicholas Kazlauskas Reviewed-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c | 1 + 1 file

[PATCH 19/24] drm/amd/display: Remove unused header

2025-02-21 Thread Zaeem Mohamed
From: Krunoslav Kovac [Why] Removes unused header Reviewed-by: Samson Tam Signed-off-by: Krunoslav Kovac Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dc/sspl/dc_spl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/sspl/dc_spl.c b/drivers

[PATCH 21/24] drm/amd/display: stop DML2 from removing pipes based on planes

2025-02-21 Thread Zaeem Mohamed
events the pipes for those ODM slices from being freed. Reviewed-by: Ovidiu Bunea Signed-off-by: Mike Katsnelson Signed-off-by: Zaeem Mohamed --- .../display/dc/dml2/dml2_dc_resource_mgmt.c | 26 --- 1 file changed, 26 deletions(-) diff --git a/drivers/gpu/drm/amd/displ

[PATCH 23/24] drm/amd/display: [FW Promotion] Release 0.0.255.0

2025-02-21 Thread Zaeem Mohamed
From: Taimur Hassan Signed-off-by: Taimur Hassan Signed-off-by: Zaeem Mohamed --- .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 76 +++ 1 file changed, 76 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display/dmub/inc

[PATCH 15/24] drm/amd/display: Temporarily disable hostvm on DCN31

2025-02-21 Thread Zaeem Mohamed
Li Signed-off-by: Aurabindo Pillai Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dc/resource/dcn31/dcn31_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/resource/dcn31/dcn31_resource.c b/drivers/gpu/drm/amd/display/dc

[PATCH 24/24] drm/amd/display: Promote DAL to 3.2.322

2025-02-21 Thread Zaeem Mohamed
From: Taimur Hassan Signed-off-by: Taimur Hassan Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index f76884fe86e3..f646f537a3dc

[PATCH 18/24] drm/amd/display: handle max_downscale_src_width fail check

2025-02-21 Thread Zaeem Mohamed
max downscale limit exceed. Reviewed-by: Samson Tam Signed-off-by: Yihan Zhu Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dc/dpp/dcn30/dcn30_dpp.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dpp/dcn30/dcn30_dpp.c

[PATCH 17/24] drm/amd/display: Update FIXED_VS Link Rate Toggle Workaround Usage

2025-02-21 Thread Zaeem Mohamed
n the LTTPR's IEEE OUI which guarantees that we only perform the toggle on affected retimers. Reviewed-by: Wenjing Liu Signed-off-by: Michael Strauss Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dc/dc_dp_types.h | 8 .../display/dc/link/protocols/link_dp_ca

[PATCH 11/24] drm/amd/display: replace dio encoder access

2025-02-21 Thread Zaeem Mohamed
mar Somasundaram Signed-off-by: Peichen Huang Signed-off-by: Zaeem Mohamed --- .../gpu/drm/amd/display/dc/core/dc_resource.c | 2 +- .../amd/display/dc/hwss/dce110/dce110_hwseq.c | 5 +- .../amd/display/dc/hwss/dcn20/dcn20_hwseq.c | 5 +- .../amd/display/dc/hwss/dcn401/dcn401_hwseq.c |

[PATCH 13/24] drm/amd/display: Refactor DCN4x and related code

2025-02-21 Thread Zaeem Mohamed
From: "Patel, Swapnil" [why & how] Refactor existing code related to DCN4x for better code sharing with other modules Reviewed-by: Charlene Liu Signed-off-by: Swapnil Patel Signed-off-by: Zaeem Mohamed --- .../amd/display/dc/dccg/dcn20/dcn20_dccg.h| 94 .../amd/d

[PATCH 10/24] drm/amd/display: Add SPL namespace

2025-02-21 Thread Zaeem Mohamed
From: Navid Assadian [Why] In order to avoid component conflicts, spl namespace is needed. [How] Adding SPL namespace to the public API os that each user of SPL can have their own namespace. Signed-off-by: Navid Assadian Reviewed-by: Samson Tam --- drivers/gpu/drm/amd/display/dc/sspl/dc_spl.

[PATCH 09/24] drm/amd/display: Fix unit test failure

2025-02-21 Thread Zaeem Mohamed
From: Samson Tam [Why] Some of unit tests use large scaling ratio such that when we calculate optimal number of taps, max_taps is negative. Then in recent change, we changed max_taps to uint instead of int so now max_taps wraps and is positive. This change changed the behaviour from returnin

[PATCH 06/24] drm/amd/display: Add opp recout adjustment

2025-02-21 Thread Zaeem Mohamed
From: Navid Assadian [Why] For subsampled YUV output formats, more pixels can get fetched and be used for scaling. [How] Add the adjustment to the calculated recout, so the viewport covers the corresponding pixels on the source plane. Signed-off-by: Navid Assadian Reviewed-by: Samson Tam ---

[PATCH 05/24] drm/amd/display: Fix mismatch type comparison in custom_float

2025-02-21 Thread Zaeem Mohamed
From: Samson Tam [Why & How] Passing uint into uchar function param. Pass uint instead Signed-off-by: Samson Tam Reviewed-by: Alvin Lee --- drivers/gpu/drm/amd/display/dc/sspl/spl_fixpt31_32.c | 2 +- drivers/gpu/drm/amd/display/dc/sspl/spl_fixpt31_32.h | 4 ++-- 2 files changed, 3 insertion

[PATCH 03/24] drm/amd/display: update incorrect cursor buffer size

2025-02-21 Thread Zaeem Mohamed
From: Alex Hung [WHAT & HOW] Fix the incorrect value of the cursor_buffer_size. Signed-off-by: Alex Hung Reviewed-by: Zaeem Mohamed --- .../amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4.c| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH 01/24] drm/amd/display: Revert "Disable PSR-SU on some OLED panel"

2025-02-21 Thread Zaeem Mohamed
From: Tom Chung This reverts commit 9b908d788090911d339a217c015e0022e8020b75. We planning to disable the PSR-SU and fallback to PSR1 for all eDP panels not only for specific eDP panel temporarily. Reviewed-by: Sun peng Li Signed-off-by: Tom Chung Signed-off-by: Roman Li --- .../drm/amd/disp

[PATCH 00/24] DC Patches FEBRUARY 18, 2025 V3

2025-02-21 Thread Zaeem Mohamed
This DC patchset brings improvements in multiple areas. In summary, we have: - Disable PSR-SU on eDP panels - Fix HPD after GPU reset - Fixes on dcn4x init, DML2 state policy on DCN36 - Various minor logic fixes Cc: Daniel Wheeler Alex Hung (1): drm/amd/display: update incorrect cursor b

[PATCH 10/24] drm/amd/display: Add SPL namespace

2025-02-21 Thread Zaeem Mohamed
From: Navid Assadian [Why] In order to avoid component conflicts, spl namespace is needed. [How] Adding SPL namespace to the public API os that each user of SPL can have their own namespace. Signed-off-by: Navid Assadian Reviewed-by: Samson Tam --- drivers/gpu/drm/amd/display/dc/sspl/dc_spl.

[PATCH 02/24] drm/amd/display: Disable PSR-SU on eDP panels

2025-02-21 Thread Zaeem Mohamed
From: Tom Chung [Why] PSR-SU may cause some glitching randomly on several panels. [How] Temporarily disable the PSR-SU and fallback to PSR1 for all eDP panels. Link: https://gitlab.freedesktop.org/drm/amd/-/issues/3388 Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Reviewe

[PATCH 04/24] drm/amd/display: Apply DCN35 DML2 state policy for DCN36 too

2025-02-21 Thread Zaeem Mohamed
From: Nicholas Kazlauskas [Why] DCN36 should inherit the same policy as DCN35 for DML2. [How] Add it to the list of checks in translation helper. Signed-off-by: Nicholas Kazlauskas Reviewed-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c | 1 + 1 file

[PATCH 05/24] drm/amd/display: Fix mismatch type comparison in custom_float

2025-02-21 Thread Zaeem Mohamed
From: Samson Tam [Why & How] Passing uint into uchar function param. Pass uint instead Signed-off-by: Samson Tam Reviewed-by: Alvin Lee --- drivers/gpu/drm/amd/display/dc/sspl/spl_fixpt31_32.c | 2 +- drivers/gpu/drm/amd/display/dc/sspl/spl_fixpt31_32.h | 4 ++-- 2 files changed, 3 insertion

[PATCH 07/24] drm/amd/display: Fix mismatch type comparison

2025-02-21 Thread Zaeem Mohamed
From: "Assadian, Navid" The mismatch type comparison/assignment may cause data loss. Since the values are always non-negative, it is safe to use unsigned variables to resolve the mismatch. Signed-off-by: Navid Assadian Reviewed-by: Joshua Aberback --- drivers/gpu/drm/amd/display/dc/sspl/dc_sp

[PATCH 06/24] drm/amd/display: Add opp recout adjustment

2025-02-21 Thread Zaeem Mohamed
From: Navid Assadian [Why] For subsampled YUV output formats, more pixels can get fetched and be used for scaling. [How] Add the adjustment to the calculated recout, so the viewport covers the corresponding pixels on the source plane. Signed-off-by: Navid Assadian Reviewed-by: Samson Tam ---

[PATCH 09/24] drm/amd/display: Fix unit test failure

2025-02-21 Thread Zaeem Mohamed
From: Samson Tam [Why] Some of unit tests use large scaling ratio such that when we calculate optimal number of taps, max_taps is negative. Then in recent change, we changed max_taps to uint instead of int so now max_taps wraps and is positive. This change changed the behaviour from returnin

[PATCH 08/24] drm/amd/display: fix check for identity ratio

2025-02-21 Thread Zaeem Mohamed
From: Samson Tam [Why] IDENTITY_RATIO check uses 2 bits for integer, which only allows checking downscale ratios up to 3. But we support up to 6x downscale [How] Update IDENTITY_RATIO to check 3 bits for integer Add ASSERT to catch if we downscale more than 6x Signed-off-by: Samson Tam Revi

[PATCH 00/24] DC Patches FEBRUARY 18, 2025 V2

2025-02-21 Thread Zaeem Mohamed
This DC patchset brings improvements in multiple areas. In summary, we have: - Disable PSR-SU on eDP panels - Fix HPD after GPU reset - Fixes on dcn4x init, DML2 state policy on DCN36 - Various minor logic fixes Cc: Daniel Wheeler Alex Hung (1): drm/amd/display: update incorrect cursor b

[PATCH 07/24] drm/amd/display: Fix mismatch type comparison

2025-02-21 Thread Zaeem Mohamed
From: "Assadian, Navid" The mismatch type comparison/assignment may cause data loss. Since the values are always non-negative, it is safe to use unsigned variables to resolve the mismatch. Signed-off-by: Navid Assadian Reviewed-by: Joshua Aberback --- drivers/gpu/drm/amd/display/dc/sspl/dc_sp

[PATCH 12/24] drm/amd/display: add a quirk to enable eDP0 on DP1

2025-02-21 Thread Zaeem Mohamed
functions to set quirk entries, retrieve_dmi_info can set quirks according to quirk entries Cc: Mario Limonciello Cc: sta...@vger.kernel.org Reviewed-by: Mario Limonciello Reviewed-by: Nicholas Kazlauskas Signed-off-by: Yilin Chen Signed-off-by: Zaeem Mohamed --- .../gpu/drm/amd/display

[PATCH 06/24] drm/amd/display: Add opp recout adjustment

2025-02-21 Thread Zaeem Mohamed
From: Navid Assadian [Why] For subsampled YUV output formats, more pixels can get fetched and be used for scaling. [How] Add the adjustment to the calculated recout, so the viewport covers the corresponding pixels on the source plane. Signed-off-by: Navid Assadian Reviewed-by: Samson Tam ---

[PATCH 08/24] drm/amd/display: fix check for identity ratio

2025-02-21 Thread Zaeem Mohamed
From: Samson Tam [Why] IDENTITY_RATIO check uses 2 bits for integer, which only allows checking downscale ratios up to 3. But we support up to 6x downscale [How] Update IDENTITY_RATIO to check 3 bits for integer Add ASSERT to catch if we downscale more than 6x Signed-off-by: Samson Tam Revi

[PATCH 09/24] drm/amd/display: Fix unit test failure

2025-02-21 Thread Zaeem Mohamed
From: Samson Tam [Why] Some of unit tests use large scaling ratio such that when we calculate optimal number of taps, max_taps is negative. Then in recent change, we changed max_taps to uint instead of int so now max_taps wraps and is positive. This change changed the behaviour from returnin

[PATCH 04/24] drm/amd/display: Apply DCN35 DML2 state policy for DCN36 too

2025-02-21 Thread Zaeem Mohamed
From: Nicholas Kazlauskas [Why] DCN36 should inherit the same policy as DCN35 for DML2. [How] Add it to the list of checks in translation helper. Signed-off-by: Nicholas Kazlauskas Reviewed-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c | 1 + 1 file

[PATCH 03/24] drm/amd/display: update incorrect cursor buffer size

2025-02-21 Thread Zaeem Mohamed
From: Alex Hung [WHAT & HOW] Fix the incorrect value of the cursor_buffer_size. Signed-off-by: Alex Hung Reviewed-by: Zaeem Mohamed --- .../amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4.c| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH 02/24] drm/amd/display: Disable PSR-SU on eDP panels

2025-02-21 Thread Zaeem Mohamed
From: Tom Chung [Why] PSR-SU may cause some glitching randomly on several panels. [How] Temporarily disable the PSR-SU and fallback to PSR1 for all eDP panels. Link: https://gitlab.freedesktop.org/drm/amd/-/issues/3388 Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Reviewe

[PATCH 01/24] drm/amd/display: Revert "Disable PSR-SU on some OLED panel"

2025-02-21 Thread Zaeem Mohamed
From: Tom Chung This reverts commit 9b908d788090911d339a217c015e0022e8020b75. We planning to disable the PSR-SU and fallback to PSR1 for all eDP panels not only for specific eDP panel temporarily. Reviewed-by: Sun peng Li Signed-off-by: Tom Chung Signed-off-by: Roman Li --- .../drm/amd/disp

[PATCH 02/14] drm/amd/display: Update CR AUX RD interval interpretation

2025-01-21 Thread Zaeem Mohamed
training. Reviewed-by: Michael Strauss Reviewed-by: Wenjing Liu Signed-off-by: George Shen Signed-off-by: Zaeem Mohamed --- .../display/dc/link/protocols/link_dp_training_8b_10b.c| 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/link

[PATCH 04/14] drm/amd/display: pass calculated dram_speed_mts to dml2

2025-01-21 Thread Zaeem Mohamed
From: Charlene Liu [why] currently dml2 is using a hard coded 16 to convert memclk to dram_speed_mts. for apu, this depends on wck_ratio. change to pass the already calculated dram_speed_mts from fpu to dml2. Reviewed-by: Natanel Roizenman Signed-off-by: Charlene Liu Signed-off-by: Zaeem

[PATCH 08/14] drm/amd/display: Ammend DCPG IP control sequences to align with HW guidance

2025-01-21 Thread Zaeem Mohamed
From: Dillon Varone [WHY&HOW] IP_REQUEST_CNTL should only be toggled off when it was originally, never unconditionally. Reviewed-by: Alvin Lee Signed-off-by: Dillon Varone Signed-off-by: Zaeem Mohamed --- .../amd/display/dc/hwss/dcn20/dcn20_hwseq.c | 14 +--- .../amd/display/dc/

[PATCH 12/14] drm/amd/display: refactor dio link encoder assigning

2025-01-21 Thread Zaeem Mohamed
accessed through pipe_ctx. 3. assign dio encoder when add stream to ctx Reviewed-by: Jun Lei Reviewed-by: Meenakshikumar Somasundaram Signed-off-by: Peichen Huang Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +- .../gpu/drm/amd/display/dc/core

[PATCH 14/14] drm/amd/display: 3.2.318

2025-01-21 Thread Zaeem Mohamed
From: Aric Cyr Signed-off-by: Aric Cyr Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index 06d9cf0a7edc..559446dcd431 100644

[PATCH 13/14] drm/amd/display: Fix possible NULL dereferencing

2025-01-21 Thread Zaeem Mohamed
From: Alex Hung [WHAT & HOW] GET_IMAGE can return null, and checking firmware_info32 before dereferencing it is necessary. This fixes 1 NULL_RETURNS issue reported by Coverity. Reviewed-by: Harry Wentland Signed-off-by: Alex Hung Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/dis

[PATCH 11/14] drm/amd/display: Guard Possible Null Pointer Dereference

2025-01-21 Thread Zaeem Mohamed
From: Sung Lee [WHY] In some situations, dc->res_pool may be null. [HOW] Check if pointer is null before dereference. Reviewed-by: Joshua Aberback Signed-off-by: Sung Lee Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dc/core/dc.c | 8 +--- 1 file changed, 5 inserti

[PATCH 09/14] drm/amd/display: Fix potential NULL dereference

2025-01-21 Thread Zaeem Mohamed
From: Wayne Lin Fix NULL_RETURNS error caught by Coverity. => firmware_info32 might be NULL. Check it before dereference. Fixes: 352f9a9451ec ("drm/amd/display/dc: add support for oem i2c in atom_firmware_info_v3_1") Reviewed-by: Wayne Lin Signed-off-by: Wayne Lin Signed-

[PATCH 07/14] drm/amd/display: Correct register address in dcn35

2025-01-21 Thread Zaeem Mohamed
From: loanchen [Why] the offset address of mmCLK5_spll_field_8 was incorrect for dcn35 which causes SSC not to be enabled. Reviewed-by: Charlene Liu Reviewed-by: Charlene Liu Signed-off-by: Lo-An Chen Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35

[PATCH 10/14] drm/amd/display: Add boot option to reduce PHY SSC for HBR3

2025-01-21 Thread Zaeem Mohamed
From: Hansen Dsouza [Why] Spread on DPREFCLK by 0.3 percent can have a negative effect on sink when PHY SSC is also spread by 0.3 percent [How] Add boot option for DMU to lower PHY SSC Reviewed-by: Nicholas Kazlauskas Signed-off-by: Hansen Dsouza Signed-off-by: Zaeem Mohamed --- drivers/gpu

[PATCH 06/14] drm/amd/display: Disable PSR-SU on some OLED panel

2025-01-21 Thread Zaeem Mohamed
From: Tom Chung [Why] PSR-SU may cause some glitching randomly on some OLED panel. [How] Disable the PSR-SU for certain PSR-SU OLED panel. Reviewed-by: Sun peng Li Signed-off-by: Tom Chung Signed-off-by: Zaeem Mohamed --- .../drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 20

[PATCH 05/14] drm/amd/display: Account For OTO Prefetch Bandwidth When Calculating Urgent Bandwidth

2025-01-21 Thread Zaeem Mohamed
-off-by: Austin Zheng Signed-off-by: Zaeem Mohamed --- .../src/dml2_core/dml2_core_dcn4_calcs.c | 25 ++- .../src/dml2_core/dml2_core_shared_types.h| 5 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml21/src

[PATCH 03/14] drm/amd/display: Update Cursor request mode to the beginning prefetch always

2025-01-21 Thread Zaeem Mohamed
cursor request mode to the beginning prefetch always and avoid wraparound calculation issues. Reviewed-by: Nicholas Kazlauskas Signed-off-by: Zhikai Zhai Signed-off-by: Zaeem Mohamed --- .../amd/display/dc/hubp/dcn31/dcn31_hubp.c| 2 +- .../amd/display/dc/hwss/dcn10/dcn10_hwseq.c | 22

[PATCH 01/14] drm/amd/display: Initial psr_version with correct setting

2025-01-21 Thread Zaeem Mohamed
From: Tom Chung [Why & How] The initial setting for psr_version is not correct while create a virtual link. The default psr_version should be DC_PSR_VERSION_UNSUPPORTED. Reviewed-by: Roman Li Signed-off-by: Tom Chung Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dc/core/

[PATCH 00/14] DC Patches JANUARY 20, 2025

2025-01-21 Thread Zaeem Mohamed
This DC patchset brings improvements in multiple areas. In summary, we have: - Fixes on psr_version, dcn35 register address, DCPG OP control sequences - Imporvements to CR AUX RD interval interpretation, dio link encoder - Disable PSR-SU on some OLED panels Cc: Daniel Wheeler Alex Hung (1)

[PATCH] SWDEV-476969 - dm/amdgpu: Fail dm_atomic_check if cursor overlay is required at MAX_SURFACES

2024-11-14 Thread Zaeem Mohamed
[why] Prevent index-out-of-bounds due to requiring cursor overlay when plane_count is MAX_SURFACES. [how] Bounds check on plane_count when requiring overlay cursor. Co-developed-by: Melissa Wen Signed-off-by: Zaeem Mohamed --- amdgpu_dm/amdgpu_dm.c | 10 +- 1 file changed, 9

[PATCH 05/17] drm/amd/display: Remove inaccessible registers from DMU diagnostics

2024-11-01 Thread Zaeem Mohamed
From: Nicholas Kazlauskas [Why] SEC_CNTL isn't readable by x86 and can block Z8 entry if read. [How] Remove the read. Reviewed-by: Ovidiu Bunea Reviewed-by: Charlene Liu Signed-off-by: Nicholas Kazlauskas Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dmub/src/dmub_dc

[PATCH 15/17] drm/amd/display: Implement new backlight_level_params structure

2024-11-01 Thread Zaeem Mohamed
conversions from PWM to nits or vice versa. [How] Modified existing functions to include the new backlight_level_params structure. Reviewed-by: Nicholas Kazlauskas Signed-off-by: Kaitlyn Tse Signed-off-by: Zaeem Mohamed --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 ++- .../drm/amd/display/dc

[PATCH 14/17] drm/amd/display: [FW Promotion] Release 0.0.241.0

2024-11-01 Thread Zaeem Mohamed
From: Taimur Hassan - Add DPCS health check - Update USB4 PHY SSC - Fix FAMS2 SubVP Close to VBlank changes - Create VESA Aux-based backlight control path - Fix PSR1 CRC error during CTS test Signed-off-by: Taimur Hassan Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dmub/inc

[PATCH 07/17] drm/amd/display: Fix brightness level not retained over reboot

2024-11-01 Thread Zaeem Mohamed
he set mode. Reviewed-by: Sun peng Li Signed-off-by: Tom Chung Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/d

[PATCH 02/17] drm/amd/display: avoid divided by zero

2024-11-01 Thread Zaeem Mohamed
From: Charlene Liu [why] insert divided by zero protection Reviewed-by: Alvin Lee Signed-off-by: Charlene Liu Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/display/modules

[PATCH 12/17] drm/amd/display: Minimize wait for pending updates

2024-11-01 Thread Zaeem Mohamed
: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dc/core/dc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c index 8a52fef46785..7872c6cabb14 100644 --- a/drivers/gpu/drm/amd/display/dc/core

[PATCH 13/17] drm/amd/display: Don't write DP_MSTM_CTRL after LT

2024-11-01 Thread Zaeem Mohamed
evice dpcd settings during resume_mst_branch_status(). Leverage drm_dp_mst_topology_queue_probe() to only probe the topology, not calling drm_dp_mst_topology_mgr_resume() which will set DP_MSTM_CTRL as well. Reviewed-by: Jerry Zuo Signed-off-by: Wayne Lin Signed-off-by: Zaeem Mohamed --- .../g

[PATCH 17/17] drm/amd/display: 3.2.308

2024-11-01 Thread Zaeem Mohamed
From: Aric Cyr This version brings along following fixes: - Prune Invalid Modes for HDMI Output - SPL Cleanup - Fix brightness level not retained over reboot - Remove inaccessible registers from DMU diagnostics Signed-off-by: Aric Cyr Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd

[PATCH 06/17] drm/amd/display: fix asserts in SPL during bootup

2024-11-01 Thread Zaeem Mohamed
function and call it if max_downscale_src_width fails. This will populate taps if scaling_quality taps are 0. Reviewed-by: Alvin Lee Signed-off-by: Samson Tam Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dc/spl/dc_spl.c | 86 - 1 file changed, 48

[PATCH 01/17] drm/amd/display: Do Not Fallback To SW Cursor If HW Cursor Required

2024-11-01 Thread Zaeem Mohamed
: Dillon Varone Signed-off-by: Austin Zheng Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c

[PATCH 09/17] drm/amd/display: Remove hw w/a toggle if on DP2/HPO

2024-11-01 Thread Zaeem Mohamed
From: Ausef Yousof [why&how] Applying a hw w/a only relevant to DIG FIFO causing corruption using HPO, do not apply the w/a if on DP2/HPO Reviewed-by: Charlene Liu Signed-off-by: Ausef Yousof Signed-off-by: Zaeem Mohamed --- .../drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c

[PATCH 16/17] drm/amd/display: Prune Invalid Modes For HDMI Output

2024-11-01 Thread Zaeem Mohamed
for pcon use case as well, if rgb/yuv444 8bpc cannot fit into pcon bw limitation of the link from the converter to HDMI sink. 3. Add readable pixel_format and color_depth into debug log. Reviewed-by: Wayne Lin Signed-off-by: Fangzhi Zuo Signed-off-by: Zaeem Mohamed --- .../gpu/drm/amd

[PATCH 10/17] drm/amd/display: Remove otg w/a toggling on HPO interfaces

2024-11-01 Thread Zaeem Mohamed
From: Ausef Yousof [why&how] Adjust otg w/a disable condition to include HPO explicitly rather than assuming it is implicitly used through DP2. Reviewed-by: Charlene Liu Signed-off-by: Ausef Yousof Signed-off-by: Zaeem Mohamed --- .../drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c

[PATCH 11/17] drm/amd/display: parse umc_info or vram_info based on ASIC

2024-11-01 Thread Zaeem Mohamed
://gitlab.freedesktop.org/drm/amd/-/issues/3678 Reviewed-by: Dillon Varone Signed-off-by: Aurabindo Pillai Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/bios

[PATCH 03/17] Revert "drm/amd/display: Block UHBR Based On USB-C PD Cable ID"

2024-11-01 Thread Zaeem Mohamed
f-by: Ausef Yousof Signed-off-by: Zaeem Mohamed --- .../dc/link/protocols/link_dp_capability.c| 22 +-- 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c b/drivers/gpu/drm/amd/display/dc/link/proto

[PATCH 04/17] drm/amd/display: fix rxstatus_msg_sz type narrowing

2024-11-01 Thread Zaeem Mohamed
. Removed spaces mixed with tabs to fix indentation on modified lines. Reviewed-by: Wenjing Liu Signed-off-by: Dominik Kaszewski Signed-off-by: Zaeem Mohamed --- .../display/modules/hdcp/hdcp2_execution.c| 31 +++ 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a

[PATCH 08/17] drm/amd/display: SPL cleanup

2024-11-01 Thread Zaeem Mohamed
From: Samson Tam [Why & How] Move from pointer to callback to reference callback directly Missed renaming fixpt functions with spl prefix Reviewed-by: Navid Assadian Signed-off-by: Samson Tam Signed-off-by: Zaeem Mohamed --- .../gpu/drm/amd/display/dc/dc_spl_translate.c

[PATCH 00/17] DC Patches October 28, 2024

2024-11-01 Thread Zaeem Mohamed
This DC patchset brings improvements in multiple areas. In summary, we have: - Prune Invalid Modes for HDMI Output - SPL Cleanup - Fix brightness level not retained over reboot - Remove inaccessible registers from DMU diagnostics Cc: Daniel Wheeler Aric Cyr (1): drm/amd/display: 3.2.308 Au

[RFC 1/1] SWDEV476969 - dm: Fail dm_atomic_check if cursor overlay is required at MAX_SURFACES

2024-10-25 Thread Zaeem Mohamed
[why] Prevent index-out-of-bounds due to requiring cursor overlay when plane_count is MAX_SURFACES. [how] Bounds check on plane_count when requiring overlay cursor. Co-developed-by: Melissa Wen Signed-off-by: Zaeem Mohamed --- amdgpu_dm/amdgpu_dm.c | 16 +++- 1 file changed, 15

[RFC 0/1] Fail dm_atomic_check if cursor overlay is required at MAX_SURFACES

2024-10-25 Thread Zaeem Mohamed
Current patch to prevent index-out-of-bounds when cursor plane is required and plane_count is MAX_SURFACES. This check needs to occur in dm_atomic_check where failing is safe. Need help with finding a better location for the bounds check within dm_atomic_commit Zaeem Mohamed (1): SWDEV476969

[PATCH 1/1] drm/amdgpu/display: remove unecessary TODO spl_os_types.h

2024-08-22 Thread Zaeem Mohamed
Remove TODO from spl_os_types.h Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dc/spl/spl_os_types.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/spl/spl_os_types.h b/drivers/gpu/drm/amd/display/dc/spl/spl_os_types.h index 058306bb41aa

[PATCH 0/1] DC Patches August 23, 2024

2024-08-22 Thread Zaeem Mohamed
One last patch to add to this weeks promotion series to align upstream with amd-dal. Cc: Daniel Wheeler Zaeem Mohamed (1): drm/amdgpu/display: remove unecessary TODO spl_os_types.h drivers/gpu/drm/amd/display/dc/spl/spl_os_types.h | 1 - 1 file changed, 1 deletion(-) -- 2.34.1

[PATCH 1/1] drm/amdgpu/display: SPDX copyright for spl_os_types.h

2024-08-22 Thread Zaeem Mohamed
Use appropriate SPDX copyright for spl_os_types.h Signed-off-by: Zaeem Mohamed --- .../gpu/drm/amd/display/dc/spl/spl_os_types.h | 29 +++ 1 file changed, 4 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/spl/spl_os_types.h b/drivers/gpu/drm/amd

[PATCH 0/1] DC Patches August 22, 2024

2024-08-22 Thread Zaeem Mohamed
This is an additional patch to be included in this week's promotion series: * Uses SPDX Copyright for spl_os_types.h Cc: Daniel Wheeler Zaeem Mohamed (1): drm/amdgpu/display: SPDX copyright for spl_os_types.h .../gpu/drm/amd/display/dc/spl/spl_os_types.h | 29 +++ 1

[PATCH 13/16] drm/amd/display: add improvements for text display and HDR DWM and MPO

2024-08-21 Thread Zaeem Mohamed
Tam Signed-off-by: Zaeem Mohamed --- .../gpu/drm/amd/display/dc/dc_spl_translate.c | 4 + drivers/gpu/drm/amd/display/dc/spl/Makefile | 2 +- drivers/gpu/drm/amd/display/dc/spl/dc_spl.c | 127 +++ .../gpu/drm/amd/display/dc/spl/dc_spl_types.h | 2 + .../drm/amd/display/dc

[PATCH 15/16] drm/amd/display: 3.2.298

2024-08-21 Thread Zaeem Mohamed
MPO - Fix Synaptics Cascaded Panamera DSC Determination - Allocate DCN35 clock table transfer buffers in GART - Add Replay Low Refresh Rate parameters in dc type Signed-off-by: Aric Cyr Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 16/16] drm/amd/display: Add DSC Debug Log

2024-08-21 Thread Zaeem Mohamed
From: Fangzhi Zuo Add DSC log in each critical routines to facilitate debugging. Reviewed-by: Rodrigo Siqueira Signed-off-by: Fangzhi Zuo Signed-off-by: Zaeem Mohamed --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 9 +- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 18

[PATCH 14/16] drm/amd/display: add sharpness support for windowed YUV420 video

2024-08-21 Thread Zaeem Mohamed
From: Samson Tam [Why] Previous only applied sharpness for fullscreen YUV420 video. [How] Remove fullscrene restriction and apply sharpness for windowed YUV420 video as well. Reviewed-by: Jun Lei Signed-off-by: Samson Tam Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dc/spl

[PATCH 12/16] drm/amd/display: Add Replay Low Refresh Rate parameters in dc type.

2024-08-21 Thread Zaeem Mohamed
From: Dennis Chan Why: To supported Low Refresh Rate panel for Replay Feature, Adding some parameters to record Low Refresh Rate information. Reviewed-by: Robin Chen Signed-off-by: Dennis Chan Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dc/dc_types.h | 19

[PATCH 06/16] drm/amd/display: do not set traslate_by_source for DCN401 cursor

2024-08-21 Thread Zaeem Mohamed
-off-by: Aurabindo Pillai Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c b/drivers/gpu/drm/amd/display/amdgpu_dm

[PATCH 10/16] drm/amd/display: Notify DMCUB of D0/D3 state

2024-08-21 Thread Zaeem Mohamed
Signed-off-by: Nicholas Kazlauskas Signed-off-by: Ovidiu Bunea Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/dc/core/dc.c | 4 ++ drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 30 ++- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.h | 24 +++- .../gpu/drm

[PATCH 09/16] drm/amd/display: Fix Synaptics Cascaded Panamera DSC Determination

2024-08-21 Thread Zaeem Mohamed
From: Fangzhi Zuo Synaptics Cascaded Panamera topology needs to unconditionally acquire root aux for dsc decoding. Reviewed-by: Roman Li Signed-off-by: Fangzhi Zuo Signed-off-by: Zaeem Mohamed --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +- 1 file changed, 1

  1   2   3   >