From: Alex Hung <alex.h...@amd.com>

[WHAT & HOW]
GET_IMAGE can return null, and checking firmware_info32 before
dereferencing it is necessary.

This fixes 1 NULL_RETURNS issue reported by Coverity.

Reviewed-by: Harry Wentland <harry.wentl...@amd.com>
Signed-off-by: Alex Hung <alex.h...@amd.com>
Signed-off-by: Zaeem Mohamed <zaeem.moha...@amd.com>
---
 drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c 
b/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
index d967065eea47..04eb647acc4e 100644
--- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
+++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
@@ -1823,7 +1823,7 @@ static enum bp_result get_firmware_info_v3_1(
        /* These fields are marked as reserved in v3_1, but they appear to be 
populated
         * properly.
         */
-       if (firmware_info32->board_i2c_feature_id == 0x2) {
+       if (firmware_info32 && firmware_info32->board_i2c_feature_id == 0x2) {
                info->oem_i2c_present = true;
                info->oem_i2c_obj_id = 
firmware_info32->board_i2c_feature_gpio_id;
        } else {
-- 
2.34.1

Reply via email to