RE: [PATCH 2/2] drm/amdgpu/vcn: Hold pg_lock before vcn power off

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Leo Liu > -Original Message- > From: Sundararaju, Sathishkumar > Sent: August 6, 2025 3:17 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Liu, Leo > ; Sundararaju, Sathishkumar &g

RE: [PATCH] drm/amdgpu: Fix unintended error log in VCN5_0_0

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Leo Liu > -Original Message- > From: Sundararaju, Sathishkumar > Sent: July 29, 2025 3:52 AM > To: amd-gfx@lists.freedesktop.org > Cc: Liu, Leo ; Sundararaju, Sathishkumar > > Subject: [P

RE: [PATCH 0/8] Generic register dump helper functions for VCN

[AMD Official Use Only - AMD Internal Distribution Only] The series is: Acked-by: Leo Liu > -Original Message- > From: Sundararaju, Sathishkumar > Sent: July 18, 2025 9:46 AM > To: amd-gfx@lists.freedesktop.org > Cc: Liu, Leo ; Sundararaju, Sathishkumar > >

RE: [PATCH] drm/amdgpu: Check vcn sram load return value

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Leo Liu > -Original Message- > From: Sundararaju, Sathishkumar > Sent: July 14, 2025 2:01 AM > To: amd-gfx@lists.freedesktop.org > Cc: Liu, Leo ; Sundararaju, Sathishkumar > > Subject: [PATCH]

RE: [PATCH] drm/amdgpu: VCN v5_0_1 to prevent FW checking RB during DPG pause

[AMD Official Use Only - AMD Internal Distribution Only] Acked-by: Leo Liu > -Original Message- > From: amd-gfx On Behalf Of Sonny > Jiang > Sent: June 12, 2025 11:16 AM > To: amd-gfx@lists.freedesktop.org > Cc: Jiang, Sonny > Subject: [PATCH] drm/amdgpu: VCN v5_0_1 to prevent FW check

RE: [PATCH v2] drm/amdgpu/vcn: using separate VCN1_AON_SOC offset

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Leo Liu > -Original Message- > From: Dong, Ruijing > Sent: May 5, 2025 10:46 AM > To: amd-gfx@lists.freedesktop.org; Jamadar, Saleemkhan > > Cc: Deucher, Alexander ; Koenig, Christian > ; Liu

RE: [PATCH v2] drm/amdgpu: Add DPG pause for VCN v5.0.1

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Leo Liu > -Original Message- > From: amd-gfx On Behalf Of Sonny > Jiang > Sent: April 25, 2025 12:42 PM > To: amd-gfx@lists.freedesktop.org > Cc: Jiang, Sonny > Subject: [PATCH v2] drm/amdgpu: Add DPG pause for VCN v

RE: [PATCH 2/2] drm/amdgpu: Enable doorbell for JPEG5_0_1

[AMD Official Use Only - AMD Internal Distribution Only] The series is: Reviewed-by: Leo Liu > -Original Message- > From: Sundararaju, Sathishkumar > Sent: April 10, 2025 9:01 AM > To: amd-gfx@lists.freedesktop.org > Cc: Liu, Leo ; Zhang, Hawking > ; Sundara

RE: [PATCH] drm/amdgpu: Add back JPEG to video caps for carrizo and newer

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Leo Liu > -Original Message- > From: amd-gfx On Behalf Of David > Rosca > Sent: April 7, 2025 8:53 AM > To: amd-gfx@lists.freedesktop.org > Cc: Rosca, David > Subject: [PATCH] drm/amdgpu: Add back JPEG to video caps

RE: [PATCH] drm/amdgpu: enable FW workaround for VCN 4_0_5

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Leo Liu > -Original Message- > From: amd-gfx On Behalf Of > boyuan.zh...@amd.com > Sent: March 28, 2025 2:27 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Boyuan > Subject: [PATCH] drm/amdgpu: enable FW workaro

RE: [PATCH 2/2] drm/amdgpu: Fix core reset sequence for JPEG5_0_1

[AMD Official Use Only - AMD Internal Distribution Only] The series is: Reviewed-by: Leo Liu > -Original Message- > From: Sundararaju, Sathishkumar > Sent: February 26, 2025 11:51 AM > To: amd-gfx@lists.freedesktop.org > Cc: Liu, Leo ; Sundararaju, Sathishkumar > >

RE: [PATCH 3/3] drm/amdgpu: Add ring reset callback for JPEG5_0_1

[AMD Official Use Only - AMD Internal Distribution Only] The series is: Reviewed-by: Leo Liu > -Original Message- > From: Sundararaju, Sathishkumar > Sent: February 20, 2025 1:37 PM > To: amd-gfx@lists.freedesktop.org > Cc: Liu, Leo ; Sundararaju, Sathishkumar > >

RE: [PATCH] drm/amdgpu: Do not poweroff UVDJ in JPEG4_0_3

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Leo Liu > -Original Message- > From: Sundararaju, Sathishkumar > Sent: February 20, 2025 8:48 AM > To: amd-gfx@lists.freedesktop.org > Cc: Liu, Leo ; Sundararaju, Sathishkumar > > Subject: [PATC

RE: [PATCH v3 10/10] drm/amdgpu: Enable devcoredump for JPEG5_0_0

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Leo Liu > -Original Message- > From: Sundararaju, Sathishkumar > Sent: January 30, 2025 4:51 AM > To: amd-gfx@lists.freedesktop.org > Cc: Liu, Leo ; Lazar, Lijo ; > Sundararaju, Sathishkumar >

RE: [PATCH 00/29] Separating vcn power management by instance

[AMD Official Use Only - AMD Internal Distribution Only] The series is: Acked-by: Leo Liu > -Original Message- > From: Zhang, Boyuan > Sent: October 24, 2024 10:35 PM > To: amd-gfx@lists.freedesktop.org; Liu, Leo ; Koenig, > Christian ; Deucher, Alexander > ; Khatri,

RE: [PATCH v2] drm/amdgpu: Save VCN shared memory with init reset

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Leo Liu > -Original Message- > From: amd-gfx On Behalf Of Lijo > Lazar > Sent: October 18, 2024 2:41 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Deucher, Alexander > ; Bhardwaj, Rajneesh > ; Errabolu

RE: [PATCH] drm/amdgpu: Save VCN shared memory with init reset

[AMD Official Use Only - AMD Internal Distribution Only] > -Original Message- > From: Lazar, Lijo > Sent: October 17, 2024 9:17 AM > To: Liu, Leo ; Koenig, Christian > ; amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Deucher, Alexander > ; Sundararaju, Sathishk

RE: [PATCH] drm/amdgpu: Save VCN shared memory with init reset

[AMD Official Use Only - AMD Internal Distribution Only] > -Original Message- > From: Lazar, Lijo > Sent: October 16, 2024 11:18 PM > To: Liu, Leo ; Koenig, Christian > ; amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Deucher, Alexander > ; Sundararaju, S

RE: [PATCH] drm/amdgpu: Save VCN shared memory with init reset

[AMD Official Use Only - AMD Internal Distribution Only] > -Original Message- > From: Koenig, Christian > Sent: October 16, 2024 9:16 AM > To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org; Liu, Leo > > Cc: Zhang, Hawking ; Deucher, Alexander > ; Sundararaju, Sathishk

RE: [PATCH] drm/amdgpu/vcn: enable AV1 on both instances

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Leo Liu > -Original Message- > From: Jamadar, Saleemkhan > Sent: September 21, 2024 3:14 AM > To: Jamadar, Saleemkhan ; Liu, Leo > ; Rao, Srinath ; Gopalakrishnan, > Veerabadhran (Veera) ; > Sund

RE: [PATCH] drm/amdgpu: add amdgpu_jpeg_sched_mask debugfs

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Leo Liu > -Original Message- > From: Sundararaju, Sathishkumar > Sent: September 10, 2024 10:32 AM > To: amd-gfx@lists.freedesktop.org > Cc: Liu, Leo ; Sundararaju, Sathishkumar > > Subject: [P

RE: [PATCH] drm/amdgpu: Fix JPEG v4.0.3 register write

[AMD Official Use Only - AMD Internal Distribution Only] Acked-by: Leo Liu > -Original Message- > From: Lazar, Lijo > Sent: September 6, 2024 4:46 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Deucher, Alexander > ; Liu, Leo ; Jian, Jane > ; Lu, Vic

RE: [PATCH v1 00/18] VCN patches with updated register list

[AMD Official Use Only - AMD Internal Distribution Only] The series is: Acked-by: Leo Liu > -Original Message- > From: Sunil Khatri > Sent: Tuesday, August 13, 2024 7:30 AM > To: Deucher, Alexander ; Lazar, Lijo > ; Liu, Leo > Cc: amd-gfx@lists.freedesktop.

RE: [PATCH 2/2] drm/amdgpu/jpeg4: properly set atomics vmid field

[AMD Official Use Only - AMD Internal Distribution Only] The series is: Reviewed-by: Leo Liu > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Tuesday, August 6, 2024 1:03 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; > sta...@vger.kernel.org >

RE: [PATCH] drm/amdgpu: drop some kernel messages in VCN code

[AMD Official Use Only - AMD Internal Distribution Only] Acked-by: Leo Liu > -Original Message- > From: Wu, David > Sent: Thursday, May 30, 2024 10:59 AM > To: amd-gfx@lists.freedesktop.org; Koenig, Christian > > Cc: Deucher, Alexander ; Liu, Leo > ; Jiang,

RE: [PATCH] drm/amd/amdgpu: update jpeg 5 capability

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Leo Liu > -Original Message- > From: Wu, David > Sent: Thursday, May 9, 2024 5:37 PM > To: amd-gfx@lists.freedesktop.org; Deucher, Alexander > > Cc: Koenig, Christian ; Liu, Leo > ; Jiang, Son

RE: [PATCH] drm/amdgpu/vcn: set VCN5 power gating state to GATE on suspend

[AMD Official Use Only - General] Reviewed-by: Leo Liu > -Original Message- > From: Wu, David > Sent: Thursday, May 9, 2024 3:59 PM > To: amd-gfx@lists.freedesktop.org; Koenig, Christian > > Cc: Deucher, Alexander ; Liu, Leo > ; Jiang, Sonny > Subject: [PA

RE: [PATCH v3] drm/amdgpu: IB test encode test package change for VCN5

[AMD Official Use Only - General] Reviewed-by: Leo Liu > -Original Message- > From: amd-gfx On Behalf Of Sonny > Jiang > Sent: Thursday, April 25, 2024 4:11 PM > To: amd-gfx@lists.freedesktop.org > Cc: Jiang, Sonny ; Jiang, Sonny > > Subject: [PATCH v3] drm/amdgpu: IB test encode test

RE: [PATCH 1/2] drm/amdgpu: IB size alignment on VCN5

[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of > Sonny Jiang > Sent: Monday, April 15, 2024 5:25 PM > To: amd-gfx@lists.freedesktop.org > Cc: Jiang, Sonny ; Jiang, Sonny > > Subject: [PATCH 1/2] drm/amdgpu: IB size alignment on VCN5 > > From: Sonny Ji

RE: [PATCH v2 3/3] drm/amdgpu/jpeg: support for sriov cpx mode

[AMD Official Use Only - General] Reviewed-by: Leo Liu > -Original Message- > From: Dhume, Samir > Sent: Friday, March 15, 2024 3:51 PM > To: amd-gfx@lists.freedesktop.org > Cc: Dhume, Samir ; Lazar, Lijo > ; Wan, Gavin ; Liu, Leo > ; Deucher, Alexander > Sub

RE: [PATCH 3/3] drm/amdgpu/jpeg: support for sriov cpx mode

[AMD Official Use Only - General] > -Original Message- > From: Dhume, Samir > Sent: Monday, March 4, 2024 10:20 AM > To: amd-gfx@lists.freedesktop.org > Cc: Dhume, Samir ; Lazar, Lijo > ; Wan, Gavin ; Liu, Leo > ; Deucher, Alexander > Subject: [PATCH 3/3] drm/

RE: [PATCH 4/4] drm/amdgpu: add vcn 4.0.6 discovery support

[AMD Official Use Only - General] The series of 4 patches are: Reviewed-by: Leo Liu > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Wednesday, February 21, 2024 12:00 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Yifan ; Deucher, Alexander > > Subject: [P

RE: [PATCH] drm/amd/amdgpu: Clean up VCN fw_shared and set flag bits during hw_init

[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of > Bokun Zhang > Sent: Tuesday, November 28, 2023 4:25 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Bokun > Subject: [PATCH] drm/amd/amdgpu: Clean up VCN fw_shared and set flag > bits during hw_init

RE: [PATCH v3] drm/amd/amdgpu/vcn: Add RB decouple feature under SRIOV

[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of > Bokun Zhang > Sent: Friday, October 13, 2023 1:43 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Bokun > Subject: [PATCH v3] drm/amd/amdgpu/vcn: Add RB decouple feature under > SRIOV > > - Add code

RE: [PATCH] drm/amdgpu: not to save bo in the case of RAS err_event_athub

[AMD Official Use Only - General] Acked-by: Leo Liu -Original Message- From: Wu, David Sent: Thursday, September 21, 2023 3:18 PM To: amd-gfx@lists.freedesktop.org Cc: Koenig, Christian ; Deucher, Alexander ; Liu, Leo Subject: [PATCH] drm/amdgpu: not to save bo in the case of RAS

RE: [PATCH] drm/amdgpu: update IP count INFO query

[AMD Official Use Only - General] Reviewed-by: Leo Liu -Original Message- From: Sundararaju, Sathishkumar Sent: Thursday, September 14, 2023 12:01 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian ; Liu, Leo ; Sundararaju, Sathishkumar Subject: [PATCH

RE: [PATCH v3 2/2] drm/amdgpu: update kernel vcn ring test

[AMD Official Use Only - General] -Original Message- From: Jamadar, Saleemkhan Sent: Monday, July 10, 2023 12:54 PM To: Jamadar, Saleemkhan ; amd-gfx@lists.freedesktop.org; Liu, Leo ; Gopalakrishnan, Veerabadhran (Veera) ; Sundararaju, Sathishkumar Cc: Koenig, Christian ; Rao

RE: [PATCH v2 2/2] drm/amdgpu: update kernel vcn ring test

[AMD Official Use Only - General] -Original Message- From: Jamadar, Saleemkhan Sent: Monday, July 10, 2023 4:24 AM To: Jamadar, Saleemkhan ; amd-gfx@lists.freedesktop.org; Liu, Leo ; Gopalakrishnan, Veerabadhran (Veera) ; Sundararaju, Sathishkumar Cc: Koenig, Christian ; Rao, Srinath

RE: [PATCH] drm/amdgpu/vcn: Need to pause dpg before stop dpg

[AMD Official Use Only - General] Hi Emily, Do you want to pause or un-pause dpg mode based on and change and commit message? With bare metal, before calling the stop, the state of dpg should be un-paused within the call the of amdgpu_vcn_idle_work_handler, is it not the case for SRIOV? Rega

Re: [PATCH] drm/amdgpu: vcn_4_0 set instance 0 init sched score to 1

[Public] Reviewed-by: Leo Liu From: amd-gfx on behalf of Sonny Jiang Sent: June 8, 2023 10:54 AM To: amd-gfx@lists.freedesktop.org Cc: Jiang, Sonny Subject: [PATCH] drm/amdgpu: vcn_4_0 set instance 0 init sched score to 1 From: Sonny Jiang Only vcn0 can pr

RE: [PATCH 1/4] drm/amdgpu/nv: don't expose AV1 if VCN0 is harvested

[AMD Official Use Only - General] The series are: Reviewed-by: Leo Liu -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: January 17, 2023 3:00 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 1/4] drm/amdgpu/nv: don't expose AV1 if VCN0 is ha

Re: [PATCH 3/3] drm/amdgpu/vcn: Add parameter to force (en/dis)abling indirect SRAM mode

; dri-de...@lists.freedesktop.org ; Lazar, Lijo ; Limonciello, Mario ; kernel-...@igalia.com ; Deucher, Alexander ; Zhu, James ; Liu, Leo ; Koenig, Christian Subject: Re: [PATCH 3/3] drm/amdgpu/vcn: Add parameter to force (en/dis)abling indirect SRAM mode On Mon, Jan 16, 2023 at 4:21 PM

RE: [PATCH] drm/amdgpu/vcn4: add missing encoder cap

[AMD Official Use Only - General] Reviewed-by: Leo Liu -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: January 10, 2023 5:48 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/vcn4: add missing encoder cap VCN4.x supports AV1 encod

RE: [PATCH v4] drm/amdgpu: add HW_IP_VCN_UNIFIED type

[AMD Official Use Only - General] Reviewed-by: Leo Liu -Original Message- From: Dong, Ruijing Sent: July 15, 2022 4:04 PM To: Koenig, Christian ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Liu, Leo ; Dong, Ruijing Subject: [PATCH v4] drm/amdgpu: add HW_IP_VCN_UNIFIED type

RE: [PATCH v3] drm/amdgpu: add comments to HW_IP_VCN_ENC

[AMD Official Use Only - General] Reviewed-by: Leo Liu -Original Message- From: Dong, Ruijing Sent: July 15, 2022 12:09 PM To: Koenig, Christian ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Liu, Leo ; Dong, Ruijing Subject: [PATCH v3] drm/amdgpu: add comments to

RE: [PATCH] drm/amdgpu: update VCN codec support for Yellow Carp

[AMD Official Use Only - General] Reviewed-by: Leo Liu -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: May 26, 2022 4:39 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu: update VCN codec support for Yellow Carp Supports AV1. Me

RE: [PATCH 1/2] drm/amdgpu/vcn: Update fw shared data structure

[AMD Official Use Only] The series are: Reviewed-by: Leo Liu -Original Message- From: Dong, Ruijing Sent: March 2, 2022 4:25 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Leo ; Deucher, Alexander Subject: [PATCH 1/2] drm/amdgpu/vcn: Update fw shared data structure Add fw log in fw

RE: [PATCH v4 2/3] drm/amdgpu: VCE avoid memory allocation during IB test

[AMD Official Use Only] 256 bytes alignment is for Video HW that is with GFX9, so it should be fine in general. Regards, Leo -Original Message- From: Koenig, Christian Sent: September 13, 2021 5:04 AM To: Pan, Xinhui ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Liu, Leo

Re: [PATCH] drm/amdgpu: Fix Gstreamer api vaapih264enc missing

[Public] On 2021-05-26 6:49 a.m., Christian König wrote: > Am 26.05.21 um 12:13 schrieb Li, Xin (Justin): >> since vcn decoding ring is not required, so just disable it. >> >> Cc: Alex.Deucher >> Cc: Christian.Konig >> Signed-off-by: Li.Xin.Justin >> Signed-off-by: Frank.Min >> --- >> driver

RE: [PATCH] drm/amdgpu/vcn3.0: add wptr/rptr reset/update for share memory

[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Leo Liu From: amd-gfx On Behalf Of Jiang, Sonny Sent: February 18, 2021 9:34 AM To: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu/vcn3.0: add wptr/rptr reset/update for share memory [AMD Official Use Only - Int

RE: [PATCH 4/4] drm/amdgpu: bump driver version for new video codec INFO ioctl query

[AMD Official Use Only - Internal Distribution Only] The series are: Reviewed-by: Leo Liu -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: January 27, 2021 12:33 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 4/4] drm/amdgpu: bump driver ver

RE: [PATCH] drm/amdgpu/vcn3.0: only SIENNA_CICHLID need specify instance for dec/enc

Reviewed-by: Leo Liu -Original Message- From: amd-gfx On Behalf Of James Zhu Sent: August 13, 2020 3:58 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, James Subject: [PATCH] drm/amdgpu/vcn3.0: only SIENNA_CICHLID need specify instance for dec/enc Only SIENNA_CICHLID(VCN3) has 2 unsymme

RE: [PATCH 2/2] drm/amdgpu/vcn3.0: remove extra asic type check

These 2 patches are: Reviewed-by: Leo Liu -Original Message- From: amd-gfx On Behalf Of James Zhu Sent: July 23, 2020 12:10 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, James Subject: [PATCH 2/2] drm/amdgpu/vcn3.0: remove extra asic type check vcn ip block is already selected based o

RE: [PATCH] drm/amdgpu: update dec ring test for VCN 3.0

[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Leo Liu From: Zhang, Boyuan Sent: July 22, 2020 5:50 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Leo Subject: [PATCH] drm/amdgpu: update dec ring test for VCN 3.0 [AMD Official Use Only - Internal Distribution Only] To

RE: [PATCH 1/2] Revert "drm/amdgpu/vcn: add shared memory restore after wake up from sleep."

The series are: Reviewed-by: Leo Liu -Original Message- From: amd-gfx On Behalf Of James Zhu Sent: July 16, 2020 9:15 AM To: amd-gfx@lists.freedesktop.org Cc: Zhu, James Subject: [PATCH 1/2] Revert "drm/amdgpu/vcn: add shared memory restore after wake up from sleep." This reverts comm

RE: [PATCH 5/5] drm/amd/sriov skip vcn powergating and dec_ring_test

Reviewed-by: Leo Liu -Original Message- From: Jack Zhang Sent: July 15, 2020 1:50 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Jack (Jian) ; Zhang, Hawking ; Liu, Leo Subject: [PATCH 5/5] drm/amd/sriov skip vcn powergating and dec_ring_test 1.Skip decode_ring test in VF, because

RE: [PATCH] drm/amdgpu: fix unused variable

Acked-by: Leo Liu -Original Message- From: amd-gfx On Behalf Of James Zhu Sent: June 18, 2020 12:52 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, James Subject: [PATCH] drm/amdgpu: fix unused variable SOC15_WAIT_ON_RREG's return value needn't always been handled by caller. new design

RE: [PATCH 2/2] drm/amdgpu/vcn2.5: Remove old DPG workaround

The 2 patches are: Reviewed-by: Leo Liu -Original Message- From: amd-gfx On Behalf Of James Zhu Sent: May 19, 2020 10:42 AM To: amd-gfx@lists.freedesktop.org Cc: Zhu, James Subject: [PATCH 2/2] drm/amdgpu/vcn2.5: Remove old DPG workaround SCRATCH2 is used to keep decode wptr as a work

RE: [PATCH] amdgpu/vcn: add dummy feedback message

[AMD Official Use Only - Internal Distribution Only] I think you need to create a MR for libdrm patch, and the tittle should be like "tests/amdgpu/vcn" Regards, Leo -Original Message- From: amd-gfx On Behalf Of James Zhu Sent: Monday, April 13, 2020 1:13 PM To: amd-gfx@lists.freedeskt

RE: [PATCH 1/3] drm/amdgpu: fix typo for vcn1 idle check

Series are: Reviewed-by: Leo Liu -Original Message- From: amd-gfx On Behalf Of James Zhu Sent: March 18, 2020 5:15 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, James Subject: [PATCH 1/3] drm/amdgpu: fix typo for vcn1 idle check fix typo for vcn1 idle check Signed-off-by: James Zhu

RE: [PATCH v5 2/4] drm/amdgpu/vcn: fix race condition issue for dpg unpause mode switch

This patch is Reviewed-by: Leo Liu -Original Message- From: amd-gfx On Behalf Of James Zhu Sent: March 11, 2020 4:50 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, James Subject: [PATCH v5 2/4] drm/amdgpu/vcn: fix race condition issue for dpg unpause mode switch Couldn't only rely on e

RE: [PATCH 1/2] drm/amdgpu/vcn: fix race condition issue for vcn start

With your patches, still seeing the hung with multiple processes of decode, encode, and transcode. I think we need find the root cause of that and give a comprehensive fix either from driver side or firmware side or both. Regards, Leo From: amd-gfx On Behalf Of Zhu, James Sent: Wednesday, Febr

RE: [PATCH] drm/amdgpu: enable VCN2.5 DPG mode for Arcturus

Reviewed-by: Leo Liu -Original Message- From: amd-gfx On Behalf Of James Zhu Sent: Monday, February 10, 2020 10:36 AM To: amd-gfx@lists.freedesktop.org Cc: Zhu, James Subject: [PATCH] drm/amdgpu: enable VCN2.5 DPG mode for Arcturus Enable VCN2.5 DPG mode for arcturus after below items

RE: [PATCH 2/2] drm/amdgpu/vcn1.0: remove duplicate defines

The value are different between VCN 1.0 and 2.x. Regards, Leo -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: January 15, 2020 5:16 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 2/2] drm/amdgpu/vcn1.0: remove duplicate defines These were a

RE: [PATCH] drm/amdgpu/vcn2.5: Silence a compiler warning

Reviewed-by: Leo Liu -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: December 18, 2019 11:52 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/vcn2.5: Silence a compiler warning Set r to 0 as a default value. Signed-off-by: Alex D

RE: [PATCH] drm/amdgpu/vcn: Enable VCN2.5 encoding

Reviewed-by: Leo Liu -Original Message- From: amd-gfx On Behalf Of Zhu, James Sent: Tuesday, October 22, 2019 10:49 AM To: amd-gfx@lists.freedesktop.org Cc: Zhu, James Subject: [PATCH] drm/amdgpu/vcn: Enable VCN2.5 encoding After VCN2.5 firmware (Version ENC: 1.1 Revision: 11), VCN2.5

Re: [PATCH] drm/amdgpu: fix structurally dead code vcn_v2_5_hw_init

On 2019-10-01 5:57 p.m., Gustavo A. R. Silva wrote: > > On 10/1/19 16:46, Liu, Leo wrote: > >>>>> + ring->sched.ready = true; >>>> This is redundant. all the sched->ready is initialized as true, please >>>> refer to drm_sch

[PATCH 1/2] drm/amdgpu/vcn: use amdgpu_ring_test_helper instead of

amdgpu_ring_test_ring, so it will determine whether the ring is ready Signed-off-by: Leo Liu Cc: Gustavo A. R. Silva --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 1 - drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 21 ++--- drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 18 ++

[PATCH 2/2] drm/amdgpu: add a comment to VCN 2.5 encode ring

Signed-off-by: Leo Liu Suggested-by: Gustavo A. R. Silva Cc: Gustavo A. R. Silva --- drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c index cc19363f..0d5c95d73b63 100644 -

Re: [PATCH] drm/amdgpu: fix structurally dead code vcn_v2_5_hw_init

On 2019-10-01 5:43 p.m., Gustavo A. R. Silva wrote: > Hi, > > On 10/1/19 16:29, Liu, Leo wrote: >> On 2019-10-01 1:16 p.m., Gustavo A. R. Silva wrote: >>> Notice that there is a *continue* statement in the middle of the >>> for loop and that prevents the c

Re: [PATCH] drm/amdgpu: fix structurally dead code vcn_v2_5_hw_init

On 2019-10-01 1:16 p.m., Gustavo A. R. Silva wrote: > Notice that there is a *continue* statement in the middle of the > for loop and that prevents the code below from ever being reached: > > r = amdgpu_ring_test_ring(ring); > if (r) { > ring->sched.ready = false; >

Re: [PATCH 2/2] drm/amdgpu: enable VCN DPG for Renoir

On 2019-08-15 2:19 p.m., Thai, Thong wrote: > Enable VCN Dynamic Powergating on Renoir devices. > > This will also enable indirect SRAM loading of VCN firmware on Renoir. This will enable indirect SRAM loading for VCN DPG mode initialization. With that fixed, the patch is: Reviewed-by: Leo Liu

Re: [PATCH 1/2] Revert "drm/amdgpu: use direct loading on renoir vcn for the moment"

This patch is: Reviewed-by: Leo Liu On 2019-08-15 2:19 p.m., Thai, Thong wrote: > This reverts commit 69fcd7347f6fb11edc7eaea7c7b9cff0044ce17e. > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 9 +++-- > drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 9 +++-- > 2 files changed, 6 inserti

Re: [PATCH] drm/amd/amdgpu: workaround for UVD busy status

On 2019-08-14 7:11 a.m., Kenneth Feng wrote: > On Vega20, tools depends on UVD_STATUS.VCPU_REPORT bit0 > to decide if UVD instances are in busy state or idle state. > This workaround fixes the issue that tools always fetch the > UVD instances state as busy state no matter if there is a UVD work.

Re: [PATCH v3 2/2] drm/amd/amdgpu/vcn_v2_0: Move VCN 2.0 specific dec ring test to vcn_v2_0

On 2019-07-25 2:15 p.m., Thai, Thong wrote: > VCN 2.0 firmware now requires a packet start command to be sent before > any other decode ring buffer command. > > Signed-off-by: Thong Thai > --- > drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 32 ++- > 1 file changed, 31 insert

Re: [PATCH v3 1/2] drm/amd/amdgpu/vcn_v2_0: Mark RB commands as KMD commands

On 2019-07-25 2:15 p.m., Thai, Thong wrote: > Sets the CMD_SOURCE bit for VCN 2.0 Decoder Ring Buffer commands. This > bit was previously set by the RBC HW on older firmware. Newer firmware > uses a SW RBC and this bit has to be set by the driver. > > Signed-off-by: Thong Thai > --- > drivers/g

Re: [PATCH] drm/amd/amdgpu/vcn_v2_0: Set CMD_SOURCE for RB commands

Please separate the patches to 2 patches. i. e. New ring test as one patch. Regards, Leo From: amd-gfx on behalf of Thai, Thong Sent: July 24, 2019 3:50:47 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amd/amdgpu/vcn_v2_0: Set CMD_SOURCE for RB comm

[PATCH] drm/amdgpu: use VCN firmware offset for cache window

Since we are using the signed FW now, and also using PSP firmware loading, but it's still potential to break driver when loading FW directly instead of PSP, so we should add offset. Signed-off-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 3 --- 1 file changed, 3 deletions(-) diff --g

[PATCH] drm/amdgpu/: use VCN firmware offset for cache window

Since we are using the signed FW now, and also using PSP firmware loading, but it's still potential to break driver when loading FW directly instead of PSP, so we should add offset. Signed-off-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 3 --- 1 file changed, 3 deletions(-) diff --g

Re: [PATCH] drm/amdgpu: fix ring test failure issue during s3 in vce 3.0

ore, a solution comes to mind: to update rptr later for initial rptr value. Tests prove it working in Chrome platforms. Fyi~ BR, Louis From: Liu, Leo <mailto:leo@amd.com> Sent: Monday, May 27, 2019 9:01 PM To: S, Shirish <mailto:shiris...@amd.com>; Grodzovsky, Andrey <

Re: [PATCH] drm/amdgpu: fix ring test failure issue during s3 in vce 3.0

On 5/27/19 3:42 AM, S, Shirish wrote: From: Louis Li [What] vce ring test fails consistently during resume in s3 cycle, due to mismatch read & write pointers. On debug/analysis its found that rptr to be compared is not being correctly updated/read, which leads to t

[PATCH 1/2] drm/amdgpu: move the VCN DPG mode read and write to VCN

Since this is VCN specific and only used by VCN Signed-off-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 20 drivers/gpu/drm/amd/amdgpu/soc15_common.h | 21 - 2 files changed, 20 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/a

[PATCH 2/2] drm/amdgpu: make VCN DPG pause mode detached from general VCN

It should be attached to VCN 1.0 Signed-off-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 130 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 2 + drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 132 +++- 3 files changed, 135 insertions(+), 129 dele

Re: [PATCH 6/6] drm/amdgpu: remove MM engine related WARN_ON for user fence

On 5/8/19 1:45 PM, Alex Deucher wrote: > [CAUTION: External Email] > > On Wed, May 8, 2019 at 11:51 AM Liu, Leo wrote: >> Since the check aleady done with command submission check > Missing signed-off-by. > > patches 1-5 are: > Reviewed-by: Alex Deucher > >

[PATCH 1/6] drm/amdgpu: add no_user_fence flag to ring funcs

So we can generalize the no user fence supported engine Signed-off-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h index d7fae2676269..cdddce938bf5 10

[PATCH 5/6] drm/amdgpu: check no_user_fence flag for engines

To replace checking ring type and make them generic Signed-off-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c index d0e221c8d940..d72

[PATCH 6/6] drm/amdgpu: remove MM engine related WARN_ON for user fence

Since the check aleady done with command submission check --- drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 2 -- drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 2 -- drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c | 2 -- drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 4 drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c |

[PATCH 4/6] drm/amdgpu/VCN: set no_user_fence flag to true

There is no user fence support for VCN Signed-off-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c index 3dbc51f9d3b9..ac2e5a1eb576 100644 --- a/drivers/gpu/

[PATCH 3/6] drm/amdgpu/VCE: set no_user_fence flag to true

There is no user fence support for VCE Signed-off-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/vce_v2_0.c | 1 + drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 2 ++ drivers/gpu/drm/amd/amdgpu/vce_v4_0.c | 1 + 3 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v2_0.c b/driver

[PATCH 2/6] drm/amdgpu/UVD: set no_user_fence flag to true

There is no user fence support for UVD Signed-off-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 1 + drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c | 1 + drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 3 +++ drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 2 ++ 4 files changed, 7 insertions(+) diff --git a/

Re: [PATCH] drm/amdgu/vce_v3: start vce block before ring test

On 2/4/19 7:49 AM, Koenig, Christian wrote: > Am 04.02.19 um 13:44 schrieb S, Shirish: >> vce ring test fails during resume since mmVCE_RB_RPTR* >> is not intitalized/updated. >> >> Hence start vce block before ring test. > Mhm, I wonder why this ever worked. But yeah, same problem seems to > exit

Re: [PATCH] drm/amdgpu: Add new VegaM pci id

Reviewed-by: Leo Liu On 12/21/18 11:36 AM, Alex Deucher wrote: > ping? > > On Thu, Dec 20, 2018 at 10:10 AM Alex Deucher wrote: >> Add a new pci id. >> >> Signed-off-by: Alex Deucher >> Cc: sta...@vger.kernel.org >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 + >> 1 file changed, 1 i

RE: [PATCH v2] drm/amdgpu:Improves robustness of SOC15_WAIT_ON_RREG

Reviewed-by: Leo Liu -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Zhu, James Sent: Monday, December 17, 2018 9:17 AM To: amd-gfx@lists.freedesktop.org Cc: jzh...@gmail.com Subject: [PATCH v2] drm/amdgpu:Improves robustness of SOC15_WAIT_ON_

Re: [PATCH v2 6/6] drm/amdgpu/vcn:Remove bit 31 for scratch2 to indicate the WA is active

The series are: Acked-by: Leo Liu On 12/13/18 1:08 PM, Zhu, James wrote: > Remove bit 31 for scratch2 to indicate the Hardware bug work around is active. > > Signed-off-by: James Zhu > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

[PATCH libdrm] tests/amdgpu/vcn: fix the nop command in IBs

Just make them properly i.e. put 0 to the Nop reg Signed-off-by: Leo Liu --- tests/amdgpu/vcn_tests.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/tests/amdgpu/vcn_tests.c b/tests/amdgpu/vcn_tests.c index d9f05af8..859ec496 100644 --- a/tests/amdgpu/vcn

Re: [PATCH] drm/amdgpu/vcn:Fixed S3 hung issue

Please re-state the patch subject instead of "Fixed S3 hung issue" With that fixed, the patch is Reviewed-by: Leo Liu On 12/4/18 10:31 AM, Zhu, James wrote: > Replace vcn_v1_0_stop with vcn_v1_0_set_powergating_state during suspend, > to keep adev->vcn.cur_state update. It will fix VCN S3 hung