[AMD Official Use Only - AMD Internal Distribution Only]
Reviewed-by: Leo Liu <leo....@amd.com>
> -----Original Message-----
> From: Sundararaju, Sathishkumar <sathishkumar.sundarar...@amd.com>
> Sent: July 29, 2025 3:52 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Leo <leo....@amd.com>; Sundararaju, Sathishkumar
> <sathishkumar.sundarar...@amd.com>
> Subject: [PATCH] drm/amdgpu: Fix unintended error log in VCN5_0_0
>
> The error log is supposed to be gaurded under if failure condition.
>
> Fixes: 29ef09ead572 ("drm/amdgpu: Check vcn sram load return value")
> Signed-off-by: Sathishkumar S <sathishkumar.sundarar...@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c
> b/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c
> index 59794bd3d747..378b94d8a835 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c
> @@ -754,9 +754,10 @@ static int vcn_v5_0_0_start_dpg_mode(struct
> amdgpu_vcn_inst *vinst,
>
> if (indirect) {
> ret = amdgpu_vcn_psp_update_sram(adev, inst_idx, 0);
> - dev_err(adev->dev, "%s: vcn sram load failed %d\n",
> __func__, ret);
> - if (ret)
> + if (ret) {
> + dev_err(adev->dev, "%s: vcn sram load failed %d\n",
> __func__, ret);
> return ret;
> + }
> }
>
> ring = &adev->vcn.inst[inst_idx].ring_enc[0];
> --
> 2.48.1
