tmas...@amd.com:
>
> Xinhui Pan
> Hamza Mahfooz
>
> I tried to contact Alex Deucher and Christian König back in early
> Februrary, but received no reply.
>
> To avoid warning emails from the future, remove Xinhui Pan from
> MAINTAINERS and add Hamza Mahfooz to .get_ma
Cc: Daniel Wheeler
Aric Cyr (1):
drm/amd/display: 3.2.310
Austin Zheng (1):
drm/amd/display: Populate Power Profile In Case of Early Return
Chris Park (1):
drm/amd/display: Ignore scalar validation failure if pipe is phantom
Dillon Varone (1):
drm/amd/display: Enable Request rate limit
From: Aric Cyr
This version brings along the following:
- DC core fixes
- DCN35 fix
- DCN4+ fixes
- DML2 fix
- New SPL features
Reviewed-by: Zaeem Mohamed
Signed-off-by: Aric Cyr
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/dc/dc.h | 2 +-
1 file changed, 1 insertion(+), 1
-by: Samson Tam
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/dc/spl/dc_spl.c | 34 -
1 file changed, 20 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/spl/dc_spl.c
b/drivers/gpu/drm/amd/display/dc/spl/dc_spl.c
index da477406a
cases.
Cc: sta...@vger.kernel.org # 6.11+
Reviewed-by: Nicholas Kazlauskas
Signed-off-by: Ovidiu Bunea
Signed-off-by: Hamza Mahfooz
---
.../drm/amd/display/dc/dccg/dcn35/dcn35_dccg.c| 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd
Signed-off-by: Dillon Varone
Signed-off-by: Hamza Mahfooz
---
.../src/dml2_core/dml2_core_dcn4_calcs.c | 6 +
.../display/dc/hubbub/dcn10/dcn10_hubbub.h| 8 ++-
.../display/dc/hubbub/dcn20/dcn20_hubbub.h| 1 +
.../display/dc/hubbub/dcn401/dcn401_hubbub.c | 24
...@vger.kernel.org
Fixes: fc8c959496fa ("drm/amd/display: Update Interface to Check UCLK DPM")
Reviewed-by: Dillon Varone
Signed-off-by: Austin Zheng
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/dc/core/dc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/d
: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/dc/spl/dc_spl.c | 63 +++--
drivers/gpu/drm/amd/display/dc/spl/dc_spl.h | 2 +
2 files changed, 48 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/spl/dc_spl.c
b/drivers/gpu/drm/amd/display/dc/spl/dc_spl.c
valid memory
accesses if the refcount was supposed to go up.
[How]
Cache and re-apply current refcount when restoring plane states.
Cc: sta...@vger.kernel.org
Reviewed-by: Josip Pavic
Signed-off-by: Joshua Aberback
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/dc/core/dc.c | 3 +
preferred pipe check.
v2: Added pipe type check for DPP pipe type before executing head pipe
check in the pipe selection logic in DML2 to avoid NULL pointer
de-reference.
Cc: sta...@vger.kernel.org
Reviewed-by: Nicholas Kazlauskas
Signed-off-by: Yihan Zhu
Signed-off-by: Hamza Mahfooz
]
Ignore scalar validation failure if the pipe validation is marked as
phantom pipe.
Cc: sta...@vger.kernel.org # 6.11+
Reviewed-by: Dillon Varone
Signed-off-by: Chris Park
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 8
1 file changed, 8 insertions
From: Fudongwang
Garbage will show due to dig is on. So blank stream needed.
Cc: sta...@vger.kernel.org
Reviewed-by: Nicholas Kazlauskas
Signed-off-by: Fudongwang
Signed-off-by: Hamza Mahfooz
---
.../gpu/drm/amd/display/dc/hwss/dcn31/dcn31_hwseq.c| 10 ++
1 file changed, 6
t dml pointers in new_state to NULL and avoid invalid
pointer
Cc: sta...@vger.kernel.org
Reviewed-by: Dillon Varone
Signed-off-by: Ryan Seto
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/dc/core/dc_state.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/dr
-off-by: Hamza Mahfooz
---
.../amd/display/dc/link/protocols/link_dp_capability.c| 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
-by: Rodrigo Siqueira
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 1d47719e7
preferred pipe check.
Cc: sta...@vger.kernel.org
Reviewed-by: Nicholas Kazlauskas
Signed-off-by: Yihan Zhu
Signed-off-by: Hamza Mahfooz
---
.../display/dc/dml2/dml2_dc_resource_mgmt.c | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display
From: Aric Cyr
This version brings along the following:
- DML2 fixes
- DP fixes
- DPMS fix
- HPD fixes
- Misc cleanup
- ODM fix
- Replay fix
- SPL fix
Reviewed-by: Leo Li
Signed-off-by: Aric Cyr
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/dc/dc.h | 2 +-
.../amd
From: Rodrigo Siqueira
This commit removes a legacy debug_defaults_diags struct.
Reviewed-by: Leo Li
Signed-off-by: Rodrigo Siqueira
Signed-off-by: Hamza Mahfooz
---
.../amd/display/dc/resource/dcn10/dcn10_resource.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/drivers
ned-off-by: Dillon Varone
Signed-off-by: Hamza Mahfooz
---
.../dc/dml2/dml21/src/dml2_pmo/dml2_pmo_dcn4_fams2.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git
a/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_pmo/dml2_pmo_dcn4_fams2.c
b/drivers/gpu/drm/amd/disp
From: Emily Nie
[Why]
IGT displays Dmesg warnings which are likely false
[How]
Disabling p-state checks leading to this warning for DCN31 and DCN314
Reviewed-by: Nicholas Kazlauskas
Signed-off-by: Emily Nie
Signed-off-by: Hamza Mahfooz
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 23
From: Tom Chung
Panel Replay feature may also use the same variable with PSR.
Change the variable name and make it not specify for PSR.
Reviewed-by: Leo Li
Signed-off-by: Tom Chung
Signed-off-by: Hamza Mahfooz
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 22
From: JinZe Xu
[Why]
If driver allocated region6 size is not same as the size in firmware,
dmcub won't enable region6.
[How]
Use region6 size in dmcub_fw_meta instead of a constant value.
Reviewed-by: Nicholas Kazlauskas
Signed-off-by: JinZe Xu
Signed-off-by: Hamza Mahfooz
---
driver
PSR.
Reviewed-by: Leo Li
Signed-off-by: Tom Chung
Signed-off-by: Hamza Mahfooz
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 111 +-
.../amd/display/amdgpu_dm/amdgpu_dm_crtc.c| 5 +-
2 files changed, 59 insertions(+), 57 deletions(-)
diff --git a/drivers/gpu/drm/amd
-by: Austin Zheng
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/dc/spl/dc_spl.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/spl/dc_spl.c
b/drivers/gpu/drm/amd/display/dc/spl/dc_spl.c
index a29a9f131e04
From: Revalla Hari Krishna
[Why]
String literals must be assigned to const char pointers.
[How]
By adding const keyword to fix compilation errors.
Reviewed-by: Lohita Mudimela
Signed-off-by: Revalla Hari Krishna
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/dc/dcn10
-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/dc/dc_types.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/display/dc/dc_types.h
b/drivers/gpu/drm/amd/display/dc/dc_types.h
index 1fd030e3f4be..edf4df1d03b5 100644
--- a/drivers/gpu/drm/amd/display/dc/dc_types.h
+++ b
From: Leon Huang
[Why]
HPD error status does not cover Replay desync error status
while executing autotests and CTS tests.
[How]
Refactor the checking flow, reporting the HPD error based on
different eDP feature.
Reviewed-by: Robin Chen
Signed-off-by: Leon Huang
Signed-off-by: Hamza Mahfooz
Cc: Daniel Wheeler
Aric Cyr (1):
drm/amd/display: 3.2.309
Aurabindo Pillai (1):
drm/amd/display: Read DP tunneling support only for DPIA endpoints
Austin Zheng (1):
drm/amd/display: Update SPL Taps Required For Integer Scaling
Dillon Varone (1):
drm/amd/display: Require minimum VBlank
On 10/4/24 16:44, Alex Deucher wrote:
On Fri, Oct 4, 2024 at 4:43 PM Hamza Mahfooz wrote:
Since, two suspend-resume cycles are required to enter hibernate and,
since we only need to enable idle optimizations in the first cycle
(which is pretty much equivalent to s2idle). We can check in_s0ix
(from display's perspective).
Cc: sta...@vger.kernel.org # 6.10+
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/dr
On 9/19/24 13:29, Alex Deucher wrote:
On Thu, Sep 19, 2024 at 12:06 PM Mario Limonciello
wrote:
On 9/19/2024 11:03, Alex Hung wrote:
A minor comment (see inline below).
Otherwise
Reviewed-by: Alex Hung
On 2024-09-18 15:38, Mario Limonciello wrote:
Some manufacturers have intentionally pu
It is enabled by W=1 and amdgpu has a clean build with it enabled. So,
to make sure we block future instances of it from showing up on
our driver, enable it by default for the module.
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/amdgpu/Makefile | 1 +
1 file changed, 1 insertion
On 5/23/24 09:37, Jani Nikula wrote:
Since commit a61ddb4393ad ("drm: enable (most) W=1 warnings by default
across the subsystem"), most of the extra warnings in the driver
Makefile are redundant. Remove them.
Note that -Wmissing-declarations and -Wmissing-prototypes are always
enabled by defaul
On 8/28/24 10:06, Jani Nikula wrote:
On Wed, 28 Aug 2024, Hamza Mahfooz wrote:
On 8/12/24 08:23, Jani Nikula wrote:
Instead of just smashing jiffies into a GUID, use guid_gen() to generate
RFC 4122 compliant GUIDs.
Signed-off-by: Jani Nikula
---
Acked-by: Hamza Mahfooz
I would prefer
On 8/12/24 08:23, Jani Nikula wrote:
Instead of just smashing jiffies into a GUID, use guid_gen() to generate
RFC 4122 compliant GUIDs.
Signed-off-by: Jani Nikula
---
Acked-by: Hamza Mahfooz
I would prefer to take this series through the amdgpu tree though,
assuming nobody minds.
Side
connected. This
caused black screens on driver disable with an MST daisy chain hooked
up.
[How]
Refactor the function to correctly return the number of FEs connected
to the input BE. Also, rename it for clarity.
Reviewed-by: Nicholas Kazlauskas
Signed-off-by: Nicholas Susanto
Signed-off-by: Hamza
From: Dillon Varone
PMO assumes that like timings can be synchronized, but DC only allows
this if the signal types match.
Cc: sta...@vger.kernel.org
Reviewed-by: Austin Zheng
Signed-off-by: Dillon Varone
Signed-off-by: Hamza Mahfooz
---
.../display/dc/dml2/dml21/src/dml2_pmo
From: Hansen Dsouza
Always allow un-gating. Follow legacy workaround for repeated
dppclk dto updates
Reviewed-by: Muhammad Ahmed
Signed-off-by: Hansen Dsouza
Signed-off-by: Hamza Mahfooz
---
.../amd/display/dc/dccg/dcn20/dcn20_dccg.h| 11 +++
.../amd/display/dc/dccg/dcn35/dcn35_dccg.c
From: Aric Cyr
This version brings along the following:
- DCN35 fixes
- DML2 fixes
- IPS fixes
- ODM fixes
- Miscellaneous cleanups
- MST fixes
- SPL fixes
Acked-by: Aurabindo Pillai
Signed-off-by: Aric Cyr
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/dc/dc.h
From: Relja Vojvodic
- Add interface for controlling shapness level input into DCN.
- Update SPL to support custom sharpness values.
- Add support for different sharpness values depending on YUV/RGB
content.
Reviewed-by: Samson Tam
Signed-off-by: Relja Vojvodic
Signed-off-by: Hamza Mahfooz
.
Cc: sta...@vger.kernel.org
Reviewed-by: Sung joon Kim
Reviewed-by: Nicholas Kazlauskas
Signed-off-by: Gabe Teeger
Signed-off-by: Hamza Mahfooz
---
.../amd/display/dc/dml2/dml2_internal_types.h | 2 +-
.../display/dc/dml2/dml2_translation_helper.c | 67 +--
.../display/dc
From: Dillon Varone
This reverts commit 3b837c45668c3026fd09145904692ba1130c5d12.
It is causing graphics hangs.
Reviewed-by: Martin Leung
Signed-off-by: Dillon Varone
Signed-off-by: Hamza Mahfooz
---
.../drm/amd/display/dc/core/dc_hw_sequencer.c | 9 +---
.../amd/display/dc/hwss/dcn20
From: Meenakshikumar Somasundaram
[Why]
To provide option to dpia control power management
[How]
By adding disable_usb4_pm_support bit field in dpia_debug option to
control dpia power management
Reviewed-by: Jun Lei
Signed-off-by: Meenakshikumar Somasundaram
Signed-off-by: Hamza Mahfooz
Signed-off-by: Hamza Mahfooz
---
.../gpu/drm/amd/display/dc/dccg/dcn35/dcn35_dccg.c | 14 +-
.../gpu/drm/amd/display/dc/dccg/dcn35/dcn35_dccg.h | 1 +
.../drm/amd/display/dc/hwss/dcn35/dcn35_hwseq.c| 4
drivers/gpu/drm/amd/display/dc/inc/hw/dccg.h | 1 +
4 files
dc, then allow IPS afterwards (if it
was previously allowed).
Cc: sta...@vger.kernel.org # 6.10+
Reviewed-by: Aurabindo Pillai
Reviewed-by: Roman Li
Signed-off-by: Leo Li
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 13 -
1 file changed, 12
ng
Signed-off-by: Samson Tam
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/dc/dc_spl_translate.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dc_spl_translate.c
b/drivers/gpu/drm/amd/display/dc/dc_spl_translate.c
index 75
: 2dd29403b206 ("DCN35 set min dispclk to 50Mhz")
Reviewed-by: Nicholas Kazlauskas
Signed-off-by: Nicholas Susanto
Signed-off-by: Hamza Mahfooz
---
.../gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c| 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drive
Tam
Signed-off-by: Hamza Mahfooz
---
.../drm/amd/display/dc/dml2/dml21/dml21_translation_helper.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
a/drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_translation_helper.c
b/drivers/gpu/drm/amd/display/dc/dml2/dml21
From: Daniel Sa
[Why]
Some asserts are always hit on startup/Pnp when they should only be used
to indicate when something has gone wrong.
[How]
Ignore result of getting function from bios cmd table for newer asics.
Reviewed-by: Jun Lei
Signed-off-by: Daniel Sa
Signed-off-by: Hamza Mahfooz
Cc: Daniel Wheeler
Aric Cyr (1):
drm/amd/display: 3.2.299
Daniel Sa (1):
drm/amd/display: only trigger BIOS related assert for older ASICs
Dillon Varone (2):
Revert "drm/amd/display: Wait for all pending cleared before full
update"
drm/amd/display: Block timing sync for different si
On 8/19/24 22:04, Mario Limonciello wrote:
From: Mario Limonciello
If the dGPU is off, then reading the sysfs files with a sensor monitoring
application will wake it. Change the behavior to return an error when the
dGPU is in D3cold.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/
On 8/23/24 00:35, Zaeem Mohamed wrote:
Remove TODO from spl_os_types.h
Signed-off-by: Zaeem Mohamed
s/unecessary TODO/unnecessary TODO in
With that addressed:
Reviewed-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/dc/spl/spl_os_types.h | 1 -
1 file changed, 1 deletion(-)
diff
On 8/22/24 20:14, Zaeem Mohamed wrote:
Use appropriate SPDX copyright for spl_os_types.h
Signed-off-by: Zaeem Mohamed
Reviewed-by: Hamza Mahfooz
---
.../gpu/drm/amd/display/dc/spl/spl_os_types.h | 29 +++
1 file changed, 4 insertions(+), 25 deletions(-)
diff --git a
) isn't necessary on AMD hardware.
Also, patches 2-3 in this series provide even laxer policies and they
are intentionally separated from patch #1. This way, if issues with them
are encountered in the wild, it should be easy to bisect the issue to
those patches.
Hamza Mahfooz (3):
drm/amd/di
Ideally, we want to enable immediate vblank disable, when possible and
we should be able to do so on DCN35+, if PSR isn't supported by a given
CRTC.
Suggested-by: Leo Li
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 ++-
1 file changed, 6 inser
much longer by default than is required on
AMD hardware).
Suggested-by: Leo Li
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
This also allows us to mimic how vblanking is handled by the windows
amdgpu driver.
Signed-off-by: Hamza Mahfooz
---
v3: use a less conservative policy
v4: drop TODO, use simplified calculation from Michel, use
DIV64_U64_ROUND_UP() and use a different policy.
---
.../gpu/drm/amd/display
lable video memory, with a default of 32. Adapt this for
the new client interface.
v2:
- style changes
Signed-off-by: Thomas Zimmermann
Cc: Alex Deucher
Cc: "Christian König"
Cc: Xinhui Pan
Tested-by: Hamza Mahfooz
Acked-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/amdgpu/am
This also allows us to mimic how vblanking is handled by the windows
amdgpu driver.
Signed-off-by: Hamza Mahfooz
---
v3: use a less conservative policy
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 38 ---
1 file changed, 33 insertions(+), 5 deletions(-)
diff --git a
We don't actually need to request that the compositor does a full
modeset to modify the panel power savings level, we can instead
just make a request to DMUB, to set the new level dynamically.
Cc: Harry Wentland
Cc: Leo Li
Cc: Mario Limonciello
Cc: Sebastian Wick
Signed-off-by: Hamza Ma
entering D3cold.
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index a312c74f1e81..1169b0de7760
set to max level, ignoring
previous value.
With the help of Arch Linux team, we was able to track bad commit to
this:
https://gitlab.freedesktop.org/agd5f/linux/-/commit/63d0b87213a0ba241b3fcfba3fe7b0aed0cd1cc5
Hamza Mahfooz, in case you missed it, that is a patch of yours:
63d0b87213a0ba (&quo
This reverts commit 9d8c094ddab05db88d183ba82e23be807848cad8.
It was merged without meeting userspace requirements.
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 4 --
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 52 ++-
.../gpu/drm/amd
This reverts commit 76299a557f36d624ca32500173ad7856e1ad93c0.
It was merged without meeting userspace requirements.
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/drm_connector.c | 48 -
include/drm/drm_connector.h | 2 --
include/drm/drm_mode_config.h
On 7/31/24 04:36, Jani Nikula wrote:
On Tue, 30 Jul 2024, Hamza Mahfooz wrote:
Video Format Data Blocks (VFDBs) contain the necessary information that
needs to be fed to the Optimized Video Timings (OVT) Algorithm.
Also, we require OVT support to cover modes that aren't supported by
ea
e OVT Algorithm, to extract all of the missing OVT
modes.
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1442
Suggested-by: Karol Herbst
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/drm_edid.c | 426
include/drm/drm_connector.h | 12 +
2 files ch
tor_type ==
DRM_MODE_CONNECTOR_WRITEBACK)
Fixes: fa7041d9d2fc ("drm/amd/display: Fix ineffective setting of max bpc
property")
Reported-by: Dan Carpenter
Cc: Tom Chung
Cc: Rodrigo Siqueira
Cc: Roman Li
Cc: Hersen Wu
Cc: Alex Hung
Cc: Aurabindo Pillai
Cc: Harry Wentland
Cc: Hamza
Hi Sasha,
On 7/16/24 10:24, Sasha Levin wrote:
From: Tom Chung
[ Upstream commit 6b8487cdf9fc7bae707519ac5b5daeca18d1e85b ]
[Why]
Sometimes the new_crtc_state->vrr_infopacket did not sync up with the
current state.
It will affect the update_freesync_state_on_stream() does not update
the state
On 7/10/24 04:43, Daniel Vetter wrote:
On Tue, Jul 09, 2024 at 10:02:08AM -0400, Hamza Mahfooz wrote:
On 7/9/24 06:09, Daniel Vetter wrote:
On Tue, Jul 09, 2024 at 11:32:11AM +0200, Daniel Vetter wrote:
On Mon, Jul 08, 2024 at 04:29:07PM -0400, Hamza Mahfooz wrote:
Hook up
On 7/3/24 01:17, Mario Limonciello wrote:
During the Display Next hackfest 2024 one of the topics discussed
was the need for compositor to be able to relay intention to drivers
that color fidelity is preferred over power savings.
To accomplish this a new optional DRM property is being introduced
On 7/9/24 06:09, Daniel Vetter wrote:
On Tue, Jul 09, 2024 at 11:32:11AM +0200, Daniel Vetter wrote:
On Mon, Jul 08, 2024 at 04:29:07PM -0400, Hamza Mahfooz wrote:
Hook up drm_crtc_set_vblank_offdelay() in amdgpu_dm, so that we can
enable PSR more quickly for displays that support it.
Signed
Hook up drm_crtc_set_vblank_offdelay() in amdgpu_dm, so that we can
enable PSR more quickly for displays that support it.
Signed-off-by: Hamza Mahfooz
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 30 ++-
1 file changed, 22 insertions(+), 8 deletions(-)
diff --git a
: Hamza Mahfooz
---
drivers/gpu/drm/drm_vblank.c | 31 ++-
include/drm/drm_vblank.h | 7 +++
2 files changed, 33 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c
index 702a12bc93bd..4f475131a092 100644
--- a
We want all DML changes to be reviewed by Chaitanya or Jun. So, add an
entry for DML to MAINTAINERS.
Suggested-by: Rodrigo Siqueira
Signed-off-by: Hamza Mahfooz
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 7fec8ddb8d5b..d2fb60fee7e8
On 6/24/24 09:58, Alex Deucher wrote:
Leftover copy pasta from original code.
Signed-off-by: Alex Deucher
Cc: harry.wentl...@amd.com
Reviewed-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/dc/dcn301/Makefile | 11 ++-
drivers/gpu/drm/amd/display/dc/dcn31/Makefile | 10
From: Anthony Koo
- Add new condition for PSR exit due to ESD recovery
- Add new VB scaling feature for ABM by interpolating between
existing VB parameters, allowing driver to have fine grain
scaled VB levels between 0 - 250
Acked-by: Hamza Mahfooz
Signed-off-by: Anthony Koo
e is pointing
to an OTG master before operate in the old OTG master reference. If it's
not, the function must set the old OTG reference to NULL and avoid
calling resource_get_opp_heads_for_otg_master before the context is
updated.
Reviewed-by: Wenjing Liu
Acked-by: Hamza Mahfooz
Co-deve
From: Ivan Lipski
These portions of code are flagged as 'UNUSED_VALUE' by the
Coverity analysis since the assigned values of these vars
are never used in the code.
Reviewed-by: Alex Hung
Reviewed-by: Aurabindo Pillai
Acked-by: Hamza Mahfooz
Signed-off-by: Ivan Lipski
---
.
y: Harry Wentland
Acked-by: Hamza Mahfooz
Signed-off-by: Alex Hung
---
drivers/gpu/drm/amd/display/dc/dml2/display_mode_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dml2/display_mode_core.c
b/drivers/gpu/drm/amd/display
From: Alex Hung
The null checks for res_pool->dccg are redundant as it was already
dereferenced previously, as reported by Coverity; therefore the
null checks are removed.
This fixes 6 REVERSE_INULL issues reported by Coverity.
Reviewed-by: Harry Wentland
Acked-by: Hamza Mahfooz
Signed-
-by: Hamza Mahfooz
Signed-off-by: Alex Hung
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +++---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 2 +-
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 3 ---
3 files changed, 4 insertions(+), 7 deleti
From: Aric Cyr
This version brings along the following:
- DCN401 fixes
- DPIA fixes
- DML21 fixes
- Misc Coverity fixes
Acked-by: Hamza Mahfooz
Signed-off-by: Aric Cyr
---
drivers/gpu/drm/amd/display/dc/dc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm
From: Alex Hung
The null checks are redundant as they were already dereferenced
previously, as reported by Coverity; therefore the null checks
are removed.
This fixes 7 REVERSE_INULL issues reported by Coverity.
Reviewed-by: Harry Wentland
Acked-by: Hamza Mahfooz
Signed-off-by: Alex Hung
From: Alex Hung
The null checks for context are redundant as it was already
dereferenced previously, as reported by Coverity; therefore
the null checks are removed.
This fixes 2 REVERSE_INULL issues reported by Coverity.
Reviewed-by: Harry Wentland
Acked-by: Hamza Mahfooz
Signed-off-by: Alex
From: Alvin Lee
Need to reconfigure ODM when resyncing FIFO because on OTG disable we
clear all ODM programming
Reviewed-by: Nicholas Kazlauskas
Acked-by: Hamza Mahfooz
Signed-off-by: Alvin Lee
---
.../amd/display/dc/hwss/dcn314/dcn314_hwseq.c | 19 ++-
.../amd/display/dc
From: Alex Hung
dc_state_get_stream_status dc_state_get_paired_subvp_stream and other
functions can return null, and therefore null must be checked before
status can be used.
This fixes 21 NULL_RETURNS issues reported by Coverity.
Reviewed-by: Harry Wentland
Acked-by: Hamza Mahfooz
Signed
From: Alex Hung
The null checks for opp are redundant as they were already
dereferenced previously, as reported by Coverity; therefore
the null checks are removed.
This fixes 2 REVERSE_INULL issues reported by Coverity.
Reviewed-by: Harry Wentland
Acked-by: Hamza Mahfooz
Signed-off-by: Alex
HWSS
- update_plane_addr should only be public, as it's used outside HWSS
Reviewed-by: Aric Cyr
Acked-by: Hamza Mahfooz
Signed-off-by: Joshua Aberback
---
.../gpu/drm/amd/display/dc/hwss/dce110/dce110_hwseq.c | 1 -
.../gpu/drm/amd/display/dc/hwss/dcn10/dcn10_hwseq.c| 10 +-
drive
From: Ivan Lipski
[WHY]
Coverity analysis flagged this condition as DEADCODE since the
variable 'req128_c' is always false, thus the condition is never
true.
[HOW]
Remove the condition.
Reviewed-by: Aurabindo Pillai
Acked-by: Hamza Mahfooz
Signed-off-by: Ivan Lipski
---
.../g
From: Alex Hung
Checks null pointer before accessing various structs.
This fixes 5 NULL_RETURNS issues reported by Coverity.
Reviewed-by: Harry Wentland
Acked-by: Hamza Mahfooz
Signed-off-by: Alex Hung
---
drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_utils.c | 2 ++
.../display/dc
: Harry Wentland
Acked-by: Hamza Mahfooz
Signed-off-by: Alex Hung
---
.../drm/amd/display/dc/dml/calcs/dcn_calcs.c | 2 +-
.../drm/amd/display/dc/dml/dcn20/dcn20_fpu.c | 20 ++---
.../dc/dml/dcn20/display_mode_vba_20.c| 16 +--
.../dc/dml/dcn20/display_mode_vba_20v2.c
From: Alex Hung
The null checks for ctx->dc_bios are redundant as it was already
dereferenced previously, as reported by Coverity; therefore the
null checks are removed.
This fixes 7 REVERSE_INULL issues reported by Coverity.
Reviewed-by: Harry Wentland
Acked-by: Hamza Mahfooz
Signed-off
From: Alex Hung
resource_get_odm_slice_count and resource_get_otg_master_for_stream can
return null, and their returns must be checked before used.
This fixes 4 NULL_RETURNS issues reported by Coverity.
Reviewed-by: Harry Wentland
Acked-by: Hamza Mahfooz
Signed-off-by: Alex Hung
describe why the warning was triggered to make the
debugging more straightforward.
Reviewed-by: Wenjing Liu
Acked-by: Hamza Mahfooz
Signed-off-by: Rodrigo Siqueira
---
drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/amd
From: Sridevi Arvindekar
Mirror case unsupported for cursors. So, remove code for mirror case
with cursors.
Reviewed-by: Nevenko Stupar
Acked-by: Hamza Mahfooz
Signed-off-by: Sridevi Arvindekar
---
.../amd/display/dc/hwss/dcn401/dcn401_hwseq.c | 30 +--
1 file changed, 1
From: Alex Hung
Callers can pass null in filter (i.e. from returned from the function
wbscl_get_filter_coeffs_16p) and a null check is added to ensure that is
not the case.
This fixes 4 NULL_RETURNS issues reported by Coverity.
Reviewed-by: Harry Wentland
Acked-by: Hamza Mahfooz
Signed-off
gamut_remap callback in
case the specific ASIC did not implement this function.
Reviewed-by: Aurabindo Pillai
Acked-by: Hamza Mahfooz
Signed-off-by: Rodrigo Siqueira
---
.../amd/display/dc/hwss/dcn10/dcn10_hwseq.c | 49 ++-
1 file changed, 27 insertions(+), 22 deletions(-)
diff --git a
From: Alex Hung
BIOS images may fail to load and null checks are added before they are
used.
This fixes 6 NULL_RETURNS issues reported by Coverity.
Reviewed-by: Harry Wentland
Acked-by: Hamza Mahfooz
Signed-off-by: Alex Hung
---
drivers/gpu/drm/amd/display/dc/bios/bios_parser.c | 14
From: Sung Joon Kim
[why]
Tell the system about the current host router bandwidth to be used to
measure and calculate the right voltage to be used.
[how]
Send SMU message of each DPIA host router bandwidth.
Reviewed-by: Nicholas Kazlauskas
Acked-by: Hamza Mahfooz
Signed-off-by: Sung Joon Kim
From: Dillon Varone
When a phantom stream is in the process of being deconstructed, there
could be pipes with no associated planes. In that case, ignore the
phantom stream entirely when searching for associated pipes.
Cc: sta...@vger.kernel.org
Reviewed-by: Alvin Lee
Acked-by: Hamza Mahfooz
1 - 100 of 592 matches
Mail list logo
