https://github.com/DimitryAndric approved this pull request.
I don't have any experience with LoongArch, but this diff looks fine to me.
https://github.com/llvm/llvm-project/pull/119191
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://l
https://github.com/DimitryAndric approved this pull request.
Seems reasonable, and it fixes both my minimized test case, and the full
original test case.
https://github.com/llvm/llvm-project/pull/107815
___
cfe-commits mailing list
cfe-commits@lists.l
DimitryAndric wrote:
Ah that was my error, I hadn't used the regenerated `*-driver.cpp` files. These
indeed should contain the `InitLLVM` call.
https://github.com/llvm/llvm-project/pull/76306
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
DimitryAndric wrote:
Maybe I'm doing something wrong, but after this commit (and its merge to 18.x)
I don't see to get stack traces from clang anymore after assertions? How is
this supposed to work?
https://github.com/llvm/llvm-project/pull/76306
_
DimitryAndric wrote:
FWIW I think I just hit this when building llvm itself (though 15.0.6) with a
recent clang, and getting:
```text
/wrkdirs/usr/ports/devel/llvm15/work-default/llvm-project-15.0.7.src/llvm/tools/sancov/sancov.cpp:532:44:
error: chosen constructor is explicit in copy-initiali
Author: Dimitry Andric
Date: 2023-12-20T20:09:39+01:00
New Revision: 2c27013fa918211816d24c9d2530469fd822bc00
URL:
https://github.com/llvm/llvm-project/commit/2c27013fa918211816d24c9d2530469fd822bc00
DIFF:
https://github.com/llvm/llvm-project/commit/2c27013fa918211816d24c9d2530469fd822bc00.diff
Author: Dimitry Andric
Date: 2023-12-20T20:07:22+01:00
New Revision: 5c1a41f8ad0c02a24345efb4adc424396b7e446b
URL:
https://github.com/llvm/llvm-project/commit/5c1a41f8ad0c02a24345efb4adc424396b7e446b
DIFF:
https://github.com/llvm/llvm-project/commit/5c1a41f8ad0c02a24345efb4adc424396b7e446b.diff
https://github.com/DimitryAndric closed
https://github.com/llvm/llvm-project/pull/75935
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -995,12 +995,7 @@ void CodeGenModule::Release() {
uint32_t(CLANG_VERSION_MINOR));
getModule().addModuleFlag(llvm::Module::Warning, "zos_product_patchlevel",
uint32_t(CLANG_VERSION_PATCHLEVEL));
-std::string
https://github.com/DimitryAndric updated
https://github.com/llvm/llvm-project/pull/75935
>From ab5263e77e19ede918faf517dd348018c1982590 Mon Sep 17 00:00:00 2001
From: Dimitry Andric
Date: Tue, 19 Dec 2023 13:37:37 +0100
Subject: [PATCH] [clang] Add getClangVendor() and use it in CodeGenModule.c
https://github.com/DimitryAndric edited
https://github.com/llvm/llvm-project/pull/75935
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DimitryAndric updated
https://github.com/llvm/llvm-project/pull/75935
>From 4b3db6bdaf9f94277f23bf9a796f474a353e4d73 Mon Sep 17 00:00:00 2001
From: Dimitry Andric
Date: Tue, 19 Dec 2023 13:37:37 +0100
Subject: [PATCH] [clang] Add getClangVendor() and use it in CodeGenModule.c
https://github.com/DimitryAndric created
https://github.com/llvm/llvm-project/pull/75935
In 9a38a72f1d482 `ProductId` was assigned from the stringified value of
`CLANG_VENDOR`, if that macro was defined. However, `CLANG_VENDOR` is supposed
to be a string, as it is defined (optionally) as such
DimitryAndric wrote:
Yes, this should be fine.
https://github.com/llvm/llvm-project/pull/73392
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DimitryAndric wrote:
Does this only affect cases where one passes `-stdlib=libc++`? What happens if
somebody passes `-stdlib=libstdc++`?
https://github.com/llvm/llvm-project/pull/68011
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://l
Author: Dimitry Andric
Date: 2023-06-14T20:34:19+02:00
New Revision: 69d42eef4bec208a2312bfa0d2194013817eeba0
URL:
https://github.com/llvm/llvm-project/commit/69d42eef4bec208a2312bfa0d2194013817eeba0
DIFF:
https://github.com/llvm/llvm-project/commit/69d42eef4bec208a2312bfa0d2194013817eeba0.diff
Author: Dimitry Andric
Date: 2023-05-03T17:54:58+02:00
New Revision: db492316399a0edc26788265c7fce78c63a0f838
URL:
https://github.com/llvm/llvm-project/commit/db492316399a0edc26788265c7fce78c63a0f838
DIFF:
https://github.com/llvm/llvm-project/commit/db492316399a0edc26788265c7fce78c63a0f838.diff
Author: Dimitry Andric
Date: 2023-04-20T19:43:51+02:00
New Revision: c1ee2192dd0f28cdf02a0544d25d0710c037bf9b
URL:
https://github.com/llvm/llvm-project/commit/c1ee2192dd0f28cdf02a0544d25d0710c037bf9b
DIFF:
https://github.com/llvm/llvm-project/commit/c1ee2192dd0f28cdf02a0544d25d0710c037bf9b.diff
Author: Dimitry Andric
Date: 2021-11-28T22:23:42+01:00
New Revision: df08b2fe8b35cb63dfb3b49738a3494b9b4e6f8e
URL:
https://github.com/llvm/llvm-project/commit/df08b2fe8b35cb63dfb3b49738a3494b9b4e6f8e
DIFF:
https://github.com/llvm/llvm-project/commit/df08b2fe8b35cb63dfb3b49738a3494b9b4e6f8e.diff
Author: Dimitry Andric
Date: 2020-08-29T12:03:20+02:00
New Revision: fc2dac4116df62c25396b15ec9730f67a0b1aac7
URL:
https://github.com/llvm/llvm-project/commit/fc2dac4116df62c25396b15ec9730f67a0b1aac7
DIFF:
https://github.com/llvm/llvm-project/commit/fc2dac4116df62c25396b15ec9730f67a0b1aac7.diff
Author: Dimitry Andric
Date: 2020-07-12T23:45:22+02:00
New Revision: 02cfa7530d9e7cfd8ea940dab4173afb7938b831
URL:
https://github.com/llvm/llvm-project/commit/02cfa7530d9e7cfd8ea940dab4173afb7938b831
DIFF:
https://github.com/llvm/llvm-project/commit/02cfa7530d9e7cfd8ea940dab4173afb7938b831.diff
Author: Dimitry Andric
Date: 2020-02-16T01:50:06+01:00
New Revision: 62654cab7e654384ba503d6b62b1054cde19a553
URL:
https://github.com/llvm/llvm-project/commit/62654cab7e654384ba503d6b62b1054cde19a553
DIFF:
https://github.com/llvm/llvm-project/commit/62654cab7e654384ba503d6b62b1054cde19a553.diff
Author: Dimitry Andric
Date: 2020-01-24T20:52:37+01:00
New Revision: 58592f6c49249293f79698cfcb31dba532e12603
URL:
https://github.com/llvm/llvm-project/commit/58592f6c49249293f79698cfcb31dba532e12603
DIFF:
https://github.com/llvm/llvm-project/commit/58592f6c49249293f79698cfcb31dba532e12603.diff
Author: Dimitry Andric
Date: 2019-11-18T21:54:25+01:00
New Revision: ee31adb7fa42f5b601d9612f23755b4604f83cac
URL:
https://github.com/llvm/llvm-project/commit/ee31adb7fa42f5b601d9612f23755b4604f83cac
DIFF:
https://github.com/llvm/llvm-project/commit/ee31adb7fa42f5b601d9612f23755b4604f83cac.diff
Author: dim
Date: Wed Sep 18 13:58:03 2019
New Revision: 372261
URL: http://llvm.org/viewvc/llvm-project?rev=372261&view=rev
Log:
On PowerPC, Secure-PLT by default for FreeBSD 13 and higher
Summary:
In https://svnweb.freebsd.org/changeset/base/349351, FreeBSD 13 and
higher transitioned to Secure-
On 9 Jul 2019, at 04:54, Tom Stellard wrote:
>
> On 07/08/2019 11:51 AM, Dimitry Andric wrote:
>> On 24 Jun 2019, at 20:40, Tom Stellard via cfe-commits
>> wrote:
>>>
>>> Author: tstellar
>>> Date: Mon Jun 24 11:40:58 2019
>>> New Revision: 364217
>>>
>>> URL: http://llvm.org/viewvc/llvm-proj
Author: dim
Date: Tue Jul 9 12:22:59 2019
New Revision: 365542
URL: http://llvm.org/viewvc/llvm-project?rev=365542&view=rev
Log:
Merging r360861, with an additional change to also add the PPC64_OPD1
and PPC64_OPD2 lines to the DEFINE_LIBUNWIND_PRIVATE_FUNCTION() macro,
which was removed in r35764
Author: dim
Date: Tue Jul 9 12:14:43 2019
New Revision: 365539
URL: http://llvm.org/viewvc/llvm-project?rev=365539&view=rev
Log:
Revert merge of r360861:
r360861 | mstorsjo | 2019-05-15 23:49:13 -0700 (Wed, 15 May 2019) | 1
On 24 Jun 2019, at 20:40, Tom Stellard via cfe-commits
wrote:
>
> Author: tstellar
> Date: Mon Jun 24 11:40:58 2019
> New Revision: 364217
>
> URL: http://llvm.org/viewvc/llvm-project?rev=364217&view=rev
> Log:
> Merging r360861:
>
>
Author: dim
Date: Wed Aug 15 10:30:32 2018
New Revision: 339794
URL: http://llvm.org/viewvc/llvm-project?rev=339794&view=rev
Log:
For FreeBSD, don't define _M in nasty_macros.hpp
Because FreeBSD uses _M in its , and it is hard to avoid
including that header, only define _M to NASTY_MACRO for othe
Author: dim
Date: Fri Jun 29 12:18:17 2018
New Revision: 336008
URL: http://llvm.org/viewvc/llvm-project?rev=336008&view=rev
Log:
Request init/fini array on FreeBSD 12 and later
Summary:
It seems a bad idea to change the default in the middle of a release
branch due to possible changes in global
On 20 Sep 2017, at 20:06, Andrew Kaylor via cfe-commits
wrote:
>
> Author: akaylor
> Date: Wed Sep 20 11:06:44 2017
> New Revision: 313784
>
> URL: http://llvm.org/viewvc/llvm-project?rev=313784&view=rev
> Log:
> Remove offset size check in nullptr arithmetic handling
>
> Differential Revision
Author: dim
Date: Wed Apr 11 10:21:52 2018
New Revision: 329827
URL: http://llvm.org/viewvc/llvm-project?rev=329827&view=rev
Log:
Document -std= values for different languages
Summary:
After a remark on a FreeBSD mailing list that the clang man page did
not have any list of possible values for th
Author: dim
Date: Sat Feb 17 13:04:35 2018
New Revision: 325446
URL: http://llvm.org/viewvc/llvm-project?rev=325446&view=rev
Log:
[X86] Add 'sahf' CPU feature to frontend
Summary:
Make clang accept `-msahf` (and `-mno-sahf`) flags to activate the
`+sahf` feature for the backend, for bug 36028 (In
On 17 Feb 2018, at 00:12, Craig Topper via Phabricator
wrote:
>
> craig.topper added inline comments.
>
>
>
> Comment at: lib/Basic/Targets/X86.cpp:1049
>
> + if (HasLAHFSAHF)
> +Builder.defineMacro("__LAHFSAHF__");
>
> dim wrote:
>> craig.topper wrote:
Author: dim
Date: Tue Feb 13 09:43:24 2018
New Revision: 325028
URL: http://llvm.org/viewvc/llvm-project?rev=325028&view=rev
Log:
Make the ctype_byname::widen test cases pass on FreeBSD.
Modified:
libcxx/trunk/test/std/localization/locale.categories/category.ctype/locale.ctype.byname/widen_1
Author: dim
Date: Tue Feb 13 09:40:59 2018
New Revision: 325027
URL: http://llvm.org/viewvc/llvm-project?rev=325027&view=rev
Log:
Put type attributes after class keyword
Summary:
Compiling `` in C++17 or higher mode results in:
```
functional:2500:1: warning: attribute '__visibility__' is ignore
Author: dim
Date: Sun Feb 11 14:31:05 2018
New Revision: 324855
URL: http://llvm.org/viewvc/llvm-project?rev=324855&view=rev
Log:
Add default C++ ABI libname and include paths for FreeBSD
Summary:
As noted in a discussion about testing the LLVM 6.0.0 release candidates
(with libc++) for FreeBSD,
Author: dim
Date: Sat Jan 20 06:34:33 2018
New Revision: 323040
URL: http://llvm.org/viewvc/llvm-project?rev=323040&view=rev
Log:
Assume the shared library path variable is LD_LIBRARY_PATH on systems
except Darwin and Windows. This prevents inserting an environment
variable with an empty name (wh
Author: dim
Date: Sun Jan 7 08:45:11 2018
New Revision: 321963
URL: http://llvm.org/viewvc/llvm-project?rev=321963&view=rev
Log:
Add pre-C++11 is_constructible wrappers for 3 arguments
Summary:
After rL319736 for D28253 (which fixes PR28929), gcc cannot compile ``
anymore in pre-C+11 modes, com
On 5 Dec 2017, at 05:09, Marshall Clow via cfe-commits
wrote:
>
> Author: marshall
> Date: Mon Dec 4 20:09:49 2017
> New Revision: 319736
>
> URL: http://llvm.org/viewvc/llvm-project?rev=319736&view=rev
> Log:
> Land D28253 which fixes PR28929 (which we mistakenly marked as fixed before)
...
>
Author: dim
Date: Mon Dec 18 11:46:56 2017
New Revision: 321016
URL: http://llvm.org/viewvc/llvm-project?rev=321016&view=rev
Log:
Fix more inconsistent line endings. NFC.
Modified:
cfe/trunk/include/clang/AST/OperationKinds.def
cfe/trunk/lib/Parse/ParseTemplate.cpp
cfe/trunk/www/cxx_d
Author: dim
Date: Mon Dec 18 11:46:56 2017
New Revision: 321016
URL: http://llvm.org/viewvc/llvm-project?rev=321016&view=rev
Log:
Fix more inconsistent line endings. NFC.
Modified:
clang-tools-extra/trunk/docs/modularize.rst
clang-tools-extra/trunk/docs/pp-trace.rst
Modified: clang-tools
Author: dim
Date: Thu Dec 14 14:32:24 2017
New Revision: 320755
URL: http://llvm.org/viewvc/llvm-project?rev=320755&view=rev
Log:
Don't trigger -Wuser-defined-literals for system headers
Summary:
In D41064, I proposed adding `#pragma clang diagnostic ignored
"-Wuser-defined-literals"` to some of
Yeah, in the past libc++ broke its own ABI with
http://llvm.org/viewvc/llvm-project?view=revision&revision=194536, which is why
we had to add the _LIBCPP_TRIVIAL_PAIR_COPY_CTOR hack to our own libc++
__config, in https://svnweb.freebsd.org/base?view=revision&revision=261801.
(Afterwards, in
ht
On 19 Jul 2017, at 16:04, Hans Wennborg via cfe-commits
wrote:
>
> Author: hans
> Date: Wed Jul 19 07:04:19 2017
> New Revision: 308470
>
> URL: http://llvm.org/viewvc/llvm-project?rev=308470&view=rev
> Log:
> Drop 'svn' suffix from version number.
[Replying to this commit, since I don't have
Author: dim
Date: Wed Jun 7 07:05:41 2017
New Revision: 304899
URL: http://llvm.org/viewvc/llvm-project?rev=304899&view=rev
Log:
Only print registered targets for `--version`
Summary:
In D33900, I added printing of the registered targets in clang's
`PrintVersion` function, which is not only used
Author: dim
Date: Tue Jun 6 16:54:45 2017
New Revision: 304837
URL: http://llvm.org/viewvc/llvm-project?rev=304837&view=rev
Log:
Adjust SetVersionPrinter call for D33899
Summary:
In D33899, I'm adding a `raw_ostream &` parameter to the function
objects passed to `cl::SetVersionPrinter`. Adjust
Author: dim
Date: Tue Jun 6 16:54:21 2017
New Revision: 304836
URL: http://llvm.org/viewvc/llvm-project?rev=304836&view=rev
Log:
Print registered targets in clang's version information
Summary:
Other llvm tools display their registered targets when showing version
information, but for some reaso
Author: dim
Date: Sat May 6 15:58:50 2017
New Revision: 302362
URL: http://llvm.org/viewvc/llvm-project?rev=302362&view=rev
Log:
Ensure showbase does not overflow do_put buffers
Summary:
In https://bugs.freebsd.org/207918, Daniel McRobb describes how using
std::showbase with ostreams can cause t
On 26 Dec 2016, at 13:23, Marina Yatsina via cfe-commits
wrote:
>
> Author: myatsina
> Date: Mon Dec 26 06:23:42 2016
> New Revision: 290539
>
> URL: http://llvm.org/viewvc/llvm-project?rev=290539&view=rev
> Log:
> [inline-asm]No error for conflict between inputs\outputs and clobber list
>
> A
Eric, you OK with that?
>
> -Dimitry
>
> > On 26 Jan 2017, at 19:37, Dimitry Andric via cfe-commits
> > mailto:cfe-commits@lists.llvm.org>> wrote:
> >
> > Author: dim
> > Date: Thu Jan 26 12:37:18 2017
> > New Revision: 293197
> >
> > URL: h
Author: dim
Date: Sun Jan 29 14:30:51 2017
New Revision: 293443
URL: http://llvm.org/viewvc/llvm-project?rev=293443&view=rev
Log:
Merging r293197:
r293197 | dim | 2017-01-26 19:37:18 +0100 (Thu, 26 Jan 2017) | 43 lines
Disab
I'd like to merge this to the release_40 branch. Eric, you OK with that?
-Dimitry
> On 26 Jan 2017, at 19:37, Dimitry Andric via cfe-commits
> wrote:
>
> Author: dim
> Date: Thu Jan 26 12:37:18 2017
> New Revision: 293197
>
> URL: http://llvm.org/viewvc/llv
Author: dim
Date: Thu Jan 26 12:37:18 2017
New Revision: 293197
URL: http://llvm.org/viewvc/llvm-project?rev=293197&view=rev
Log:
Disable thread safety analysis for some functions in __thread_support
Many thread-related libc++ test cases fail on FreeBSD, due to the
following -Werror warnings:
> On 17 Jan 2017, at 23:10, Eric Fiselier via cfe-commits
> wrote:
>
> Author: ericwf
> Date: Tue Jan 17 16:10:32 2017
> New Revision: 292276
>
> URL: http://llvm.org/viewvc/llvm-project?rev=292276&view=rev
> Log:
> Fix std::string assignment ambiguity from braced initializer lists.
>
> When
On 14 Jan 2017, at 22:12, Yaron Keren via cfe-commits
wrote:
> Author: yrnkrn
> Date: Sat Jan 14 15:12:08 2017
> New Revision: 292032
>
> URL: http://llvm.org/viewvc/llvm-project?rev=292032&view=rev
> Log:
> Fix PR31644 introduced by r287138 and add a regression test.
> Thanks Dimitry Andric for
On 22 Oct 2016, at 00:00, Richard Smith via cfe-commits
wrote:
>
> Author: rsmith
> Date: Fri Oct 21 17:00:42 2016
> New Revision: 284890
>
> URL: http://llvm.org/viewvc/llvm-project?rev=284890&view=rev
> Log:
> DR583, DR1512: Implement a rewrite to C++'s 'composite pointer type' rules.
> This
Author: dim
Date: Mon Jan 9 14:29:35 2017
New Revision: 291476
URL: http://llvm.org/viewvc/llvm-project?rev=291476&view=rev
Log:
Move _PairT declaration out of __hash_combine to avoid warning under C++98
Summary:
Some parts of the FreeBSD tree are still compiled with C++98, and until
rL288554 th
I can confirm that r290169 indeed fixes the three test failures I got earlier.
Thanks George!
-Dimitry
> On 23 Dec 2016, at 02:29, George Burgess IV
> wrote:
>
> It looks like the root of this is that we're treating calls to `allocsize`
> functions as AllocLike (e.g. any allocation function
This is when running "ninja check-all", in a tree with llvm, clang and
compiler-rt checked out. The first program that shows a failure is
projects/compiler-rt/lib/asan/tests/default/Asan-i386-inline-Test:
[==] Running 92 tests from 3 test cases.
[--] Global test environment set-
On 20 Dec 2016, at 09:28, Chandler Carruth via cfe-commits
wrote:
> Author: chandlerc
> Date: Tue Dec 20 02:28:19 2016
> New Revision: 290169
>
> URL: http://llvm.org/viewvc/llvm-project?rev=290169&view=rev
> Log:
> Revert r290149: Add the alloc_size attribute to clang.
>
> This commit fails MS
Hi Alexey,
Does this look like a good candidate for 3.9.1?
-Dimitry
> On 07 Nov 2016, at 19:15, Alexey Bataev via cfe-commits
> wrote:
>
> Author: abataev
> Date: Mon Nov 7 12:15:02 2016
> New Revision: 286129
>
> URL: http://llvm.org/viewvc/llvm-project?rev=286129&view=rev
> Log:
> [OPENMP
dim accepted this revision.
dim added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D25593
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
Author: dim
Date: Wed Oct 12 15:26:47 2016
New Revision: 284047
URL: http://llvm.org/viewvc/llvm-project?rev=284047&view=rev
Log:
Disable trivial pair copy/move tests when unsupported
Summary:
On FreeBSD, for ABI compatibility reasons, the pair trivial copy
constructor is disabled, using the aptl
dim created this revision.
dim added reviewers: EricWF, emaste, rsmith, theraven.
dim added a subscriber: cfe-commits.
On FreeBSD, for ABI compatibility reasons, the pair trivial copy
constructor is disabled, using the aptly-named
`_LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR` define.
Di
dim accepted this revision.
dim added a comment.
This revision is now accepted and ready to land.
Yes, this looks good to me. For trunk r283783, this brought the number of
unexpected failures down from 61 to 41. Tests fixed by this change:
libc++ :: std/algorithms/alg.sorting/alg.min.max/min
dim accepted this revision.
dim added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D24867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
dim added a comment.
FWIW, I have already imported this fix into FreeBSD two weeks ago:
https://svnweb.freebsd.org/changeset/base/304960
It has been working fine for us.
https://reviews.llvm.org/D23921
___
cfe-commits mailing list
cfe-commits@lists
Author: dim
Date: Mon Sep 5 13:01:13 2016
New Revision: 280669
URL: http://llvm.org/viewvc/llvm-project?rev=280669&view=rev
Log:
Add missing _US_ACTION_MASK constant to unwind.h
Summary:
During building of recent compiler-rt sources on FreeBSD for arm, I
noticed that our unwind.h (which originat
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280543: Avoid narrowing warnings in __bitset constructor
(authored by dim).
Changed prior to commit:
https://reviews.llvm.org/D23960?vs=69489&id=70231#toc
Repository:
rL LLVM
https://reviews.llvm.or
Author: dim
Date: Fri Sep 2 16:02:11 2016
New Revision: 280543
URL: http://llvm.org/viewvc/llvm-project?rev=280543&view=rev
Log:
Avoid narrowing warnings in __bitset constructor
When is compiled with warnings enabled, on a platform where
size_t is 4 bytes, it results in errors similar to:
dim added a comment.
@mclow.lists, I tested code generation (on i386-freebsd) with this small sample
program:
#include
void f(const std::bitset<53>&);
void g(void)
{
std::bitset<53> bs(0x1234567890abcdef);
f(bs);
}
The assembly doesn't change at all after this fix:
g
dim added inline comments.
Comment at: include/bitset:262
@@ -261,3 +261,3 @@
#elif __SIZEOF_SIZE_T__ == 4
-: __first_{__v, __v >> __bits_per_word}
+: __first_{static_cast<__storage_type>(__v),
static_cast<__storage_type>(__v >> __bits_per_word)}
#else
dim added a comment.
Ping...
https://reviews.llvm.org/D23960
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dim added a subscriber: dim.
dim added a comment.
This works for me. I had two test cases from the FreeBSD source tree which
resulted in warnings, e.g.:
cddl/contrib/opensolaris/lib/libnvpair/libnvpair.c:388:15: error: passing an
object that undergoes default argument promotion to 'va_start'
dim added a comment.
In https://reviews.llvm.org/D23961#527284, @vitalybuka wrote:
> PPC bots are broken by this patch
> http://lab.llvm.org:8011/builders/sanitizer-ppc64be-linux/builds/3547
> http://lab.llvm.org:8011/builders/sanitizer-ppc64le-linux/builds/2353
I saw some mails about it, bu
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279926: Avoid embedded preprocessor directives in __tree
(authored by dim).
Changed prior to commit:
https://reviews.llvm.org/D23961?vs=69492&id=69496#toc
Repository:
rL LLVM
https://reviews.llvm.or
Author: dim
Date: Sat Aug 27 14:32:03 2016
New Revision: 279926
URL: http://llvm.org/viewvc/llvm-project?rev=279926&view=rev
Log:
Avoid embedded preprocessor directives in __tree
Similar to rL242623, move C++ version checks outside of _NOEXCEPT_()
macro invocation argument lists, to avoid "embedd
dim created this revision.
dim added reviewers: mclow.lists, EricWF.
dim added subscribers: emaste, cfe-commits.
When I compile as part of clang, with -pedantic enabled, I get the
following warnings:
In file included from /usr/include/c++/v1/map:442:
/usr/include/c++/v1/__tree:874:2: war
dim created this revision.
dim added reviewers: mclow.lists, EricWF.
dim added subscribers: emaste, cfe-commits.
When I compile is compiled with warnings enabled, I get the
following error (which is interesting in itself, it should only be a
warning):
/usr/include/c++/v1/bitset:265:16: error
Marshall, this is maybe a good candidate for merging to release_39?
-Dimitry
> On 17 Aug 2016, at 07:58, Marshall Clow via cfe-commits
> wrote:
>
> Author: marshall
> Date: Wed Aug 17 00:58:40 2016
> New Revision: 278904
>
> URL: http://llvm.org/viewvc/llvm-project?rev=278904&view=rev
> Log:
Ah, I missed Doug's follow-up commit r266797, which moved the code again. I
noticed that the RenderDebugEnablingArgs() call was missing in the spot
indicated below, but it was only moved.
-Dimitry
> On 17 Aug 2016, at 01:17, Hans Wennborg wrote:
>
> Looks like it was committed back in April,
Hi Hans,
Can we please merge this one to release_39 too? I forgot all about it, sorry.
Doug, can you please approve?
-Dimitry
> On 19 Apr 2016, at 19:43, Douglas Katzman via cfe-commits
> wrote:
>
> Author: dougk
> Date: Tue Apr 19 12:43:54 2016
> New Revision: 266775
>
> URL: http://llvm.
to merge this one to release_39, since it fixes a few third
>> party programs using cpuid.h, and expecting gcc-compatible CPUID bit macros.
>>
>> -Dimitry
>>
>>> On 31 Jul 2016, at 22:23, Dimitry Andric via cfe-commits
>>> wrote:
>>>
>>
Hi Hans,
I would like to merge this one to release_39, since it fixes a few third party
programs using cpuid.h, and expecting gcc-compatible CPUID bit macros.
-Dimitry
> On 31 Jul 2016, at 22:23, Dimitry Andric via cfe-commits
> wrote:
>
> Author: dim
> Date: Sun Jul 31 15:2
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277307: Add more gcc compatibility names to clang's cpuid.h
(authored by dim).
Changed prior to commit:
https://reviews.llvm.org/D22010?vs=62781&id=66250#toc
Repository:
rL LLVM
https://reviews.llvm
Author: dim
Date: Sun Jul 31 15:23:23 2016
New Revision: 277307
URL: http://llvm.org/viewvc/llvm-project?rev=277307&view=rev
Log:
Add more gcc compatibility names to clang's cpuid.h
Summary:
Some cpuid bit defines are named slightly different from how gcc's
cpuid.h calls them.
Define a few more
dim added inline comments.
Comment at: lib/Headers/cpuid.h:114
@@ -109,2 +113,3 @@
#define bit_AVX 0x1000
+#define bit_F16C0x2000
#define bit_RDRND 0x4000
bruno wrote:
> Isn't this one also meant for gcc compat?
Well, we didn't
dim added a comment.
Ping.
http://reviews.llvm.org/D22010
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dim added a comment.
In http://reviews.llvm.org/D21329#475105, @theraven wrote:
> Looks fine to me, though I wonder if we want to move to the new ABI for
> FreeBSD11 and use the old one for <=10.
For 11 it is certainly too late now, since it is ABI/API frozen now, and we
would still need to f
dim created this revision.
dim added reviewers: joerg, rsmith.
dim added a subscriber: cfe-commits.
Some cpuid bit defines are named slightly different from how gcc's cpuid.h
calls them.
Define a few more compatibility names to appease software built for gcc:
* `bit_PCLMUL` alias of `bit_PC
dim added a comment.
@theraven, do you have any other feedback? :)
http://reviews.llvm.org/D21329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dim accepted this revision.
dim added a comment.
This revision is now accepted and ready to land.
LGTM. Eric, apologies that this took some time to review. I finally dug out
my old test cases for the original problem report in FreeBSD, and re-tested
them against this patch. (These test cases
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270240: Make __FreeBSD_cc_version predefined macro
configurable at build time (authored by dim).
Changed prior to commit:
http://reviews.llvm.org/D20037?vs=56476&id=57952#toc
Repository:
rL LLVM
htt
Author: dim
Date: Fri May 20 12:27:22 2016
New Revision: 270240
URL: http://llvm.org/viewvc/llvm-project?rev=270240&view=rev
Log:
Make __FreeBSD_cc_version predefined macro configurable at build time
The `FreeBSDTargetInfo` class has always set the `__FreeBSD_cc_version`
predefined macro to a rat
dim added a subscriber: cfe-commits.
dim added a comment.
Belatedly adding cfe-commits.
http://reviews.llvm.org/D20037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dim accepted this revision.
dim added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: test/Sema/format-strings-freebsd.c:39
@@ -35,1 +38,3 @@
+ freebsd_kernel_printf("%hr", h); // no-warning
+
// %y expects an int
It's nice to a
dim abandoned this revision.
dim added a comment.
Yes, this was indeed the wrong include order. During the latter stages of
FreeBSD's buildworld, the compiler is invoked with `-nostdinc++`, but
`/usr/include` was put before the libc++ include directory,
`/usr/include/c++/v1`. So as @rsmith re
dim added a comment.
Note that these compilation errors came up specifically because @bdrewery is
doing cross-compilation of FreeBSD with recent versions of gcc. Apparently
clang does not give the same errors on these undefined identifiers, but I'm not
entirely sure why not...
http://reviews
1 - 100 of 166 matches
Mail list logo
