dim accepted this revision. dim added a comment. This revision is now accepted and ready to land.
Yes, this looks good to me. For trunk r283783, this brought the number of unexpected failures down from 61 to 41. Tests fixed by this change: libc++ :: std/algorithms/alg.sorting/alg.min.max/minmax.pass.cpp libc++ :: std/algorithms/alg.sorting/alg.min.max/minmax_comp.pass.cpp libc++ :: std/algorithms/alg.sorting/alg.min.max/minmax_element.pass.cpp libc++ :: std/algorithms/alg.sorting/alg.min.max/minmax_element_comp.pass.cpp libc++ :: std/algorithms/alg.sorting/alg.min.max/minmax_init_list.pass.cpp libc++ :: std/algorithms/alg.sorting/alg.min.max/minmax_init_list_comp.pass.cpp libc++ :: std/experimental/string.view/string.view.find/find_pointer_size.pass.cpp libc++ :: std/experimental/string.view/string.view.find/find_pointer_size_size.pass.cpp libc++ :: std/experimental/string.view/string.view.find/find_string_view_size.pass.cpp libc++ :: std/strings/string.view/string.view.find/find_pointer_size.pass.cpp libc++ :: std/strings/string.view/string.view.find/find_pointer_size_size.pass.cpp libc++ :: std/strings/string.view/string.view.find/find_string_view_size.pass.cpp libc++ :: std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex_try_to_lock.pass.cpp libc++ :: std/utilities/tuple/tuple.tuple/tuple.apply/make_from_tuple.pass.cpp libc++ :: std/utilities/utility/pairs/pairs.pair/const_pair_U_V.pass.cpp libc++ :: std/utilities/utility/pairs/pairs.pair/copy_ctor.pass.cpp libc++ :: std/utilities/utility/pairs/pairs.pair/move_ctor.pass.cpp libc++ :: std/utilities/utility/pairs/pairs.pair/rv_pair_U_V.pass.cpp libc++ :: std/utilities/utility/pairs/pairs.pair/special_member_generation_test.pass.cpp libc++ :: std/utilities/utility/pairs/pairs.spec/make_pair.pass.cpp https://reviews.llvm.org/D25389 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
