On 20 Dec 2016, at 09:28, Chandler Carruth via cfe-commits <cfe-commits@lists.llvm.org> wrote: > Author: chandlerc > Date: Tue Dec 20 02:28:19 2016 > New Revision: 290169 > > URL: http://llvm.org/viewvc/llvm-project?rev=290169&view=rev > Log: > Revert r290149: Add the alloc_size attribute to clang. > > This commit fails MSan when running test/CodeGen/object-size.c in > a confusing way. After some discussion with George, it isn't really > clear what is going on here. We can make the MSan failure go away by > testing for the invalid bit, but *why* things are invalid isn't clear. > And yet, other code in the surrounding area is doing precisely this and > testing for invalid. > > George is going to take a closer look at this to better understand the > nature of the failure and recommit it, for now backing it out to clean > up MSan builds.
Hmm, was this reapplied later on? I'm still getting the following
AddressSanitizer failures on FreeBSD, and bisecting has pointed to r290149 as
the cause:
FAIL: AddressSanitizer-Unit ::
Asan-i386-inline-Test/AddressSanitizer.ReallocFreedPointerTest (2124 of 30204)
******************** TEST 'AddressSanitizer-Unit ::
Asan-i386-inline-Test/AddressSanitizer.ReallocFreedPointerTest' FAILED
********************
Note: Google Test filter = AddressSanitizer.ReallocFreedPointerTest
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from AddressSanitizer
[ RUN ] AddressSanitizer.ReallocFreedPointerTest
/share/dim/src/llvm/trunk/projects/compiler-rt/lib/asan/tests/asan_test.cc:377:
Failure
Death test: ptr = realloc(ptr, 77)
Result: failed to die.
Error msg:
[ DEATH ]
[ FAILED ] AddressSanitizer.ReallocFreedPointerTest (30 ms)
[----------] 1 test from AddressSanitizer (30 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (31 ms total)
[ PASSED ] 0 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] AddressSanitizer.ReallocFreedPointerTest
1 FAILED TEST
YOU HAVE 24 DISABLED TESTS
********************
Testing: 0 .
FAIL: AddressSanitizer-Unit ::
Asan-i386-with-calls-Test/AddressSanitizer.ReallocFreedPointerTest (2233 of
30204)
******************** TEST 'AddressSanitizer-Unit ::
Asan-i386-with-calls-Test/AddressSanitizer.ReallocFreedPointerTest' FAILED
********************
Note: Google Test filter = AddressSanitizer.ReallocFreedPointerTest
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from AddressSanitizer
[ RUN ] AddressSanitizer.ReallocFreedPointerTest
/share/dim/src/llvm/trunk/projects/compiler-rt/lib/asan/tests/asan_test.cc:377:
Failure
Death test: ptr = realloc(ptr, 77)
Result: failed to die.
Error msg:
[ DEATH ]
[ FAILED ] AddressSanitizer.ReallocFreedPointerTest (24 ms)
[----------] 1 test from AddressSanitizer (24 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (25 ms total)
[ PASSED ] 0 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] AddressSanitizer.ReallocFreedPointerTest
1 FAILED TEST
YOU HAVE 24 DISABLED TESTS
********************
Testing: 0 .
FAIL: AddressSanitizer-i386-freebsd :: TestCases/Posix/free_hook_realloc.cc
(2399 of 30204)
******************** TEST 'AddressSanitizer-i386-freebsd ::
TestCases/Posix/free_hook_realloc.cc' FAILED ********************
Script:
--
/home/dim/obj/llvm-290338-trunk-freebsd12-i386-ninja-rel-1/./bin/clang
--driver-mode=g++ -fsanitize=address -mno-omit-leaf-frame-pointer
-fno-omit-frame-pointer -fno-optimize-sibling-calls -gline-tables-only -m32 -O2
/share/dim/src/llvm/trunk/projects/compiler-rt/test/asan/TestCases/Posix/free_hook_realloc.cc
-o
/home/dim/obj/llvm-290338-trunk-freebsd12-i386-ninja-rel-1/projects/compiler-rt/test/asan/I386FreeBSDConfig/TestCases/Posix/Output/free_hook_realloc.cc.tmp
/home/dim/obj/llvm-290338-trunk-freebsd12-i386-ninja-rel-1/projects/compiler-rt/test/asan/I386FreeBSDConfig/TestCases/Posix/Output/free_hook_realloc.cc.tmp
2>&1 | FileCheck
/share/dim/src/llvm/trunk/projects/compiler-rt/test/asan/TestCases/Posix/free_hook_realloc.cc
--
Exit Code: 2
Command Output (stderr):
--
FileCheck error: '-' is empty.
FileCheck command line: FileCheck
/share/dim/src/llvm/trunk/projects/compiler-rt/test/asan/TestCases/Posix/free_hook_realloc.cc
--
********************
Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
Testing Time: 880.55s
********************
Failing Tests (3):
AddressSanitizer-Unit ::
Asan-i386-inline-Test/AddressSanitizer.ReallocFreedPointerTest
AddressSanitizer-Unit ::
Asan-i386-with-calls-Test/AddressSanitizer.ReallocFreedPointerTest
AddressSanitizer-i386-freebsd :: TestCases/Posix/free_hook_realloc.cc
Expected Passes : 26881
Expected Failures : 144
Unsupported Tests : 3176
Unexpected Failures: 3
1 warning(s) in tests.
-Dimitry
signature.asc
Description: Message signed with OpenPGP using GPGMail
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
