Re: [Twisted-Python] Release blocker: Use latest pydoctor release ?

On Wed, Mar 3, 2021 at 7:18 AM Maarten ter Huurne wrote: > > Yes, as far as I know the intention is to reduce the amount of > infrastructure that has to be maintained by Twisted developers. > > Adi is doing the actual work for the migration; I only contribute > indirectly by reviewing PRs that ma

Re: [Twisted-Python] Twisted v21.2.0 breaks Crossbar.io

On Tue, Mar 2, 2021 at 12:12 PM Tobias Oberstein wrote: > > this fix broke our workaround for the bug now fixed;) > > I had to read that sentence a few times before I fully understood it, and my mind did a backflip. :) Is there a quick and dirty way to run Crossbar's CI against a pre-release ver

Re: [Twisted-Python] Twisted 21.2.0 Release Announcement

Glyph, The 21.2.0 release branch is ready for review so that it can be merged back to trunk: https://github.com/twisted/twisted/pull/1514 Thanks. -- Craig ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-b

Re: [Twisted-Python] Post Release updates

On Mon, Mar 1, 2021 at 9:13 AM Colin Watson wrote: > > Isn't this just because incremental hasn't had a release since 17.5.0? > I added post= support way back in > https://github.com/twisted/incremental/pull/37, but that was after > 17.5.0. > > -- > Colin Watson (he/him)

Re: [Twisted-Python] Need help releasing new version of Twisted incremental

On Mon, Mar 1, 2021 at 4:47 PM Kyle Altendorf wrote: > > My point was that you missed a review and you missed running towncrier > and depending what release process you are following you missed a tag in > the branch and a post-release-version-change. You asked about how to > release but gave no

Re: [Twisted-Python] Need help releasing new version of Twisted incremental

On Mon, Mar 1, 2021 at 4:44 PM Amber Brown wrote: > > The ghost of ADHD present has smiled upon you this day! > > I added glyph, JP, and rodrigc as collaborators on the incremental project. > > Wow, thanks! Nice to see you! -- Craig ___ Twisted-Python

Re: [Twisted-Python] Need help releasing new version of Twisted incremental

On Mon, Mar 1, 2021 at 3:27 PM Kyle Altendorf wrote: > On 2021-03-01 14:13, Craig Rodrigues wrote: > > > On Mon, Mar 1, 2021 at 9:13 AM Colin Watson > > wrote: > > > >> Isn't this just because incremental hasn't had a release since 17.5.0? > &

[Twisted-Python] Need help releasing new version of Twisted incremental

On Mon, Mar 1, 2021 at 9:13 AM Colin Watson wrote: > > Isn't this just because incremental hasn't had a release since 17.5.0? > I added post= support way back in > https://github.com/twisted/incremental/pull/37, but that was after > 17.5.0. > > Oh wow! You are right. Can someone help me release

Re: [Twisted-Python] Post Release updates

On Mon, Mar 1, 2021 at 2:38 AM Hynek Schlawack wrote: > > FWIW, I think it’s common (aka _I_ do it that way) that .post are indeed > post-releases like a documentation update that doesn’t warrant a proper > update. PEP 440 specifies it and RTD has good support for that. E.g. > https://www.attrs.o

Re: [Twisted-Python] Post Release updates

On Sun, Feb 28, 2021 at 12:43 PM Adi Roiban wrote: > > And we have not yet decided if the trunk should be using `.dev` or .post` > :( > > According to the Twisted release process, one of the last things I need to do is bump the Twisted version: https://github.com/twisted/twisted/blob/trunk/docs/c

Re: [Twisted-Python] Twisted 21.2.0 Release Announcement

On Sun, Feb 28, 2021 at 1:55 PM Adi Roiban wrote: > > > > Hi, > > Thanks Craig for managing this release. > You are welcome Adi! I am happy to contribute my efforts to the Twisted community and to push the project along. In 2015-2016, unfortunately I lost my job. While in between jobs, I con

Re: [Twisted-web] [Twisted-Python] Twisted 21.2.0 Release Announcement

On Sun, Feb 28, 2021 at 1:55 PM Adi Roiban wrote: > > > > Hi, > > Thanks Craig for managing this release. > You are welcome Adi! I am happy to contribute my efforts to the Twisted community and to push the project along. In 2015-2016, unfortunately I lost my job. While in between jobs, I con

Re: [Twisted-Python] Release blocker: Use latest pydoctor release ?

On Sun, Feb 28, 2021 at 1:50 PM Maarten ter Huurne wrote: > On Sunday, 28 February 2021 22:02:48 CET Craig Rodrigues wrote: > > That sounds like a good plan. Thanks for working on this. > > > > Keep in mind the points regarding docs raised by Glyph here: > > > &

Re: [Twisted-Python] Release blocker: Use latest pydoctor release ?

That sounds like a good plan. Thanks for working on this. Keep in mind the points regarding docs raised by Glyph here: https://twistedmatrix.com/pipermail/twisted-python/2021-February/065432.html -- Craig On Sunday, February 28, 2021, Maarten ter Huurne wrote: > > > However, I think that it

Twisted 21.2.0 Release Announcement

On behalf of Twisted Matrix Laboratories, I am honored to announce the release of Twisted 21.2.0! There are two major announcements for this release: - Python 2.7 support has been dropped. Twisted 21.2.0 supports Python 3.5.3 and higher only - This will be the last Twisted release to support Py

[Twisted-web] Twisted 21.2.0 Release Announcement

On behalf of Twisted Matrix Laboratories, I am honored to announce the release of Twisted 21.2.0! There are two major announcements for this release: - *Python 2.7 support has been dropped*. Twisted 21.2.0 supports Python 3.5.3 and higher only - *This will be the last Twisted release to support

[Twisted-Python] Twisted 21.2.0 Release Announcement

On behalf of Twisted Matrix Laboratories, I am honored to announce the release of Twisted 21.2.0! There are two major announcements for this release: - *Python 2.7 support has been dropped*. Twisted 21.2.0 supports Python 3.5.3 and higher only - *This will be the last Twisted release to support

Re: [Twisted-Python] Twisted 21.2.0rc1 Release Candidate Announcement

On Thu, Feb 25, 2021 at 7:03 PM Craig Rodrigues wrote: > > > On Mon, Feb 22, 2021 at 5:30 AM Richard van der Hoff > wrote: > >> As it happens, it also fails (for an import of typing.Deque) on Python >> 3.5.3, as used by Debian oldstable. >> >> Craig, what

Re: [Twisted-Python] Release blocker: Use latest pydoctor release ?

//github.com/orgs/twisted/teams/twisted-contributors > could do a release. > > Maarten did the release work in the recent past but if he is busy, in > theory anyone could step in and help with a new pydoctor release. > > Regards > > On Sat, 20 Feb 2021 at 17:47, Craig Rodrigues

Re: [Twisted-Python] Release instructions: `tox -e towncrier` does not work?

On Saturday, February 27, 2021, Adi Roiban wrote: > Hi, > > Sorry for the late reply. > > Here is a patch waiting for review https://github.com/twisted/ > twisted/pull/1527 > > Thanks. I have approved that. That patch won't make it into the 21.2.0 release, but it is not a release blocker since

[Twisted-Python] Twisted 21.2.0rc1 Release Candidate Announcement

On Monday, February 15, 2021, Kyle Altendorf wrote: > > > I went ahead and set pip_pre=true in pytest-twisted's tox.ini to try it > out and got warnings/errors with PyPy 3.7 about use of t.i.d.returnValue > claiming it should only be used in @inlineCallbacks decorated functions > even though the l

Re: [Twisted-Python] Twisted 21.2.0rc1 Release Candidate Announcement

On Mon, Feb 22, 2021 at 5:30 AM Richard van der Hoff wrote: > As it happens, it also fails (for an import of typing.Deque) on Python > 3.5.3, as used by Debian oldstable. > > Craig, what is your intention here? I think it's ok to drop support for > these ancient versions of Python 3.5, but please

Re: [Twisted-Python] Twisted 21.2.0rc1 Release Candidate Announcement

On Sat, Feb 20, 2021 at 4:32 PM Richard van der Hoff wrote: > (env3)rav@faith:~$ python3 > Python 3.5.2 (default, Oct 7 2020, 17:19:02) > [GCC 5.4.0 20160609] on linux > Type "help", "copyright", "credits" or "license" for more information. > >>> from twisted.python import log > Traceback (most

Re: [Twisted-Python] Release blocker: Use latest pydoctor release ?

hosted on Read > The Docs at docs.twistedmatrix.com > > I have updated the ticket to no longer block the release. > > Cheers > > > On Sat, 20 Feb 2021 at 02:08, Craig Rodrigues > wrote: > >> Adi, >> >> Is there anything to be done here, or is this

Re: [Twisted-Python] Release blocker: Use latest pydoctor release ?

Adi, Is there anything to be done here, or is this still a release blocker? -- Craig On Sun, Feb 14, 2021 at 4:15 PM Craig Rodrigues wrote: > Hi, > > This ticket: Use latest pydoctor release, > https://twistedmatrix.com/trac/ticket/10068 > > is marked as a release blocker.

Re: [Twisted-Python] Twisted 21.2.0rc1 Release Candidate Announcement

On Monday, February 15, 2021, Kyle Altendorf wrote: > > NonLocalExitTests > test_returnValueNonLocalDeferred ... [FAIL] > test_returnValueNonLocalWarning ... [FAIL] > > Ticketed as https://twistedmatrix.com/trac/ticket/10093. > > > > Thanks for the testing, detailed analysis, and ticket. If you

[Twisted-Python] Twisted 21.2.0rc1 Release Candidate Announcement

It's time for another Twisted release! There are two major announcements for this release: - *Python 2.7 support has been dropped*. Twisted 21.2.0 supports Python 3.5 and higher only - *This will be the last Twisted release to support Python 3.5*. Twisted 21.2.0rc1 brings the following: - twist

[Twisted-Python] Release instructions: `tox -e towncrier` does not work?

In https://github.com/twisted/twisted/commit/0ad24679b168370bf0d695825170a7532bf0698f#diff-4fd162cb9fc2878b140dcc9d9d364f9f60d404a76ebda2c10518810ffe63852dL115 Adi Roiban changed one of the steps the release documentation to run a command: *tox -e towncrier* but that tox target does not exist.

[Twisted-Python] Release blocker: Use latest pydoctor release ?

Hi, This ticket: Use latest pydoctor release, https://twistedmatrix.com/trac/ticket/10068 is marked as a release blocker. Has that been resolved or is there more work that needs to be done to fix that? -- Craig ___ Twisted-Python mailing list Twisted

Re: [Twisted-Python] Twisted trunk and klein?

On Thu, Feb 11, 2021 at 2:29 PM Glyph wrote: > > > I filed https://github.com/pypa/pip/issues/9601 for this since it seems like > it's well outside of our control. If anyone else can add more information > that would be great. > Thanks for doing the analysis and filing that bug. I didn't wan

Re: [Twisted-Python] Moving iocpsupport to an external package? Implications on Windows?

On Wed, Feb 10, 2021 at 2:57 PM Glyph wrote: > > > > On Feb 10, 2021, at 6:45 AM, Craig Rodrigues wrote: > > > > On Wednesday, February 10, 2021, Glyph wrote: >> >> >> >> On Feb 10, 2021, at 12:40 AM, Craig Rodrigues wrote: >> >>

[Twisted-Python] Twisted trunk and klein?

Hi, I quickly asked Wilfredo if Twisted trunk worked with Klein, and he mentioned that he saw this dependency issue on the Twisted klein side when used with Twisted trunk: The conflict is caused by: The user requested idna==3.1 hyperlink 21.0.0 depends on idna>=2.5 requests 2.25.1 dep

Re: [Twisted-Python] Moving iocpsupport to an external package? Implications on Windows?

On Wednesday, February 10, 2021, Glyph wrote: > > > On Feb 10, 2021, at 12:40 AM, Craig Rodrigues > wrote: > > How will this patch change for people installing Twisted on Windows? > > Twisted is still used by a lot of users on Windows, and the IOCP Reactor is >

[Twisted-Python] Getting ready to do a release of Twisted

Thanks to review work by Tom Most, I have modified and merged https://github.com/twisted/twisted/pull/1502 which addresses test failures encountered against Buildbot's regression suite. I would like to proceed with doing a Twisted release. Does anyone have any PR's that they are working on that t

[Twisted-Python] Moving iocpsupport to an external package? Implications on Windows?

Looking at this PR: https://github.com/twisted/twisted/pull/1446 I see that iocpsupport was moved to a separate package, in order to make building wheels on Windows easier. Before this patch, I was prototyping building binary wheels on Windows of Twisted core, and I had it working. It looks lik

Re: [Twisted-Python] Developer docs should be updated on wiki when steps changed in code?

On Wednesday, February 3, 2021, Glyph wrote: > > > > Docs in the tree always win. > > Let's start deleting them now, and replacing them with links to the > in-tree docs, rather than updating them. They've been skewing out of date > for a long time. When I was looking for information about how to

[Twisted-Python] Developer docs should be updated on wiki when steps changed in code?

In this PR: https://github.com/twisted/twisted/pull/1461 some changes were made to the Twisted development process for running the various linters before committing code. I noticed that the changes in PR 1461 were not reflected in docs on the wiki, specifically here: https://twistedmatrix.com/trac

Re: [Twisted-Python] resolving release management conflict

On Mon, Feb 1, 2021 at 1:00 PM Glyph wrote: > > I believe the proximate cause of the conflict here is that we're dealing > with this regression incorrectly. When a regression is introduced, there's > a process for dealing with it, originally documented here: > https://twistedmatrix.com/trac/wiki

Re: [Twisted-Python] Upcoming Twisted Release

On Mon, Feb 1, 2021 at 11:27 AM Adi Roiban wrote: > Hi, > > So, speaking for myself here and not representing the Twisted community or > anyone else. > Thanks for making this clear that you are speaking for yourself and no one else. > * A release blocker bug - https://twistedmatrix.com/trac/t

Re: [Twisted-Python] Questions about Project Leadership committee

On Sat, Jan 23, 2021 at 4:54 PM Glyph wrote: > At the time the committee was created, I don’t remember if this was > public, so I don’t feel comfortable sharing identities publicly because it > wasn’t part of the deal at the time. This is not the way I’d structure > things now, but given that sev

[Twisted-Python] Questions about Project Leadership committee

Hi, I asked some questions about the Twisted project leadership committee here: https://twistedmatrix.com/pipermail/twisted-python/2020-December/065367.html but it looks like my questions got lost in the thread, and no one aso I will ask again. Who are the current members of the committee? What a

Re: [Twisted-Python] Upcoming Twisted Release

On Fri, Jan 15, 2021 at 10:42 AM Glyph wrote: > > > > Following up on this, since we are now officially past the "beginning" of > January: Craig, is a release imminent or can someone else pick up some > tasks yet? > > I'm close to getting this done, and want to complete this. -- Craig __

Re: [Twisted-Python] Plan/Goal for GitHub Sponsors

On Wed, Dec 23, 2020 at 1:41 PM Adi Roiban wrote: > Hi, > > I started a separate discussion to confirm the goal for a future > fundraising. > > Top priority - Pay someone to help with the review queue > Nice to have - Move server/services to Azure VM - We have at least $100 > monthly allowance f

Re: [Twisted-Python] Updating the project leadership committee

obably written down in some internal conservancy document, maybe. If we’re going to do something new, obviously it should be a bit more transparent. > > On December 28, 2020 at 5:52:08 PM, Craig Rodrigues ( rodr...@crodrigues.org) wrote: >> >> >> >> On Sat, Dec 26, 2020 at 2:

Re: [Twisted-Python] Upcoming Twisted Release

On Sun, Dec 27, 2020 at 3:59 PM Adi Roiban wrote: > > Is there anything still blocking you ? > Can I help? > I do not need specific help from you at the moment, but when I do, I will ask. Thanks. -- Craig ___ Twisted-Python mailing list Twisted-Pytho

Re: [Twisted-Python] Updating the project leadership committee

On Sat, Dec 26, 2020 at 2:01 PM Glyph wrote: > > I am *extremely *enthusiastic for your future reign on a new and improved > project leadership committee :-). Thank you for working on this! > > Where is the documentation for the existing Twisted Project Leadership Committee? I couldn't find it o

Re: [Twisted-Python] Upcoming Twisted Release

On Mon, Dec 28, 2020 at 10:04 AM Glyph wrote: > > From what I can see though, this one is a pretty straightforward case of > us just introducing a bug into a perfectly valid configuration though, just > not one we happen to have in our test matrix right now. > > I am working on this right now, a

Re: [Twisted-Python] Upcoming Twisted Release

On Sun, Dec 27, 2020 at 3:59 PM Adi Roiban wrote: > Hi Craig, > > On Sun, 27 Dec 2020 at 20:10, Craig Rodrigues > wrote: > >> >> >> On Sat, Dec 26, 2020 at 3:50 PM Adi Roiban wrote: >> >>> Hi, >>> >>> I plan to act as a release

Re: [Twisted-Python] Upcoming Twisted Release

On Sat, Dec 26, 2020 at 3:50 PM Adi Roiban wrote: > Hi, > > I plan to act as a release manager for the next release and follow the > plan documented at > > > https://docs.twistedmatrix.com/en/latest/core/development/policy/release-process.html > > I was previously working on releasing Twisted. I

Re: [Twisted-Python] Request for new Twisted release?

On Mon, Oct 12, 2020 at 11:36 AM Wilfredo Sánchez Vega < wsanc...@wsanchez.net> wrote: > > Craig: this does have to work around non-black output from incremental: > https://github.com/twisted/klein/blob/master/release.py#L86 > > I don't need this klein workaround at the moment. I can confirm th

Re: [Twisted-Python] Re-run Azure tests

On Mon, Oct 12, 2020 at 11:12 AM Adi Roiban wrote: > >> It looks like the re-run feature is broken. > > No, the re-run feature in Azure is not broken. I've managed to do it several times successfully. There might be some issue with your account access, but I don't know enough about Azure to kno

Re: [Twisted-Python] Request for new Twisted release?

On Sunday, October 4, 2020, Craig Rodrigues wrote: > On Sat, Oct 3, 2020 at 5:14 PM Glyph wrote: > >> >> >> >> Absolutely OK with me. More than OK. Please do this! I can't wait >> until we have the level of automation you've been working on f

Re: [Twisted-Python] Request for new Twisted release?

On Sat, Oct 3, 2020 at 5:14 PM Glyph wrote: > > > > Absolutely OK with me. More than OK. Please do this! I can't wait until > we have the level of automation you've been working on for *anybody* to > cut the release. I take it this means you'll officially be the release > manager for 20.10.0?

Re: [Twisted-Python] Request for new Twisted release?

On Wed, Sep 23, 2020 at 10:11 AM Glyph wrote: > > > On Sep 22, 2020, at 3:42 PM, Craig Rodrigues > wrote: > > Amber, > > Can we have a new Twisted release within the next two months, say in > Nov./Dec. timeframe, or > sooner if you'd like? > > > G

Re: [Twisted-Python] Twisted with pypy3 on Ubuntu 20.4, SSL error: 'ee key too small'

Adi, Thanks for the tip. Yes, increasing the key size in the tests definitely eliminated this error: https://github.com/twisted/twisted/pull/1411 -- Craig On Tue, Sep 29, 2020 at 3:34 PM Adi Roiban wrote: > > > On Tue, 29 Sep 2020 at 23:25, Craig Rodrigues > wrote: > >&g

[Twisted-Python] Twisted with pypy3 on Ubuntu 20.4, SSL error: 'ee key too small'

Hi, I ran an experiment to run the Twisted tests on Ubuntu 20.4 using this version of using pypy3: *Python 3.6.9 (2ad108f17bdb, Apr 07 2020, 02:29:05* *Pypy 7.3.1 with GCC 7.3.1 20180303 (Red Hat 7.3.1-5)* A bunch of the conch tests failed in this Ubuntu environment: https://github.com/twisted/

Re: [Twisted-Python] Request for new Twisted release?

Adi, In this Twisted subproject, you implemented something which releases to Pypi upon creation of a tag: https://github.com/twisted/twistedchecker/blob/master/.travis.yml#L23 Maybe we can do something similar for the main Twisted project. GitHub Actions allows you to run a specific workflow in

[Twisted-Python] Request for new Twisted release?

Amber, Can we have a new Twisted release within the next two months, say in Nov./Dec. timeframe, or sooner if you'd like? In Twisted trunk, there are a lot of things that would be good to have in a new release. Here are some of the high order items: *Python 3 Fixes* - twist dns --pyzone now

Re: [Twisted-Python] Only run Azure, Travis, or CircleCI if GitHub actions pass

On Sun, Sep 20, 2020 at 9:22 PM Glyph wrote: > > > On Sep 19, 2020, at 5:27 PM, Adi Roiban wrote: > > > > On Sat, 19 Sep 2020 at 21:30, Craig Rodrigues > wrote: > >> Adi, >> >> Is it possible to configure the CI so that >> Azure, Travis and C

[Twisted-Python] Only run Azure, Travis, or CircleCI if GitHub actions pass

Adi, Is it possible to configure the CI so that Azure, Travis and CircleCI only runs if GitHub actions pass? For example here: https://github.com/twisted/twisted/runs/1137175269 *Azure Pipelines* and *Travis* should only run if the GitHub actions pass. -- Craig

Re: [Twisted-Python] Broken Javascript on https://twistedmatrix.com ?

://www.paypalobjects.com/en_US/i/scr/pixel.gif' , I filed this bug: https://github.com/paypal/paypal-checkout-components/issues/1432 -- Craig On Thu, Sep 17, 2020 at 12:47 PM Craig Rodrigues wrote: > Doing a force refresh in my browser fixed it. I can now click on > *Publish/Subscribe* and swi

Re: [Twisted-Python] Broken Javascript on https://twistedmatrix.com ?

S in t-web, push to master, and then `fab > config.production t-web.update`. > > Good luck, > > -g > > P.S.: braid still requires python2, so anybody enthusiastic about python3 > porting is encouraged to take a look at it :-). > > On Sep 17, 2020, at 8:37 AM, Craig R

Re: [Twisted-Python] Broken Javascript on https://twistedmatrix.com ?

nchor tag with a relative href) is not being executed, > either because it is being blocked by the browser, or as a side-effect of > other things being blocked. > > Hope this helps, > > Daniel > -- > L. Daniel Burr > ldanielb...@me.com > (312) 656-8387 > > On Sep

[Twisted-Python] Broken Javascript on https://twistedmatrix.com ?

If I go to https://twistedmatrix.com and click on one of the tabs in the *Code Examples* section, such as *Publish/Subscribe*, the tab does not switch. This looks like a Javascript problem. Does anyone with knowledge of Javascript have an idea what the problem is? -- Craig __

Re: [Twisted-Python] code contribution/participation policy

On Sat, Sep 5, 2020 at 10:25 AM Boris Epstein wrote: > > Now how do I proceed? What is the convention for Git brach names, etc? > > This document should give you the steps to create a Git branch and proceed with a PR: https://twistedmatrix.com/trac/wiki/TwistedDevelopment#SubmittingaPatch -- Cr

[Twisted-Python] Pycodestyle disabled in trunk, time to enable black?

In this PR: https://github.com/twisted/twisted/pull/1365 pycodestyle was disabled in trunk in order to make it easier to merge changes and not have pycodestyle error out, due to the code not meeting existing Twisted style guidelines. So this means that the old pycodestyle is not enforced in trunk.

Re: [Twisted-Python] Change Trac /login link to point to /trac/github/login

that's probably the maximum energy I can personally afford to > dedicate to it :). > > On Aug 29, 2020, at 10:56 AM, Craig Rodrigues > wrote: > > If I am not logged in, and click on: > > https://twistedmatrix.com/trac/newticket > > It takes me to a page: > > Yo

[Twisted-Python] Change Trac /login link to point to /trac/github/login

If I am not logged in, and click on: https://twistedmatrix.com/trac/newticket It takes me to a page: You are currently not logged in. You may want to do so now. If I click on *do so*, it takes me to: No handler matched request to /login Can this be fixe

[Twisted-Python] mypy now mandatory for Twisted pull requests

Hi, In the Twisted trunk branch, I have reduced the number of errors reported by mypy to *zero!* You verify this by running: *tox -e mypy* In addition, I have worked with Adi to enable CI for Twisted checkins so that mypy is run for each pull request. Adi configured the GitHub repo to *require

Re: [Twisted-Python] Changing supported configurations regarding Unicode handling on Windows

On Mon, Jun 22, 2020 at 12:08 AM Glyph wrote: > > figure out a way to fix it after the immediate issue where folks with > non-ascii letters in their names can't submit PRs. > > Thanks so much for investigating! > > I worked with Michał Górny who helped me debug this. When Michał submits a PR fro

[Twisted-Python] mypy integrated with CI for twisted

I have merged some more fixes for mypy to Twisted trunk branch. In trunk, you can run mypy with: *tox -e mypy* Currently this results in *171* errors, which is way down from >1000 errors a month ago. In addition, if you look at any new PR's there is a *Mypy Ubuntu* job running on Azure pipeline

Re: [Twisted-Python] Running tests with monkeytype

On Sat, Jun 20, 2020 at 4:02 PM Tom Most wrote: > > Let's definitely move to type annotations, since they are much more likely > to be correct due to validation by MyPy. > > To start, we'll need to revise the Twisted coding standard [1] to permit > type annotations instead of @type lines in the d

[Twisted-Python] mypy: class ThreadPool has workers redefined

While looking at these mypy logs: https://dev.azure.com/twistedmatrix/twisted/_build/results?buildId=1904&view=logs&j=d78da089-4bf6-58fe-28a5-46635fd5b8d1&t=45ce7910-c28c-5e9a-4ee7-e041d314a5fc I found an interesting one: src/twisted/python/threadpool.py:84:6: error: Name 'workers' already defin

Re: [Twisted-Python] Question about FileDescriptor.loseConnection() signature found by mypy

submitted this: https://github.com/twisted/twisted/pull/1292 -- Craig On Tue, Jun 16, 2020 at 1:52 AM Glyph wrote: > > > > On Jun 15, 2020, at 8:43 PM, Craig Rodrigues > wrote: > > > > In twisted.internet.abstract.FileDescriptor.loseConnection, the > loseConnect

[Twisted-Python] Question about FileDescriptor.loseConnection() signature found by mypy

In twisted.internet.abstract.FileDescriptor.loseConnection, the loseConnection method is defined like: def loseConnection(self, _connDone=failure.Failure(main.CONNECTION_DONE)): while in twisted.internet._newtls.ConnectionMixin , we have: def loseConnection(self): If I run *tox -e mypy*

Re: [Twisted-Python] twistedchecker now uses pylint >= 2.4.4, can we use type annotations in Twisted now?

Thanks to Adi and Wilfredo who have reviewed my PR's. Currently in trunk, I have eliminated hundreds of mypy errors through a combination of trivial fixes to code, adding type annotations, and adding special comments to turn off mypy errors in a few places. I have one more pending PR ( https://gi

Re: [Twisted-Python] twistedchecker now uses pylint >= 2.4.4, can we use type annotations in Twisted now?

I have merged a few PR's to trunk which eliminate hundreds of errors encountered with: *tox -e mypy* I think we can take several passes with more PR's to whack away all these mypy errors, and turn on mypy as part of the default CI for Twisted. I have seen a few errors like: src/twisted/words/pr

Re: [Twisted-Python] [RFC] Drop support for Python 3.5 sometime after May 2021?

(Which has 3.5) falls > > into ESM, so maybe we can wait? > > I don't have strong feelings, but it is a datapoint. > > > > Moshe Z. > > > > On Wed, May 13, 2020, at 22:13, Glyph wrote: > > > On May 13, 2020, at 10:04 PM, Amber Brown (hawkowl) &

Re: [Twisted-Python] [RFC] Drop support for Python 3.5 sometime after May 2021?

On Wed, May 13, 2020 at 10:05 PM Amber Brown (hawkowl) < hawk...@atleastfornow.net> wrote: > > So, I guess if we have 3.8 support, the next release can announce the > dropping of 3.5, and then the release after that can be the final one > with support. > In trunk, on Python 3.8, all the tests in

[Twisted-Python] [RFC] Drop support for Python 3.5 sometime after May 2021?

I would like to propose that Twisted drop support for Python 3.5 one year from now in 2021. Reasons: 1. Python 3.5.9 will be the final release of Python 3.5, in November 2019 ( https://www.python.org/dev/peps/pep-0478/ ) 2. Python 3.6.0 was released in December 2016 ( https://www.python.org/dev

Re: [Twisted-Python] twistedchecker now uses pylint >= 2.4.4, can we use type annotations in Twisted now?

On Wed, Apr 22, 2020 at 12:28 AM Glyph wrote: > > > On Apr 21, 2020, at 8:57 PM, Craig Rodrigues > wrote: > > Does anyone else have opinions on > type hints and mypy? > > > We use them at work, and on some other Twisted projects (Klein) and > they're absolu

[Twisted-Python] twistedchecker now uses pylint >= 2.4.4, can we use type annotations in Twisted now?

Hi, Last week I did some work and updated twistedchecker so that it uses pylint >= 2.4.4. Before that, it was using a really old version of pylint. twistedchecker is run over the Twisted code as part of CI, and reports various style issues. Now that twistedchecker is using a newer pylint, it sh

[jenkinsci/jira-plugin] 9ae048: If issue.txt is empty, getIssue() should return nu...

Branch: refs/heads/master Home: https://github.com/jenkinsci/jira-plugin Commit: 9ae048c6aafb4d751f4b8b4998218aabf815573c https://github.com/jenkinsci/jira-plugin/commit/9ae048c6aafb4d751f4b8b4998218aabf815573c Author: Craig Rodrigues Date: 2020-02-26 (Wed, 26 Feb 2020

[jenkinsci/jira-plugin] 15ea74: Update screenshot of plugin configuration (#211)

Branch: refs/heads/master Home: https://github.com/jenkinsci/jira-plugin Commit: 15ea74f564e59679435542ad3ff774b8ff02ef52 https://github.com/jenkinsci/jira-plugin/commit/15ea74f564e59679435542ad3ff774b8ff02ef52 Author: Craig Rodrigues Date: 2020-02-20 (Thu, 20 Feb 2020

Re: [go-nuts] go test -c in go 1.13 does not include -test.timeout flag in binary?

On Monday, February 3, 2020 at 11:37:08 AM UTC-8, Ian Lance Taylor wrote: > > On Mon, Feb 3, 2020 at 8:13 AM Craig Rodrigues > wrote: > > > > Regarding the fact that I should not call flag.Parse() from inside an > init() method in my_test.go file, > > if a not

Re: [go-nuts] go test -c in go 1.13 does not include -test.timeout flag in binary?

On Friday, January 31, 2020 at 1:56:49 PM UTC-8, Ian Lance Taylor wrote: > > On Fri, Jan 31, 2020 at 10:33 AM Craig Rodrigues > wrote: > > > > Thanks for the response. I have a few questions. > > > > 1. In https://golang.org/pkg/flag/#Parse , would it be a

Re: [go-nuts] go test -c in go 1.13 does not include -test.timeout flag in binary?

On Friday, January 31, 2020 at 7:23:32 AM UTC-8, Ian Lance Taylor wrote: > > > Calling flag.Parse in an init function never worked reliably, unless > you took special care. Flags are themselves often defined in init > functions, so calling flag.Parse in an init function will see the > flags t

Re: [go-nuts] go test -c in go 1.13 does not include -test.timeout flag in binary?

On Thursday, January 30, 2020 at 11:03:04 PM UTC-8, Craig Rodrigues wrote: > > > > On Thursday, January 30, 2020 at 10:06:36 PM UTC-8, Ian Lance Taylor wrote: >> >> On Thu, Jan 30, 2020 at 9:43 PM Craig Rodrigues >> wrote: >> > I see here that this might

Re: [go-nuts] go test -c in go 1.13 does not include -test.timeout flag in binary?

On Thursday, January 30, 2020 at 10:06:36 PM UTC-8, Ian Lance Taylor wrote: > > On Thu, Jan 30, 2020 at 9:43 PM Craig Rodrigues > wrote: > > I see here that this might be related: > https://golang.org/doc/go1.13#testing > > > > Testing flags are

[go-nuts] go test -c in go 1.13 does not include -test.timeout flag in binary?

Hi, I ran a quick experiment in my source tree, and saw a difference in the behavior of "go test -c" between go 1.12 and go 1.13. EXPERIMENT 1: using docker image golang:1.12-alpine with go1.12.16 linux/amd64 --

Re: GitHub webhooks, where to put smee client if Jenkins is in a container?

Michael, I tried following your blog post: https://jenkins.io/blog/2019/01/07/webhook-firewalls/ I did the following additional steps not in your blog post using a Jenkins 2.190.2 server: 1. I configured the smee endpoint, https://smee.io/myendpoint 2. I ran the smee client, which just si

Re: GitHub webhooks, where to put smee client if Jenkins is in a container?

wrote: > Hi Craig - I think that you need the trailing slash (as per the blog - I > seem to recall it was very fickle about that, probably stapler!) > > On Sat, Nov 9, 2019 at 7:06 AM Craig Rodrigues > wrote: > >> Michael, >> >> It looks like the smee client has

Re: GitHub webhooks, where to put smee client if Jenkins is in a container?

Michael, It looks like the smee client has a *--target* option to specify where to send notifications to: *Usage: smee [options]Options: -v, --version output the version number -u, --url URL of the webhook proxy service. Default: https://smee.io/new

Re: GitHub webhooks, where to put smee client if Jenkins is in a container?

your Jenkins master instance is discoverable and > accessible from elsewhere from the cluster - which I guess it would be > right?). It only uses the REST api, and only the /github-webhook endpoint, > nothing else. > > On Fri, Oct 25, 2019 at 1:18 AM Craig Rodrigues > wrote: > >>

Re: GitHub webhooks, where to put smee client if Jenkins is in a container?

od-overview/ (look > for sidecar) > > So then it depends how you deployed that image into a pod (but to start > with would need to cook up an image with smee in it ready to go - I am not > sure if one exists yet). > > > > On Thu, Oct 24, 2019 at 5:39 PM Craig Rodrigues

GitHub webhooks, where to put smee client if Jenkins is in a container?

Michael, In your blog post: "Triggering builds with webhooks behind a secure firewall" https://jenkins.io/blog/2019/01/07/webhook-firewalls/ You gave a good overview of how someone can use webhooks invoked from GitHub in the cloud, to a Jenkins server which exists behind a firewall, using https:

[go-nuts] Cannot find libraries at go.pedge.io by Peter Edge

I have a package where the dependencies were vendored in a few years ago using govendor. I am trying to convert the vendor tree from govendor to go modules. I a having problems finding libraries written by Peter Edge, which had a DNS entry of go.pedge.io: "path": "go.pedge.io/env",

[jenkinsci/slack-plugin] 24ce84: Catch possible JSON exceptions when parsing respon...

Branch: refs/heads/master Home: https://github.com/jenkinsci/slack-plugin Commit: 24ce8464c08eda5c7f3ae045f3937aa577b0885f https://github.com/jenkinsci/slack-plugin/commit/24ce8464c08eda5c7f3ae045f3937aa577b0885f Author: Craig Rodrigues Date: 2019-07-26 (Fri, 26 Jul 2019

[Python-buildbots] Buildbot 2.1.0 and TLS between master and worker

Buildbot 2.1.0 (which is running at https://buildbot.python.org/all/ ) now supports TLS between a buildbot worker and the buildbot master. There is an example of setting this up here: http://docs.buildbot.net/current/manual/installation/worker.html#worker-tls-configuration For folks interested i

[jenkinsci/extended-choice-parameter-plugin] c795ff: [JENKINS-34617] Add a @Symbol for "extendedChoice"...

Branch: refs/heads/master Home: https://github.com/jenkinsci/extended-choice-parameter-plugin Commit: c795ff083b954d0120aeb2c59cd4c09935fb35c0 https://github.com/jenkinsci/extended-choice-parameter-plugin/commit/c795ff083b954d0120aeb2c59cd4c09935fb35c0 Author: Craig Rodrigues

  1   2   3   4   5   6   7   8   9   10   >