[U-Boot] [PATCHv2] OMAP: Fix compile issue
Fixes this compile error: board.c: In function 'do_switch_ecc': board.c:339: error: 'cmd_tbl_t' has no member named 'help' make[1]: *** [board.o] Error 1 make[1]: Leaving directory `/db/psp_git/users/a0756819/u-boot/cpu/arm_cortexa8/omap3' make: *** [cpu/arm_cortexa8/omap3/libomap3.a] Error 2 This is due to the fact that current command uses long help for the usage print even if the CONFIG_SYS_LONGHELP is not enabled. (Thanks Jean-Christophe for explanation). Signed-off-by: Sanjeev Premi --- cpu/arm_cortexa8/omap3/board.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cpu/arm_cortexa8/omap3/board.c b/cpu/arm_cortexa8/omap3/board.c index 7bb3e28..15ea936 100644 --- a/cpu/arm_cortexa8/omap3/board.c +++ b/cpu/arm_cortexa8/omap3/board.c @@ -331,7 +331,7 @@ static int do_switch_ecc(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[]) return 0; usage: - printf ("Usage: nandecc %s\n", cmdtp->help); + printf ("Usage: nandecc %s\n", cmdtp->usage); return 1; } -- 1.6.2.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] s3c64xx: move reset_cpu to soc and support the soft reset at s3c6410
This patch support the soft reset at s3c6410 Signed-off-by: Minkyu Kang --- cpu/arm1176/cpu.c| 16 cpu/arm1176/s3c64xx/interrupts.c | 15 +++ include/s3c6400.h|5 + 3 files changed, 20 insertions(+), 16 deletions(-) diff --git a/cpu/arm1176/cpu.c b/cpu/arm1176/cpu.c index 1e94f7d..fe41290 100644 --- a/cpu/arm1176/cpu.c +++ b/cpu/arm1176/cpu.c @@ -107,22 +107,6 @@ int cleanup_before_linux (void) return 0; } - -/* * reset the cpu by setting up the watchdog timer and let him time out */ -void reset_cpu (ulong ignored) -{ - printf("reset... \n\n\n"); - SW_RST_REG = 0x6400; - /* loop forever and wait for reset to happen */ - while (1) { - if (serial_tstc()) { - serial_getc(); - break; - } - } - /*NOTREACHED*/ -} - int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]) { disable_interrupts (); diff --git a/cpu/arm1176/s3c64xx/interrupts.c b/cpu/arm1176/s3c64xx/interrupts.c index 83f3806..e68f3ae 100644 --- a/cpu/arm1176/s3c64xx/interrupts.c +++ b/cpu/arm1176/s3c64xx/interrupts.c @@ -175,3 +175,18 @@ void udelay(unsigned long usec) while (get_ticks() < tmp)/* loop till event */ /*NOP*/; } + +/* reset the cpu by setting up the watchdog timer and let him time out */ +void reset_cpu(ulong ignored) +{ + printf("reset... \n\n\n"); + SW_RST_REG = SW_RST_CODE; + /* loop forever and wait for reset to happen */ + while (1) { + if (serial_tstc()) { + serial_getc(); + break; + } + } + /*NOTREACHED*/ +} diff --git a/include/s3c6400.h b/include/s3c6400.h index fd3e99b..4bf5a7f 100644 --- a/include/s3c6400.h +++ b/include/s3c6400.h @@ -203,6 +203,11 @@ #define INF_REG6 (ELFIN_CLOCK_POWER_BASE + INF_REG6_OFFSET) #define INF_REG7 (ELFIN_CLOCK_POWER_BASE + INF_REG7_OFFSET) +#if defined(CONFIG_S3C6410) +#define SW_RST_CODE0x6410 +#else +#define SW_RST_CODE0x6400 +#endif /* * GPIO ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/2] 85xx: Fix the clock adjust of mpc8569mds board
Currently the clk_adj is 6 (3/4 cycle), The settings will cause the DDR controller hang at the data init. Change the clk_adj from 6 to 4 (1/2 cycle), make the memory system stable. Signed-off-by: Dave Liu --- board/freescale/mpc8569mds/ddr.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/board/freescale/mpc8569mds/ddr.c b/board/freescale/mpc8569mds/ddr.c index 4b4533e..e938788 100644 --- a/board/freescale/mpc8569mds/ddr.c +++ b/board/freescale/mpc8569mds/ddr.c @@ -54,7 +54,7 @@ void fsl_ddr_board_options(memctl_options_t *popts, * 01103/4 cycle late * 01117/8 cycle late */ - popts->clk_adjust = 6; + popts->clk_adjust = 4; /* * Factors to consider for CPO: -- 1.5.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 2/2] 85xx: add the nfsboot/ramboot to default environment
Give the MPC8569MDS board one default environment var. Signed-off-by: Dave Liu --- include/configs/MPC8569MDS.h | 72 -- 1 files changed, 41 insertions(+), 31 deletions(-) diff --git a/include/configs/MPC8569MDS.h b/include/configs/MPC8569MDS.h index b0af5dc..7fd2b56 100644 --- a/include/configs/MPC8569MDS.h +++ b/include/configs/MPC8569MDS.h @@ -409,46 +409,56 @@ extern unsigned long get_clock_freq(void); * Environment Configuration */ #define CONFIG_HOSTNAME mpc8569mds -#define CONFIG_ROOTPATH /nfsroot -#define CONFIG_BOOTFILE your.uImage +#define CONFIG_ROOTPATH /tftpboot +#define CONFIG_BOOTFILE uImage.8569 +#define CONFIG_HAS_ETH0 +#define CONFIG_ETHADDR 00:E0:0C:85:69:01 +#define CONFIG_HAS_ETH1 +#define CONFIG_ETH1ADDR00:E0:0C:85:69:02 + +#define CONFIG_IPADDR192.168.1.100 #define CONFIG_SERVERIP 192.168.1.1 -#define CONFIG_GATEWAYIP 192.168.1.1 +#define CONFIG_GATEWAYIP 192.168.1.254 #define CONFIG_NETMASK 255.255.255.0 -#define CONFIG_LOADADDR 20 /*default location for tftp and bootm*/ +#define CONFIG_LOADADDR 100 /*default location for tftp and bootm*/ #define CONFIG_BOOTDELAY 10 /* -1 disables auto-boot */ #undef CONFIG_BOOTARGS /* the boot command will set bootargs*/ #define CONFIG_BAUDRATE115200 -#defineCONFIG_EXTRA_ENV_SETTINGS \ - "netdev=eth0\0" \ - "consoledev=ttyS0\0"\ - "ramdiskaddr=60\0" \ - "ramdiskfile=your.ramdisk.u-boot\0" \ - "fdtaddr=40\0" \ - "fdtfile=your.fdt.dtb\0"\ - "nfsargs=setenv bootargs root=/dev/nfs rw " \ - "nfsroot=$serverip:$rootpath " \ - "ip=$ipaddr:$serverip:$gatewayip:$netmask:$hostname:$netdev:off " \ - "console=$consoledev,$baudrate $othbootargs\0" \ - "ramargs=setenv bootargs root=/dev/ram rw " \ - "console=$consoledev,$baudrate $othbootargs\0" \ - -#define CONFIG_NFSBOOTCOMMAND \ - "run nfsargs;" \ - "tftp $loadaddr $bootfile;" \ - "tftp $fdtaddr $fdtfile;" \ - "bootm $loadaddr - $fdtaddr" - -#define CONFIG_RAMBOOTCOMMAND \ - "run ramargs;" \ - "tftp $ramdiskaddr $ramdiskfile;" \ - "tftp $loadaddr $bootfile;" \ - "bootm $loadaddr $ramdiskaddr" - -#define CONFIG_BOOTCOMMAND CONFIG_NFSBOOTCOMMAND +#defineCONFIG_EXTRA_ENV_SETTINGS \ + "netdev=eth0\0" \ + "uboot=u-boot.8569\0" \ + "tftpflash=tftpboot $loadaddr $uboot; " \ + "protect off " MK_STR(TEXT_BASE) " +$filesize; "\ + "erase " MK_STR(TEXT_BASE) " +$filesize; " \ + "cp.b $loadaddr " MK_STR(TEXT_BASE) " $filesize; " \ + "protect on " MK_STR(TEXT_BASE) " +$filesize; " \ + "cmp.b $loadaddr " MK_STR(TEXT_BASE) " $filesize\0" \ + "consoledev=ttyS0\0" \ + "ramdiskaddr=200\0" \ + "ramdiskfile=ramdisk.8569\0" \ + "fdtaddr=c0\0"\ + "fdtfile=dtb.8569\0" + +#define CONFIG_NFSBOOTCOMMAND \ + "setenv bootargs root=/dev/nfs rw " \ + "nfsroot=$serverip:$rootpath "\ + "ip=$ipaddr:$serverip:$gatewayip:$netmask:$hostname:$netdev:off " \ + "console=$consoledev,$baudrate $othbootargs;" \ + "tftp $loadaddr $bootfile;" \ + "tftp $fdtaddr $fdtfile;" \ + "bootm $loadaddr - $fdtaddr" + +#define CONFIG_RAMBOOTCOMMAND \ + "setenv bootargs root=/dev/ram rw " \ + "console=$consoledev,$baudrate $othbootargs;" \ + "tftp $ramdiskaddr $ramdiskfile;" \ + "tftp $loadaddr $bootfile;" \ + "tftp $fdtaddr $fdtfile;" \ + "bootm $loadaddr $ramdiskaddr $fdtaddr" #endif /* __CONFIG_H */ -- 1.5.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] drivers/usb: regorganisation
move to linux usb driver organisation as following drivers/usb/gadget drivers/usb/host drivers/usb/musb Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD Cc: Remy Bohmer --- Hi Remy, This version containt everyone ask and is based on the AT91 tree which contain the patch that move the at91 usb to drivers/usb Best Regards, J. Makefile |4 +- drivers/serial/usbtty.c|2 +- drivers/serial/usbtty.h|6 +- drivers/usb/{ => gadget}/Makefile | 30 +++-- drivers/usb/{usbdcore.c => gadget/core.c} |2 +- drivers/usb/{usbdcore_ep0.c => gadget/ep0.c} |2 +- include/usbdcore_ep0.h => drivers/usb/gadget/ep0.h |0 .../usb/{usbdcore_mpc8xx.c => gadget/mpc8xx_udc.c} |9 ++-- .../{usbdcore_omap1510.c => gadget/omap1510_udc.c} |6 +- drivers/usb/{ => host}/Makefile| 37 +-- drivers/usb/{usb_ehci_core.h => host/ehci-core.h} |0 drivers/usb/{usb_ehci_fsl.c => host/ehci-fsl.c}|6 +- drivers/usb/{usb_ehci_fsl.h => host/ehci-fsl.h}|0 drivers/usb/{usb_ehci_core.c => host/ehci-hcd.c} |3 +- drivers/usb/{usb_ehci_ixp.c => host/ehci-ixp4xx.c} |5 +- drivers/usb/{usb_ehci_pci.c => host/ehci-pci.c}|5 +- drivers/usb/{usb_ehci_vct.c => host/ehci-vct.c}|4 +- drivers/usb/{usb_ehci.h => host/ehci.h}|0 drivers/usb/{ => host}/isp116x-hcd.c |0 drivers/usb/{ => host}/isp116x.h |0 drivers/usb/{atmel_usb.c => host/ohci-at91.c} |0 drivers/usb/{usb_ohci.c => host/ohci-hcd.c}|3 +- drivers/usb/{usb_ohci.h => host/ohci.h}|0 drivers/usb/{ => host}/r8a66597-hcd.c |0 drivers/usb/{ => host}/r8a66597.h |0 drivers/usb/{s3c64xx_usb.c => host/s3c64xx-hcd.c} |0 drivers/usb/{sl811_usb.c => host/sl811-hcd.c} |2 +- drivers/usb/{ => host}/sl811.h |0 drivers/usb/musb/Makefile | 47 drivers/usb/{davinci_usb.c => musb/davinci.c} |2 +- drivers/usb/{davinci_usb.h => musb/davinci.h} |0 drivers/usb/{ => musb}/musb_core.c |0 drivers/usb/{ => musb}/musb_core.h |0 drivers/usb/{ => musb}/musb_hcd.c |0 drivers/usb/{ => musb}/musb_hcd.h |0 include/{usbdcore_mpc8xx.h => usb/mpc8xx_udc.h}|0 .../{usbdcore_omap1510.h => usb/omap1510_udc.h}|0 include/{usbdcore.h => usbdevice.h}|0 38 files changed, 100 insertions(+), 75 deletions(-) copy drivers/usb/{ => gadget}/Makefile (60%) rename drivers/usb/{usbdcore.c => gadget/core.c} (99%) rename drivers/usb/{usbdcore_ep0.c => gadget/ep0.c} (99%) rename include/usbdcore_ep0.h => drivers/usb/gadget/ep0.h (100%) rename drivers/usb/{usbdcore_mpc8xx.c => gadget/mpc8xx_udc.c} (99%) rename drivers/usb/{usbdcore_omap1510.c => gadget/omap1510_udc.c} (99%) rename drivers/usb/{ => host}/Makefile (64%) rename drivers/usb/{usb_ehci_core.h => host/ehci-core.h} (100%) rename drivers/usb/{usb_ehci_fsl.c => host/ehci-fsl.c} (97%) rename drivers/usb/{usb_ehci_fsl.h => host/ehci-fsl.h} (100%) rename drivers/usb/{usb_ehci_core.c => host/ehci-hcd.c} (99%) rename drivers/usb/{usb_ehci_ixp.c => host/ehci-ixp4xx.c} (96%) rename drivers/usb/{usb_ehci_pci.c => host/ehci-pci.c} (97%) rename drivers/usb/{usb_ehci_vct.c => host/ehci-vct.c} (96%) rename drivers/usb/{usb_ehci.h => host/ehci.h} (100%) rename drivers/usb/{ => host}/isp116x-hcd.c (100%) rename drivers/usb/{ => host}/isp116x.h (100%) rename drivers/usb/{atmel_usb.c => host/ohci-at91.c} (100%) rename drivers/usb/{usb_ohci.c => host/ohci-hcd.c} (99%) rename drivers/usb/{usb_ohci.h => host/ohci.h} (100%) rename drivers/usb/{ => host}/r8a66597-hcd.c (100%) rename drivers/usb/{ => host}/r8a66597.h (100%) rename drivers/usb/{s3c64xx_usb.c => host/s3c64xx-hcd.c} (100%) rename drivers/usb/{sl811_usb.c => host/sl811-hcd.c} (99%) rename drivers/usb/{ => host}/sl811.h (100%) create mode 100644 drivers/usb/musb/Makefile rename drivers/usb/{davinci_usb.c => musb/davinci.c} (99%) rename drivers/usb/{davinci_usb.h => musb/davinci.h} (100%) rename drivers/usb/{ => musb}/musb_core.c (100%) rename drivers/usb/{ => musb}/musb_core.h (100%) rename drivers/usb/{ => musb}/musb_hcd.c (100%) rename drivers/usb/{ => musb}/musb_hcd.h (100%) rename include/{usbdcore_mpc8xx.h => usb/mpc8xx_udc.h} (100%) rename include/{usbdcore_omap1510.h => usb/omap1510_udc.h} (100%) rename include/{usbdcore.h => usbdevice.h} (100%) diff --git a/Makefile b/Makefile index 39c1903..b946009 100644 --- a/Makefile +++ b/Makefile @@ -263,7 +263,9 @@ endif LIBS += drivers/rtc/librtc.a LIBS += drivers/serial/libserial.a LIBS += drivers/twserial/libtws.a -LIBS += drivers/usb/libusb.a +LIBS += drivers/u
Re: [U-Boot] [PATCH] drivers/usb: regorganisation
Hello Jean-Christophe, 2009/4/3 Jean-Christophe PLAGNIOL-VILLARD : > move to linux usb driver organisation > > as following > > drivers/usb/gadget > drivers/usb/host > drivers/usb/musb > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > Cc: Remy Bohmer > --- > Hi Remy, > This version containt everyone ask > and is based on the AT91 tree > which contain the patch that move the at91 usb to drivers/usb I will wait until the at91 has been pulled by mainline, then I can integrate this patch in the usb-branch Thanks. Remy > > Best Regards, > J. > Makefile | 4 +- > drivers/serial/usbtty.c | 2 +- > drivers/serial/usbtty.h | 6 +- > drivers/usb/{ => gadget}/Makefile | 30 +++-- > drivers/usb/{usbdcore.c => gadget/core.c} | 2 +- > drivers/usb/{usbdcore_ep0.c => gadget/ep0.c} | 2 +- > include/usbdcore_ep0.h => drivers/usb/gadget/ep0.h | 0 > .../usb/{usbdcore_mpc8xx.c => gadget/mpc8xx_udc.c} | 9 ++-- > .../{usbdcore_omap1510.c => gadget/omap1510_udc.c} | 6 +- > drivers/usb/{ => host}/Makefile | 37 +-- > drivers/usb/{usb_ehci_core.h => host/ehci-core.h} | 0 > drivers/usb/{usb_ehci_fsl.c => host/ehci-fsl.c} | 6 +- > drivers/usb/{usb_ehci_fsl.h => host/ehci-fsl.h} | 0 > drivers/usb/{usb_ehci_core.c => host/ehci-hcd.c} | 3 +- > drivers/usb/{usb_ehci_ixp.c => host/ehci-ixp4xx.c} | 5 +- > drivers/usb/{usb_ehci_pci.c => host/ehci-pci.c} | 5 +- > drivers/usb/{usb_ehci_vct.c => host/ehci-vct.c} | 4 +- > drivers/usb/{usb_ehci.h => host/ehci.h} | 0 > drivers/usb/{ => host}/isp116x-hcd.c | 0 > drivers/usb/{ => host}/isp116x.h | 0 > drivers/usb/{atmel_usb.c => host/ohci-at91.c} | 0 > drivers/usb/{usb_ohci.c => host/ohci-hcd.c} | 3 +- > drivers/usb/{usb_ohci.h => host/ohci.h} | 0 > drivers/usb/{ => host}/r8a66597-hcd.c | 0 > drivers/usb/{ => host}/r8a66597.h | 0 > drivers/usb/{s3c64xx_usb.c => host/s3c64xx-hcd.c} | 0 > drivers/usb/{sl811_usb.c => host/sl811-hcd.c} | 2 +- > drivers/usb/{ => host}/sl811.h | 0 > drivers/usb/musb/Makefile | 47 > > drivers/usb/{davinci_usb.c => musb/davinci.c} | 2 +- > drivers/usb/{davinci_usb.h => musb/davinci.h} | 0 > drivers/usb/{ => musb}/musb_core.c | 0 > drivers/usb/{ => musb}/musb_core.h | 0 > drivers/usb/{ => musb}/musb_hcd.c | 0 > drivers/usb/{ => musb}/musb_hcd.h | 0 > include/{usbdcore_mpc8xx.h => usb/mpc8xx_udc.h} | 0 > .../{usbdcore_omap1510.h => usb/omap1510_udc.h} | 0 > include/{usbdcore.h => usbdevice.h} | 0 > 38 files changed, 100 insertions(+), 75 deletions(-) > copy drivers/usb/{ => gadget}/Makefile (60%) > rename drivers/usb/{usbdcore.c => gadget/core.c} (99%) > rename drivers/usb/{usbdcore_ep0.c => gadget/ep0.c} (99%) > rename include/usbdcore_ep0.h => drivers/usb/gadget/ep0.h (100%) > rename drivers/usb/{usbdcore_mpc8xx.c => gadget/mpc8xx_udc.c} (99%) > rename drivers/usb/{usbdcore_omap1510.c => gadget/omap1510_udc.c} (99%) > rename drivers/usb/{ => host}/Makefile (64%) > rename drivers/usb/{usb_ehci_core.h => host/ehci-core.h} (100%) > rename drivers/usb/{usb_ehci_fsl.c => host/ehci-fsl.c} (97%) > rename drivers/usb/{usb_ehci_fsl.h => host/ehci-fsl.h} (100%) > rename drivers/usb/{usb_ehci_core.c => host/ehci-hcd.c} (99%) > rename drivers/usb/{usb_ehci_ixp.c => host/ehci-ixp4xx.c} (96%) > rename drivers/usb/{usb_ehci_pci.c => host/ehci-pci.c} (97%) > rename drivers/usb/{usb_ehci_vct.c => host/ehci-vct.c} (96%) > rename drivers/usb/{usb_ehci.h => host/ehci.h} (100%) > rename drivers/usb/{ => host}/isp116x-hcd.c (100%) > rename drivers/usb/{ => host}/isp116x.h (100%) > rename drivers/usb/{atmel_usb.c => host/ohci-at91.c} (100%) > rename drivers/usb/{usb_ohci.c => host/ohci-hcd.c} (99%) > rename drivers/usb/{usb_ohci.h => host/ohci.h} (100%) > rename drivers/usb/{ => host}/r8a66597-hcd.c (100%) > rename drivers/usb/{ => host}/r8a66597.h (100%) > rename drivers/usb/{s3c64xx_usb.c => host/s3c64xx-hcd.c} (100%) > rename drivers/usb/{sl811_usb.c => host/sl811-hcd.c} (99%) > rename drivers/usb/{ => host}/sl811.h (100%) > create mode 100644 drivers/usb/musb/Makefile > rename drivers/usb/{davinci_usb.c => musb/davinci.c} (99%) > rename drivers/usb/{davinci_usb.h => musb/davinci.h} (100%) > rename drivers/usb/{ => musb}/musb_core.c (100%) > rename drivers/usb/{ => musb}/musb_core.h (100%) > rename drivers/usb/{ => musb}/musb_hcd.c (100%) > rename drivers/usb/{ => musb}/musb_hcd.h (100%) > rename include/{usbdcore_mpc8xx.h => usb/mpc8xx_udc.h} (100%) > rename includ
Re: [U-Boot] [PATCH] s3c64xx: move reset_cpu to soc and support the soft reset at s3c6410
On 17:51 Fri 03 Apr , Minkyu Kang wrote: > This patch support the soft reset at s3c6410 > > Signed-off-by: Minkyu Kang > --- > cpu/arm1176/cpu.c| 16 > cpu/arm1176/s3c64xx/interrupts.c | 15 +++ > include/s3c6400.h|5 + > 3 files changed, 20 insertions(+), 16 deletions(-) > > diff --git a/cpu/arm1176/cpu.c b/cpu/arm1176/cpu.c > index 1e94f7d..fe41290 100644 > --- a/cpu/arm1176/cpu.c > +++ b/cpu/arm1176/cpu.c > @@ -107,22 +107,6 @@ int cleanup_before_linux (void) > return 0; > } > > - > -/* * reset the cpu by setting up the watchdog timer and let him time out */ > -void reset_cpu (ulong ignored) > -{ > - printf("reset... \n\n\n"); > - SW_RST_REG = 0x6400; > - /* loop forever and wait for reset to happen */ > - while (1) { > - if (serial_tstc()) { > - serial_getc(); > - break; > - } > - } > - /*NOTREACHED*/ > -} > - > int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]) > { > disable_interrupts (); > diff --git a/cpu/arm1176/s3c64xx/interrupts.c > b/cpu/arm1176/s3c64xx/interrupts.c cpu.c will be better because interrupts.c will be rename timer.c with the new timer cleanup work > index 83f3806..e68f3ae 100644 > --- a/cpu/arm1176/s3c64xx/interrupts.c > +++ b/cpu/arm1176/s3c64xx/interrupts.c > @@ -175,3 +175,18 @@ void udelay(unsigned long usec) > while (get_ticks() < tmp)/* loop till event */ >/*NOP*/; > } > + > +/* reset the cpu by setting up the watchdog timer and let him time out */ > +void reset_cpu(ulong ignored) > +{ > + printf("reset... \n\n\n"); > + SW_RST_REG = SW_RST_CODE; writel? > + /* loop forever and wait for reset to happen */ > + while (1) { > + if (serial_tstc()) { > + serial_getc(); > + break; > + } > + } > + /*NOTREACHED*/ > +} Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Compilation warning: "MSR_RI" redefined
Hi, > On Apr 2, 2009, at 4:03 AM, Stefan Roese wrote: > >> On Thursday 02 April 2009, Detlev Zundel wrote: I suggest to either remove this MSI_RI from the header again (it doesn't seem to be used here) or rename it. >>> >>> Ok, so much for the plan to add the defines not bit by bit as needed, >>> but register-wise, while we're there. >>> >>> I actually would prefer to use UART_MSR_RI, as this is a UART thingy >>> rather than to remove the define as we surely use the register, so I >>> feel it worthwhile to have the whole definition on board. >> >> That's my preference as well. > > Agreed, when I saw MSR_RI I wasn't thinking UART at all. That's really context specific. Looking at 16550 registers for a day, I forgot the "other" meaning of MSR ;) Attached is a patch which fixes this fallout and starts a round of cleanups. Thanks Detlev -- Alisa Sherer (AMD) suggested that consumer demand will not follow faster clock speeds. Marketing might help with this problem, she added.-- 2004/02/20 -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de >From 92a20fe9a3004cbd3685491ca51054e6cb6ba1e3 Mon Sep 17 00:00:00 2001 From: Detlev Zundel Date: Fri, 3 Apr 2009 11:53:01 +0200 Subject: [PATCH] Rename common ns16550 constants with UART_ prefix to prevent conflicts Fix problems introduced in commit 7b5611cdd12ca0cc33f994f0d4a4454788fc3124 [inka4x0: Add hardware diagnosis functions for inka4x0] which redefined MSR_RI which is already used on PowerPC systems. Also eliminate redundant definitions in ps2mult.h. More cleanup will be needed for other redundant occurrences though. Signed-off-by: Detlev Zundel --- board/inka4x0/inkadiag.c | 20 board/linkstation/avr.c |6 +- drivers/input/ps2ser.c | 22 drivers/serial/ns16550.c | 39 +++-- include/ns16550.h| 135 +++-- include/ps2mult.h| 99 - 6 files changed, 139 insertions(+), 182 deletions(-) diff --git a/board/inka4x0/inkadiag.c b/board/inka4x0/inkadiag.c index 06c9807..12c0a85 100644 --- a/board/inka4x0/inkadiag.c +++ b/board/inka4x0/inkadiag.c @@ -280,48 +280,48 @@ static int do_inkadiag_serial(cmd_tbl_t *cmdtp, int flag, int argc, if ((num >= 0) && (num <= 7)) { if (mode & 1) { /* turn on 'loopback' mode */ - out_8(&uart->mcr, MCR_LOOP); + out_8(&uart->mcr, UART_MCR_LOOP); } else { /* * establish the UART's operational parameters * set DLAB=1, so rbr accesses DLL */ - out_8(&uart->lcr, LCR_DLAB); + out_8(&uart->lcr, UART_LCR_DLAB); /* set baudrate */ out_8(&uart->rbr, combrd); /* set data-format: 8-N-1 */ - out_8(&uart->lcr, LCR_WLS_8); + out_8(&uart->lcr, UART_LCR_WLS_8); } if (mode & 2) { /* set request to send */ - out_8(&uart->mcr, MCR_RTS); + out_8(&uart->mcr, UART_MCR_RTS); udelay(10); /* check clear to send */ - if ((in_8(&uart->msr) & MSR_CTS) == 0x00) + if ((in_8(&uart->msr) & UART_MSR_CTS) == 0x00) return -1; } if (mode & 4) { /* set data terminal ready */ - out_8(&uart->mcr, MCR_DTR); + out_8(&uart->mcr, UART_MCR_DTR); udelay(10); /* check data set ready and carrier detect */ - if ((in_8(&uart->msr) & (MSR_DSR | MSR_DCD)) - != (MSR_DSR | MSR_DCD)) + if ((in_8(&uart->msr) & (UART_MSR_DSR | UART_MSR_DCD)) + != (UART_MSR_DSR | UART_MSR_DCD)) return -1; } /* write each message-character, read it back, and display it */ for (i = 0, len = strlen(argv[3]); i < len; ++i) { j = 0; - while ((in_8(&uart->lsr) & LSR_THRE) == 0x00) { + while ((in_8(&uart->lsr) & UART_LSR_THRE) == 0x00) { if (j++ > CONFIG_SYS_HZ) break; udelay(10); } out_8(&uart->rbr, argv[3][i]); j = 0; - while ((in_8(&uart->lsr) & LSR_DR) == 0x00) { + while ((in_8(&uart->lsr) & UART_LSR_DR) == 0x00) { if (j++ > CONFIG_SYS_HZ) break; udelay(10); diff --git a/board/linkstation/avr.c b/board/linkstation/avr.c index fda1b91..782b24a 100644 --- a/board/linkstation/avr.c +++ b/board/linkstation/avr.c @@ -90,12 +90,12 @@ void init_AVR_DUART (void) */ AVR_port->lcr = 0x00; AVR_port->ier = 0x00; - AVR_port->lcr = LCR_BKSE; + AVR_port->lcr = UART_LCR_BKSE; AVR_port->dll = clock_divisor & 0xff; AVR_port->dlm = (clock_divisor >> 8) & 0xff; - AVR_port->lcr = LCR_WLS_8 | LCR_PEN | LCR_EPS; + AVR_port->lcr = UART_LCR_WLS_8 | UART_LCR_PEN | UART_LCR_EPS; AVR_port->mcr = 0x00; - AVR_port->fcr = FCR_FIFO_EN | FCR_RXSR | FCR_TXSR; + AVR_port->fcr = UART_FCR_FIFO_EN | UART_FCR_RXSR | UART_FCR_TXSR; miconCntl_DisWDT(); diff --git a/drivers/input/ps2ser.c b/drivers/input/ps2ser.c index 1af3fde..1a5e2d4 100644 --- a/drivers/input/ps2ser.c +++ b/drivers/in
Re: [U-Boot] Help about a simplified bootloader.
On 14:44 Fri 03 Apr , os user wrote: > Hi all, > > I want to boot linux by a simplified bootloader. I use Atmel's ARM > chip (AT91SAM9RL64EK board). Now, I can boot linux with my small > program. The small program will parse the image generaed by "mkimage" > and copy the kernel bianry from NAND flash to SDRAM, construct the tag > list, disable I/D cache, disable interrupt and then jump to kernel > entry point. The system can startup, but when accessing rootfile > system(the rootfile system was also in the NAND chip), a lot of CRC > errors were found. See below, > mtd->read(0x1fb2c bytes from 0x1804d4) returned ECC error > mtd->read(0x1fa38 bytes from 0x3e05c8) returned ECC error > mtd->read(0x1f7dc bytes from 0x7c0824) returned ECC error > jffs2_scan_inode_node(): CRC failed on node at 0x007c37a4: Read > 0xd9b2bc33, calculated 0xda4805c1 > > and sometimes the sytem even crashed when R/W filesystem. > > But with the same linux kernel and rootfile system, if I use U-Boot to > boot linux, everything seems OK. > > Can anyone tell is there any trick that's related with linux NAND > driver in U-Boot? Or any suggestion to help me moving on? use U-Boot or Atmel Bootstrap Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] s3c64xx: fix the wrong gpio offset
On 09:56 Fri 03 Apr , Minkyu Kang wrote: > This patch fix the wrong gpio offset > > Signed-off-by: Minkyu Kang > --- Applied Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] at91: change CONFIG_SYS_HZ to 1000
Jean-Christophe PLAGNIOL-VILLARD wrote: > I've send a new patch that introduce an improve of the clock on at91 > which give you the calculated main_clock based on the main crystal and the > lowlevel settings I was looking for that patch in git://git.denx.de/u-boot-at91.git, but couldn't find it there (it should add a new file cpu/arm926ejs/at91/clock.c, correct?). Where can I find that patch? Best Regards, Detlef ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] at91: change CONFIG_SYS_HZ to 1000
Detlef Vollmann a écrit : > Jean-Christophe PLAGNIOL-VILLARD wrote: >> I've send a new patch that introduce an improve of the clock on at91 >> which give you the calculated main_clock based on the main crystal and the >> lowlevel settings > I was looking for that patch in git://git.denx.de/u-boot-at91.git, > but couldn't find it there (it should add a new file > cpu/arm926ejs/at91/clock.c, correct?). > Where can I find that patch? > http://article.gmane.org/gmane.comp.boot-loaders.u-boot/56837 Is it interesting to loose time calculating PLL values at each boot when these value can be defined in the board config file ? Eric ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] at91: change CONFIG_SYS_HZ to 1000
On 15:20 Fri 03 Apr , Eric BENARD wrote: > Detlef Vollmann a écrit : >> Jean-Christophe PLAGNIOL-VILLARD wrote: >>> I've send a new patch that introduce an improve of the clock on at91 >>> which give you the calculated main_clock based on the main crystal and the >>> lowlevel settings >> I was looking for that patch in git://git.denx.de/u-boot-at91.git, >> but couldn't find it there (it should add a new file >> cpu/arm926ejs/at91/clock.c, correct?). >> Where can I find that patch? >> > http://article.gmane.org/gmane.comp.boot-loaders.u-boot/56837 > > Is it interesting to loose time calculating PLL values at each boot when > these value can be defined in the board config file ? yes because you will not loose that much 1ms in the worse case but you will be sure about it evenif you change it in the at91bootstrap change or the lowlevel_init. It's safer Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] at91: change CONFIG_SYS_HZ to 1000
Jean-Christophe PLAGNIOL-VILLARD a écrit : > On 15:20 Fri 03 Apr , Eric BENARD wrote: >> Detlef Vollmann a écrit : >>> Jean-Christophe PLAGNIOL-VILLARD wrote: I've send a new patch that introduce an improve of the clock on at91 which give you the calculated main_clock based on the main crystal and the lowlevel settings >>> I was looking for that patch in git://git.denx.de/u-boot-at91.git, >>> but couldn't find it there (it should add a new file >>> cpu/arm926ejs/at91/clock.c, correct?). >>> Where can I find that patch? >>> >> http://article.gmane.org/gmane.comp.boot-loaders.u-boot/56837 >> This patch is not adressing the problem of the network timeout. In fact Detlef's patch is still needed (with some rework for G20) to fix this tiemout problem. Eric ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Macronix MX25xx MTD SPI flash driver
On Friday 03 April 2009 07:49:19 Prafulla Wadaskar wrote: > --- a/drivers/mtd/spi/Makefile > +++ b/drivers/mtd/spi/Makefile > @@ -28,6 +28,7 @@ LIB := $(obj)libspi_flash.a > COBJS-$(CONFIG_SPI_FLASH)+= spi_flash.o > COBJS-$(CONFIG_SPI_FLASH_ATMEL) += atmel.o > COBJS-$(CONFIG_SPI_FLASH_STMICRO)+= stmicro.o > +COBJS-$(CONFIG_SPI_FLASH_MACRONIX) += macronix.o please keep the list sorted > --- /dev/null > +++ b/drivers/mtd/spi/macronix.c > @@ -0,0 +1,319 @@ > + * Based on drivers/mtd/spi/stmicor.c typo in file name > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, > + * MA 02110-1301 USA > + */ > +#include please add a new line there > +/* MX25Pxx-specific commands */ > +#define CMD_MX25PXX_WREN 0x06/* Write Enable */ > +#define CMD_MX25PXX_WRDI 0x04/* Write Disable */ > +#define CMD_MX25PXX_RDSR 0x05/* Read Status Register */ > +#define CMD_MX25PXX_WRSR 0x01/* Write Status Register */ > +#define CMD_MX25PXX_READ 0x03/* Read Data Bytes */ > +#define CMD_MX25PXX_FAST_READ0x0b/* Read Data Bytes at Higher > Speed */ > +#define CMD_MX25PXX_PP 0x02/* Page Program */ > +#define CMD_MX25PXX_SE 0x20/* Sector Erase */ > +#define CMD_MX25PXX_BE 0xD8/* Block Erase */ > +#define CMD_MX25PXX_CE 0xc7/* Chip Erase */ > +#define CMD_MX25PXX_DP 0xb9/* Deep Power-down */ > +#define CMD_MX25PXX_RES 0xab/* Release from DP, and Read > Signature */ is it really MX25PXX ? or should it be MX25XX ? the P looks like a hold over from the stmicro driver. > +struct macronix_spi_flash { > + const struct macronix_spi_flash_params *params; > + struct spi_flash flash; > +}; the spi_flash struct needs to be the first member in order to prevent crashes when working with the spi flash layer > + u8 cmd[4] = { CMD_MX25PXX_RDSR, 0xff, 0xff, 0xff }; > + > + ret = spi_xfer(spi, 32, &cmd[0], NULL, SPI_XFER_BEGIN); do you actually need to read/write 4 bytes here ? shouldnt it be: u8 cmd = CMD_MX25PXX_RDSR; ret = spi_xfer(spi, 8, &cmd, NULL, SPI_XFER_BEGIN); > + if (ret) { > + debug("SF: Failed to send command %02x: %d\n", cmd[0], ret); then you'll need to change to "cmd" > + debug("SF: STMicro Page Program failed\n"); > + debug("SF: STMicro: Successfully programmed %u bytes @ 0x%x\n", > + len, offset); > + debug("SF: STMicro page erase failed\n"); > + debug("SF: STMicro page erase timed out\n"); > + debug("SF: STMicro: Successfully erased %u bytes @ 0x%x\n", > + len * sector_size, offset); > + debug("SF: Unsupported STMicro ID %02x\n", id[1]); this isnt STMicro anymore ... > + /* Up to 2 seconds */ > + ret = macronix_wait_ready(flash, 2 * CONFIG_SYS_HZ); there's a common flash erase timeout define > +*spi_flash_probe_macronix(struct spi_slave *spi, u8 * idcode) no space between "*" and "idcode" > + u8 id[3]; > + > + ret = spi_flash_cmd(spi, CMD_READ_ID, id, sizeof(id)); > + if (ret) > + return NULL; no need to read id here ... use the idcode passed in to you > + if (params->idcode1 == idcode[2]) { > + break; > + } drop the {} braces > --- a/drivers/mtd/spi/spi_flash.c > +++ b/drivers/mtd/spi/spi_flash.c > @@ -3,7 +3,6 @@ > * > * Copyright (C) 2008 Atmel Corporation > */ > -#define DEBUG > #include > #include > #include please drop this hunk ... it doesnt belong in this patch (and it's already been merged elsewhere) -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] at91: change CONFIG_SYS_HZ to 1000
Jean-Christophe PLAGNIOL-VILLARD wrote: > On 15:20 Fri 03 Apr , Eric BENARD wrote: >> Detlef Vollmann a écrit : >>> Where can I find that patch? >>> >> http://article.gmane.org/gmane.comp.boot-loaders.u-boot/56837 Thanks. >> Is it interesting to loose time calculating PLL values at each boot when >> these value can be defined in the board config file ? > yes because you will not loose that much 1ms in the worse case > but you will be sure about it evenif you change it in the at91bootstrap change > or the lowlevel_init. It's safer I probably agree. (Well, not completely, as I'd like to get rid of at91bootstrap completely and let U-Boot be the original boot code, but that's future.) Unfortunately that clock patch doesn't solve the timer issue, and makes it even worse... And I agree that it's not very useful to apply my old patch against that. The point is that I don't know against which git repository I should create any new patch. I'd prefer to use git://git.denx.de/u-boot.git, but I'm willing to use git://git.denx.de/u-boot-at91.git, but neither of those contain the clock patch yet... Best Regards, Detlef ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] include/ns16550.h: Unify structure declaration for registers
Instead of special casing the different access patterns, use common code with light macros sprinkled in to accomodate for the different layouts of the register structure. Note that this also changes the types of the registers for the "positively packed (>1)" cases. As the registers truly are unsigned chars, this is surely the Right Thing, but it is a semantic change. Note that for this case depending on the endianness on the bus, we may see a change of behaviour. Signed-off-by: Detlev Zundel --- include/ns16550.h | 130 +++-- 1 files changed, 37 insertions(+), 93 deletions(-) Note, that I checked that the offsets are ok in the used cases switching from the old to the new code. They *do* shift however in the positive packed cases, because the old code uses data types different than unsigned char. Note that doing this, I also noticed that using "unsigned long" for 4 byte registers is also no longer true on 64-bit architectures. One more reason to change the code. Apart from that the code was also compile tested on several configurations using different REG_SIZES and compiles without warnings. The special interesting case of +4 was successfully tested on CU824. diff --git a/include/ns16550.h b/include/ns16550.h index 87624bf..ce606b5 100644 --- a/include/ns16550.h +++ b/include/ns16550.h @@ -16,102 +16,46 @@ * by Richard Danter (richard.dan...@windriver.com), (C) 2005 Wind River Systems */ -#if (CONFIG_SYS_NS16550_REG_SIZE == 1) -struct NS16550 { - unsigned char rbr; /* 0 */ - unsigned char ier; /* 1 */ - unsigned char fcr; /* 2 */ - unsigned char lcr; /* 3 */ - unsigned char mcr; /* 4 */ - unsigned char lsr; /* 5 */ - unsigned char msr; /* 6 */ - unsigned char scr; /* 7 */ -#if defined(CONFIG_OMAP730) - unsigned char mdr1; /* 8 */ - unsigned char reg9; /* 9 */ - unsigned char regA; /* A */ - unsigned char regB; /* B */ - unsigned char regC; /* C */ - unsigned char regD; /* D */ - unsigned char regE; /* E */ - unsigned char regF; /* F */ - unsigned char reg10;/* 10 */ - unsigned char ssr; /* 11*/ -#endif -} __attribute__ ((packed)); -#elif (CONFIG_SYS_NS16550_REG_SIZE == 2) -struct NS16550 { - unsigned short rbr; /* 0 */ - unsigned short ier; /* 1 */ - unsigned short fcr; /* 2 */ - unsigned short lcr; /* 3 */ - unsigned short mcr; /* 4 */ - unsigned short lsr; /* 5 */ - unsigned short msr; /* 6 */ - unsigned short scr; /* 7 */ -} __attribute__ ((packed)); -#elif (CONFIG_SYS_NS16550_REG_SIZE == 4) -struct NS16550 { - unsigned long rbr; /* 0 r */ - unsigned long ier; /* 1 rw */ - unsigned long fcr; /* 2 w */ - unsigned long lcr; /* 3 rw */ - unsigned long mcr; /* 4 rw */ - unsigned long lsr; /* 5 r */ - unsigned long msr; /* 6 r */ - unsigned long scr; /* 7 rw */ -}; /* No need to pack an already aligned struct */ -#elif (CONFIG_SYS_NS16550_REG_SIZE == -4) -struct NS16550 { - unsigned char rbr; /* 0 */ - int pad1:24; - unsigned char ier; /* 1 */ - int pad2:24; - unsigned char fcr; /* 2 */ - int pad3:24; - unsigned char lcr; /* 3 */ - int pad4:24; - unsigned char mcr; /* 4 */ - int pad5:24; - unsigned char lsr; /* 5 */ - int pad6:24; - unsigned char msr; /* 6 */ - int pad7:24; - unsigned char scr; /* 7 */ - int pad8:24; -#if defined(CONFIG_OMAP) - unsigned char mdr1; /* mode select reset TL16C750*/ -#endif -#ifdef CONFIG_OMAP1510 - int pad9:24; - unsigned long pad[10]; - unsigned char osc_12m_sel; - int pad10:24; -#endif -} __attribute__ ((packed)); -#elif (CONFIG_SYS_NS16550_REG_SIZE == -8) -struct NS16550 { - unsigned char rbr; /* 0 */ - unsigned char pad0[7]; - unsigned char ier; /* 1 */ - unsigned char pad1[7]; - unsigned char fcr; /* 2 */ - unsigned char pad2[7]; - unsigned char lcr; /* 3 */ - unsigned char pad3[7]; - unsigned char mcr; /* 4 */ - unsigned char pad4[7]; - unsigned char lsr; /* 5 */ - unsigned char pad5[7]; - unsigned char msr; /* 6 */ - unsigned char pad6[7]; - unsigned char scr;
Re: [U-Boot] [PATCH] include/ns16550.h: Unify structure declaration for registers
Detlev Zundel writes: > Instead of special casing the different access patterns, use common > code with light macros sprinkled in to accomodate for the different > layouts of the register structure. > > Note that this also changes the types of the registers for the > "positively packed (>1)" cases. As the registers truly are unsigned > chars, this is surely the Right Thing, but it is a semantic change. > Note that for this case depending on the endianness on the bus, we may > see a change of behaviour. > > Signed-off-by: Detlev Zundel > --- > include/ns16550.h | 130 > +++-- > 1 files changed, 37 insertions(+), 93 deletions(-) I forgot to say, this patch depend on the previous cleanup patch sent earlier today (Rename-common-ns16550-constants-with-UART_-prefix). Cheers Detlev -- 1. What is the best thing about Unix? A: The community. 2. What is the worst thing about Unix? A: That there are so many communities. (Rob Pike) -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Uboot bringing an RTOS instead of linux.
Hi All, I am currently working on OMAP3530 fromMistral solutions. This is the booting sequence in OMAP3530 The OMAP3530 contains a boot ROM starting at location 0x. When power on, the PC register jumps there. The boot ROM then looks at the sys_boot pins to determine boot order. For NAND booting, the x-loader is located at offset 0 in NAND. Actually the first two words in NAND are the length of the x-loader and the address in internal RAM to load it. The boot ROM then reads the x-loader from NAND into internal RAM and jumps to that. The x-loader configures the clocks and SDRAM and then reads u-boot from NAND into SDRAM. After u-boot is in SDRAM, the x-loader jumps to u-boot and u-boot starts to run. If I don't press any key for 4 seconds uboot brings linux and linux shell comes up. Instead of linux I need to bring my custom RTOS. As linux, custom RTOS will reside in NAND Flash too. What is the procedure for bringing an OS from uboot.? As uboot bringing Linux , it needs to bring an RTOS too. How do I write a script for that? How do I tell uboot to load My custom rtos instead of linux. I need to avoid the loading of linux and bring in my RTOS . Any help on this is highly appreciated Thanks Rahanesh The information contained in this electronic message and any attachments to this message are intended for the exclusive use of the addressee(s) and may contain proprietary, confidential or privileged information. If you are not the intended recipient, you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately and destroy all copies of this message and any attachments contained in it. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] at91: change CONFIG_SYS_HZ to 1000
On 16:46 Fri 03 Apr , Detlef Vollmann wrote: > Jean-Christophe PLAGNIOL-VILLARD wrote: >> On 15:20 Fri 03 Apr , Eric BENARD wrote: >>> Detlef Vollmann a écrit : Where can I find that patch? >>> http://article.gmane.org/gmane.comp.boot-loaders.u-boot/56837 > Thanks. > >>> Is it interesting to loose time calculating PLL values at each boot when >>> these value can be defined in the board config file ? >> yes because you will not loose that much 1ms in the worse case >> but you will be sure about it evenif you change it in the at91bootstrap >> change >> or the lowlevel_init. It's safer > I probably agree. (Well, not completely, as I'd like to get rid > of at91bootstrap completely and let U-Boot be the original boot > code, but that's future.) I've a patch that I'll send tomorow that boot the at91sam9263ek from NOR without the AT91bootstrap > > Unfortunately that clock patch doesn't solve the timer issue, and > makes it even worse... > And I agree that it's not very useful to apply my old patch against > that. The point is that I don't know against which git repository > I should create any new patch. > I'd prefer to use git://git.denx.de/u-boot.git, but I'm willing to > use git://git.denx.de/u-boot-at91.git, but neither of those contain > the clock patch yet... I'll put in the clock branch Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] U-boot NAND boot support on Freescale PDK
Hi Magnus, Thanks for the response:) > Until yesterday you were correct. I spent some time updating the > published patches to the current u-boot and the status now is that I > was able to compile the stuff. Haven't tried it on a PDK board yet but > I'm hoping to do that in a couple of days. > I will post patches when the stuff is running, the patches will most > likely not be ready to be merged as there are previous comments to > take care of. Ii had actually embarked myself on modifying the lowlevelinit.S and start.S to create a SPL for uboot although i wasn't sure of finishing it that soo;(. I hope these files apart from the linker script(u-boot.lds) and the config files(config.mk and Makefile) are the ones that need to change for getting NAND boot to work. Please correct me if i don't understand it correctly. I wasn't actually sure why there is a need to create a separate linker script like u-boot_nand.lds. So i hope the patch would be ready in a couple of days. If you want me to try them on the PDK before you actually release it, that would be great. Another thing i noticed while poking around the code is that though MX35 PDK had SDHC(sd card) drivers in it, the MX31 did not. Would it be in a individual GIT , e.g the U-boot mmc git. Thanks, Alfred. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] at91: change CONFIG_SYS_HZ to 1000
Eric BENARD wrote: > Detlef Vollmann a écrit : >> I probably agree. (Well, not completely, as I'd like to get rid >> of at91bootstrap completely and let U-Boot be the original boot >> code, but that's future.) >> > check Ilko Iliev's patch for pm9263 which integrates at91bootstrap's > features in lowlevelinit.S when using NOR boot, it works on SAM9260 with > a few changes. Thanks. I'll have a look at it. But it probably takes a bit more to boot from NAND... >> Unfortunately that clock patch doesn't solve the timer issue, and >> makes it even worse... >> And I agree that it's not very useful to apply my old patch against >> that. The point is that I don't know against which git repository >> I should create any new patch. >> I'd prefer to use git://git.denx.de/u-boot.git, but I'm willing to >> use git://git.denx.de/u-boot-at91.git, but neither of those contain >> the clock patch yet... >> > With your patch on top of Jean Christophe's patch and when changing > CONFIG_SYS_HZ to 1000, I don't get anymore timeout during tftp. Yes, it should, if your master clock is at 100MHz. But as with the new clock framework the value can be completely different (at least in theory), the patch needs to care about that. Best Regards, Detlef ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Uboot bringing an RTOS instead of linux.
On 20:26 Fri 03 Apr , rahan...@tataelxsi.co.in wrote: > Hi All, > > I am currently working on OMAP3530 fromMistral solutions. This is the > booting sequence in OMAP3530 > > The OMAP3530 contains a boot ROM starting at location 0x. When > power on, the PC register jumps there. The boot ROM then looks at the > sys_boot pins to determine boot order. For NAND booting, > > the x-loader is located at offset 0 in NAND. Actually the first two words > in NAND are the length of the x-loader and the address in internal RAM to > load it. The boot ROM then reads the x-loader from NAND into > > internal RAM and jumps to that. The x-loader configures the clocks and > SDRAM and then reads u-boot from NAND into SDRAM. After u-boot is in SDRAM, > the x-loader jumps to u-boot and u-boot starts to run. If > > I don't press any key for 4 seconds uboot brings linux and linux shell comes > up. > > Instead of linux I need to bring my custom RTOS. As linux, custom RTOS will > reside in NAND Flash too. > > What is the procedure for bringing an OS from uboot.? As uboot bringing > Linux , it needs to bring an RTOS too. > > How do I write a script for that? How do I tell uboot to load My custom rtos > instead of linux. I need to avoid the loading of linux and bring in my RTOS it will depend on your OS boot requierement but if you can boot it as a elf try bootelf Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] U-boot NAND boot support on Freescale PDK
On Fri, Apr 03, 2009 at 10:21:50AM -0500, alfred steele wrote: > I wasn't actually sure why there is a need to create a separate linker > script like u-boot_nand.lds. The addresses may be different than normal u-boot (though we could take care of that by preprocessing the linker scripts), and you don't need to pull in as many sections (though it would be harmless to do so if those sections are empty in the loader). mpc8313erdb uses the nand_spl linker script to provide a link-time warning if the size limit is exceeded. A more basic question is why does each board need its own linker script, NAND or not? -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] PIO Mode Read/Write support for FSL eSDHC
PIO mode support for freescale eSDHC Driver. PIO has added to enable data transfer without use of eSDHC DMA Engine. Signed-off-by: Dipen Dudhat --- drivers/mmc/fsl_esdhc.c | 136 +++ include/fsl_esdhc.h |1 + 2 files changed, 127 insertions(+), 10 deletions(-) diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c index 0ba45cd..c96011f 100644 --- a/drivers/mmc/fsl_esdhc.c +++ b/drivers/mmc/fsl_esdhc.c @@ -71,8 +71,12 @@ uint esdhc_xfertyp(struct mmc_cmd *cmd, struct mmc_data *data) uint xfertyp = 0; if (data) { +#ifdef CONFIG_SYS_FSL_ESDHC_USE_PIO + xfertyp |= XFERTYP_DPSEL; +#else xfertyp |= XFERTYP_DPSEL | XFERTYP_DMAEN; +#endif if (data->blocks > 1) { xfertyp |= XFERTYP_MSBSEL; xfertyp |= XFERTYP_BCEN; @@ -96,6 +100,102 @@ uint esdhc_xfertyp(struct mmc_cmd *cmd, struct mmc_data *data) return XFERTYP_CMD(cmd->cmdidx) | xfertyp; } +#ifdef CONFIG_SYS_FSL_ESDHC_USE_PIO +static int esdhc_setup_pio_data(struct mmc *mmc, struct mmc_data *data) +{ + int timeout; + struct fsl_esdhc *regs = mmc->priv; + + if (!(data->flags & MMC_DATA_READ)) { + if ((in_be32(®s->prsstat) & PRSSTAT_WPSPL) == 0) { + printf("\nThe SD card is locked. " + "Can not write to a locked card.\n\n"); + return TIMEOUT; + } + out_be32(®s->dsaddr, (u32)data->src); + } else + out_be32(®s->dsaddr, (u32)data->dest); + + out_be32(®s->blkattr, data->blocks << 16 | data->blocksize); + + /* Calculate the timeout period for data transactions */ + timeout = __ilog2(mmc->tran_speed/10); + timeout -= 13; + + if (timeout > 14) + timeout = 14; + + if (timeout < 0) + timeout = 0; + + clrsetbits_be32(®s->sysctl, SYSCTL_TIMEOUT_MASK, timeout << 16); + + return 0; +} + +/* + * PIO Read/Write Mode reduce the performace as DMA is not used in this mode. + */ + +static void +esdhc_pio_read_write(struct mmc *mmc, struct mmc_data *data) +{ + volatile struct fsl_esdhc *regs = mmc->priv; + uint blocks; + uchar* buffer; + uint chunk_remain; + uint databuf; + uint size,irqstat; + + if (data->flags & MMC_DATA_READ) { + blocks = data->blocks; + buffer = (uchar*) data->dest; + chunk_remain = 0; + while(blocks) { + size = data->blocksize; + irqstat = in_be32(®s->irqstat); + while(!(in_be32(®s->prsstat) & PRSSTAT_BREN)); + while(size && (!(irqstat & IRQSTAT_TC))) { + if(chunk_remain == 0) { + udelay(1000); + irqstat = in_be32(®s->irqstat); + databuf = in_be32(®s->datport); + chunk_remain =4; + } + *buffer = databuf & 0xFF; + buffer++; + databuf >>= 8; + size--; + chunk_remain--; + } + blocks--; + } + } else { + blocks = data->blocks; + buffer = (uchar*) data->src; + chunk_remain = 4; + while(blocks) { + size = data->blocksize; + irqstat = in_be32(®s->irqstat); + while(!(in_be32(®s->prsstat) & PRSSTAT_BWEN)); + while(size && (!(irqstat & IRQSTAT_TC))) { + databuf >>=8; + databuf |= (u32)*buffer<<24; + buffer++; + size--; + chunk_remain--; + if(chunk_remain == 0) { + irqstat = in_be32(®s->irqstat); + out_be32(®s->datport,databuf); + chunk_remain =4; + } + } + blocks--; + } + } +} +#endif + static int esdhc_setup_data(struct mmc *mmc, struct mmc_data *data) { uint wml_value; @@ -141,6 +241,23 @@ static int esdhc_setup_data(struct mmc *mmc, struct mmc_data *data) return 0; } +static void +esdhc_dma_read_write(struct mmc *mmc) +{ + volatile struct fsl_esdhc *regs = mmc->priv; + uint irqstat; + + do { + irqstat = in_be32(®s->irqstat); + + if (irqstat & DATA_ERR) +
Re: [U-Boot] Help about a simplified bootloader.
On Fri, Apr 03, 2009 at 02:44:03PM +0800, os user wrote: > I want to boot linux by a simplified bootloader. I use Atmel's ARM > chip (AT91SAM9RL64EK board). Now, I can boot linux with my small > program. The small program will parse the image generaed by "mkimage" > and copy the kernel bianry from NAND flash to SDRAM, construct the tag > list, disable I/D cache, disable interrupt and then jump to kernel > entry point. The system can startup, but when accessing rootfile > system(the rootfile system was also in the NAND chip), a lot of CRC > errors were found. See below, > mtd->read(0x1fb2c bytes from 0x1804d4) returned ECC error > mtd->read(0x1fa38 bytes from 0x3e05c8) returned ECC error > mtd->read(0x1f7dc bytes from 0x7c0824) returned ECC error > jffs2_scan_inode_node(): CRC failed on node at 0x007c37a4: Read > 0xd9b2bc33, calculated 0xda4805c1 > > and sometimes the sytem even crashed when R/W filesystem. > > But with the same linux kernel and rootfile system, if I use U-Boot to > boot linux, everything seems OK. > > Can anyone tell is there any trick that's related with linux NAND > driver in U-Boot? Or any suggestion to help me moving on? Are you using the same software to program the NAND in each case? If not, perhaps they have a different OOB layout? -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCHv2] OMAP: Fix compile issue
On 14:00 Fri 03 Apr , Sanjeev Premi wrote: > Fixes this compile error: > board.c: In function 'do_switch_ecc': > board.c:339: error: 'cmd_tbl_t' has no member named 'help' > make[1]: *** [board.o] Error 1 > make[1]: Leaving directory > `/db/psp_git/users/a0756819/u-boot/cpu/arm_cortexa8/omap3' > make: *** [cpu/arm_cortexa8/omap3/libomap3.a] Error 2 > > This is due to the fact that current command uses long > help for the usage print even if the CONFIG_SYS_LONGHELP > is not enabled. (Thanks Jean-Christophe for explanation). > > Signed-off-by: Sanjeev Premi > --- Applied Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Pull request u-boot-blackfin.git
The following changes since commit dfc91c33957c95da34e3888dc87912d5c15a7603: Wolfgang Denk (1): Merge branch 'master' of git://git.denx.de/u-boot-arm are available in the git repository at: git://www.denx.de/git/u-boot-blackfin.git master Mike Frysinger (13): Blackfin: bf548-ezkit: new board port Blackfin: bf527-ezkit: new board port Blackfin: bf538f-ezkit: new board port Blackfin: bf526-ezbrd: new board port Blackfin: bf518f-ezbrd: new board port Blackfin: fix crash when booting from external memory Blackfin: bf537-stamp: split CF/IDE code out into dedicated cf-ide.c Blackfin: convert bfin_sdh to legacy mmc Blackfin: drop newline from OTP help Blackfin: do not delay on output bytes Blackfin: add BF538/BF539 SPI portmux handling Blackfin: bf533-stamp: drop old spi flash driver Blackfin: force all boards to HZ of 1000 MAINTAINERS |5 + MAKEALL |5 + Makefile|6 +- board/bf518f-ezbrd/.gitignore |1 + board/bf518f-ezbrd/Makefile | 57 + board/bf518f-ezbrd/bf518f-ezbrd.c | 101 board/bf518f-ezbrd/config.mk| 32 +++ board/bf518f-ezbrd/u-boot.lds.S | 124 ++ board/bf526-ezbrd/.gitignore|1 + board/bf526-ezbrd/Makefile | 58 + board/bf526-ezbrd/bf526-ezbrd.c | 77 +++ board/bf526-ezbrd/config.mk | 32 +++ board/bf526-ezbrd/status-led.c | 56 + board/bf526-ezbrd/u-boot.lds.S | 124 ++ board/bf527-ezkit/.gitignore|1 + board/bf527-ezkit/Makefile | 58 + board/bf527-ezkit/bf527-ezkit.c | 77 +++ board/bf527-ezkit/config.mk | 32 +++ board/bf527-ezkit/u-boot.lds.S | 124 ++ board/bf527-ezkit/video.c | 317 ++ board/bf533-stamp/Makefile |1 - board/bf533-stamp/spi_flash.c |2 - board/bf537-stamp/Makefile |1 + board/bf537-stamp/bf537-stamp.c | 57 +- board/bf537-stamp/ide-cf.c | 66 ++ board/bf538f-ezkit/.gitignore |1 + board/bf538f-ezkit/Makefile | 57 + board/bf538f-ezkit/bf538f-ezkit.c | 27 +++ board/bf538f-ezkit/config.mk| 33 +++ board/bf538f-ezkit/u-boot.lds.S | 143 board/bf548-ezkit/.gitignore|1 + board/bf548-ezkit/Makefile | 58 + board/bf548-ezkit/bf548-ezkit.c | 79 +++ board/bf548-ezkit/config.mk | 37 +++ board/bf548-ezkit/u-boot.lds.S | 124 ++ board/bf548-ezkit/video.c | 327 +++ common/cmd_otp.c|2 +- cpu/blackfin/initcode.c |9 + cpu/blackfin/serial.c |4 - cpu/blackfin/start.S|2 + drivers/mmc/bfin_sdh.c | 14 +- drivers/spi/bfin_spi.c | 18 ++ include/asm-blackfin/blackfin-config-post.h |8 +- include/configs/bf518f-ezbrd.h | 147 include/configs/bf526-ezbrd.h | 190 include/configs/bf527-ezkit.h | 172 ++ include/configs/bf538f-ezkit.h | 139 include/configs/bf548-ezkit.h | 211 + 48 files changed, 3140 insertions(+), 78 deletions(-) create mode 100644 board/bf518f-ezbrd/.gitignore create mode 100644 board/bf518f-ezbrd/Makefile create mode 100644 board/bf518f-ezbrd/bf518f-ezbrd.c create mode 100644 board/bf518f-ezbrd/config.mk create mode 100644 board/bf518f-ezbrd/u-boot.lds.S create mode 100644 board/bf526-ezbrd/.gitignore create mode 100644 board/bf526-ezbrd/Makefile create mode 100644 board/bf526-ezbrd/bf526-ezbrd.c create mode 100644 board/bf526-ezbrd/config.mk create mode 100644 board/bf526-ezbrd/status-led.c create mode 100644 board/bf526-ezbrd/u-boot.lds.S create mode 100644 board/bf527-ezkit/.gitignore create mode 100644 board/bf527-ezkit/Makefile create mode 100644 board/bf527-ezkit/bf527-ezkit.c create mode 100644 board/bf527-ezkit/config.mk create mode 100644 board/bf527-ezkit/u-boot.lds.S create mode 100644 board/bf527-ezkit/video.c delete mode 100644 board/bf533-stamp/spi_flash.c create mode 100644 board/bf537-stamp/ide-cf.c create mode 100644 board/bf538f-ezkit/.gitignore create mode 100644 board/bf538f-ezkit/Makefile create mode 100644 board/bf538f-ezkit/bf538f-ezkit.c create mode 100644 board/bf538f-ezkit/config.mk create mode 100644 board/bf538f-ezkit/u-boot.l
[U-Boot] Pull request spi flash changes from u-boot-blackfin.git
The following changes since commit dfc91c33957c95da34e3888dc87912d5c15a7603: Wolfgang Denk (1): Merge branch 'master' of git://git.denx.de/u-boot-arm are available in the git repository at: git://www.denx.de/git/u-boot-blackfin.git sf Jean-Christophe PLAGNIOL-VILLARD (1): mtd: add some at45 spi flash support Mike Frysinger (7): sf: drop DEBUG defines sf: add driver for SST flashes sf: stmicro: drop redundant id read sf: always read 5 bytes for the idcode sf: stmicro: use common page timeout define sf: set common timeouts in seconds, not milliseconds sf: stmicro: dont send 4 bytes when reading status register Mingkai Hu (1): mtd: SPI Flash: Support the Spansion Flash drivers/mtd/spi/Makefile |2 + drivers/mtd/spi/atmel.c | 50 +- drivers/mtd/spi/spansion.c | 350 + drivers/mtd/spi/spi_flash.c | 13 +- drivers/mtd/spi/spi_flash_internal.h | 10 +- drivers/mtd/spi/sst.c| 358 ++ drivers/mtd/spi/stmicro.c| 17 +-- 7 files changed, 780 insertions(+), 20 deletions(-) create mode 100644 drivers/mtd/spi/spansion.c create mode 100644 drivers/mtd/spi/sst.c ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] Marvell Feroceon-FR131/Sheeva-88SV131 cpu core support
This is ARM v5TE-compliant processor core with MMU and L1/L2 Cache Signed-off-by: prafulla_wadaskar Reviewed by: Ronen Shitrit --- cpu/arm926ejs/start.S |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/cpu/arm926ejs/start.S b/cpu/arm926ejs/start.S index ed4932a..08ec955 100644 --- a/cpu/arm926ejs/start.S +++ b/cpu/arm926ejs/start.S @@ -214,10 +214,15 @@ cpu_init_crit: * disable MMU stuff and caches */ mrc p15, 0, r0, c1, c0, 0 +#if defined (CONFIG_FEROCEON_88FR131) || defined (CONFIG_SHEEVA_88SV131) + bic r0, r0, #0x0007 /* clear bits 2:0 (CAM) */ + orr r0, r0, #0x0002 /* set bit 2 (A) Align */ +#else bic r0, r0, #0x2300 /* clear bits 13, 9:8 (--V- --RS) */ bic r0, r0, #0x0087 /* clear bits 7, 2:0 (B--- -CAM) */ orr r0, r0, #0x0002 /* set bit 2 (A) Align */ orr r0, r0, #0x1000 /* set bit 12 (I) I-Cache */ +#endif mcr p15, 0, r0, c1, c0, 0 /* -- 1.5.3.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] Marvell 88EXXXX Switch/PHY init support
From: prafulla_wadaskar Chips supprted:- 1. 88E61XX 6 port gbe swtich with 5 integrated PHYs 2. 88E6061 6 port fe swtich with 5 integrated PHYs 3. 88E1116 gbe transceiver Contributors: Yotam Admon Michael Blostein Reviewed by: Ronen Shitrit --- board/Marvell/common/mv88e1116.c | 72 +++ board/Marvell/common/mv88e60xx.c | 409 + board/Marvell/common/mv88e61xx.c | 414 ++ 3 files changed, 895 insertions(+), 0 deletions(-) create mode 100644 board/Marvell/common/mv88e1116.c create mode 100644 board/Marvell/common/mv88e60xx.c create mode 100644 board/Marvell/common/mv88e61xx.c diff --git a/board/Marvell/common/mv88e1116.c b/board/Marvell/common/mv88e1116.c new file mode 100644 index 000..87ec550 --- /dev/null +++ b/board/Marvell/common/mv88e1116.c @@ -0,0 +1,72 @@ +/* + * (C) Copyright 2009 + * Marvell Semiconductor + * Prafulla Wadaskar + * + * Contributors + * + * See file CREDITS for list of people who contributed to this + * project. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, + * MA 02110-1301 USA + */ + +#ifndef MV88E1116_DEBUG +#define MV88E1116_DEBUG 0 +#endif +#define DEBUG_PRINTMV88E1116_DEBUG + +#include +#include +#include "../common/ppc_error_no.h" + +#if defined (CONFIG_PHY_88E1116) + +/* + * Marvell 88E1116 PHY initialization + */ +void mv_phy_88e1116_init(u32 eth_port_num) +{ + u16 reg; + u32 smi_dev_addr; + + debug_print_ftrace(); + smi_dev_addr = KW_REG_READ(KW_ETH_PHY_ADDR_REG(eth_port_num)); + + /* Leds link and activity */ + eth_smi_reg_write(eth_port_num, smi_dev_addr, 22, 0x3); + eth_smi_reg_read(eth_port_num, smi_dev_addr, 16, ®); + reg &= ~0xf; + reg |= 0x1; + eth_smi_reg_write(eth_port_num, smi_dev_addr, 16, reg); + eth_smi_reg_write(eth_port_num, smi_dev_addr, 22, 0x0); + + /* Set RGMII delay */ + eth_smi_reg_write(eth_port_num, smi_dev_addr, 22, 2); + eth_smi_reg_read(eth_port_num, smi_dev_addr, 21, ®); + reg |= (BIT5 | BIT4); + eth_smi_reg_write(eth_port_num, smi_dev_addr, 21, reg); + eth_smi_reg_write(eth_port_num, smi_dev_addr, 22, 0); + + /* reset the phy */ + eth_smi_reg_read(eth_port_num, smi_dev_addr, 0, ®); + reg |= BIT15; + eth_smi_reg_write(eth_port_num, smi_dev_addr, 0, reg); + + info_print("88E1116 Initialized"); +} + +#endif /* CONFIG_PHY_88E61XX */ diff --git a/board/Marvell/common/mv88e60xx.c b/board/Marvell/common/mv88e60xx.c new file mode 100644 index 000..6034f7b --- /dev/null +++ b/board/Marvell/common/mv88e60xx.c @@ -0,0 +1,409 @@ +/* + * (C) Copyright 2009 + * Marvell Semiconductor + * Prafulla Wadaskar + * + * See file CREDITS for list of people who contributed to this + * project. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, + * MA 02110-1301 USA + */ + +#ifndef MV88E60XX_DEBUG +#define MV88E60XX_DEBUG 0 +#endif +#define DEBUG_PRINTMV88E60XX_DEBUG + +#include +#include +#include "../common/ppc_error_no.h" +#include +#include +#include +#include +#include +#include +#if defined(CONFIG_CMD_NET) +#include +#endif + +#if defined (CONFIG_SWITCH_88E60XX) + +/* CPU port can be configured in board header file */ +#if defined (CONFIG_SWITCH_88E60XX_CPU_PORT) +#define MV88E60XX_CPU_PORT CONFIG_SWITCH_88E60XX_CPU_PORT +#else +#define MV88E60XX_CPU_PORT 0x5 +#endif +/* Enabled ports can be configured in board header file */ +#if defined (CONFIG_SWITCH_88E60XX_ENABLED_PORTS) +#define MV88E60XX_ENABLED_PORTS CONFIG_SWITCH_88E60XX_ENABLED_PORTS +#else +#define MV88E60XX_ENABLED_PORTS (BIT0 | BIT1 | BIT2
[U-Boot] [PATCH] Marvell MV88F6281GTW_GE Board support
From: prafulla_wadaskar This is Marvell's 88F6281_A0 based custom board developed for wireless access point product This patch is tested for- 1. Boot from DRAM/SPI flash/NFS 2. File transfer using tftp and loadb 3. SPI flash read/write/erase 4. Booting Linux kernel and RFS from SPI flash Signed-off-by: prafulla_wadaskar Reviewed by: Ronen Shitrit Tested by: Piyush Shah --- MAKEALL |1 + Makefile|3 + board/Marvell/mv88f6281gtw_ge/Makefile | 54 +++ board/Marvell/mv88f6281gtw_ge/bin_dep.sh| 74 + board/Marvell/mv88f6281gtw_ge/config.mk | 25 +++ board/Marvell/mv88f6281gtw_ge/dramregs_333h.txt | 27 board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.c | 135 board/Marvell/mv88f6281gtw_ge/u-boot.lds| 53 +++ include/configs/mv88f6281gtw_ge.h | 187 +++ 9 files changed, 559 insertions(+), 0 deletions(-) create mode 100644 board/Marvell/mv88f6281gtw_ge/Makefile create mode 100755 board/Marvell/mv88f6281gtw_ge/bin_dep.sh create mode 100644 board/Marvell/mv88f6281gtw_ge/config.mk create mode 100644 board/Marvell/mv88f6281gtw_ge/dramregs_333h.txt create mode 100644 board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.c create mode 100644 board/Marvell/mv88f6281gtw_ge/u-boot.lds create mode 100644 include/configs/mv88f6281gtw_ge.h diff --git a/MAKEALL b/MAKEALL index 854f303..de25165 100755 --- a/MAKEALL +++ b/MAKEALL @@ -506,6 +506,7 @@ LIST_ARM9=" \ lpd7a400\ mx1ads \ mx1fs2 \ + mv88f6281gtw_ge \ netstar \ nmdk8815\ omap1510inn \ diff --git a/Makefile b/Makefile index 8bf36ce..eb2fdfb 100644 --- a/Makefile +++ b/Makefile @@ -2564,6 +2564,9 @@ DB64360_config: unconfig DB64460_config:unconfig @$(MKCONFIG) DB64460 ppc 74xx_7xx db64460 Marvell +mv88f6281gtw_ge_config: unconfig + @$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) Marvell kirkwood + ELPPC_config: unconfig @$(MKCONFIG) $(@:_config=) ppc 74xx_7xx elppc eltec diff --git a/board/Marvell/mv88f6281gtw_ge/Makefile b/board/Marvell/mv88f6281gtw_ge/Makefile new file mode 100644 index 000..32acefc --- /dev/null +++ b/board/Marvell/mv88f6281gtw_ge/Makefile @@ -0,0 +1,54 @@ +# +# (C) Copyright 2009 +# Marvell Semiconductor +# Prafulla Wadaskar +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, +# MA 02110-1301 USA +# + +include $(TOPDIR)/config.mk + +LIB= $(obj)lib$(BOARD).a + +COBJS := mv88f6281gtw_ge.o +COBJS += ../common/mv88e61xx.o + +SOBJS := ../common/kw_lowlevel_init.o + +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS)) +SOBJS := $(addprefix $(obj),$(SOBJS)) + +$(LIB):$(obj).depend $(OBJS) $(SOBJS) + $(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS) + +clean: + rm -f $(SOBJS) $(OBJS) + +distclean: clean + rm -f $(LIB) core *.bak .depend + +# + +# defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + +# diff --git a/board/Marvell/mv88f6281gtw_ge/bin_dep.sh b/board/Marvell/mv88f6281gtw_ge/bin_dep.sh new file mode 100755 index 000..5cb1e36 --- /dev/null +++ b/board/Marvell/mv88f6281gtw_ge/bin_dep.sh @@ -0,0 +1,74 @@ +#!/bin/sh + +# (C) Copyright 2009 +# Marvell Semiconductor +# Prafulla Wadaskar +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have rec
Re: [U-Boot] [PATCH] Marvell 88EXXXX Switch/PHY init support
Hi Prafulla, Prafulla Wadaskar wrote: > From: prafulla_wadaskar > > Chips supprted:- > 1. 88E61XX 6 port gbe swtich with 5 integrated PHYs > 2. 88E6061 6 port fe swtich with 5 integrated PHYs > 3. 88E1116 gbe transceiver > > Contributors: > Yotam Admon > Michael Blostein > Signed-off-by: prafulla_wadaskar > Reviewed by: Ronen Shitrit > I'll review these changes, but as-is placing chip support in 'board/Marvell' is inappropriate. If they are pure ethernet devices they need to go in 'drivers/net'. We also need to move the Marvell system controller chips that are already in 'board/Marvell', but I'm not sure where they should go. As you see, there's a tremendous amount of redundancy there. regards, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Help about a simplified bootloader.
Dear os user, In message <34f262ce0904022344u6e27ad07g8263785dd36ac...@mail.gmail.com> you wrote: > > I want to boot linux by a simplified bootloader. I use Atmel's ARM > chip (AT91SAM9RL64EK board). Now, I can boot linux with my small > program. The small program will parse the image generaed by "mkimage" ... > and sometimes the sytem even crashed when R/W filesystem. > > But with the same linux kernel and rootfile system, if I use U-Boot to > boot linux, everything seems OK. > > Can anyone tell is there any trick that's related with linux NAND > driver in U-Boot? Or any suggestion to help me moving on? Well, you already mentioned the solution: either use U-Boot, which seems to be working fine, or fix your own program such that it performs the same intializations like U-Boot. Be careful when copying code from U-Boot - U-Boot is under GPL, and you may quickly find that you have to release your program under GPL, too. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "Maintain an awareness for contribution -- to your schedule, your project, our company." - A Group of Employees ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] debug_print macros support
Dear Prafulla Wadaskar, In message <1238759359-6544-1-git-send-email-prafu...@marvell.com> you wrote: > From: prafulla_wadaskar > > This debug_prints strategy provides- > A. pre-formatted debug and print macros to be used in a code > B. flexiblility to enable selective debug prints without >modifying a source code > For more details refer doc/README.debug_prints > > Signed-off-by: prafulla_wadaskar This seems to be a lot of effort, from code to command line pollution - for what exactly? Which is the problem you are trying to solve? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Wisdom is one of the few things that looks bigger the further away it is. - Terry Pratchett, _Witches Abroad_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] bin_dep.sh Support
Dear Prafulla Wadaskar, In message <1238759359-6544-2-git-send-email-prafu...@marvell.com> you wrote: > From: prafulla_wadaskar > > In some cases the u-boot.bin need to be processed further > to create bootable u-boot binary from boot device > This processing may be cpu,soc and/or board spcific > bin_dep.sh provides a mechanism to execute bin_dep.sh > if present in above platform specific folders > > Signed-off-by: prafulla_wadaskar > --- > Makefile |2 + > tools/bin_dep.sh | 79 > ++ > 2 files changed, 81 insertions(+), 0 deletions(-) > create mode 100755 tools/bin_dep.sh I don't see use cases for this. This should probably remain out of tree. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de I can't understand it. I can't even understand the people who can understand it.- Queen Juliana of the Netherlands. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Uboot bringing an RTOS instead of linux.
Dear rahan...@tataelxsi.co.in, In message you wrote: > > What is the procedure for bringing an OS from uboot.? As uboot bringing > Linux , it needs to bring an RTOS too. The first step you are supposed to perform is reading the available documentation (README, Manual). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Voodoo Programming: Things programmers do that they know shouldn't work but they try anyway, and which sometimes actually work, such as recompiling everything. - Karl Lehenbauer ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Gbe Controller driver support for kirkwood SOCs
On Friday 03 April 2009 18:39:28 Prafulla Wadaskar wrote: > --- a/net/eth.c > +++ b/net/eth.c > @@ -73,6 +73,7 @@ int board_eth_init(bd_t *bis) __attribute((weak, > alias("__def_eth_init"))); > > extern int mv6436x_eth_initialize(bd_t *); > extern int mv6446x_eth_initialize(bd_t *); > +extern int kirkwood_egiga_initialize(bd_t*); > > #ifdef CONFIG_API > extern void (*push_packet)(volatile void *, int); > @@ -205,6 +206,9 @@ int eth_initialize(bd_t *bis) > #if defined(CONFIG_DB64460) || defined(CONFIG_P3Mx) > mv6446x_eth_initialize(bis); > #endif > +#ifdef CONFIG_KIRKWOOD_EGIGA > + kirkwood_egiga_initialize(bis); > +#endif > if (!eth_devices) { > puts ("No ethernet found.\n"); > show_boot_progress (-64); this should be dying, not new additions. define board_eth_init() like everyone else now. -mike ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Marvell Feroceon-FR131/Sheeva-88SV131 cpu core support
Dear Prafulla Wadaskar, In message <1238798370-9245-1-git-send-email-prafu...@marvell.com> you wrote: > This is ARM v5TE-compliant processor core with > MMU and L1/L2 Cache > > Signed-off-by: prafulla_wadaskar > Reviewed by: Ronen Shitrit > --- > cpu/arm926ejs/start.S |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/cpu/arm926ejs/start.S b/cpu/arm926ejs/start.S > index ed4932a..08ec955 100644 > --- a/cpu/arm926ejs/start.S > +++ b/cpu/arm926ejs/start.S > @@ -214,10 +214,15 @@ cpu_init_crit: >* disable MMU stuff and caches >*/ > mrc p15, 0, r0, c1, c0, 0 > +#if defined (CONFIG_FEROCEON_88FR131) || defined (CONFIG_SHEEVA_88SV131) > + bic r0, r0, #0x0007 /* clear bits 2:0 (CAM) */ > + orr r0, r0, #0x0002 /* set bit 2 (A) Align */ > +#else > bic r0, r0, #0x2300 /* clear bits 13, 9:8 (--V- --RS) */ > bic r0, r0, #0x0087 /* clear bits 7, 2:0 (B--- -CAM) */ > orr r0, r0, #0x0002 /* set bit 2 (A) Align */ > orr r0, r0, #0x1000 /* set bit 12 (I) I-Cache */ > +#endif > mcr p15, 0, r0, c1, c0, 0 Why is this special case needed? Cannot you enable the IC, too? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Voodoo Programming: Things programmers do that they know shouldn't work but they try anyway, and which sometimes actually work, such as recompiling everything. - Karl Lehenbauer ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Marvell MV88F6281GTW_GE Board support
Dear Prafulla Wadaskar, In message <1238798370-9245-5-git-send-email-prafu...@marvell.com> you wrote: > From: prafulla_wadaskar > > This is Marvell's 88F6281_A0 based custom board developed > for wireless access point product > > This patch is tested for- > 1. Boot from DRAM/SPI flash/NFS > 2. File transfer using tftp and loadb > 3. SPI flash read/write/erase > 4. Booting Linux kernel and RFS from SPI flash > > Signed-off-by: prafulla_wadaskar > Reviewed by: Ronen Shitrit > Tested by: Piyush Shah ... > --- a/MAKEALL > +++ b/MAKEALL > @@ -506,6 +506,7 @@ LIST_ARM9=" \ > lpd7a400\ > mx1ads \ > mx1fs2 \ > + mv88f6281gtw_ge \ > netstar \ > nmdk8815\ > omap1510inn \ Please keep lists sorted. > diff --git a/Makefile b/Makefile > index 8bf36ce..eb2fdfb 100644 > --- a/Makefile > +++ b/Makefile > @@ -2564,6 +2564,9 @@ DB64360_config: unconfig > DB64460_config: unconfig > @$(MKCONFIG) DB64460 ppc 74xx_7xx db64460 Marvell > > +mv88f6281gtw_ge_config: unconfig > + @$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) Marvell kirkwood > + > ELPPC_config: unconfig > @$(MKCONFIG) $(@:_config=) ppc 74xx_7xx elppc eltec Please keep lists sorted. > diff --git a/board/Marvell/mv88f6281gtw_ge/bin_dep.sh > b/board/Marvell/mv88f6281gtw_ge/bin_dep.sh > new file mode 100755 > index 000..5cb1e36 > --- /dev/null > +++ b/board/Marvell/mv88f6281gtw_ge/bin_dep.sh > @@ -0,0 +1,74 @@ ... > +CUR_DIR=$2 > +TOP_DIR=`pwd` > +BIN_FILE=$TOP_DIR/$1 > + > +DOIMAGE=$TOP_DIR/cpu/arm926ejs/kirkwood/doimage/doimage Please explain why this would be needed for? Note that this most probably will not fork with out of tree builds. ... > diff --git a/board/Marvell/mv88f6281gtw_ge/dramregs_333h.txt > b/board/Marvell/mv88f6281gtw_ge/dramregs_333h.txt > new file mode 100644 > index 000..d40a9c7 > --- /dev/null > +++ b/board/Marvell/mv88f6281gtw_ge/dramregs_333h.txt > @@ -0,0 +1,27 @@ > +0xFFD01400 0x43000a00 > +0xFFD01404 0x38543000 > +0xFFD01408 0x2202433D > +0xFFD0140C 0x002A > +0xFFD01410 0x000D > +0xFFD01414 0x > +0xFFD01418 0x > +0xFFD0141C 0x0c52 > +0xFFD01420 0x0046 > +0xFFD01424 0xF1FF > +0xFFD01428 0x00085520 > +0xFFD0147c 0x8552 > +0xFFD01508 0x > +0xFFD01504 0x07F1 > +0xFFD0150C 0x > +0xFFD01514 0x > +0xFFD0151C 0x > +0xFFD01494 0x00010001 > +0xFFD01498 0x > +0xFFD0149C 0xE811 > +0xFFD01480 0x0001 > +0xFFD20204 0x > +0xFFD100E0 0x1B1B1B9B > +0xFFD100D8 0x0060 > +0xFFD1007C 0x0068 > +0xFFD50430 0x0008 > +0x0 0x0 What sort of file is this? Under which license is it? > diff --git a/board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.c > b/board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.c > new file mode 100644 > index 000..b88fe3e > --- /dev/null > +++ b/board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.c > @@ -0,0 +1,135 @@ ... > +#ifndef MV88F6281GTW_GE_DEBUG > +#define MV88F6281GTW_GE_DEBUG0 > +#endif > +#define DEBUG_PRINT MV88F6281GTW_GE_DEBUG Unused code? Delete! > +#include > +#include Non existent file included here. > +/* this line must be removed after this machine name gets mainlined in > mach_types.h*/ > +#define MACH_TYPE_MV88F6281GTW_GE 1932 Please first register the MACH ID, then fix this, then resubmit. > +DECLARE_GLOBAL_DATA_PTR; > + > +#define MV88F6281GTW_GE_OE_VAL_LOW (BIT20) /*make GLED on */ > +#define MV88F6281GTW_GE_OE_VAL_HIGH ((BIT6)|(BIT13)|(BIT16)|(BIT17)) > +#define MV88F6281GTW_GE_OE_LOW (~((BIT7) | (BIT20) | (BIT21))) > /*enable GLED,RLED */ > +#define MV88F6281GTW_GE_OE_HIGH > (~((BIT4)|(BIT6)|(BIT7)|(BIT12)|(BIT13)|(BIT16)|(BIT17))) Lines too long (also check in all other files). > +/* > + * Default values for MPP registers > + */ > +#define MV88F6281GTW_GE_MPP0_7 0x0111 > +#define MV88F6281GTW_GE_MPP8_15 0x11103311 > +#define MV88F6281GTW_GE_MPP16_23 0x > +#define MV88F6281GTW_GE_MPP24_31 0x > +#define MV88F6281GTW_GE_MPP32_39 0x40440222 > +#define MV88F6281GTW_GE_MPP40_47 0x > +#define MV88F6281GTW_GE_MPP48_55 0x > + > +/* > + * function definitations > + */ > +#ifdef CONFIG_SWITCH_88E61XX > +extern int mv_switch_88e61xx_init(u32 eth_port_num); > +#endif Do not use extern. Privde proper prototypes in the respective header files. > +int board_init(void) > +{ ... > + /* relocate the exception vectors */ > + /* U-Boot is running from DRAM at this stage */ > + for (i = 0; i < 0x100; i += 4) { > + *(unsigned int *)(0x0 + i) = *(unsigned int *)(TEXT_BASE + i); > + } Are you absolutely sure this code is correct? > +int dram_init(void) > +{ > + int i; > + > + debug_print_ftrace(); You probably want to get rid of
[U-Boot] Writing a YAFFS image to NAND
Is there support in the 2009.03 version of U-boot to allow writing a YAFFS image created by mkyaffs2image to NAND, including the meta-data in the OOB? Looking over the nand write/read commands, they look to ignore the OOB data interleaved in the image (i.e. 2048+16 bytes per page for large-block NAND). I did see a patch from fmandarino on the list, but that doesn't look to be in the 2009.03 codebase. Thanks in advance! -- Peter Barada ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Writing a YAFFS image to NAND
Peter Barada wrote: > Is there support in the 2009.03 version of U-boot to allow writing a > YAFFS image created by mkyaffs2image to NAND, including the meta-data in > the OOB? Not that I know of (unless something in cmd_yaffs2.c can do it). > Looking over the nand write/read commands, they look to ignore the OOB > data interleaved in the image (i.e. 2048+16 bytes per page for > large-block NAND). I did see a patch from fmandarino on the list, but > that doesn't look to be in the 2009.03 codebase. That was several years ago; if someone wants to submit a proper patch against current u-boot (without the pre-2.6.18 support, or at least with the newer format being the default), I'll apply it. Better yet would be a more general mechanism whereby the user specifies how many OOB bytes are interleaved in the supplied image, without any specific knowledege of yaffs. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Gbe Controller driver support for kirkwood SOCs
Prafulla Wadaskar wrote: > From: prafulla_wadaskar > > Contributors: > Yotam Admon > Michael Blostein > Signed-off-by: prafulla_wadaskar > Reviewed by: Ronen Shitrit > --- > > diff --git a/net/eth.c b/net/eth.c > index 4bbf84b..77fa8a5 100644 > --- a/net/eth.c > +++ b/net/eth.c > @@ -73,6 +73,7 @@ int board_eth_init(bd_t *bis) __attribute((weak, > alias("__def_eth_init"))); > > extern int mv6436x_eth_initialize(bd_t *); > extern int mv6446x_eth_initialize(bd_t *); > +extern int kirkwood_egiga_initialize(bd_t*); > > #ifdef CONFIG_API > extern void (*push_packet)(volatile void *, int); > @@ -205,6 +206,9 @@ int eth_initialize(bd_t *bis) > #if defined(CONFIG_DB64460) || defined(CONFIG_P3Mx) > mv6446x_eth_initialize(bis); > #endif > +#ifdef CONFIG_KIRKWOOD_EGIGA > + kirkwood_egiga_initialize(bis); > +#endif > if (!eth_devices) { > puts ("No ethernet found.\n"); > show_boot_progress (-64); > I believe Mike mentioned this already, but you shouldn't be initializing your drivers here. You'll notice that this area of code is much smaller than it used to be, and the only drivers left are Marvell ones. I started cleaning them up, but the work was huge and lacking hardware I was nervous about breaking things. IIRC, the MV6436X and MV6446X drivers duplicate code > 99%. regards, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Marvell Kirkwood family SOC support
Dear Prafulla Wadaskar, In message <1238798370-9245-2-git-send-email-prafu...@marvell.com> you wrote: > From: prafulla_wadaskar > > Kirkwood family controllers are highly integrated SOCs > based on Feroceon-88FR131/Sheeva-88SV131 cpu core. > > SOC versions supported:- > 1) 88F6281-Z0 define CONFIG_KW88F6281_Z0 > 2) 88F6281-A0 define CONFIG_KW88F6281_A0 > 3) 88F6192-A0 define CONFIG_KW88F6192_A0 > > Other supported features:- > 1) Doimage utility needed to create binaries with >bootROM header > 2) get_random_hex() fucntion > 3) SPI port controller driver > 4) PCI Express port initialization > > Contributors: > Yotam Admon > Michael Blostein > Signed-off-by: prafulla_wadaskar > Reviewed by: Ronen Shitrit ... > board/Marvell/common/kw_lowlevel_init.S| 45 + > board/Marvell/include/core.h |4 + > cpu/arm926ejs/kirkwood/Makefile| 52 + > cpu/arm926ejs/kirkwood/bin_dep.sh | 50 + > cpu/arm926ejs/kirkwood/config.mk | 25 + > cpu/arm926ejs/kirkwood/doimage/Makefile| 112 ++ > cpu/arm926ejs/kirkwood/doimage/bootstrap_def.h | 88 ++ > cpu/arm926ejs/kirkwood/doimage/doimage | Bin 0 -> 17712 bytes Never ever add binaries !!! > --- a/board/Marvell/include/core.h > +++ b/board/Marvell/include/core.h > @@ -12,9 +12,11 @@ space). The macros take care of Big/Little endian > conversions. > #ifndef __INCcoreh > #define __INCcoreh > > +#ifndef CONFIG_KIRKWOOD > #include "mv_gen_reg.h" > > extern unsigned int INTERNAL_REG_BASE_ADDR; > +#endif /* CONFIG_KIRKWOOD */ > > // > /* GENERAL Definitions */ > @@ -91,10 +93,12 @@ extern unsigned int INTERNAL_REG_BASE_ADDR; > #define _1G 0x4000 > #define _2G 0x8000 Please get rid of these "cool" (actually stupid) macros. > +#ifndef __ASSEMBLY__ > #ifndef BOOL_WAS_DEFINED > #define BOOL_WAS_DEFINED > typedef enum _bool{false,true} bool; > #endif > +#endif > > /* Little to Big endian conversion macros */ Please also use standard macros here, and clean up these proprietary definitions. > diff --git a/cpu/arm926ejs/kirkwood/bin_dep.sh > b/cpu/arm926ejs/kirkwood/bin_dep.sh > new file mode 100755 > index 000..1b36e91 > --- /dev/null > +++ b/cpu/arm926ejs/kirkwood/bin_dep.sh ... > +TOP_DIR=`pwd` > +CUR_DIR=$2 > +BIN_FILE=$TOP_DIR/$1 > + > +if [ "clean" == "$1" ]; then > + # erase created doimage utility > + rm -f $CUR_DIR/doimage/doimage > + exit 0 > +fi > + > +if [ ! -f $BIN_FILE ]; then > + echo Error.. could not find $BIN_FILE > + exit 1 > +else > + make -C $CUR_DIR/doimage > + exit 0 > +fi Please get rid of this. It doesn't for for out-of-tree builds anyway. ... > diff --git a/cpu/arm926ejs/kirkwood/doimage/Makefile > b/cpu/arm926ejs/kirkwood/doimage/Makefile > new file mode 100644 > index 000..219ae1e > --- /dev/null > +++ b/cpu/arm926ejs/kirkwood/doimage/Makefile > @@ -0,0 +1,112 @@ .. > +BIN_FILES= doimage$(SFX) > + > +OBJ_LINKS= > +OBJ_FILES= doimage.o > + > +LIBFDT_OBJ_FILES = > + > +#- > + > +HOSTARCH := $(shell uname -m | \ > + sed -e s/i.86/i386/ \ > + -e s/sun4u/sparc64/ \ > + -e s/arm.*/arm/ \ > + -e s/sa110/arm/ \ > + -e s/powerpc/ppc/ \ > + -e s/Power\ Macintosh/ppc/ \ > + -e s/macppc/ppc/) > + > +HOSTOS := $(shell uname -s | tr A-Z a-z | \ > + sed -e 's/\(cygwin\).*/cygwin/') Why is this needed? You should get this from the top level Makefile. > +# > diff --git a/cpu/arm926ejs/kirkwood/doimage/bootstrap_def.h > b/cpu/arm926ejs/kirkwood/doimage/bootstrap_def.h > new file mode 100644 > index 000..8782206 > --- /dev/null > +++ b/cpu/arm926ejs/kirkwood/doimage/bootstrap_def.h Do you REEALLY need all this stuff? Why? What is the rationale behind it? Did I miss the documentation for it? Apropos documentation... how about entries to the MAINTAINERS file, MAKEALL, etc. ? ... > +/* typedefs */ > + > +typedef char s8; > +typedef unsigned char u8; > + > +typedef int s32; > +typedef unsigned int u32; > + > +typedef short s16; > +typedef unsigned short u16; > + > +typedef long s64; > +typedef unsigned long u64; > + Why is theis needed? Please include the respexctive standard headers. > diff --git a/cpu/arm926ejs/kirkwood/doimage/doimage > b/cpu/arm926ejs/kirkwood/doimage/doimage > new file mode 100755 > index > ..9fee11740454ff880c081a64be0d692b1da4c19a > GIT binary patch > literal 17712 > zcmcIse|%KcmA{h=Fd#ayQbf(l!zLA42nnP#P^kP$gccORAQmtT$%Gl3WMbxx1Q%-J > zWR$m$X;~#*yJ8DU`*B;_;#LAEQxjlGw01XGYjJg3RMZ)RHtSDnquKBG-uEVNNWk`w > zeSB{2Irp4 diff --git a/cpu/arm926ejs/kirkwood/doimage/doimage.c > b/cpu/arm926ejs/kirkwood/doimage/doimag
Re: [U-Boot] [PATCH] Marvell 88EXXXX Switch/PHY init support
Dear Prafulla Wadaskar, In message <1238798370-9245-4-git-send-email-prafu...@marvell.com> you wrote: > From: prafulla_wadaskar > > Chips supprted:- > 1. 88E61XX 6 port gbe swtich with 5 integrated PHYs > 2. 88E6061 6 port fe swtich with 5 integrated PHYs > 3. 88E1116 gbe transceiver > > Contributors: > Yotam Admon > Michael Blostein > Signed-off-by: prafulla_wadaskar > Reviewed by: Ronen Shitrit ben has already commented on the incorrect location of this code in the directory hierarchy. I will restrict my review to formal issues. > diff --git a/board/Marvell/common/mv88e1116.c > b/board/Marvell/common/mv88e1116.c > new file mode 100644 > index 000..87ec550 > --- /dev/null > +++ b/board/Marvell/common/mv88e1116.c ... > +#ifndef MV88E1116_DEBUG > +#define MV88E1116_DEBUG 0 > +#endif > +#define DEBUG_PRINT MV88E1116_DEBUG > + > +#include > +#include > +#include "../common/ppc_error_no.h" See before (i. e. get rid of this stuff, here and everywhere else; it will make the code jkust simpler). > diff --git a/board/Marvell/common/mv88e60xx.c > b/board/Marvell/common/mv88e60xx.c > new file mode 100644 > index 000..6034f7b > --- /dev/null > +++ b/board/Marvell/common/mv88e60xx.c ... > +static void mv_switch_88e60xx_vlan_init(u32 eth_port_num, > + u32 switch_cpu_port, > + u32 switch_max_ports_num, > + u32 switch_ports_ofs, > + u32 switch_enabled_ports_mask) > +{ > + u32 prt; > + u16 reg; > + > + debug_print_ftrace(); > + /* be sure all ports are disabled */ > + for (prt = 0; prt < switch_max_ports_num; prt++) { > + mv_sw_eth_phy_reg_read(eth_port_num, (switch_ports_ofs + prt), > +MV88E60XX_PORT_CONTROL_REG, ®); > + reg &= ~0x3; > + mv_sw_eth_phy_reg_write(eth_port_num, (switch_ports_ofs + prt), > + MV88E60XX_PORT_CONTROL_REG, reg); Please read the CodingStyle document about resonable choice oif namess for functions, variables, etc. Names like mv_switch_88e60xx_vlan_init(), mv_sw_eth_phy_reg_read(), switch_max_ports_num, etc. are a pain to write, and a bigger pain to read. Please use SIMPLE, readable names. ... > +U_BOOT_CMD(smi, CONFIG_SYS_MAXARGS, 1, do_smi, > +"smi - isues read/write command on smi for switch registers\n", > +"smi read [smiaddr] [regaddr] [page]\n" > +"- read smi register command\n" > +"smi write [smiaddr] [regaddr] [value] [page]\n" > +"- write to register command\n" > +"- run the commands in the environment variable(s) 'var'\n"); The definition of the U_BOOT_CMD macro has changed, please fix your ... > +U_BOOT_CMD(dump60xxphy, CONFIG_SYS_MAXARGS, 1, do_dump60xxphy, > +"dump60xxphy - dump 88360xx registers\n", > +"var [...]\n" > +"- run the commands in the environment variable(s) 'var'\n"); > +#endif /* CONFIG_CMD_DUMP60XXPHY */ Ditto. Hm... if we the function of this is to "dump 88360xx registers", then why is the command name "dump60xxphy" ? 60xx != 88360xx ?? Ditto for the rest of the file. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Eeeek! 'eval' on strings should have been named 'evil'.-- Tom Phoenix in ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Gbe Controller driver support for kirkwood SOCs
Dear Prafulla Wadaskar, In message <1238798370-9245-3-git-send-email-prafu...@marvell.com> you wrote: > From: prafulla_wadaskar > > Contributors: > Yotam Admon > Michael Blostein > Signed-off-by: prafulla_wadaskar > Reviewed by: Ronen Shitrit ... > diff --git a/cpu/arm926ejs/kirkwood/Makefile b/cpu/arm926ejs/kirkwood/Makefile > index 41ac8d7..3e20898 100644 > --- a/cpu/arm926ejs/kirkwood/Makefile > +++ b/cpu/arm926ejs/kirkwood/Makefile > @@ -30,6 +30,7 @@ COBJS-y = timer.o > COBJS-y += serial.o > COBJS-y += kwcore.o > COBJS-y += dram.o > +COBJS-y += egiga.o Please sort such lists. ... > +int eth_smi_reg_read(u32 eth_port_num, u32 phy_adr, u32 reg_ofs, u16 * data) > +{ > + u32 smi_reg; > + volatile u32 timeout; > + > + /* check parameters */ > + if ((phy_adr << ETH_PHY_SMI_DEV_ADDR_OFFS) & > ~ETH_PHY_SMI_DEV_ADDR_MASK) { Line too long. (Hint: consider using shorter names! :-) ... > + /* fill the phy address and regiser offset and read opcode */ > + smi_reg = > + (phy_adr << ETH_PHY_SMI_DEV_ADDR_OFFS) | (reg_ofs << > + KW_ETH_SMI_REG_ADDR_OFFS) > + | ETH_PHY_SMI_OPCODE_READ; Please clean up indentation here. ... > +static int egiga_free_rx_rings(struct eth_device *dev) > +{ > + u32 queue; > + ETH_PORT_INFO *ethernet_private; > + struct egiga_priv *port_private; > + u32 port_num; > + volatile ETH_RX_DESC *p_rx_curr_desc; > + > + ethernet_private = (ETH_PORT_INFO *) dev->priv; > + port_private = (struct egiga_priv *)ethernet_private->port_private; > + port_num = port_private->port_num; > + > + /* Stop RX Queues */ > + KW_REG_WRITE(KW_ETH_RECEIVE_QUEUE_COMMAND_REG(port_num), 0xff00); > + > + /* Free RX rings */ > + debug_print("Clearing previously allocated RX queues... "); > + for (queue = 0; queue < KW_RX_QUEUE_NUM; queue++) { > + /* Free preallocated skb's on RX rings */ > + for (p_rx_curr_desc = > + ethernet_private->p_rx_desc_area_base[queue]; > + (((u32)p_rx_curr_desc < > +((u32)ethernet_private-> > + p_rx_desc_area_base[queue] + > + ethernet_private->rx_desc_area_size[queue]))); > + p_rx_curr_desc = > + (ETH_RX_DESC *) ((u32)p_rx_curr_desc + > + RX_DESC_ALIGNED_SIZE)) { > + if (p_rx_curr_desc->return_info != 0) { > + p_rx_curr_desc->return_info = 0; > + debug_print("freed"); > + } ... and here. Such code is basicly unreadable. ... > +static ETH_FUNC_RET_STATUS eth_port_send(ETH_PORT_INFO * p_eth_port_ctrl, > + ETH_QUEUE tx_queue, > + PKT_INFO * p_pkt_info) > +{ > + volatile ETH_TX_DESC *p_tx_desc_first; > + volatile ETH_TX_DESC *p_tx_desc_curr; > + volatile ETH_TX_DESC *p_tx_next_desc_curr; > + volatile ETH_TX_DESC *p_tx_desc_used; > + u32 command_status; > + > +#ifdef CONFIG_TX_PKT_DISPLAY > + { > + u16 pcnt = p_pkt_info->byte_cnt; > + u8 *prndt = (char *)p_pkt_info->buf_ptr; > + printf("cnt=%d ", pcnt); Blank line after declarations, please (check gloabally, please). Also, pelase try to acoid such nested blocks with additional declarations. > + while (pcnt) { > + printf("%02x,", prndt[0]); > + prndt++; > + pcnt--; > + } > + printf(" pckend \n"); > + > + } > +#endif ... > diff --git a/cpu/arm926ejs/kirkwood/egiga.h b/cpu/arm926ejs/kirkwood/egiga.h > new file mode 100644 > index 000..83dc4b3 > --- /dev/null > +++ b/cpu/arm926ejs/kirkwood/egiga.h > @@ -0,0 +1,707 @@ ... > +#ifndef TRUE > +#define TRUE 1 > +#endif > +#ifndef FALSE > +#define FALSE 0 > +#endif Omit? ... > +struct net_device_stats { > + u32 rx_packets; /* total packets received */ > + u32 tx_packets; /* total packets transmitted*/ > + u32 rx_bytes; /* total bytes received */ > + u32 tx_bytes; /* total bytes transmitted */ > + u32 rx_errors; /* bad packets received */ > + u32 tx_errors; /* packet transmit problems */ > + u32 rx_dropped; /* no space in linux buffers*/ > + u32 tx_dropped; /* no space available in linux */ > + u32 multicast; /* multicast packets received */ > + u32 collisions; > + /* detailed rx_errors: */ > + u32 rx_length_errors; > + u32 rx_over_errors; /* receiver ring buff overflow */ > + u32 rx_crc_errors; /* recved pkt with crc error*/ > + u32 rx_frame_errors;/* recv'd frame alignment error */ > + u32 rx_fifo_errors; /* recv'r fifo overrun */ > + u32 rx_missed_errors; /* r
Re: [U-Boot] release timing wrt linux
Hello everybody in message <200904020716.34368.vap...@gentoo.org> Mike Frysinger wrote: > > can we shorten/elongate (doesnt matter to me) the next release process ? the > original time frame was picked so as to not overlap with the linux kernel, > but > the current merge window did exactly that :(. This being a correct and reasonable request, I decided to extend the stabilzation phase for the next release by 3 weeks. i. e. the release schedule (see also http://www.denx.de/wiki/U-Boot/ReleaseCycle) now looks like this: - The next version will be called v2009.06 - The merge window for v2009.06 closes in 2 hours from now. So better hurry up if you still want to get something into this release ;-) - The release of v2009.06 is scheduled for Sunday, June 14, 2009. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de There's no future in time travel. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Add "GPL cleanup" task to feature-removal-schedule.txt
In message <1238686269-30075-1-git-send-email...@denx.de> I wrote: > From: Wolfgang Denk > > Announce removal of all non-GPL or GPL-incompatible files > after August 2009. > > Signed-off-by: Wolfgang Denk > --- > doc/feature-removal-schedule.txt | 14 ++ > 1 files changed, 14 insertions(+), 0 deletions(-) Applied. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de I think animal testing is a terrible idea; they get all nervous and give the wrong answers. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Add "source" command; prepare removal of "autoscr" command
In message <1238621652-2984-1-git-send-email...@denx.de> I wrote: > According to the doc/feature-removal-schedule.txt, the "autoscr" > command will be replaced by the "source" command in approximately 6 > months from now. > > This patch prepares this change and starts a 6 month transition > period as follows: > > - The new "source" command has been added, which implements exactly > the same functionlaity as the old "autoscr" command before > - The old "autoscr" command name is kept as an alias for compatibility > - Command sequences, script files atc. have been adapted to use the > new "source" command > - Related environment variables ("autoscript", "autoscript_uname") > have *not* been adapted yet; these will be renamed resp. removed in > a separate patch when the support for the "autoscr" command get's > finally dropped. > > Signed-off-by: Wolfgang Denk > --- > Changes since V1: > - add DEPRECATED warning message to "autoscr" help text. > - Print DEPRECATED warning message whenever "autoscr" command gets > used. > > README | 10 +- > board/cray/L1/L1.c |2 +- > board/cray/L1/bootscript.hush|2 +- > board/esd/common/cmd_loadpci.c |6 +- > board/pn62/cmd_pn62.c|7 +- > common/Makefile |4 +- > common/cmd_autoscript.c | 241 --- > common/cmd_load.c|7 +- > common/cmd_net.c |7 +- > common/cmd_source.c | 256 > ++ > doc/feature-removal-schedule.txt | 20 ++- > include/common.h |4 +- > include/config_cmd_all.h |2 +- > include/config_cmd_default.h |2 +- > include/configs/APC405.h | 14 +- > include/configs/CRAYL1.h | 26 ++-- > include/configs/DU440.h | 12 +- > include/configs/EP1C20.h |2 +- > include/configs/GEN860T.h|2 +- > include/configs/MVBC_P.h | 12 +- > include/configs/MVBLM7.h | 12 +- > include/configs/NETPHONE.h |2 +- > include/configs/NETTA2.h |2 +- > include/configs/NX823.h |4 +- > include/configs/PN62.h |6 +- > include/configs/TOP860.h |8 +- > include/configs/TQM5200.h|2 +- > include/configs/VoVPN-GW.h |4 +- > include/configs/afeb9260.h |6 +- > include/configs/apollon.h|2 +- > include/configs/at91cap9adk.h|4 +- > include/configs/at91sam9260ek.h |6 +- > include/configs/at91sam9261ek.h |6 +- > include/configs/at91sam9263ek.h |6 +- > include/configs/at91sam9rlek.h |6 +- > include/configs/atngw100.h |2 +- > include/configs/atstk1002.h |2 +- > include/configs/atstk1006.h |2 +- > include/configs/eNET.h |6 +- > include/configs/favr-32-ezkit.h |2 +- > include/configs/grsim.h | 26 ++-- > include/configs/grsim_leon2.h| 22 ++-- > include/configs/gth2.h | 14 +- > include/configs/keymile-common.h |2 +- > include/configs/lwmon.h |4 +- > include/configs/lwmon5.h |2 +- > include/configs/mp2usb.h |4 +- > include/configs/mx1fs2.h |6 +- > include/configs/omap2420h4.h |2 +- > include/configs/omap3_beagle.h |2 +- > include/configs/omap3_evm.h |2 +- > include/configs/omap3_overo.h|2 +- > include/configs/omap3_pandora.h |2 +- > include/configs/omap3_zoom1.h|2 +- > include/configs/sc3.h| 24 ++-- > include/configs/scb9328.h|4 +- > include/configs/stxxtc.h |2 +- > include/configs/vct.h| 38 +++--- > include/configs/wepep250.h |6 +- > 59 files changed, 458 insertions(+), 436 deletions(-) > delete mode 100644 common/cmd_autoscript.c > create mode 100644 common/cmd_source.c Applied. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The most exciting phrase to hear in science, the one that heralds new discoveries, is not "Eureka!" (I found it!) but "That's funny ..." -- Isaac Asimov ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] NetLoop initialization bug
Dear Ben Warren, In message <49d5338c.1050...@gmail.com> you wrote: > > > Could you please do an additional try to apply the patch produced > > with git-format-patch. I hope it is OK now. > > > I tried to apply it but it didn't work, but this isn't my usual > computer. I'll try on my other machine tonight. BTW - what mailer are > you using? It fails for me, too. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "Ja, mach' nur einen Plan,sei nur ein grosses Licht und mach' dann noch 'nen zweiten Plan,geh'n tun sie beide nicht." -- Bert Brecht, Dreigroschenoper ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] NetLoop initialization bug
Hi Ben, On Fri, Apr 3, 2009 at 12:52 AM, Ben Warren wrote: > > I tried to apply it but it didn't work, but this isn't my usual computer. > I'll try on my other machine tonight. BTW - what mailer are you using? > I used Firefox as front-end web interface to communicate with gmail server - the only option I have at my work place. It obviously caused the problem. The http://kerneltrap.org/Linux/Email_Clients_and_Patches perfectly describes this. Today I created the patch on my home's Linux with git-format-patch and sent it by git-send-email via msmtp. I would like to apologize for inconvenience and ask you to try patch again. BTW - what mailer do you use to communicate to the gmail server? Thanks, Michael ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/2] PQ2FADS: Enable PCI.
PCI on PQ2FADS is very similar to PCI on MPC8272ADS. Signed-off-by: Scott Wood --- cpu/mpc8260/pci.c|2 ++ include/configs/MPC8260ADS.h | 19 ++- 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/cpu/mpc8260/pci.c b/cpu/mpc8260/pci.c index f1e9bb4..6a14ba4 100644 --- a/cpu/mpc8260/pci.c +++ b/cpu/mpc8260/pci.c @@ -258,6 +258,8 @@ void pci_mpc8250_init (struct pci_controller *hose) immap->im_siu_conf.sc_siumcr = (immap->im_siu_conf.sc_siumcr & ~SIUMCR_LBPC11) | SIUMCR_LBPC01; +#elif defined(CONFIG_ADSTYPE) && CONFIG_ADSTYPE == CONFIG_SYS_PQ2FADS +/* nothing to do for this board here */ #elif defined CONFIG_MPC8272 immap->im_siu_conf.sc_siumcr = (immap->im_siu_conf.sc_siumcr & ~SIUMCR_BBD & diff --git a/include/configs/MPC8260ADS.h b/include/configs/MPC8260ADS.h index 21210eb..088df8b 100644 --- a/include/configs/MPC8260ADS.h +++ b/include/configs/MPC8260ADS.h @@ -69,6 +69,13 @@ #if CONFIG_ADSTYPE == CONFIG_SYS_8272ADS #define CONFIG_MPC8272 1 +#elif CONFIG_ADSTYPE == CONFIG_SYS_PQ2FADS +/* + * Actually MPC8275, but the code is littered with ifdefs that + * apply to both, or which use this ifdef to assume board-specific + * details. :-( + */ +#define CONFIG_MPC8272 1 #else #define CONFIG_MPC8260 1 #endif /* CONFIG_ADSTYPE == CONFIG_SYS_8272ADS */ @@ -178,7 +185,7 @@ #endif /* CONFIG_ADSTYPE >= CONFIG_SYS_PQ2FADS */ /*PCI*/ -#ifdef CONFIG_MPC8272 +#if CONFIG_ADSTYPE >= CONFIG_SYS_PQ2FADS #define CONFIG_PCI #define CONFIG_PCI_PNP #define CONFIG_PCI_BOOTDELAY 0 @@ -246,7 +253,6 @@ #elif CONFIG_ADSTYPE >= CONFIG_SYS_PQ2FADS #undef CONFIG_CMD_SDRAM #undef CONFIG_CMD_I2C -#undef CONFIG_CMD_PCI #else #undef CONFIG_CMD_PCI @@ -320,7 +326,7 @@ #define CONFIG_SYS_IMMR0xF000 #define CONFIG_SYS_BCSR0xF450 -#if CONFIG_ADSTYPE == CONFIG_SYS_8272ADS +#if CONFIG_ADSTYPE >= CONFIG_SYS_PQ2FADS #define CONFIG_SYS_PCI_INT 0xF820 #endif #define CONFIG_SYS_SDRAM_BASE 0x @@ -412,9 +418,12 @@ /*We need to configure chip select to use CPLD PCI IC on MPC8272ADS*/ -#if CONFIG_ADSTYPE == CONFIG_SYS_8272ADS +#if CONFIG_ADSTYPE == CONFIG_SYS_MPC8272ADS #define CONFIG_SYS_BR3_PRELIM (CONFIG_SYS_PCI_INT | 0x1801) /* PCI interrupt controller */ #define CONFIG_SYS_OR3_PRELIM 0x8010 +#elif CONFIG_ADSTYPE == CONFIG_SYS_PQ2FADS +#define CONFIG_SYS_BR8_PRELIM (CONFIG_SYS_PCI_INT | 0x1801) /* PCI interrupt controller */ +#define CONFIG_SYS_OR8_PRELIM 0x8010 #endif #define CONFIG_SYS_RMR RMR_CSRE @@ -449,7 +458,7 @@ #define CONFIG_SYS_RESET_ADDRESS 0x0440 -#if CONFIG_ADSTYPE == CONFIG_SYS_8272ADS +#if CONFIG_ADSTYPE >= CONFIG_SYS_PQ2FADS /* PCI Memory map (if different from default map */ #define CONFIG_SYS_PCI_SLV_MEM_LOCAL CONFIG_SYS_SDRAM_BASE /* Local base */ -- 1.5.6.rc1.6.gc53ad ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 2/2] MPC8260ADS: Define CONFIG_HAS_ETH0.
This is required so that the MAC address will be updated in the device tree. Signed-off-by: Scott Wood --- include/configs/MPC8260ADS.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/configs/MPC8260ADS.h b/include/configs/MPC8260ADS.h index 088df8b..de6a3e3 100644 --- a/include/configs/MPC8260ADS.h +++ b/include/configs/MPC8260ADS.h @@ -519,6 +519,8 @@ #endif /* CONFIG_ADSTYPE == CONFIG_8272ADS*/ +#define CONFIG_HAS_ETH0 + #if CONFIG_ADSTYPE == CONFIG_SYS_8272ADS #define CONFIG_HAS_ETH1 #endif -- 1.5.6.rc1.6.gc53ad ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] unassigned-patches/36: [PATCH] NetLoop initialization bug
The patch fixes the bug of partial initialization of global network parameters. Upon u-boot's start up the first ping command causes a failure of the consequent TFTP command. It happens in the recently added mechanism of the NetLoop initialization where initialization of global network parameters is separated in the NetInitLoop routine which is called per env_id change. Thus, ping request will initialize the network parameters necessary for ping operation only, afterwards the env_changed_id will be set to the env_id that will prevent all following initialization requests from other protocols. The problem is that the initialized by ping subset of network parameters is not sufficient for other protocols and particularly for TFTP which requires the NetServerIp also. Signed-off-by: Michael Zaidman --- Added to GNATS database as unassigned-patches/36 >Responsible:patch-coord >Message-Id: <1238789765-8024-1-git-send-email-michael.zaid...@gmail.com> >In-Reply-To: >References: >Patch-Date: Fri Apr 03 22:16:05 +0200 2009 --- net/net.c | 61 +++-- 1 files changed, 3 insertions(+), 58 deletions(-) diff --git a/net/net.c b/net/net.c index a89f6a0..97883df 100644 --- a/net/net.c +++ b/net/net.c @@ -285,67 +285,15 @@ NetInitLoop(proto_t protocol) int env_id = get_env_id (); /* update only when the environment has changed */ - if (env_changed_id == env_id) - return 0; - - switch (protocol) { -#if defined(CONFIG_CMD_NFS) - case NFS: -#endif -#if defined(CONFIG_CMD_PING) - case PING: -#endif -#if defined(CONFIG_CMD_SNTP) - case SNTP: -#endif - case NETCONS: - case TFTP: + if (env_changed_id != env_id) { NetCopyIP(&NetOurIP, &bd->bi_ip_addr); NetOurGatewayIP = getenv_IPaddr ("gatewayip"); NetOurSubnetMask= getenv_IPaddr ("netmask"); - NetOurVLAN = getenv_VLAN("vlan"); - NetOurNativeVLAN = getenv_VLAN("nvlan"); - - switch (protocol) { -#if defined(CONFIG_CMD_NFS) - case NFS: -#endif - case NETCONS: - case TFTP: - NetServerIP = getenv_IPaddr ("serverip"); - break; -#if defined(CONFIG_CMD_PING) - case PING: - /* nothing */ - break; -#endif -#if defined(CONFIG_CMD_SNTP) - case SNTP: - /* nothing */ - break; -#endif - default: - break; - } - - break; - case BOOTP: - case RARP: - /* -* initialize our IP addr to 0 in order to accept ANY -* IP addr assigned to us by the BOOTP / RARP server -*/ - NetOurIP = 0; NetServerIP = getenv_IPaddr ("serverip"); - NetOurVLAN = getenv_VLAN("vlan"); /* VLANs must be read */ - NetOurNativeVLAN = getenv_VLAN("nvlan"); - case CDP: - NetOurVLAN = getenv_VLAN("vlan"); /* VLANs must be read */ NetOurNativeVLAN = getenv_VLAN("nvlan"); - break; - default: - break; + NetOurVLAN = getenv_VLAN("vlan"); } + env_changed_id = env_id; return 0; } @@ -440,10 +388,7 @@ restart: #if defined(CONFIG_CMD_DHCP) case DHCP: - /* Start with a clean slate... */ BootpTry = 0; - NetOurIP = 0; - NetServerIP = getenv_IPaddr ("serverip"); DhcpRequest(); /* Basically same as BOOTP */ break; #endif -- 1.5.6.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2] PQ2FADS: Enable PCI.
PCI on PQ2FADS is very similar to PCI on MPC8272ADS. Signed-off-by: Scott Wood --- Removed an inadvertent change to an 8272ads ifdef. cpu/mpc8260/pci.c|2 ++ include/configs/MPC8260ADS.h | 17 + 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/cpu/mpc8260/pci.c b/cpu/mpc8260/pci.c index f1e9bb4..6a14ba4 100644 --- a/cpu/mpc8260/pci.c +++ b/cpu/mpc8260/pci.c @@ -258,6 +258,8 @@ void pci_mpc8250_init (struct pci_controller *hose) immap->im_siu_conf.sc_siumcr = (immap->im_siu_conf.sc_siumcr & ~SIUMCR_LBPC11) | SIUMCR_LBPC01; +#elif defined(CONFIG_ADSTYPE) && CONFIG_ADSTYPE == CONFIG_SYS_PQ2FADS +/* nothing to do for this board here */ #elif defined CONFIG_MPC8272 immap->im_siu_conf.sc_siumcr = (immap->im_siu_conf.sc_siumcr & ~SIUMCR_BBD & diff --git a/include/configs/MPC8260ADS.h b/include/configs/MPC8260ADS.h index 21210eb..c75fbb4 100644 --- a/include/configs/MPC8260ADS.h +++ b/include/configs/MPC8260ADS.h @@ -69,6 +69,13 @@ #if CONFIG_ADSTYPE == CONFIG_SYS_8272ADS #define CONFIG_MPC8272 1 +#elif CONFIG_ADSTYPE == CONFIG_SYS_PQ2FADS +/* + * Actually MPC8275, but the code is littered with ifdefs that + * apply to both, or which use this ifdef to assume board-specific + * details. :-( + */ +#define CONFIG_MPC8272 1 #else #define CONFIG_MPC8260 1 #endif /* CONFIG_ADSTYPE == CONFIG_SYS_8272ADS */ @@ -178,7 +185,7 @@ #endif /* CONFIG_ADSTYPE >= CONFIG_SYS_PQ2FADS */ /*PCI*/ -#ifdef CONFIG_MPC8272 +#if CONFIG_ADSTYPE >= CONFIG_SYS_PQ2FADS #define CONFIG_PCI #define CONFIG_PCI_PNP #define CONFIG_PCI_BOOTDELAY 0 @@ -246,7 +253,6 @@ #elif CONFIG_ADSTYPE >= CONFIG_SYS_PQ2FADS #undef CONFIG_CMD_SDRAM #undef CONFIG_CMD_I2C -#undef CONFIG_CMD_PCI #else #undef CONFIG_CMD_PCI @@ -320,7 +326,7 @@ #define CONFIG_SYS_IMMR0xF000 #define CONFIG_SYS_BCSR0xF450 -#if CONFIG_ADSTYPE == CONFIG_SYS_8272ADS +#if CONFIG_ADSTYPE >= CONFIG_SYS_PQ2FADS #define CONFIG_SYS_PCI_INT 0xF820 #endif #define CONFIG_SYS_SDRAM_BASE 0x @@ -415,6 +421,9 @@ #if CONFIG_ADSTYPE == CONFIG_SYS_8272ADS #define CONFIG_SYS_BR3_PRELIM (CONFIG_SYS_PCI_INT | 0x1801) /* PCI interrupt controller */ #define CONFIG_SYS_OR3_PRELIM 0x8010 +#elif CONFIG_ADSTYPE == CONFIG_SYS_PQ2FADS +#define CONFIG_SYS_BR8_PRELIM (CONFIG_SYS_PCI_INT | 0x1801) /* PCI interrupt controller */ +#define CONFIG_SYS_OR8_PRELIM 0x8010 #endif #define CONFIG_SYS_RMR RMR_CSRE @@ -449,7 +458,7 @@ #define CONFIG_SYS_RESET_ADDRESS 0x0440 -#if CONFIG_ADSTYPE == CONFIG_SYS_8272ADS +#if CONFIG_ADSTYPE >= CONFIG_SYS_PQ2FADS /* PCI Memory map (if different from default map */ #define CONFIG_SYS_PCI_SLV_MEM_LOCAL CONFIG_SYS_SDRAM_BASE /* Local base */ -- 1.5.6.rc1.6.gc53ad ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] NetLoop initialization bug
Dear Michael & Ben, In message <660c0f820904031320s392b010bx8796823194bcd...@mail.gmail.com> you wrote: > > I used Firefox as front-end web interface to communicate with gmail > server - the only option I have at my work place. It obviously caused > the problem. The http://kerneltrap.org/Linux/Email_Clients_and_Patches > perfectly describes this. Today I created the patch on my home's Linux > with git-format-patch and sent it by git-send-email via msmtp. I would > like to apologize for inconvenience and ask you to try patch again. I confirm that this patch applies cleanly. [I cannot comment on the content, though.] Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Each kiss is as the first. -- Miramanee, Kirk's wife, "The Paradise Syndrome", stardate 4842.6 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] bugs/36
Synopsis: [U-Boot][PATCH] NetLoop initialization bug Responsible-Changed-From-To: patch-coord->gu-net Responsible-Changed-By: wd Responsible-Changed-When: Fri, 03 Apr 2009 22:31:14 +0200 Responsible-Changed-Why: Assigned to Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Pull request: nand flash
The following changes since commit dfc91c33957c95da34e3888dc87912d5c15a7603: Wolfgang Denk (1): Merge branch 'master' of git://git.denx.de/u-boot-arm are available in the git repository at: git://git.denx.de/u-boot-nand-flash.git master Scott Wood (1): Noisily disable the legacy NAND subsystem. apgmoorthy (1): Fix OneNAND ipl to read CONFIG_SYS_MONITOR_LEN common/cmd_doc.c |4 + doc/README.nand | 109 - drivers/mtd/nand_legacy/nand_legacy.c |3 + onenand_ipl/onenand_boot.c|2 +- onenand_ipl/onenand_ipl.h |8 +-- onenand_ipl/onenand_read.c| 58 -- 6 files changed, 64 insertions(+), 120 deletions(-) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Compilation warning: "MSR_RI" redefined
Dear Detlev, In message you wrote: > > Attached is a patch which fixes this fallout and starts a round of > cleanups. Please submit patches inline, not as attachments! > Subject: [PATCH] Rename common ns16550 constants with UART_ prefix to prevent > conflicts > > Fix problems introduced in commit > 7b5611cdd12ca0cc33f994f0d4a4454788fc3124 [inka4x0: Add hardware > diagnosis functions for inka4x0] which redefined MSR_RI which is > already used on PowerPC systems. > > Also eliminate redundant definitions in ps2mult.h. More cleanup will > be needed for other redundant occurrences though. > > Signed-off-by: Detlev Zundel > --- > board/inka4x0/inkadiag.c | 20 > board/linkstation/avr.c |6 +- > drivers/input/ps2ser.c | 22 > drivers/serial/ns16550.c | 39 +++-- > include/ns16550.h| 135 +++-- > include/ps2mult.h| 99 - > 6 files changed, 139 insertions(+), 182 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de [Doctors and Bartenders], We both get the same two kinds of customers -- the living and the dying. -- Dr. Boyce, "The Menagerie" ("The Cage"), stardate unknown ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request: u-boot-fdt
Dear Jerry Van Baren, In message <49d58bcf.6020...@gmail.com> you wrote: > Dear Wolfgang, > > Please pull git://git.denx.de/u-boot-fdt.git master. These are bugfixes > from dtc/libfdt and resynchronizes us. > > Thanks, > gvb > > The following changes since commit ed9953d6903c9673135a96ae1644f61cb0eac5ce: >Wolfgang Denk (1): > Merge branch 'master' of git://git.denx.de/u-boot-i2c > > are available in the git repository at: > >git://git.denx.de/u-boot-fdt.git master > > David Gibson (2): >libfdt: Rework fdt_next_node() >libfdt: Rework/cleanup fdt_next_tag() > > Emil Medve (1): >Fix a possible overflow case detected by gcc 4.3.2 > > Laurent Gregoire (1): >libfdt: Fix C++ compile-time cast error on gnu 4.2.1 > > include/libfdt.h |2 +- > libfdt/fdt.c | 50 ++ > libfdt/fdt_ro.c | 53 > ++--- > libfdt/fdt_rw.c |2 + > libfdt/fdt_sw.c | 11 - > libfdt/fdt_wip.c | 41 ++- > libfdt/libfdt_internal.h |1 - > 7 files changed, 63 insertions(+), 97 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Your csh still thinks true is false. Write to your vendor today and tell them that next year Configure ought to "rm /bin/csh" unless they fix their blasted shell. :-) - Larry Wall in Configure from the perl distribution ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] NetLoop initialization bug
Hi Michael, Michael Zaidman wrote: > Hi Ben, > > On Fri, Apr 3, 2009 at 12:52 AM, Ben Warren wrote: > >> I tried to apply it but it didn't work, but this isn't my usual computer. >> I'll try on my other machine tonight. BTW - what mailer are you using? >> >> > I used Firefox as front-end web interface to communicate with gmail > server - the only option I have at my work place. It obviously caused > the problem. The http://kerneltrap.org/Linux/Email_Clients_and_Patches > perfectly describes this. Today I created the patch on my home's Linux > with git-format-patch and sent it by git-send-email via msmtp. I would > like to apologize for inconvenience and ask you to try patch again. > > BTW - what mailer do you use to communicate to the gmail server? > I use Thunderbird via IMAP. IMAP is nice because the messages all stay on the server so if you have a few different machines and OSs you don't have to worry about keeping things coherent. Sending patches through TBird usually works, as long as you cut&paste into a 'preformat' block (available from a pull-down menu). But it's not bulletproof. The only sure way to send a patch without worrying about line wrapping etc. is to use git-send-email. You can find instructions online on how to do this with gmail, IIRC you need to have some sendmail-like relay running on your Linux box. I don't remember the details and am not at that computer right now. cheers, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] NetLoop initialization bug
Wolfgang Denk wrote: > Dear Michael & Ben, > > In message <660c0f820904031320s392b010bx8796823194bcd...@mail.gmail.com> you > wrote: > >> I used Firefox as front-end web interface to communicate with gmail >> server - the only option I have at my work place. It obviously caused >> the problem. The http://kerneltrap.org/Linux/Email_Clients_and_Patches >> perfectly describes this. Today I created the patch on my home's Linux >> with git-format-patch and sent it by git-send-email via msmtp. I would >> like to apologize for inconvenience and ask you to try patch again. >> > > I confirm that this patch applies cleanly. > > [I cannot comment on the content, though.] > > Best regards, > > Wolfgang Denk > > Cool - I'll try it out soon. regards, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request u-boot-blackfin.git
Dear Mike Frysinger, In message <1238779289-6054-1-git-send-email-vap...@gentoo.org> you wrote: > The following changes since commit dfc91c33957c95da34e3888dc87912d5c15a7603: > Wolfgang Denk (1): > Merge branch 'master' of git://git.denx.de/u-boot-arm > > are available in the git repository at: > > git://www.denx.de/git/u-boot-blackfin.git master > > Mike Frysinger (13): > Blackfin: bf548-ezkit: new board port > Blackfin: bf527-ezkit: new board port > Blackfin: bf538f-ezkit: new board port > Blackfin: bf526-ezbrd: new board port > Blackfin: bf518f-ezbrd: new board port > Blackfin: fix crash when booting from external memory > Blackfin: bf537-stamp: split CF/IDE code out into dedicated cf-ide.c > Blackfin: convert bfin_sdh to legacy mmc > Blackfin: drop newline from OTP help > Blackfin: do not delay on output bytes > Blackfin: add BF538/BF539 SPI portmux handling > Blackfin: bf533-stamp: drop old spi flash driver > Blackfin: force all boards to HZ of 1000 > > MAINTAINERS |5 + > MAKEALL |5 + > Makefile|6 +- > board/bf518f-ezbrd/.gitignore |1 + > board/bf518f-ezbrd/Makefile | 57 + > board/bf518f-ezbrd/bf518f-ezbrd.c | 101 > board/bf518f-ezbrd/config.mk| 32 +++ > board/bf518f-ezbrd/u-boot.lds.S | 124 ++ > board/bf526-ezbrd/.gitignore|1 + > board/bf526-ezbrd/Makefile | 58 + > board/bf526-ezbrd/bf526-ezbrd.c | 77 +++ > board/bf526-ezbrd/config.mk | 32 +++ > board/bf526-ezbrd/status-led.c | 56 + > board/bf526-ezbrd/u-boot.lds.S | 124 ++ > board/bf527-ezkit/.gitignore|1 + > board/bf527-ezkit/Makefile | 58 + > board/bf527-ezkit/bf527-ezkit.c | 77 +++ > board/bf527-ezkit/config.mk | 32 +++ > board/bf527-ezkit/u-boot.lds.S | 124 ++ > board/bf527-ezkit/video.c | 317 ++ > board/bf533-stamp/Makefile |1 - > board/bf533-stamp/spi_flash.c |2 - > board/bf537-stamp/Makefile |1 + > board/bf537-stamp/bf537-stamp.c | 57 +- > board/bf537-stamp/ide-cf.c | 66 ++ > board/bf538f-ezkit/.gitignore |1 + > board/bf538f-ezkit/Makefile | 57 + > board/bf538f-ezkit/bf538f-ezkit.c | 27 +++ > board/bf538f-ezkit/config.mk| 33 +++ > board/bf538f-ezkit/u-boot.lds.S | 143 > board/bf548-ezkit/.gitignore|1 + > board/bf548-ezkit/Makefile | 58 + > board/bf548-ezkit/bf548-ezkit.c | 79 +++ > board/bf548-ezkit/config.mk | 37 +++ > board/bf548-ezkit/u-boot.lds.S | 124 ++ > board/bf548-ezkit/video.c | 327 > +++ > common/cmd_otp.c|2 +- > cpu/blackfin/initcode.c |9 + > cpu/blackfin/serial.c |4 - > cpu/blackfin/start.S|2 + > drivers/mmc/bfin_sdh.c | 14 +- > drivers/spi/bfin_spi.c | 18 ++ > include/asm-blackfin/blackfin-config-post.h |8 +- > include/configs/bf518f-ezbrd.h | 147 > include/configs/bf526-ezbrd.h | 190 > include/configs/bf527-ezkit.h | 172 ++ > include/configs/bf538f-ezkit.h | 139 > include/configs/bf548-ezkit.h | 211 + > 48 files changed, 3140 insertions(+), 78 deletions(-) > create mode 100644 board/bf518f-ezbrd/.gitignore > create mode 100644 board/bf518f-ezbrd/Makefile > create mode 100644 board/bf518f-ezbrd/bf518f-ezbrd.c > create mode 100644 board/bf518f-ezbrd/config.mk > create mode 100644 board/bf518f-ezbrd/u-boot.lds.S > create mode 100644 board/bf526-ezbrd/.gitignore > create mode 100644 board/bf526-ezbrd/Makefile > create mode 100644 board/bf526-ezbrd/bf526-ezbrd.c > create mode 100644 board/bf526-ezbrd/config.mk > create mode 100644 board/bf526-ezbrd/status-led.c > create mode 100644 board/bf526-ezbrd/u-boot.lds.S > create mode 100644 board/bf527-ezkit/.gitignore > create mode 100644 board/bf527-ezkit/Makefile > create mode 100644 board/bf527-ezkit/bf527-ezkit.c > create mode 100644 board/bf527-ezkit/config.mk > create mode 100644 board/bf527-ezkit/u-boot.lds.S > create mode 100644 board/bf527-ezkit/video.c > delete mode 100644 board/bf533-stamp/spi_flash.c > create mode
[U-Boot] [PATCH] NetLoop initialization bug
The patch fixes the bug of partial initialization of global network parameters. Upon u-boot's start up the first ping command causes a failure of the consequent TFTP command. It happens in the recently added mechanism of the NetLoop initialization where initialization of global network parameters is separated in the NetInitLoop routine which is called per env_id change. Thus, ping request will initialize the network parameters necessary for ping operation only, afterwards the env_changed_id will be set to the env_id that will prevent all following initialization requests from other protocols. The problem is that the initialized by ping subset of network parameters is not sufficient for other protocols and particularly for TFTP which requires the NetServerIp also. Signed-off-by: Michael Zaidman --- net/net.c | 61 +++-- 1 files changed, 3 insertions(+), 58 deletions(-) diff --git a/net/net.c b/net/net.c index a89f6a0..97883df 100644 --- a/net/net.c +++ b/net/net.c @@ -285,67 +285,15 @@ NetInitLoop(proto_t protocol) int env_id = get_env_id (); /* update only when the environment has changed */ - if (env_changed_id == env_id) - return 0; - - switch (protocol) { -#if defined(CONFIG_CMD_NFS) - case NFS: -#endif -#if defined(CONFIG_CMD_PING) - case PING: -#endif -#if defined(CONFIG_CMD_SNTP) - case SNTP: -#endif - case NETCONS: - case TFTP: + if (env_changed_id != env_id) { NetCopyIP(&NetOurIP, &bd->bi_ip_addr); NetOurGatewayIP = getenv_IPaddr ("gatewayip"); NetOurSubnetMask= getenv_IPaddr ("netmask"); - NetOurVLAN = getenv_VLAN("vlan"); - NetOurNativeVLAN = getenv_VLAN("nvlan"); - - switch (protocol) { -#if defined(CONFIG_CMD_NFS) - case NFS: -#endif - case NETCONS: - case TFTP: - NetServerIP = getenv_IPaddr ("serverip"); - break; -#if defined(CONFIG_CMD_PING) - case PING: - /* nothing */ - break; -#endif -#if defined(CONFIG_CMD_SNTP) - case SNTP: - /* nothing */ - break; -#endif - default: - break; - } - - break; - case BOOTP: - case RARP: - /* -* initialize our IP addr to 0 in order to accept ANY -* IP addr assigned to us by the BOOTP / RARP server -*/ - NetOurIP = 0; NetServerIP = getenv_IPaddr ("serverip"); - NetOurVLAN = getenv_VLAN("vlan"); /* VLANs must be read */ - NetOurNativeVLAN = getenv_VLAN("nvlan"); - case CDP: - NetOurVLAN = getenv_VLAN("vlan"); /* VLANs must be read */ NetOurNativeVLAN = getenv_VLAN("nvlan"); - break; - default: - break; + NetOurVLAN = getenv_VLAN("vlan"); } + env_changed_id = env_id; return 0; } @@ -440,10 +388,7 @@ restart: #if defined(CONFIG_CMD_DHCP) case DHCP: - /* Start with a clean slate... */ BootpTry = 0; - NetOurIP = 0; - NetServerIP = getenv_IPaddr ("serverip"); DhcpRequest(); /* Basically same as BOOTP */ break; #endif -- 1.5.6.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request spi flash changes from u-boot-blackfin.git
Dear Mike Frysinger, In message <1238779336-6138-1-git-send-email-vap...@gentoo.org> you wrote: > The following changes since commit dfc91c33957c95da34e3888dc87912d5c15a7603: > Wolfgang Denk (1): > Merge branch 'master' of git://git.denx.de/u-boot-arm > > are available in the git repository at: > > git://www.denx.de/git/u-boot-blackfin.git sf > > Jean-Christophe PLAGNIOL-VILLARD (1): > mtd: add some at45 spi flash support > > Mike Frysinger (7): > sf: drop DEBUG defines > sf: add driver for SST flashes > sf: stmicro: drop redundant id read > sf: always read 5 bytes for the idcode > sf: stmicro: use common page timeout define > sf: set common timeouts in seconds, not milliseconds > sf: stmicro: dont send 4 bytes when reading status register > > Mingkai Hu (1): > mtd: SPI Flash: Support the Spansion Flash > > drivers/mtd/spi/Makefile |2 + > drivers/mtd/spi/atmel.c | 50 +- > drivers/mtd/spi/spansion.c | 350 + > drivers/mtd/spi/spi_flash.c | 13 +- > drivers/mtd/spi/spi_flash_internal.h | 10 +- > drivers/mtd/spi/sst.c| 358 > ++ > drivers/mtd/spi/stmicro.c| 17 +-- > 7 files changed, 780 insertions(+), 20 deletions(-) > create mode 100644 drivers/mtd/spi/spansion.c > create mode 100644 drivers/mtd/spi/sst.c Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de There is is no reason for any individual to have a computer in their home. -- Ken Olsen (President of Digital Equipment Corporation), Convention of the World Future Society, in Boston, 1977 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request: nand flash
Dear Scott Wood, In message <20090403203311.ga9...@ld0162-tx32.am.freescale.net> you wrote: > The following changes since commit dfc91c33957c95da34e3888dc87912d5c15a7603: > Wolfgang Denk (1): > Merge branch 'master' of git://git.denx.de/u-boot-arm > > are available in the git repository at: > > git://git.denx.de/u-boot-nand-flash.git master > > Scott Wood (1): > Noisily disable the legacy NAND subsystem. > > apgmoorthy (1): > Fix OneNAND ipl to read CONFIG_SYS_MONITOR_LEN > > common/cmd_doc.c |4 + > doc/README.nand | 109 > - > drivers/mtd/nand_legacy/nand_legacy.c |3 + > onenand_ipl/onenand_boot.c|2 +- > onenand_ipl/onenand_ipl.h |8 +-- > onenand_ipl/onenand_read.c| 58 -- > 6 files changed, 64 insertions(+), 120 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de ...though his invention worked superbly -- his theory was a crock of sewage from beginning to end. - Vernor Vinge, "The Peace War" ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] NetLoop initialization bug
Hi Ben, Ben Warren wrote: > Hi Michael, > > Michael Zaidman wrote: >> >> Hi Ben, >> >> On Fri, Apr 3, 2009 at 12:52 AM, Ben Warren >> wrote: >> >>> >>> I tried to apply it but it didn't work, but this isn't my usual computer. >>> I'll try on my other machine tonight. BTW - what mailer are you using? >>> >>> >> >> I used Firefox as front-end web interface to communicate with gmail >> server - the only option I have at my work place. It obviously caused >> the problem. The http://kerneltrap.org/Linux/Email_Clients_and_Patches >> perfectly describes this. Today I created the patch on my home's Linux >> with git-format-patch and sent it by git-send-email via msmtp. I would >> like to apologize for inconvenience and ask you to try patch again. >> >> BTW - what mailer do you use to communicate to the gmail server? >> > > I use Thunderbird via IMAP. IMAP is nice because the messages all stay on > the server so if you have a few different machines and OSs you don't have to > worry about keeping things coherent. Sending patches through TBird usually > works, as long as you cut&paste into a 'preformat' block (available from a > pull-down menu). But it's not bulletproof. The only sure way to send a > patch without worrying about line wrapping etc. is to use git-send-email. > You can find instructions online on how to do this with gmail, IIRC you > need to have some sendmail-like relay running on your Linux box. I don't > remember the details and am not at that computer right now. > > cheers, > Ben > Thanks for the info. I played today with the Evolution which also keeps mails on the server and has 'preformated' option trying to compose correct inline patch attachment but with no success. Good night, Michael ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] i.MX31: Add basic support for Freescale's i.MX31 PDK board.
Dear Magnus Lilja, In message <1224746663-12321-2-git-send-email-lilja.mag...@gmail.com> you wrote: > Add support for the Freescale i.MX31 PDK (a.k.a 3DS) board. Ethernet and > MC13873 RTC support is enabled by this patch. > > Booting from NAND is not supported yet so U-boot relies on some other > initial boot loader to set up SDRAM and clocks and copying U-boot to SDRAM. > > Signed-off-by: Magnus Lilja Do you still plan to submit an updated version of this patch one day? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de If the hours are long enough and the pay is short enough, someone will say it's women's work. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] at91: add support for PM9261 board
Dear Ilko Iliev, In message <12260566511023-git-send-email-il...@ronetix.at> you wrote: > This patch adds support for the PM9261 board of Ronetix GmbH (www.ronetix.at) > > Signed-off-by: Ilko Iliev > --- > MAKEALL |1 + > Makefile|3 + > board/ronetix/pm9261/Makefile | 60 + > board/ronetix/pm9261/config.mk |1 + > board/ronetix/pm9261/pm9261.c | 352 + > board/ronetix/pm9261/pm9261_led.c | 79 ++ > board/ronetix/pm9261/pm9261_lowlevel_init.S | 368 > +++ > board/ronetix/pm9261/pm9261_nand.c | 79 ++ > board/ronetix/pm9261/pm9261_partition.c | 47 > include/configs/pm9261.h| 266 > 10 files changed, 1265 insertions(+), 0 deletions(-) > mode change 100755 => 100644 MAKEALL > create mode 100644 board/ronetix/pm9261/Makefile > create mode 100644 board/ronetix/pm9261/config.mk > create mode 100644 board/ronetix/pm9261/pm9261.c > create mode 100644 board/ronetix/pm9261/pm9261_led.c > create mode 100644 board/ronetix/pm9261/pm9261_lowlevel_init.S > create mode 100644 board/ronetix/pm9261/pm9261_nand.c > create mode 100644 board/ronetix/pm9261/pm9261_partition.c > create mode 100644 include/configs/pm9261.h Jean-Christophe says he asked you for a cleaned up / rebased version of this patch. Will you submit one any time soon? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] IXP425: Add new IXP425 board emPC-A400 Part 2/2
Dear Stefan Althoefer, In message <49384735.jeywxlj6p3fgt8ht%stefan.althoe...@web.de> you wrote: > [PATCH] IXP425: Add new IXP425 board emPC-A400 > > This patch adds support for the emPC-A400 CPU board from > Janz Automationssysteme. It will also apply to some > of the Janz emVIEW displays which are based on this CPU > board. > > Besides of the board support, the patch includes > two features which are (up to now) private to this > port but might be of interrest to others. > > 1. Ability to download microcode to the NPE unit. This >code works without using the Intel Library (which >makes it smaller). This is good if you do not want >to do networking in u-boot, but want boot an NFS-rooted >linux system (where linux cannot load the microcode >by itself). >Refer to boards/empca400/cmd_npe.c > 2. Ability to boot the IXP425 Windows-CE kernel. Refer >to boards/empca400/cmd_bootce.c. Jean-Christophe says he has requested a cleaned up / rebased version from you; to you plan to submit one any time soon? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "I knew then (in 1970) that a 4-kbyte minicomputer would cost as much as a house. So I reasoned that after college, I'd have to live cheaply in an apartment and put all my money into owning a computer." - Apple co-founder Steve Wozniak, EE Times, June 6, 1988, pg 45 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] integratorap: fix PCI support
Dear Jean-Christophe PLAGNIOL-VILLARD, In message <1229198885-24298-1-git-send-email-plagn...@jcrosoft.com> you wrote: > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > > diff --git a/include/configs/integratorap.h b/include/configs/integratorap.h > index 6ce3b4d..d7f617f 100644 > --- a/include/configs/integratorap.h > +++ b/include/configs/integratorap.h > @@ -143,7 +143,7 @@ > * PCI definitions > */ > > -/*#define CONFIG_PCI /--* include pci support*/ > +#ifdef CONFIG_PCI/* pci support */ > #undef CONFIG_PCI_PNP > #define CONFIG_PCI_SCAN_SHOW 1 /* show pci devices on startup */ > #define DEBUG > @@ -151,7 +151,6 @@ > #define CONFIG_EEPRO100 > #define CONFIG_SYS_RX_ETH_BUFFER 8 /* use 8 rx buffer on eepro100 > */ > > - > #define INTEGRATOR_BOOT_ROM_BASE 0x2000 > #define INTEGRATOR_HDR0_SDRAM_BASE 0x8000 > > @@ -279,6 +278,7 @@ > #define INTEGRATOR_SC_PCIENABLE \ > (INTEGRATOR_SC_BASE + INTEGRATOR_SC_PCIENABLE_OFFSET) > > +#endif /* CONFIG_PCI */ Do you plan to pull this into the ARM tree for the upcoming release? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de G's Third Law: In spite of all evidence to the contra- ry, the entire universe is composed of only two basic substances: magic and bullshit. H's Dictum:There is no magic ... ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [Bug] IXP425 and e1000 network driver
Dear Ben, In message Stefan Althoefer wrote: > Hi, > > I found that IXP425 (big endian ARM) did not work with e1000 network > driver. The reason is broken access to controller registers. > > I get it working with this patch: > > > --- a/drivers/net/e1000.c > +++ b/drivers/net/e1000.c > @@ -105,12 +105,15 @@ static void e1000_phy_hw_reset(struct e1000_hw *hw); > static int e1000_phy_reset(struct e1000_hw *hw); > static int e1000_detect_gig_phy(struct e1000_hw *hw); > > -#define E1000_WRITE_REG(a, reg, value) (writel((value), ((a)->hw_addr + > E1000_##reg))) > -#define E1000_READ_REG(a, reg) (readl((a)->hw_addr + E1000_##reg)) > -#define E1000_WRITE_REG_ARRAY(a, reg, offset, value) (\ > - writel((value), ((a)->hw_addr + E1000_##reg + ((offset) > << 2 > -#define E1000_READ_REG_ARRAY(a, reg, offset) ( \ > - readl((a)->hw_addr + E1000_##reg + ((offset) << 2))) > +#define E1000_WRITE_REG(a, reg, value) \ > + (writel(cpu_to_le32(value), ((a)->hw_addr + E1000_##reg))) > +#define E1000_READ_REG(a, reg) \ > + (le32_to_cpu(readl((a)->hw_addr + E1000_##reg))) > +#define E1000_WRITE_REG_ARRAY(a, reg, offset, value) \ > + (writel(cpu_to_le32(value),\ > + ((a)->hw_addr + E1000_##reg + ((offset) << 2 > +#define E1000_READ_REG_ARRAY(a, reg, offset) \ > + (le32_to_cpu(readl((a)->hw_addr + E1000_##reg + ((offset) << 2 > #define E1000_WRITE_FLUSH(a) {uint32_t x; x = E1000_READ_REG(a, STATUS);} > > #ifndef CONFIG_AP1000 /* remove for warnings */ > - > > However, I'm not sure it this is the correct fix. > > Is readl supposed to read raw data? > > Is le32_to_cpu/cpu_to_le32 a function or a macro? In the later case the > code is not save or slow due to multiple argument expansion. > > -- Stefan I have never seen any comments on this. Could you please have a look at it? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Unix is like a toll road on which you have to stop every 50 feet to pay another nickel. But hey! You only feel 5 cents poorer each time. - Larry Wall in <1992aug13.192357.15...@netlabs.com> ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] at91: CONFIG_USART3 renamed to CONFIG_USART_DBGU
Dear Michael Roth, In message <1233929554-11483-3-git-send-email-mr...@nessie.de> you wrote: > In reality there are only three usarts on at91 SoC and one serial > debug port called DBGU which is a reduced functionality usart. > > For reasons of clarity and consistency the prefix USART is maintained > independently the fact that normally the debug port is just called DBGU. > > Signed-off-by: Michael Roth > --- > drivers/serial/atmel_usart.c | 23 ++- > include/asm-arm/arch-at91/clk.h|5 + > include/asm-arm/arch-at91/memory-map.h |8 > include/configs/afeb9260.h |2 +- > include/configs/at91cap9adk.h |2 +- > include/configs/at91sam9260ek.h|2 +- > include/configs/at91sam9261ek.h|2 +- > include/configs/at91sam9263ek.h|2 +- > include/configs/at91sam9rlek.h |2 +- > 9 files changed, 29 insertions(+), 19 deletions(-) If I understand correctly, we are waiting for an updated / rebased version of this patch from you. Are you going to submit one any time soon? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Q: How many DEC repairman does it take to fix a flat? A: Five; four to hold the car up and one to swap tires. Q: How long does it take? A: It's indeterminate. It will depend upon how many flats they've brought with them. Q: What happens if you've got TWO flats? A: They replace your generator. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] Support for PXA27X UDC.
Dear Jean-Christophe & Remy, In message <1236684053-21368-1-git-send-email-vivek.ku...@azingo.com> Vivek Kutal wrote: > This Patch adds Support for PXA27X UDC. > > Signed-off-by: Vivek Kutal > --- > Resinding after doing the changes suggested by Kim. > > drivers/serial/usbtty.h |4 +- > drivers/usb/Makefile|1 + > drivers/usb/usbdcore_pxa27x.c | 702 > +++ > include/asm-arm/arch-pxa/pxa-regs.h | 296 --- > include/usbdcore_pxa27x.h | 69 > 5 files changed, 1018 insertions(+), 54 deletions(-) > create mode 100644 drivers/usb/usbdcore_pxa27x.c > create mode 100644 include/usbdcore_pxa27x.h Is this going to go through the USB or through the PXA tree? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] net: Add Xilinx LL Temac driver
Dear Michal, In message <4981658c.7070...@monstr.eu> you wrote: > > > I'm really sorry for taking so long getting to this. Mostly little things: > > it's ok you are busy guy. I removed uninteresting part of code. > I added all your reported things to u-boot-microblaze.git net branch. > Thanks for pull. What exactly is the state of this today? It seems this did not hit mainline yet? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de There is enough for the need of everyone in this world, but not for the greed of everyone. - Mahatma Gandhi ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [Bug] IXP425 and e1000 network driver
Wolfgang Denk wrote: > Dear Ben, > > In message Stefan Althoefer wrote: > >> Hi, >> >> I found that IXP425 (big endian ARM) did not work with e1000 network >> driver. The reason is broken access to controller registers. >> >> I get it working with this patch: >> >> >> --- a/drivers/net/e1000.c >> +++ b/drivers/net/e1000.c >> @@ -105,12 +105,15 @@ static void e1000_phy_hw_reset(struct e1000_hw *hw); >> static int e1000_phy_reset(struct e1000_hw *hw); >> static int e1000_detect_gig_phy(struct e1000_hw *hw); >> >> -#define E1000_WRITE_REG(a, reg, value) (writel((value), ((a)->hw_addr + >> E1000_##reg))) >> -#define E1000_READ_REG(a, reg) (readl((a)->hw_addr + E1000_##reg)) >> -#define E1000_WRITE_REG_ARRAY(a, reg, offset, value) (\ >> -writel((value), ((a)->hw_addr + E1000_##reg + ((offset) >> << 2 >> -#define E1000_READ_REG_ARRAY(a, reg, offset) ( \ >> -readl((a)->hw_addr + E1000_##reg + ((offset) << 2))) >> +#define E1000_WRITE_REG(a, reg, value) \ >> +(writel(cpu_to_le32(value), ((a)->hw_addr + E1000_##reg))) >> +#define E1000_READ_REG(a, reg) \ >> +(le32_to_cpu(readl((a)->hw_addr + E1000_##reg))) >> +#define E1000_WRITE_REG_ARRAY(a, reg, offset, value) \ >> +(writel(cpu_to_le32(value),\ >> +((a)->hw_addr + E1000_##reg + ((offset) << 2 >> +#define E1000_READ_REG_ARRAY(a, reg, offset) \ >> +(le32_to_cpu(readl((a)->hw_addr + E1000_##reg + ((offset) << 2 >> #define E1000_WRITE_FLUSH(a) {uint32_t x; x = E1000_READ_REG(a, STATUS);} >> >> #ifndef CONFIG_AP1000 /* remove for warnings */ >> - >> >> However, I'm not sure it this is the correct fix. >> >> Is readl supposed to read raw data? >> >> Is le32_to_cpu/cpu_to_le32 a function or a macro? In the later case the >> code is not save or slow due to multiple argument expansion. >> >> -- Stefan >> > > I have never seen any comments on this. Could you please have a look > at it? > > Best regards, > > Wolfgang Denk > > Sure thing. regards, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [U-BOOT][PATCH 1/3] mflash : Fix some style issue
Dear unsik Kim, In message <49a210ac.3080...@gmail.com> you wrote: > > From 53292a06d57fcd93fa508c5c698bca5b60a19691 Mon Sep 17 00:00:00 2001 > From: unsik Kim > Date: Wed, 18 Feb 2009 14:31:49 +0900 > Subject: [PATCH 09/13] Initial mflash support > > Mflash is fusion memory device mainly targeted consumer eletronic and > mobile phone. > Internally, it have nand flash and other hardware logics and supports > some different operation (ATA, IO, XIP) modes. > > IO mode is custom mode for the host that doesn't have IDE interface. > (Many mobile targeted SoC doesn't have IDE bus) > > This driver support mflash IO mode. > > Followings are brief descriptions about IO mode. > > 1. IO mode based on ATA protocol and uses some custom command. (read > confirm, write confirm) > 2. IO mode uses SRAM bus interface. > > Signed-off-by: unsik Kim > --- > common/Makefile |2 + > common/cmd_mgdisk.c | 76 ++ > common/cmd_nvedit.c |8 +- > common/env_mgdisk.c | 92 +++ > disk/part.c |8 +- > disk/part_amiga.c |5 +- > disk/part_dos.c |1 + > disk/part_efi.c |1 + > disk/part_iso.c |1 + > disk/part_mac.c |1 + > doc/README.mflash | 94 +++ > drivers/block/Makefile |5 +- > drivers/block/mg_disk.c | 582 > +++ > drivers/block/mg_disk_prv.h | 145 +++ > fs/fat/fat.c|2 + > include/config_cmd_all.h|1 + > include/environment.h | 12 + > include/mg_disk.h | 51 > include/part.h |1 + > 19 files changed, 1080 insertions(+), 8 deletions(-) > create mode 100644 common/cmd_mgdisk.c > create mode 100644 common/env_mgdisk.c > create mode 100644 doc/README.mflash > create mode 100644 drivers/block/mg_disk.c > create mode 100644 drivers/block/mg_disk_prv.h > create mode 100644 include/mg_disk.h Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de In a business, marketroids, salespukes, and lawyers have different goals from those who actually do work and produce something. Usually, is is the former who triumph over the latter, due to the simple rule that those who print the money make the rules. -- Tom Christiansen in <5jdcls$b0...@csnews.cs.colorado.edu> ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] mflash: Initial mflash support
Dear unsik Kim, In message <1235529084-5499-1-git-send-email-donar...@gmail.com> you wrote: > Mflash is fusion memory device mainly targeted consumer eletronic and > mobile phone. > Internally, it have nand flash and other hardware logics and supports > some different operation (ATA, IO, XIP) modes. > > IO mode is custom mode for the host that doesn't have IDE interface. > (Many mobile targeted SoC doesn't have IDE bus) > > This driver support mflash IO mode. > > Followings are brief descriptions about IO mode. > > 1. IO mode based on ATA protocol and uses some custom command. (read > confirm, write confirm) > 2. IO mode uses SRAM bus interface. > > Signed-off-by: unsik Kim > --- > This is all-in-one mflash patch. (Whole series of patches were squashed > and rebased.) Please, use this if you forgot <49a210ac.3080...@gmail.com>. > --- > common/Makefile |2 + > common/cmd_mgdisk.c | 76 ++ > common/cmd_nvedit.c |8 +- > common/env_mgdisk.c | 92 +++ > disk/part.c |8 +- > disk/part_amiga.c |5 +- > disk/part_dos.c |1 + > disk/part_efi.c |1 + > disk/part_iso.c |1 + > disk/part_mac.c |1 + > doc/README.mflash | 94 +++ > drivers/block/Makefile |5 +- > drivers/block/mg_disk.c | 582 > +++ > drivers/block/mg_disk_prv.h | 145 +++ > fs/fat/fat.c|2 + > include/config_cmd_all.h|1 + > include/environment.h | 12 + > include/mg_disk.h | 51 > include/part.h |1 + > 19 files changed, 1080 insertions(+), 8 deletions(-) > create mode 100644 common/cmd_mgdisk.c > create mode 100644 common/env_mgdisk.c > create mode 100644 doc/README.mflash > create mode 100644 drivers/block/mg_disk.c > create mode 100644 drivers/block/mg_disk_prv.h > create mode 100644 include/mg_disk.h Oops. Forget my previous message, please. Applied this one. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The human race has one really effective weapon, and that is laughter. - Mark Twain ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2 V4] cmd_bdinfo: move implementation to arch instead of common
Dear Jean-Christophe PLAGNIOL-VILLARD, In message <1235453714-5143-1-git-send-email-plagn...@jcrosoft.com> you wrote: > introduce 3 new weak functions board_bdinfo, cpu_bdinfo and soc_bdinfo to > allow > board, cpu and soc to print more information > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > Acked-by: Mike Frysinger > Ack-by: Haavard Skinnemoen > --- > Change from V3 > SOC weak function > and Mike Suggestion > > Best Regards, > J. > common/cmd_bdinfo.c | 462 > --- > include/bdinfo.h| 49 + > lib_arm/Makefile|1 + > lib_arm/bdinfo.c| 53 ++ > lib_avr32/Makefile |1 + > lib_avr32/bdinfo.c | 47 + > lib_blackfin/Makefile |1 + > lib_blackfin/bdinfo.c | 55 ++ > lib_i386/Makefile |1 + > lib_i386/bdinfo.c | 47 + > lib_m68k/Makefile |1 + > lib_m68k/bdinfo.c | 75 > lib_microblaze/Makefile |1 + > lib_microblaze/bdinfo.c | 51 + > lib_mips/Makefile |1 + > lib_mips/bdinfo.c | 47 + > lib_nios/Makefile |1 + > lib_nios/bdinfo.c | 46 + > lib_nios2/Makefile |1 + > lib_nios2/bdinfo.c | 54 ++ > lib_ppc/Makefile|1 + > lib_ppc/bdinfo.c| 107 +++ > lib_sh/Makefile |1 + > lib_sh/bdinfo.c | 47 + > lib_sparc/Makefile | 13 +- > lib_sparc/bdinfo.c | 61 ++ > 26 files changed, 837 insertions(+), 388 deletions(-) > rewrite common/cmd_bdinfo.c (88%) > create mode 100644 include/bdinfo.h > create mode 100644 lib_arm/bdinfo.c > create mode 100644 lib_avr32/bdinfo.c > create mode 100644 lib_blackfin/bdinfo.c > create mode 100644 lib_i386/bdinfo.c > create mode 100644 lib_m68k/bdinfo.c > create mode 100644 lib_microblaze/bdinfo.c > create mode 100644 lib_mips/bdinfo.c > create mode 100644 lib_nios/bdinfo.c > create mode 100644 lib_nios2/bdinfo.c > create mode 100644 lib_ppc/bdinfo.c > create mode 100644 lib_sh/bdinfo.c > create mode 100644 lib_sparc/bdinfo.c Sorry, does not apply any more. Please rebase and resubmit (also "[PATCH 2/2] bdinfo: coding style cleanup" which depends on this). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "I'm not a god, I was misquoted." - Lister, Red Dwarf ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [RFC 0/5] MX31: NAND boot for phyCORE and PDK boards.
Hi all, The following patches add NAND boot support for the i.MX31. I have cleaned up Maxim Artamonov's latest patch (which was for the phyCORE module) and also added i.MX31 PDK support. The series applies on top of Wolfgang's main tree as of yesterday. The original NAND SPL patch has been split into two patches, one that adds the NAND SPL framework for i.MX31 and one that contains only the phyCORE parts. The last two patches first add i.MX31 PDK support and then NAND boot. I haven't taken care of all comments that were presented to Maxim's latest patch so there's more work to be done before this can be added to the main U-boot tree. So this is a work in progress presented "as is" since some people on the list are interested in booting the PDK from NAND. The code for i.MX31 PDK has been tested on real hardware and boots Linux from ethernet. phyCORE has only been compiled. Regards, Magnus Magnus Lilja (5): MX31: Add NAND SPL for i.MX31. MX31: Add NAND SPL support for phycore i.MX31 board. Add NAND SPL entries to gitignore. MX31: Add basic support for Freescale i.MX31 PDK board. MX31: Add NAND SPL boot support to i.MX31 PDK board. .gitignore |1 + MAKEALL |3 + Makefile| 19 +++- board/freescale/mx31pdk/Makefile| 53 +++ board/freescale/mx31pdk/config.mk |5 + board/freescale/mx31pdk/lowlevel_init.S | 123 board/freescale/mx31pdk/mx31pdk.c | 76 ++ board/freescale/mx31pdk/u-boot-nand.lds | 33 + board/freescale/mx31pdk/u-boot.lds | 59 board/imx31_phycore/config.mk | 10 ++ board/imx31_phycore/lowlevel_init.S | 26 cpu/arm1136/start.S | 36 -- include/asm-arm/arch-mx31/mx31-regs.h | 98 + include/configs/imx31_phycore.h | 33 + include/configs/mx31pdk.h | 175 +++ nand_spl/.gitignore |7 + nand_spl/board/freescale/mx31pdk/.gitignore |8 + nand_spl/board/freescale/mx31pdk/Makefile | 66 + nand_spl/board/freescale/mx31pdk/config.mk |5 + nand_spl/board/freescale/mx31pdk/u-boot.lds | 36 + nand_spl/nand_boot_mx31.c | 204 +++ 21 files changed, 1066 insertions(+), 10 deletions(-) create mode 100644 board/freescale/mx31pdk/Makefile create mode 100644 board/freescale/mx31pdk/config.mk create mode 100644 board/freescale/mx31pdk/lowlevel_init.S create mode 100644 board/freescale/mx31pdk/mx31pdk.c create mode 100644 board/freescale/mx31pdk/u-boot-nand.lds create mode 100644 board/freescale/mx31pdk/u-boot.lds create mode 100644 include/configs/mx31pdk.h create mode 100644 nand_spl/.gitignore create mode 100644 nand_spl/board/freescale/mx31pdk/.gitignore create mode 100644 nand_spl/board/freescale/mx31pdk/Makefile create mode 100644 nand_spl/board/freescale/mx31pdk/config.mk create mode 100644 nand_spl/board/freescale/mx31pdk/u-boot.lds create mode 100644 nand_spl/nand_boot_mx31.c ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [RFC 3/5] Add NAND SPL entries to gitignore.
--- .gitignore |1 + nand_spl/.gitignore |7 +++ 2 files changed, 8 insertions(+), 0 deletions(-) create mode 100644 nand_spl/.gitignore diff --git a/.gitignore b/.gitignore index e13fc96..6c7406d 100644 --- a/.gitignore +++ b/.gitignore @@ -29,6 +29,7 @@ /u-boot.ldr.srec /u-boot-onenand.bin /u-boot-flexonenand.bin +/u-boot-nand.bin # # Generated files diff --git a/nand_spl/.gitignore b/nand_spl/.gitignore new file mode 100644 index 000..af5f02b --- /dev/null +++ b/nand_spl/.gitignore @@ -0,0 +1,7 @@ +# NAND-SPL files +/u-boot-spl +/u-boot-spl-aligned.bin +/u-boot-spl.bin +/u-boot-spl.map +/board/imx31_phycore/nand_boot_mx31.c +/board/imx31_phycore/*.S -- 1.5.6 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [RFC 4/5] MX31: Add basic support for Freescale i.MX31 PDK board.
Add support for Freescale's i.MX31 PDK board (a.k.a. 3 stack board). This patch assumes that some other program performs the actual NAND boot. --- MAKEALL |1 + Makefile|3 + board/freescale/mx31pdk/Makefile| 53 ++ board/freescale/mx31pdk/config.mk |1 + board/freescale/mx31pdk/lowlevel_init.S | 30 ++ board/freescale/mx31pdk/mx31pdk.c | 76 ++ board/freescale/mx31pdk/u-boot.lds | 59 +++ include/asm-arm/arch-mx31/mx31-regs.h |2 + include/configs/mx31pdk.h | 162 +++ 9 files changed, 387 insertions(+), 0 deletions(-) create mode 100644 board/freescale/mx31pdk/Makefile create mode 100644 board/freescale/mx31pdk/config.mk create mode 100644 board/freescale/mx31pdk/lowlevel_init.S create mode 100644 board/freescale/mx31pdk/mx31pdk.c create mode 100644 board/freescale/mx31pdk/u-boot.lds create mode 100644 include/configs/mx31pdk.h diff --git a/MAKEALL b/MAKEALL index 94ad389..b581608 100755 --- a/MAKEALL +++ b/MAKEALL @@ -549,6 +549,7 @@ LIST_ARM11="\ imx31_phycore_eet \ imx31_phycore_nand \ mx31ads \ + mx31pdk \ qong\ smdk6400\ " diff --git a/Makefile b/Makefile index f0981ce..40f3465 100644 --- a/Makefile +++ b/Makefile @@ -3081,6 +3081,9 @@ imx31_phycore_nand_config : unconfig mx31ads_config : unconfig @$(MKCONFIG) $(@:_config=) arm arm1136 mx31ads freescale mx31 +mx31pdk_config : unconfig + @$(MKCONFIG) $(@:_config=) arm arm1136 mx31pdk freescale mx31 + omap2420h4_config : unconfig @$(MKCONFIG) $(@:_config=) arm arm1136 omap2420h4 NULL omap24xx diff --git a/board/freescale/mx31pdk/Makefile b/board/freescale/mx31pdk/Makefile new file mode 100644 index 000..b64cec8 --- /dev/null +++ b/board/freescale/mx31pdk/Makefile @@ -0,0 +1,53 @@ +# +# (C) Copyright 2008 Magnus Lilja +# +# (C) Copyright 2000-2006 +# Wolfgang Denk, DENX Software Engineering, w...@denx.de. +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +include $(TOPDIR)/config.mk + +LIB= $(obj)lib$(BOARD).a + +COBJS := mx31pdk.o +SOBJS := lowlevel_init.o + +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS)) +SOBJS := $(addprefix $(obj),$(SOBJS)) + +$(LIB):$(obj).depend $(OBJS) $(SOBJS) + $(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS) + +clean: + rm -f $(SOBJS) $(OBJS) + +distclean: clean + rm -f $(LIB) core *.bak $(obj).depend + +# + +# defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + +# diff --git a/board/freescale/mx31pdk/config.mk b/board/freescale/mx31pdk/config.mk new file mode 100644 index 000..d34dc02 --- /dev/null +++ b/board/freescale/mx31pdk/config.mk @@ -0,0 +1 @@ +TEXT_BASE = 0x87f0 diff --git a/board/freescale/mx31pdk/lowlevel_init.S b/board/freescale/mx31pdk/lowlevel_init.S new file mode 100644 index 000..ec5eedb --- /dev/null +++ b/board/freescale/mx31pdk/lowlevel_init.S @@ -0,0 +1,30 @@ +/* + * (C) Copyright 2008 Magnus Lilja + * + * See file CREDITS for list of people who contributed to this + * project. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, + * MA 02111-1307 USA + */ + +/* + * This is just to kee
[U-Boot] [RFC 2/5] MX31: Add NAND SPL support for phycore i.MX31 board.
This patch is the phycore part of Maxim Artamonov's NAND SPL on phycore patch. The note below is from the original patch. Note: By default, Phytec phyCORE-i.MX31 board (pcm-037 and pcm-970) is not suitable for nand-bootloading, because of SW5 switchers block haven't appropriate modes (8-bit, 2k page or 16-bit, 512 page) for BOOTPINS[4:0] and nand-flash (8-bit mode, 512B page) contemporary. There is require to make RESOLDER for really nand-booting either BOOTPIN state or JN1/2 and RN41/42. The original patch was signed-off-by Maxim Artamonov . --- MAKEALL |1 + Makefile|9 - board/imx31_phycore/config.mk | 10 ++ board/imx31_phycore/lowlevel_init.S | 26 ++ include/configs/imx31_phycore.h | 33 + 5 files changed, 78 insertions(+), 1 deletions(-) diff --git a/MAKEALL b/MAKEALL index 854f303..94ad389 100755 --- a/MAKEALL +++ b/MAKEALL @@ -547,6 +547,7 @@ LIST_ARM11="\ imx31_litekit \ imx31_phycore \ imx31_phycore_eet \ + imx31_phycore_nand \ mx31ads \ qong\ smdk6400\ diff --git a/Makefile b/Makefile index f857641..f0981ce 100644 --- a/Makefile +++ b/Makefile @@ -367,7 +367,7 @@ $(NAND_SPL):$(TIMESTAMP_FILE) $(VERSION_FILE) $(obj)include/autoconf.mk $(MAKE) -C nand_spl/board/$(BOARDDIR) all $(U_BOOT_NAND):$(NAND_SPL) $(obj)u-boot.bin $(obj)include/autoconf.mk - cat $(obj)nand_spl/u-boot-spl-16k.bin $(obj)u-boot.bin > $(obj)u-boot-nand.bin + cat $(obj)nand_spl/u-boot-spl-aligned.bin $(obj)u-boot.bin > $(obj)u-boot-nand.bin $(ONENAND_IPL):$(TIMESTAMP_FILE) $(VERSION_FILE) $(obj)include/autoconf.mk $(MAKE) -C onenand_ipl/board/$(BOARDDIR) all @@ -3071,6 +3071,13 @@ imx31_phycore_config : unconfig fi @$(MKCONFIG) -a imx31_phycore arm arm1136 imx31_phycore NULL mx31 +imx31_phycore_nand_config : unconfig + @mkdir -p $(obj)include $(obj)board/imx31_phycore + @mkdir -p $(obj)nand_spl/board/imx31_phycore + @echo "#define CONFIG_NAND_U_BOOT" > $(obj)include/config.h + @$(MKCONFIG) -n $@ -a imx31_phycore arm arm1136 imx31_phycore NULL mx31 + @echo "CONFIG_NAND_U_BOOT = y" >> $(obj)include/config.mk + mx31ads_config : unconfig @$(MKCONFIG) $(@:_config=) arm arm1136 mx31ads freescale mx31 diff --git a/board/imx31_phycore/config.mk b/board/imx31_phycore/config.mk index d34dc02..412defc 100644 --- a/board/imx31_phycore/config.mk +++ b/board/imx31_phycore/config.mk @@ -1 +1,11 @@ +# +# (C) Copyright 2008 +# was changed by Maxim Artamonov, +# + +ifndef CONFIG_NAND_SPL TEXT_BASE = 0x87f0 +else +TEXT_BASE = 0x87ec +endif + diff --git a/board/imx31_phycore/lowlevel_init.S b/board/imx31_phycore/lowlevel_init.S index c5d6eb0..0733240 100644 --- a/board/imx31_phycore/lowlevel_init.S +++ b/board/imx31_phycore/lowlevel_init.S @@ -1,5 +1,8 @@ /* * + * (C) Copyright 2008 + * Maxim Artamonov, + * * (c) 2007 Pengutronix, Sascha Hauer * * See file CREDITS for list of people who contributed to this @@ -43,6 +46,20 @@ bcs 1b .endm +#ifdef CONFIG_NAND_SPL +/* somewhat macro to reduce bin size for CONFIG_NAND_SPL*/ +.macro FILLREGS begreg, val, count, step + ldr r2, =\begreg + ldr r3, =\val + ldr r4, =\count +2: + str r3, [r2] + add r2, r2, #\step + subsr4, r4, #1 + bcs 2b +.endm +#endif + .globl lowlevel_init lowlevel_init: @@ -60,10 +77,18 @@ lowlevel_init: REG CCM_SPCTL, PLL_PD(1) | PLL_MFD(0x43) | PLL_MFI(12) | PLL_MFN(1) +#ifdef CONFIG_NAND_SPL + FILLREGS 0x43FAC26C, 0, 0x3, 0x4 +#else REG 0x43FAC26C, 0 /* SDCLK */ REG 0x43FAC270, 0 /* CAS */ REG 0x43FAC274, 0 /* RAS */ +#endif /* CONFIG_NAND_SPL */ REG 0x43FAC27C, 0x1000 /* CS2 (CSD0) */ + +#ifdef CONFIG_NAND_SPL + FILLREGS 0x43FAC284, 0, 0x17, 0x4 +#else REG 0x43FAC284, 0 /* DQM3 */ REG 0x43FAC288, 0 /* DQM2, DQM1, DQM0, SD31-SD0, A25-A0, MA10 (0x288..0x2DC) */ REG 0x43FAC28C, 0 @@ -87,6 +112,7 @@ lowlevel_init: REG 0x43FAC2D4, 0 REG 0x43FAC2D8, 0 REG 0x43FAC2DC, 0 +#endif /* CONFIG_NAND_SPL */ REG 0xB8001010, 0x0004 REG 0xB8001004, 0x006ac73a REG 0xB8001000, 0x9210 diff --git a/include/configs/imx31_phycore.h b/include/configs/imx31_phycore.h index cbc0b92..dbe415b 100644 --- a/include/configs/imx31_phycore.h +++ b/include/configs/imx31_phycore.h @@ -1,4 +1,7 @@ /* + * (C) Copyright 2008 + * Maxim Artamonov, + * * (C) Copyright 2004 * Texas Instruments. * Richard Woodruff @@ -34,6 +37,11 @@ #define
[U-Boot] [RFC 1/5] MX31: Add NAND SPL for i.MX31.
This patch adds the NAND SPL framework needed to boot i.MX31 boards from NAND. The patch is based on the work by Maxim Artamonov (which was signed-off-by him). -- Changes since V3 (original author's latest post): * Updated to apply on the main U-boot tree as of 2009-04-02 * Split the patch into two parts, one with the NAND SPL framework and one which activates the NAND boot for the phycore board. * Coding style corrections. --- cpu/arm1136/start.S | 36 +-- include/asm-arm/arch-mx31/mx31-regs.h | 96 +++ nand_spl/nand_boot_mx31.c | 204 + 3 files changed, 327 insertions(+), 9 deletions(-) create mode 100644 nand_spl/nand_boot_mx31.c diff --git a/cpu/arm1136/start.S b/cpu/arm1136/start.S index e622338..e87bf99 100644 --- a/cpu/arm1136/start.S +++ b/cpu/arm1136/start.S @@ -1,6 +1,9 @@ /* * armboot - Startup Code for OMP2420/ARM1136 CPU-core * + * + * Copyright (c) 2008 Maxim Artamonov, + * * Copyright (c) 2004 Texas Instruments * * Copyright (c) 2001 Marius Gröger @@ -32,6 +35,15 @@ #include .globl _start _start: b reset +#ifdef CONFIG_NAND_SPL + nop + nop + nop + nop + nop + nop + nop +#else #ifdef CONFIG_ONENAND_IPL ldr pc, _hang ldr pc, _hang @@ -68,6 +80,7 @@ _irq: .word irq _fiq: .word fiq _pad: .word 0x12345678 /* now 16*4=64 */ #endif /* CONFIG_ONENAND_IPL */ +#endif /* CONFIG_NAND_SPL */ .global _end_vect _end_vect: @@ -156,9 +169,9 @@ relocate: /* relocate U-Boot to RAM */ adr r0, _start /* r0 <- current position of code */ ldr r1, _TEXT_BASE /* test if we run from flash or RAM */ cmp r0, r1 /* don't reloc during debug */ -#ifndef CONFIG_ONENAND_IPL +#if !defined(CONFIG_ONENAND_IPL) && !defined(CONFIG_NAND_SPL) beq stack_setup -#endif /* CONFIG_ONENAND_IPL */ +#endif /* !CONFIG_ONENAND_IPL && !CONFIG_NAND_SPL*/ ldr r2, _armboot_start ldr r3, _bss_start @@ -175,7 +188,7 @@ copy_loop: /* Set up the stack */ stack_setup: ldr r0, _TEXT_BASE /* upper 128 KiB: relocated uboot */ -#ifdef CONFIG_ONENAND_IPL +#if defined(CONFIG_ONENAND_IPL) || defined (CONFIG_NAND_SPL) sub sp, r0, #128/* leave 32 words for abort-stack */ #else sub r0, r0, #CONFIG_SYS_MALLOC_LEN /* malloc area */ @@ -184,14 +197,14 @@ stack_setup: sub r0, r0, #(CONFIG_STACKSIZE_IRQ+CONFIG_STACKSIZE_FIQ) #endif sub sp, r0, #12 /* leave 3 words for abort-stack*/ -#endif /* CONFIG_ONENAND_IPL */ +#endif /* CONFIG_ONENAND_IPL || CONFIG_NAND_SPL*/ clear_bss: ldr r0, _bss_start /* find start of bss segment*/ ldr r1, _bss_end/* stop here*/ mov r2, #0x /* clear*/ -#ifndef CONFIG_ONENAND_IPL +#if !defined(CONFIG_ONENAND_IPL) && !defined(CONFIG_NAND_SPL) clbss_l:strr2, [r0]/* clear loop...*/ add r0, r0, #4 cmp r0, r1 @@ -200,12 +213,15 @@ clbss_l:str r2, [r0]/* clear loop...*/ ldr pc, _start_armboot +#ifdef CONFIG_NAND_SPL +_start_armboot: .word nand_boot +#else #ifdef CONFIG_ONENAND_IPL _start_armboot: .word start_oneboot #else _start_armboot: .word start_armboot -#endif - +#endif /* CONFIG_ONENAND_IPL */ +#endif /* CONFIG_NAND_SPL */ /* * @@ -244,7 +260,7 @@ cpu_init_crit: mov lr, ip /* restore link */ mov pc, lr /* back to my caller */ -#ifndef CONFIG_ONENAND_IPL +#if !defined(CONFIG_ONENAND_IPL) && !defined(CONFIG_NAND_SPL) /* * * @@ -357,11 +373,12 @@ cpu_init_crit: .macro get_fiq_stack@ setup FIQ stack ldr sp, FIQ_STACK_START .endm -#endif /* CONFIG_ONENAND_IPL */ +#endif /* !CONFIG_ONENAND_IPL && !CONFIG_NAND_SPL*/ /* * exception handlers */ +#ifndef CONFIG_NAND_SPL #ifdef CONFIG_ONENAND_IPL .align 5 do_hang: @@ -436,3 +453,4 @@ arm1136_cache_flush: mcr p15, 0, r1, c7, c5, 0 @ invalidate I cache mov pc, lr @ back to caller #endif /* CONFIG_ONENAND_IPL */ +#endif /* !CONFIG_NAND_SPL*/ diff --git a/include/asm-arm/arch-mx31/mx31-regs.h b/include/asm-arm/arch-mx31/mx31-regs.h index a8a05c8..45f2ae3 100644 --- a/include/asm-arm/arch-mx31/mx31-regs.h +++ b/include/asm-arm/arch-mx31/mx31-r
[U-Boot] [RFC 5/5] MX31: Add NAND SPL boot support to i.MX31 PDK board.
--- MAKEALL |3 +- Makefile|7 ++ board/freescale/mx31pdk/config.mk |4 + board/freescale/mx31pdk/lowlevel_init.S | 93 +++ board/freescale/mx31pdk/u-boot-nand.lds | 33 ++ include/configs/mx31pdk.h | 19 +- nand_spl/board/freescale/mx31pdk/.gitignore |8 ++ nand_spl/board/freescale/mx31pdk/Makefile | 66 +++ nand_spl/board/freescale/mx31pdk/config.mk |5 ++ nand_spl/board/freescale/mx31pdk/u-boot.lds | 36 ++ 10 files changed, 270 insertions(+), 4 deletions(-) create mode 100644 board/freescale/mx31pdk/u-boot-nand.lds create mode 100644 nand_spl/board/freescale/mx31pdk/.gitignore create mode 100644 nand_spl/board/freescale/mx31pdk/Makefile create mode 100644 nand_spl/board/freescale/mx31pdk/config.mk create mode 100644 nand_spl/board/freescale/mx31pdk/u-boot.lds diff --git a/MAKEALL b/MAKEALL index b581608..2f55060 100755 --- a/MAKEALL +++ b/MAKEALL @@ -549,7 +549,8 @@ LIST_ARM11="\ imx31_phycore_eet \ imx31_phycore_nand \ mx31ads \ - mx31pdk \ + mx31pdk \ + mx31pdk_nand\ qong\ smdk6400\ " diff --git a/Makefile b/Makefile index 40f3465..9706cb2 100644 --- a/Makefile +++ b/Makefile @@ -3084,6 +3084,13 @@ mx31ads_config : unconfig mx31pdk_config : unconfig @$(MKCONFIG) $(@:_config=) arm arm1136 mx31pdk freescale mx31 +mx31pdk_nand_config: unconfig + @mkdir -p $(obj)include $(obj)board/mx31pdk + @mkdir -p $(obj)nand_spl/board/mx31pdk + @echo "#define CONFIG_NAND_U_BOOT" > $(obj)include/config.h + @$(MKCONFIG) -n $@ -a mx31pdk arm arm1136 mx31pdk freescale mx31 + @echo "CONFIG_NAND_U_BOOT = y" >> $(obj)include/config.mk + omap2420h4_config : unconfig @$(MKCONFIG) $(@:_config=) arm arm1136 omap2420h4 NULL omap24xx diff --git a/board/freescale/mx31pdk/config.mk b/board/freescale/mx31pdk/config.mk index d34dc02..dcaa09f 100644 --- a/board/freescale/mx31pdk/config.mk +++ b/board/freescale/mx31pdk/config.mk @@ -1 +1,5 @@ +ifdef CONFIG_NAND_SPL +TEXT_BASE = 0x87ec +else TEXT_BASE = 0x87f0 +endif diff --git a/board/freescale/mx31pdk/lowlevel_init.S b/board/freescale/mx31pdk/lowlevel_init.S index ec5eedb..602eb53 100644 --- a/board/freescale/mx31pdk/lowlevel_init.S +++ b/board/freescale/mx31pdk/lowlevel_init.S @@ -26,5 +26,98 @@ .globl lowlevel_init +#ifdef CONFIG_NAND_SPL +#include + +.macro REG reg, val + ldr r2, =\reg + ldr r3, =\val + str r3, [r2] +.endm + +.macro REG8 reg, val + ldr r2, =\reg + ldr r3, =\val + strbr3, [r2] +.endm + +.macro DELAY loops + ldr r2, =\loops +1: + subsr2, r2, #1 + nop + bcs 1b +.endm + +.globl lowlevel_init +lowlevel_init: + /* Also setup the Peripheral Port Remap register inside the core */ + ldr r0, =ARM_PPMRR /* start from AIPS 2GB region */ + mcr p15, 0, r0, c15, c2, 4 + + REG IPU_CONF, IPU_CONF_DI_EN + REG CCM_CCMR, 0x074B0BF5 + + DELAY 0x4 + + REG CCM_CCMR, 0x074B0BF5 | CCMR_MPE + REG CCM_CCMR, (0x074B0BF5 | CCMR_MPE) & ~CCMR_MDS + + /* Set up clock to 532MHz */ + REG CCM_PDR0, 0xFF871D58 + REG CCM_MPCTL, 0x0033280C + + REG CCM_SPCTL, PLL_PD(1) | PLL_MFD(4) | PLL_MFI(12) | PLL_MFN(1) + + /* Set up CPLD on CS5 */ + REG CSCR_U(5), 0xD843 + REG CSCR_L(5), 0x22252521 + REG CSCR_A(5), 0x0A00 + + /* Set up MX31 DDR Memory Controller */ + REG 0x43FAC26C, 0 /* SDCLK */ + REG 0x43FAC270, 0 /* CAS */ + REG 0x43FAC274, 0 /* RAS */ + REG 0x43FAC27C, 0x1000 /* CS2 CSD0) */ + REG 0x43FAC284, 0 /* DQM3 */ + REG 0x43FAC288, 0 /* DQM2, DQM1, DQM0, SD31-SD0, A25-A0, MA10 0x288..0x2DC) */ + REG 0x43FAC28C, 0 + REG 0x43FAC290, 0 + REG 0x43FAC294, 0 + REG 0x43FAC298, 0 + REG 0x43FAC29C, 0 + REG 0x43FAC2A0, 0 + REG 0x43FAC2A4, 0 + REG 0x43FAC2A8, 0 + REG 0x43FAC2AC, 0 + REG 0x43FAC2B0, 0 + REG 0x43FAC2B4, 0 + REG 0x43FAC2B8, 0 + REG 0x43FAC2BC, 0 + REG 0x43FAC2C0, 0 + REG 0x43FAC2C4, 0 + REG 0x43FAC2C8, 0 + REG 0x43FAC2CC, 0 + REG 0x43FAC2D0, 0 + REG 0x43FAC2D4, 0 + REG 0x43FAC2D8, 0 + REG 0x43FAC2DC, 0 + REG 0xB8001010, 0x0004 + REG 0xB8001004, 0x006ac73a + REG 0xB8001000, 0x9210 + REG 0x8f00, 0x12344321 + REG 0xB800
Re: [U-Boot] [PATCH 1/2] rtl8169: fix cache coherency problem
Dear Ben, In message <49a4d6bc.3010...@renesas.com> Yoshihiro Shimoda wrote: > Fix the problem that cannot access actual data when CPU data cache enabled. > > Signed-off-by: Yoshihiro Shimoda > --- > drivers/net/rtl8169.c | 11 ++- > 1 files changed, 10 insertions(+), 1 deletions(-) I did not see any comments on this? Ditto for the other patch: http://article.gmane.org/gmane.comp.boot-loaders.u-boot/55286 ? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Do not follow where the path may leadgo instead where there is no path and leave a trail. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] netloop: updates for NetLoop
Dear Ben, In message <49a641e4.8000...@denx.de> you wrote: > [PATCH v2] netloop: updates for NetLoop > > Fix some issues introduced from commit: > 2f70c49e5b9813635ad73666aa30f304c7fdeda9 > suggested by Mike Frysinger. > > - added some comment for the env_id variable in common_cmd_nvedit.c > - moved some variables in fn scope instead of file scope > - NetInitLoop now static void > > Signed-off-by: Heiko Schocher > --- > changes since v1: > - added comments from Mike Frysinger > > common/cmd_nvedit.c |7 +++ > net/eth.c |5 ++--- > net/net.c |8 +++- > 3 files changed, 12 insertions(+), 8 deletions(-) Except for an Ack from Mike I did not see any comments? Ditto for this one: http://article.gmane.org/gmane.comp.boot-loaders.u-boot/55341 Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Children are natural mimics who act like their parents despite every effort to teach them good manners. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [RFC 3/5] Add NAND SPL entries to gitignore.
Magnus Lilja wrote: > diff --git a/nand_spl/.gitignore b/nand_spl/.gitignore > new file mode 100644 > index 000..af5f02b > --- /dev/null > +++ b/nand_spl/.gitignore > @@ -0,0 +1,7 @@ > +# NAND-SPL files > +/u-boot-spl > +/u-boot-spl-aligned.bin > +/u-boot-spl.bin > +/u-boot-spl.map > +/board/imx31_phycore/nand_boot_mx31.c > +/board/imx31_phycore/*.S Hmm, can we create a directory for board-specific temporary files to go, so we don't need board-specific stuff in .gitignore? Or better, add some makefile rules so we can produce nand_spl versions of .o files without having to symlink the source anywhere. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/15] tools/Makefile: Remove inappropriate double-tabs
Dear Peter Tyser, In message <774d4e517995c43614a1b3870814d6e5829ab6c3.1236207433.git.pty...@xes-inc.com> you wrote: > Signed-off-by: Peter Tyser > --- > tools/Makefile | 153 > > 1 files changed, 77 insertions(+), 76 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de NOTE: The Most Fundamental Particles in This Product Are Held Together by a "Gluing" Force About Which Little is Currently Known and Whose Adhesive Power Can Therefore Not Be Permanently Guaranteed. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 02/15] tools/Makefile: Split variable declarations into multiple lines
Dear Peter Tyser, In message <2e1eea15f282ac75853cd510fa4301e3f0763e75.1236207433.git.pty...@xes-inc.com> you wrote: > Split variable declarations into multiple lines and use the standard > VAR-y convention. This should more easily allow conditional > compilation of files in the future. > > Signed-off-by: Peter Tyser > --- > tools/Makefile | 46 ++ > 1 files changed, 34 insertions(+), 12 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "The question of whether a computer can think is no more interesting than the question of whether a submarine can swim" - Edsgar W. Dijkstra ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] i.MX31: Add basic support for Freescale's i.MX31 PDK board.
Wolfgang, 2009/4/3 Wolfgang Denk : > Dear Magnus Lilja, > > In message <1224746663-12321-2-git-send-email-lilja.mag...@gmail.com> you > wrote: >> Add support for the Freescale i.MX31 PDK (a.k.a 3DS) board. Ethernet and >> MC13873 RTC support is enabled by this patch. >> >> Booting from NAND is not supported yet so U-boot relies on some other >> initial boot loader to set up SDRAM and clocks and copying U-boot to SDRAM. >> >> Signed-off-by: Magnus Lilja > > Do you still plan to submit an updated version of this patch one day? I've been waiting for the i.MX31 NAND SPL boot patch to be updated and applied to mainline but since nothing happened for two months I've now posted a set of patches that continues this work. Regards, Magnus ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 03/15] tools/Makefile: Build bmp_logo only when LCD or VIDEO logos are enabled
Dear Peter Tyser, In message <22a383f60a66b6c9baa54dcc1766b3ebde62c873.1236207433.git.pty...@xes-inc.com> you wrote: > Signed-off-by: Peter Tyser > --- > tools/Makefile | 107 > +--- > 1 files changed, 55 insertions(+), 52 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A wise person makes his own decisions, a weak one obeys public opinion. -- Chinese proverb ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 04/15] tools/Makefile: Make img2srec dependent upon CONFIG_CMD_LOADS
Dear Peter Tyser, In message <1939e61f7ae1d5fd4133207ca9935bdfde54d448.1236207433.git.pty...@xes-inc.com> you wrote: > Signed-off-by: Peter Tyser > --- > tools/Makefile |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A good marriage would be between a blind wife and deaf husband. -- Michel de Montaigne ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 05/15] tools/Makefile: Make ubsha1 dependent upon CONFIG_SHA1_CHECK_UB_IMG
Dear Peter Tyser, In message <843a50a7133b20d731e1fb154c749c6d8e701b3a.1236207433.git.pty...@xes-inc.com> you wrote: > Signed-off-by: Peter Tyser > --- > tools/Makefile |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "Logic and practical information do not seem to apply here." "You admit that?" "To deny the facts would be illogical, Doctor" -- Spock and McCoy, "A Piece of the Action", stardate unknown ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 06/15] tools/Makefile: Make inca-swap-bytes dependent on CONFIG_INCA_IP
Dear Peter Tyser, In message <7b401d04ef4d44513d04fe514d5919b59527ca85.1236207433.git.pty...@xes-inc.com> you wrote: > Signed-off-by: Peter Tyser > --- > tools/Makefile |7 ++- > 1 files changed, 2 insertions(+), 5 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Killing is wrong. -- Losira, "That Which Survives", stardate unknown ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 07/15] tools/Makefile: Make envcrc dependent upon CONFIG_ENV_IS_EMBEDDED
Dear Peter Tyser, In message <14dd76717b4b634d3860b9d7759726e52a9d455d.1236207433.git.pty...@xes-inc.com> you wrote: > Signed-off-by: Peter Tyser > --- > tools/Makefile |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de You'll learn something about men and women -- the way they're supposed to be. Caring for each other, being happy with each other, being good to each other. That's what we call love. You'll like that a lot. -- Kirk, "The Apple", stardate 3715.6 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 08/15] tools/Makefile: Make gen_eth_addr dependent upon CONFIG_CMD_NET
Dear Peter Tyser, In message you wrote: > Signed-off-by: Peter Tyser > --- > tools/Makefile |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "Get back to your stations!" "We're beaming down to the planet, sir." -- Kirk and Mr. Leslie, "This Side of Paradise", stardate 3417.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 09/15] tools/Makefile: Compile ncb when CONFIG_NETCONSOLE
Dear Peter Tyser, In message <2b3b8ecc973665b7f706c787318cef12d035ae57.1236207433.git.pty...@xes-inc.com> you wrote: > Signed-off-by: Peter Tyser > --- > doc/README.NetConsole |6 ++ > tools/Makefile|1 + > 2 files changed, 3 insertions(+), 4 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "Wagner's music is better than it sounds." - Mark Twain ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 10/15] gen_eth_addr: Use POSIX rand() and srand()
Dear Mike Frysinger, In message <200903041853.05083.vap...@gentoo.org> you wrote: > > On Wednesday 04 March 2009 18:33:00 Peter Tyser wrote: > > Replace random()/srandom() use with rand()/srand() to support > > compilation with the mingw toolchain > > i'd add to the changelog that in general, the latter should be more common > than the former since they've been around longer. and note that no > functionality should be lost as the sets of functions do the same thing. Comment added. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Like winter snow on summer lawn, time past is time gone. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 10/15] gen_eth_addr: Use POSIX rand() and srand()
Dear Peter Tyser, In message <0bca9a93be63621ee791be20c6bd1c33495af517.1236207433.git.pty...@xes-inc.com> you wrote: > Replace random()/srandom() use with rand()/srand() to support > compilation with the mingw toolchain > > Signed-off-by: Peter Tyser > --- > tools/gen_eth_addr.c |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de You can love it, change it, or leave it.There is NO other option. But do not complain - it is your own choice... -- wd ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot